[GitHub] incubator-trafodion pull request #953: [TRAFODION-2478] Reduce the number of...

[selvaganesang]

GitHub user selvaganesang opened a pull request:

https://github.com/apache/incubator-trafodion/pull/953

[TRAFODION-2478] Reduce the number of memory monitoring threads in Tr…

…afodion SQL processes

The memory monitor thread is now moved to mxsscp process and the collected 
data is
stored in RMS shared segment. All SQL proceses have access to it.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/selvaganesang/incubator-trafodion 
trafodion-2478

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/953.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #953


commit 3d7df2d24db818ade2c94d58ed9cd01c1c43f847
Author: selvaganesang 
Date:   2017-02-10T23:56:56Z

[TRAFODION-2478] Reduce the number of memory monitoring threads in 
Trafodion SQL processes

The memory monitor thread is now moved to mxsscp process and the collected 
data is
stored in RMS shared segment. All SQL proceses have access to it.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request #946: TRAFODION-1562 Enable Vsbb upsert for...

[sureshsubbiah]

Github user sureshsubbiah commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/946#discussion_r100641201
  
--- Diff: core/sql/optimizer/BindRelExpr.cpp ---
@@ -10605,43 +10605,62 @@ NABoolean 
Insert::isUpsertThatNeedsTransformation(NABoolean isAlignedRowFormat,
   NABoolean 
omittedCurrentDefaultClassCols,
   NABoolean ) const
 {
-  // The necessary conditions to transform upsert 
+  toMerge = FALSE;
+  // If the the table has an identity column in clustering key or has a 
syskey 
+  // we dont need to do this transformation.The incoming row will always 
be 
+  // unique. So first check if we any of the conditions are satisfied to 
+  //even try the transform
+  NABoolean mustTryTransform = FALSE;
   if (isUpsert() && 
-  (NOT getIsTrafLoadPrep()) && 
+  ( NOT getIsTrafLoadPrep()) &&
   (NOT (getTableDesc()->isIdentityColumnGeneratedAlways() && 
-getTableDesc()->hasIdentityColumnInClusteringKey())) && 
-  (NOT 
(getTableDesc()->getClusteringIndex()->getNAFileSet()->hasSyskey())) && 
-  // table has secondary indexes or
-  (getTableDesc()->hasSecondaryIndexes() ))
-{
-  toMerge = FALSE;
-  return TRUE;
-}
-  else if (isUpsert() &&   (NOT getIsTrafLoadPrep()) && 
-   (NOT (getTableDesc()->isIdentityColumnGeneratedAlways() && 
getTableDesc()->hasIdentityColumnInClusteringKey())) && 
-   (NOT 
(getTableDesc()->getClusteringIndex()->getNAFileSet()->hasSyskey())) && 
-   // CQD is set to MERGE  
-   ((CmpCommon::getDefault(TRAF_UPSERT_MODE) == DF_MERGE) &&
-// omitted current default columns with non-aligned row format 
tables
-// or omitted default columns with aligned row format tables 
-(((NOT isAlignedRowFormat) && omittedCurrentDefaultClassCols) 
||
-(isAlignedRowFormat && omittedDefaultCols))) ||
-   // CQD is set to Optimal, for non-aligned row format with 
omitted 
-   // current columns, it is converted into merge though it is not
-   // optimal for performance - This is done to ensure that when 
the 
-   // CQD is set to optimal, non-aligned format would behave like 
-   // merge when any column is  omitted 
-   ((CmpCommon::getDefault(TRAF_UPSERT_MODE) == DF_OPTIMAL) &&
-((NOT isAlignedRowFormat) && omittedCurrentDefaultClassCols)))
+getTableDesc()->hasIdentityColumnInClusteringKey()))  && 
+  
(NOT(getTableDesc()->getClusteringIndex()->getNAFileSet()->hasSyskey(
+{
+  mustTryTransform = TRUE;
+}
+
+  // Transform upsert to merge in case of special modes and
+  // omitted default columns
+  // Case 1 :  CQD is set to MERGE, omitted current(timestamp) default 
+  //   columns with  non-aligned row format table or omitted 
+  //   default columns with aligned row format tables 
+
+  // Case 2 :  CQD is set to Optimal, for non-aligned row format with 
omitted 
+  //   current(timestamp) columns, it is converted into merge 
+  //   though it is not optimal for performance. This is done to 
ensure
+  //   that when the CQD is set to optimal, non-aligned format 
would 
+  //   behave like merge when any column is  omitted 
+  if (isUpsert()  &&   
+  mustTryTransform &&  
+  ((CmpCommon::getDefault(TRAF_UPSERT_MODE) == DF_MERGE) && 
+   (((NOT isAlignedRowFormat) && omittedCurrentDefaultClassCols) ||
+(isAlignedRowFormat && omittedDefaultCols)))
+  ||
+  ((CmpCommon::getDefault(TRAF_UPSERT_MODE) == DF_OPTIMAL) &&
+   ((NOT isAlignedRowFormat) && omittedCurrentDefaultClassCols)))
 {
   toMerge = TRUE;
   return TRUE;
 }
-  toMerge = FALSE;
+
+  // Transform upsert to efficient tree if none of the above conditions 
+  // are true and the table has secondary indexes 
+  if (isUpsert() &&  
+  mustTryTransform &&
+  (getTableDesc()->hasSecondaryIndexes()))
+{
+  toMerge = FALSE;
+  return TRUE;
+}
+  
--- End diff --

Looks good @sandhyasun. All my concerns have been addressed in the best 
possible manner. Thanks.+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request #951: [TRAFODION-2314] MXOSRVR sometimes ex...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafodion/pull/951


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request #952: [TRAFODION-2473] sqnodestatus report ...

[mkby]

GitHub user mkby opened a pull request:

https://github.com/apache/incubator-trafodion/pull/952

[TRAFODION-2473] sqnodestatus report wrong status if ssh banner is 
configured.

specify the '-q' command to ignore ssh banner.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mkby/incubator-trafodion 2473

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/952.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #952


commit a265a2176c4189d5ba9fb49080f2cb2f8f06c310
Author: Eason 
Date:   2017-02-10T13:35:12Z

[TRAFODION-2473] sqnodestatus report wrong status if ssh banner is 
configured.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---