Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/1288
---
Github user EEDY commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r150739956
--- Diff: core/sql/sqlcomp/CmpDescribe.cpp ---
@@ -3059,6 +3061,54 @@ short CmpDescribeSeabaseTable (
outputLongLine(*space,
Github user EEDY commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r150739473
--- Diff: core/sql/parser/sqlparser.y ---
@@ -33167,7 +33173,106 @@ stats_merge_clause : /*empty */
{ $$ =
Github user EEDY commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r150739440
--- Diff: core/sql/common/ComSmallDefs.h ---
@@ -660,7 +662,9 @@ enum ComTextType {COM_VIEW_TEXT = 0,
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r150693464
--- Diff: core/sql/sqlcomp/CmpDescribe.cpp ---
@@ -4129,6 +4280,37 @@ char buf[1000];
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r150690560
--- Diff: core/sql/common/ComSmallDefs.h ---
@@ -660,7 +662,9 @@ enum ComTextType {COM_VIEW_TEXT = 0,
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r150693110
--- Diff: core/sql/sqlcomp/CmpDescribe.cpp ---
@@ -3059,6 +3061,54 @@ short CmpDescribeSeabaseTable (
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r150694388
--- Diff: core/sql/sqlcomp/CmpSeabaseDDLschema.cpp ---
@@ -445,14 +445,39 @@ Int16 status =
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r150693531
--- Diff: core/sql/sqlcomp/CmpDescribe.cpp ---
@@ -4634,12 +4816,49 @@ short CmpDescribeRoutine (const CorrName & cn,
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r150693272
--- Diff: core/sql/sqlcomp/CmpDescribe.cpp ---
@@ -3777,6 +3826,76 @@ short CmpDescribeSeabaseTable (
}
}
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r150693830
--- Diff: core/sql/sqlcomp/CmpSeabaseDDLcommentOn.cpp ---
@@ -0,0 +1,349 @@
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r150691328
--- Diff: core/sql/parser/StmtDDLCommentOn.h ---
@@ -0,0 +1,153 @@
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r150692372
--- Diff: core/sql/parser/sqlparser.y ---
@@ -33167,7 +33173,106 @@ stats_merge_clause : /*empty */
{ $$ =
Github user EEDY commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r149039000
--- Diff: core/sql/sqlcomp/CmpSeabaseDDLmd.h ---
@@ -115,7 +115,8 @@ static const QString seabaseColumnsDDL[] =
{" hbase_col_qualifier
Github user EEDY commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r149038713
--- Diff: core/sql/sqlcomp/CmpDescribe.cpp ---
@@ -3059,6 +3061,36 @@ short CmpDescribeSeabaseTable (
outputLongLine(*space,
Github user EEDY commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r149038134
--- Diff: core/sql/sqlcomp/CmpSeabaseDDLcommentOn.cpp ---
@@ -0,0 +1,202 @@
Github user EEDY commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r149039165
--- Diff: core/sql/parser/sqlparser.y ---
@@ -33167,7 +33173,102 @@ stats_merge_clause : /*empty */
{ $$ =
Github user EEDY commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r149039183
--- Diff: core/sql/sqlcomp/CmpDescribe.cpp ---
@@ -3059,6 +3061,36 @@ short CmpDescribeSeabaseTable (
outputLongLine(*space,
Github user robertamarton commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r148654665
--- Diff: core/sql/sqlcomp/CmpSeabaseDDLtable.cpp ---
@@ -12940,6 +12940,142 @@ TrafDesc
Github user robertamarton commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r148654612
--- Diff: core/sql/sqlcomp/CmpSeabaseDDLtable.cpp ---
@@ -12940,6 +12940,142 @@ TrafDesc
Github user robertamarton commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r148654557
--- Diff: core/sql/sqlcomp/CmpSeabaseDDLtable.cpp ---
@@ -12940,6 +12940,142 @@ TrafDesc
Github user robertamarton commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r148654517
--- Diff: core/sql/sqlcomp/CmpSeabaseDDLschema.cpp ---
@@ -445,13 +445,36 @@ Int16 status =
Github user robertamarton commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r148654478
--- Diff: core/sql/sqlcomp/CmpSeabaseDDLmd.h ---
@@ -115,7 +115,8 @@ static const QString seabaseColumnsDDL[] =
{"
Github user robertamarton commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r148654412
--- Diff: core/sql/sqlcomp/CmpSeabaseDDLcommentOn.cpp ---
@@ -0,0 +1,202 @@
Github user robertamarton commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r148654381
--- Diff: core/sql/sqlcomp/CmpSeabaseDDLcommentOn.cpp ---
@@ -0,0 +1,202 @@
Github user robertamarton commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r148654441
--- Diff: core/sql/sqlcomp/CmpSeabaseDDLcommentOn.cpp ---
@@ -0,0 +1,202 @@
Github user robertamarton commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r148654287
--- Diff: core/sql/sqlcomp/CmpDescribe.cpp ---
@@ -4129,6 +4219,33 @@ char buf[1000];
Github user robertamarton commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r148654201
--- Diff: core/sql/sqlcomp/CmpDescribe.cpp ---
@@ -3777,6 +3808,65 @@ short CmpDescribeSeabaseTable (
}
}
Github user robertamarton commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r148654147
--- Diff: core/sql/sqlcomp/CmpDescribe.cpp ---
@@ -3059,6 +3061,36 @@ short CmpDescribeSeabaseTable (
Github user robertamarton commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r148654170
--- Diff: core/sql/sqlcomp/CmpDescribe.cpp ---
@@ -3059,6 +3061,36 @@ short CmpDescribeSeabaseTable (
Github user robertamarton commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r148654096
--- Diff: core/sql/parser/sqlparser.y ---
@@ -33167,7 +33173,102 @@ stats_merge_clause : /*empty */
{ $$ =
Github user robertamarton commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1288#discussion_r148654006
--- Diff: core/sql/parser/BindStmtDDL.cpp ---
@@ -2576,6 +2576,60 @@ StmtDDLAlterUser::bindNode(BindWA * pBindWA)
}
GitHub user EEDY opened a pull request:
https://github.com/apache/incubator-trafodion/pull/1288
New COMMENT-ON SQL statement
[SQL_COMMENT_feature_design.171025.docx](https://github.com/apache/incubator-trafodion/files/1437382/SQL_COMMENT_feature_design.171025.docx)
1. new
33 matches
Mail list logo
