[GitHub] incubator-trafodion pull request #754: [TRAFODION-2262] Mxosrvr or java core...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafodion/pull/754


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request #754: [TRAFODION-2262] Mxosrvr or java core...

[DaveBirdsall]

Github user DaveBirdsall commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/754#discussion_r8280
  
--- Diff: core/sql/qmscommon/QRLogger.cpp ---
@@ -186,6 +188,9 @@ NABoolean QRLogger::initLog4cxx(const char* 
configFileName)
 {
   NAString logFileName;
 
+  if (gv_QRLoggerInitialized_)
+ return TRUE;
+ 
   // get the log directory
--- End diff --

I cannot figure out if this code is thread-safe. What if two threads 
concurrently enter this function and both see gv_QRLoggerInitialized_ as FALSE. 
Both would then call CommonLogger::initLog4cxx and possibly introduceSelf(). Is 
there any harm in this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request #754: [TRAFODION-2262] Mxosrvr or java core...

[selvaganesang]

GitHub user selvaganesang opened a pull request:

https://github.com/apache/incubator-trafodion/pull/754

[TRAFODION-2262] Mxosrvr or java core with the stack trace pointing t…

…o log4Cxx functions

The Logger repository needs to be initialized. The method 
QRLogger::initLog4cxx
initialized the commonLogger infrastructure also.

PR #745 merged to fix this issue exposed a problem in SSMP. This
caused SSMP to dump core when a node is brought down.
SSMP should have create the connection to SSCP on that node.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/selvaganesang/incubator-trafodion 
trafodion-2261

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/754.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #754


commit 8c9fce8c13054fdd150d75cc79e2a20a38b3f47c
Author: selvaganesang 
Date:   2016-10-11T03:39:23Z

[TRAFODION-2262] Mxosrvr or java core with the stack trace pointing to 
log4Cxx functions

The Logger repository needs to be initialized. The method 
QRLogger::initLog4cxx
initialized the commonLogger infrastructure also.

PR #745 merged to fix this issue exposed a problem in SSMP. This
caused SSMP to dump core when a node is brought down.
SSMP should have create the connection to SSCP on that node.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---