[GitHub] incubator-trafodion pull request #763: [TRAFODION-1893]ODBC:Remove vcredist ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafodion/pull/763


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request #763: [TRAFODION-1893]ODBC:Remove vcredist ...

[hegdean]

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/763#discussion_r83725920
  
--- Diff: win-odbc64/Install/win64_installer/installer.iss ---
@@ -152,6 +141,40 @@ begin
   Result := (GetUninstallString() <> '');
 end;
 
+procedure CurStepChanged(CurStep: TSetupStep);
+var
+  bRedistNeedsInstall: Boolean;
+  sDefaultBrowserName: String;
+  sDefaultBrowserReg: String;
+  sDefaultBrowserValue: String;
+  iQuotePos: Integer;
+  lLength: Longint;
+  iRetCode: Integer;
+begin
+  if CurStep=ssPostInstall then
+  begin
+bRedistNeedsInstall := VCRedistNeedsInstall();
+if bRedistNeedsInstall=True then
+begin
+  MsgBox('Install of Visual C++ Redistributable Packages for Visual 
Studio 2013 is not dectected.'+ #13#10#13#10 + 'Please download 
vcredist_x64.exe from Microsoft Download Centre and install it.', 
mbInformation, MB_OK);
--- End diff --

Can we change the message to be as follows:
Run-time dependency needed by the driver is not found. Proceeding to 
download and install run-time dependency from Microsoft.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request #763: [TRAFODION-1893]ODBC:Remove vcredist ...

[rwbzx]

GitHub user rwbzx opened a pull request:

https://github.com/apache/incubator-trafodion/pull/763

[TRAFODION-1893]ODBC:Remove vcredist from win-odbc build

1. Remove vcredist_x64.exe packaging inside win-odbc installer.
2. If no install of dependency package is detected, a message-box will 
popup prompting users to download and install it. 
3. And by the time the [OK] button of the prompt message-box is clicked, 
the installer will use system-default browser to open download URL, also at the 
same time, the Setup Finish Page will pop-up.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rwbzx/incubator-trafodion TRAFODION-1893

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/763.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #763


commit 78139ddedfbf943178aa2a57136eb65bea5681c5
Author: rwbzx 
Date:   2016-10-14T09:33:02Z

TRAFODION-1893
Remove vcredist from win-odbc build




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---