Re: [collectd] [PATCH] Interface option for network plugin

2010-03-14 Thread Max Henkel
Hello list! On Tue, Mar 09, 2010 at 08:07:20PM +0100, Max Henkel wrote: On Tue, Mar 09, 2010 at 06:17:35PM +0100, Florian Forster wrote: [...] On Fri, Feb 26, 2010 at 12:49:02PM +0100, Max Henkel wrote: [...] @@ -2842,6 +2929,8 @@ static int network_config (oconfig_item_t *ci) /* {{{

Re: [collectd] [PATCH] Interface option for network plugin

2010-03-09 Thread Florian Forster
Hi Max, thanks for your patch :) On Fri, Feb 26, 2010 at 12:49:02PM +0100, Max Henkel wrote: +#if KERNEL_LINUX + struct ip_mreqn mreq; +#else + struct ip_mreq mreq; +#endif As far as I see, the only difference between the two structs is the imr_address, which you

Re: [collectd] [PATCH] Interface option for network plugin

2010-03-09 Thread Sebastian Harl
Hi, On Tue, Mar 09, 2010 at 06:17:35PM +0100, Florian Forster wrote: On Fri, Feb 26, 2010 at 12:49:02PM +0100, Max Henkel wrote: + if (! IN_MULTICAST (ntohl (addr-sin_addr.s_addr))) + return (0); Doesn't it make sense to be able to set the interface in unicast

Re: [collectd] [PATCH] Interface option for network plugin

2010-03-09 Thread Max Henkel
Hi octo and list! On Tue, Mar 09, 2010 at 06:17:35PM +0100, Florian Forster wrote: [...] On Fri, Feb 26, 2010 at 12:49:02PM +0100, Max Henkel wrote: +#if KERNEL_LINUX + struct ip_mreqn mreq; +#else + struct ip_mreq mreq; +#endif As far as I see, the only