Re: [collectd] [PATCH 2/5] sigrok: bare bones plugin

2013-07-26 Thread Bert Vermeulen
I've reworked the patch to take comments into account, and resubmitted it as a pull request on github. I'll reply to the comments raised below: On 07/22/2013 09:35 PM, Dan Fandrich wrote: > On Mon, Jul 22, 2013 at 06:21:18PM +0200, Bert Vermeulen wrote: >> +static int plugin_config(const char *key

Re: [collectd] [PATCH 2/5] sigrok: bare bones plugin

2013-07-22 Thread Florian Forster
Hi Bert, thank you very much for your patches! On Mon, Jul 22, 2013 at 06:21:18PM +0200, Bert Vermeulen wrote: > + * This program is free software: you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation,

Re: [collectd] [PATCH 2/5] sigrok: bare bones plugin

2013-07-22 Thread Dan Fandrich
On Mon, Jul 22, 2013 at 06:21:18PM +0200, Bert Vermeulen wrote: > +static int plugin_config(const char *key, const char *value) > +{ > + > + if (!strcmp(key, "loglevel")) > + loglevel = atoi(value); > + else if (!strcmp(key, "conn")) > + conn = strdup(value); This w

[collectd] [PATCH 2/5] sigrok: bare bones plugin

2013-07-22 Thread Bert Vermeulen
--- src/sigrok.c | 109 +++ 1 file changed, 109 insertions(+) create mode 100644 src/sigrok.c diff --git a/src/sigrok.c b/src/sigrok.c new file mode 100644 index 000..7189366 --- /dev/null +++ b/src/sigrok.c @@ -0,0 +1,109 @@ +/* + * co