Re: [collectd] [PATCH] New plugin - lpar

2010-09-07 Thread Aurélien Reynaud
Hi Florian, I saw how you modified my code and I find it indeed much more elegant to directly use raw counters as they are calculated and reported by the system. Many people expect the CPU usage to be in percent. You can easily calculate that in the front-end as percent busy = 100.0 *

Re: [collectd] [PATCH] New plugin - lpar

2010-09-07 Thread Florian Forster
Hi Aurélien, On Tue, Sep 07, 2010 at 11:50:09AM +0200, Aurélien Reynaud wrote: Many people expect the CPU usage to be in percent. You can easily calculate that in the front-end as What I am saying here is that we cannot just compute a ratio with the raw counters, we need to have the final

Re: [collectd] [PATCH] New plugin - lpar

2010-09-07 Thread Aurélien Reynaud
Hello Florian, Yeah, since the LPAR documentation itself always talks in terms of virtual CPUs we might as well adopt that terminology in the plugin. Currently I tend towards the solution I think you originally implemented: Introduce a vcpu_gauge (or simply vcpu) type and track usage in