[accumulo-testing] branch main updated: Create unique directory for each run of `cingest verify` to store test output (#152)

[domgarguilo]

This is an automated email from the ASF dual-hosted git repository.

domgarguilo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/accumulo-testing.git


The following commit(s) were added to refs/heads/main by this push:
     new d415164  Create unique directory for each run of `cingest verify` to 
store test output (#152)
d415164 is described below

commit d4151644a9102ccd447a60a402aaeeab748ef230
Author: Dom G <47725857+domgargu...@users.noreply.github.com>
AuthorDate: Fri Sep 17 12:01:09 2021 -0400

    Create unique directory for each run of `cingest verify` to store test 
output (#152)
    
    * Now creates a new unique directory to store test output of each run of 
`cingest verify
    * Now no longer stops the test when the output directory already exists
---
 .../testing/continuous/ContinuousVerify.java         | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git 
a/src/main/java/org/apache/accumulo/testing/continuous/ContinuousVerify.java 
b/src/main/java/org/apache/accumulo/testing/continuous/ContinuousVerify.java
index 5db4350..10d224e 100644
--- a/src/main/java/org/apache/accumulo/testing/continuous/ContinuousVerify.java
+++ b/src/main/java/org/apache/accumulo/testing/continuous/ContinuousVerify.java
@@ -52,12 +52,14 @@ import org.slf4j.LoggerFactory;
 public class ContinuousVerify extends Configured implements Tool {
   public static final VLongWritable DEF = new VLongWritable(-1);
 
+  private static final Logger log = 
LoggerFactory.getLogger(ContinuousVerify.class);
+
   public static class CMapper extends 
Mapper<Key,Value,LongWritable,VLongWritable> {
 
-    private static final Logger log = LoggerFactory.getLogger(CMapper.class);
-    private LongWritable row = new LongWritable();
-    private LongWritable ref = new LongWritable();
-    private VLongWritable vrow = new VLongWritable();
+    private static final Logger cMapperLogger = 
LoggerFactory.getLogger(CMapper.class);
+    private final LongWritable row = new LongWritable();
+    private final LongWritable ref = new LongWritable();
+    private final VLongWritable vrow = new VLongWritable();
 
     private long corrupt = 0;
 
@@ -72,9 +74,9 @@ public class ContinuousVerify extends Configured implements 
Tool {
       } catch (ContinuousWalk.BadChecksumException bce) {
         context.getCounter(Counts.CORRUPT).increment(1L);
         if (corrupt < 1000) {
-          log.error("Bad checksum : " + key);
+          cMapperLogger.error("Bad checksum : " + key);
         } else if (corrupt == 1000) {
-          log.error("Too many bad checksums, not printing anymore!");
+          cMapperLogger.error("Too many bad checksums, not printing anymore!");
         }
         corrupt++;
         return;
@@ -99,7 +101,7 @@ public class ContinuousVerify extends Configured implements 
Tool {
   }
 
   public static class CReducer extends 
Reducer<LongWritable,VLongWritable,Text,Text> {
-    private ArrayList<Long> refs = new ArrayList<>();
+    private final ArrayList<Long> refs = new ArrayList<>();
 
     @Override
     public void reduce(LongWritable key, Iterable<VLongWritable> values, 
Context context)
@@ -188,7 +190,9 @@ public class ContinuousVerify extends Configured implements 
Tool {
       
job.getConfiguration().setBoolean("mapred.map.tasks.speculative.execution", 
scanOffline);
       job.getConfiguration().set("mapreduce.job.classloader", "true");
 
-      TextOutputFormat.setOutputPath(job, new Path(outputDir));
+      Path outputPath = new Path(outputDir + "/" + job.getJobName());
+      TextOutputFormat.setOutputPath(job, outputPath);
+      log.info("Results from this run will be stored in {}", outputPath);
 
       job.waitForCompletion(true);