[jira] [Created] (AIRFLOW-3628) set MIME from in alert email

2019-01-03 Thread yu jiantao (JIRA)
yu jiantao created AIRFLOW-3628: --- Summary: set MIME from in alert email Key: AIRFLOW-3628 URL: https://issues.apache.org/jira/browse/AIRFLOW-3628 Project: Apache Airflow Issue Type:

[GitHub] feng-tao commented on issue #3197: [AIRFLOW-2267] Airflow DAG level access

2019-01-03 Thread GitBox
feng-tao commented on issue #3197: [AIRFLOW-2267] Airflow DAG level access URL: https://github.com/apache/incubator-airflow/pull/3197#issuecomment-451367438 @kaxil , could we add this change including https://github.com/apache/incubator-airflow/pull/4305 to v10.2? Or v10.2 is for minor

[GitHub] pingzh commented on issue #4425: [AIRFLOW-3623] Support download logs by attempts from UI

2019-01-03 Thread GitBox
pingzh commented on issue #4425: [AIRFLOW-3623] Support download logs by attempts from UI URL: https://github.com/apache/incubator-airflow/pull/4425#issuecomment-451366052 @msumit Thanks for the info. In my mind, for large log files, `tailing` or `range` lines does not provide lots of

[GitHub] feng-tao commented on issue #4425: [AIRFLOW-3623] Support download logs by attempts from UI

2019-01-03 Thread GitBox
feng-tao commented on issue #4425: [AIRFLOW-3623] Support download logs by attempts from UI URL: https://github.com/apache/incubator-airflow/pull/4425#issuecomment-451364978 @msumit , I think your point is valid, but sometimes the log file is very hard to render and view if the file is

[GitHub] feng-tao commented on issue #4419: [AIRFLOW-3612] Remove incubation/incubator mention

2019-01-03 Thread GitBox
feng-tao commented on issue #4419: [AIRFLOW-3612] Remove incubation/incubator mention URL: https://github.com/apache/incubator-airflow/pull/4419#issuecomment-451362887 PTAL @ashb @kaxil @Fokko @bolkedebruin @mistercrunch @r39132 @jghoman I believe we need to commit this change by

[GitHub] codecov-io edited a comment on issue #4433: [AIRFLOW-3627] Improve queries performance in /task_stats in views.py by ~20%

2019-01-03 Thread GitBox
codecov-io edited a comment on issue #4433: [AIRFLOW-3627] Improve queries performance in /task_stats in views.py by ~20% URL: https://github.com/apache/incubator-airflow/pull/4433#issuecomment-451358210 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4433?src=pr=h1)

[GitHub] codecov-io commented on issue #4433: [AIRFLOW-3627] Improve queries performance in /task_stats in views.py by ~20%

2019-01-03 Thread GitBox
codecov-io commented on issue #4433: [AIRFLOW-3627] Improve queries performance in /task_stats in views.py by ~20% URL: https://github.com/apache/incubator-airflow/pull/4433#issuecomment-451358210 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4433?src=pr=h1) Report

[GitHub] codecov-io commented on issue #4433: [AIRFLOW-3627] Improve queries performance in /task_stats in views.py by ~20%

2019-01-03 Thread GitBox
codecov-io commented on issue #4433: [AIRFLOW-3627] Improve queries performance in /task_stats in views.py by ~20% URL: https://github.com/apache/incubator-airflow/pull/4433#issuecomment-451358212 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4433?src=pr=h1) Report

[GitHub] pingzh commented on issue #4425: [AIRFLOW-3623] Support download logs by attempts from UI

2019-01-03 Thread GitBox
pingzh commented on issue #4425: [AIRFLOW-3623] Support download logs by attempts from UI URL: https://github.com/apache/incubator-airflow/pull/4425#issuecomment-451356987 @msumit great point. One big reason for this feature is for large log files, it is expensive to pull the large logs

[GitHub] codecov-io commented on issue #4185: [AIRFLOW-3340] Placeholder support in connections form

2019-01-03 Thread GitBox
codecov-io commented on issue #4185: [AIRFLOW-3340] Placeholder support in connections form URL: https://github.com/apache/incubator-airflow/pull/4185#issuecomment-451356788 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4185?src=pr=h1) Report > Merging

[GitHub] msumit commented on issue #4425: [AIRFLOW-3623] Support download logs by attempts from UI

2019-01-03 Thread GitBox
msumit commented on issue #4425: [AIRFLOW-3623] Support download logs by attempts from UI URL: https://github.com/apache/incubator-airflow/pull/4425#issuecomment-451356539 @pingzh @feng-tao sorry for late comment, but won't it be better if we provide download logs feature at the "View

[jira] [Updated] (AIRFLOW-3516) Improve K8 Executors Pod creation Rate

2019-01-03 Thread raman (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] raman updated AIRFLOW-3516: --- Component/s: (was: scheduler) > Improve K8 Executors Pod creation Rate >

[jira] [Commented] (AIRFLOW-3516) Improve K8 Executors Pod creation Rate

2019-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733829#comment-16733829 ] ASF GitHub Bot commented on AIRFLOW-3516: - ramandumcs commented on pull request #4434:

[GitHub] ramandumcs opened a new pull request #4434: [AIRFLOW-3516] Support to create k8 worker pods in batches

2019-01-03 Thread GitBox
ramandumcs opened a new pull request #4434: [AIRFLOW-3516] Support to create k8 worker pods in batches URL: https://github.com/apache/incubator-airflow/pull/4434 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[jira] [Assigned] (AIRFLOW-3516) Improve K8 Executors Pod creation Rate

2019-01-03 Thread raman (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] raman reassigned AIRFLOW-3516: -- Assignee: raman > Improve K8 Executors Pod creation Rate > -- >

[GitHub] feng-tao commented on issue #4377: [AIRFLOW-3574 ]Added changes to filter dags by comparing dag owner with username when using rbac

2019-01-03 Thread GitBox
feng-tao commented on issue #4377: [AIRFLOW-3574 ]Added changes to filter dags by comparing dag owner with username when using rbac URL: https://github.com/apache/incubator-airflow/pull/4377#issuecomment-451353396 +1 on @jgao54 , the filtering could be done through DAG-level access if

[jira] [Commented] (AIRFLOW-3623) Support download log file from UI

2019-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733821#comment-16733821 ] ASF GitHub Bot commented on AIRFLOW-3623: - feng-tao commented on pull request #4425:

[jira] [Closed] (AIRFLOW-3623) Support download log file from UI

2019-01-03 Thread Tao Feng (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tao Feng closed AIRFLOW-3623. - Resolution: Fixed > Support download log file from UI > - > >

[GitHub] codecov-io edited a comment on issue #4428: [AIRFLOW-3624] Add masterType parameter to MLEngineTrainingOperator

2019-01-03 Thread GitBox
codecov-io edited a comment on issue #4428: [AIRFLOW-3624] Add masterType parameter to MLEngineTrainingOperator URL: https://github.com/apache/incubator-airflow/pull/4428#issuecomment-451334549 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4428?src=pr=h1) Report >

[GitHub] jgao54 commented on issue #4377: [AIRFLOW-3574 ]Added changes to filter dags by comparing dag owner with username when using rbac

2019-01-03 Thread GitBox
jgao54 commented on issue #4377: [AIRFLOW-3574 ]Added changes to filter dags by comparing dag owner with username when using rbac URL: https://github.com/apache/incubator-airflow/pull/4377#issuecomment-451349665 Hmmm... not sure what the goal is here. If it is to make DAGs more

[jira] [Updated] (AIRFLOW-3627) Improve performance of /task_stats in views.py of both /www and /www_rbac

2019-01-03 Thread Xiaodong DENG (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaodong DENG updated AIRFLOW-3627: --- Summary: Improve performance of /task_stats in views.py of both /www and /www_rbac (was:

[jira] [Commented] (AIRFLOW-3627) Queries in /task_stats of both /www & /www_rbac can be refined significantly by minor changes

2019-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733814#comment-16733814 ] ASF GitHub Bot commented on AIRFLOW-3627: - XD-DENG commented on pull request #4433:

[GitHub] msumit commented on issue #4185: [AIRFLOW-3340] Placeholder support in connections form

2019-01-03 Thread GitBox
msumit commented on issue #4185: [AIRFLOW-3340] Placeholder support in connections form URL: https://github.com/apache/incubator-airflow/pull/4185#issuecomment-451348468 Thanks for the info @jgao54, will do the changes there as well.

[GitHub] XD-DENG opened a new pull request #4433: [AIRFLOW-3627] Improve queries performance in /task_stats in views.py by ~20%

2019-01-03 Thread GitBox
XD-DENG opened a new pull request #4433: [AIRFLOW-3627] Improve queries performance in /task_stats in views.py by ~20% URL: https://github.com/apache/incubator-airflow/pull/4433 ### Jira - https://issues.apache.org/jira/browse/AIRFLOW-3627 ### Description

[jira] [Created] (AIRFLOW-3627) Queries in /task_stats of both /www & /www_rbac can be refined significantly by minor changes

2019-01-03 Thread Xiaodong DENG (JIRA)
Xiaodong DENG created AIRFLOW-3627: -- Summary: Queries in /task_stats of both /www & /www_rbac can be refined significantly by minor changes Key: AIRFLOW-3627 URL:

[GitHub] codecov-io edited a comment on issue #4428: [AIRFLOW-3624] Add masterType parameter to MLEngineTrainingOperator

2019-01-03 Thread GitBox
codecov-io edited a comment on issue #4428: [AIRFLOW-3624] Add masterType parameter to MLEngineTrainingOperator URL: https://github.com/apache/incubator-airflow/pull/4428#issuecomment-451334549 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4428?src=pr=h1) Report >

[GitHub] codecov-io edited a comment on issue #4428: [AIRFLOW-3624] Add masterType parameter to MLEngineTrainingOperator

2019-01-03 Thread GitBox
codecov-io edited a comment on issue #4428: [AIRFLOW-3624] Add masterType parameter to MLEngineTrainingOperator URL: https://github.com/apache/incubator-airflow/pull/4428#issuecomment-451334549 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4428?src=pr=h1) Report >

[GitHub] codecov-io edited a comment on issue #4428: [AIRFLOW-3624] Add masterType parameter to MLEngineTrainingOperator

2019-01-03 Thread GitBox
codecov-io edited a comment on issue #4428: [AIRFLOW-3624] Add masterType parameter to MLEngineTrainingOperator URL: https://github.com/apache/incubator-airflow/pull/4428#issuecomment-451334549 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4428?src=pr=h1) Report >

[GitHub] codecov-io edited a comment on issue #4425: [AIRFLOW-3623] Support download logs by attempts from UI

2019-01-03 Thread GitBox
codecov-io edited a comment on issue #4425: [AIRFLOW-3623] Support download logs by attempts from UI URL: https://github.com/apache/incubator-airflow/pull/4425#issuecomment-451043829 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4425?src=pr=h1) Report > Merging

[GitHub] pingzh commented on issue #4425: [AIRFLOW-3623] Support download logs by attempts from UI

2019-01-03 Thread GitBox
pingzh commented on issue #4425: [AIRFLOW-3623] Support download logs by attempts from UI URL: https://github.com/apache/incubator-airflow/pull/4425#issuecomment-451324241 Thanks for your feedback, @feng-tao. I have addressed them.

[GitHub] pingzh commented on a change in pull request #4425: [AIRFLOW-3623] Support download logs by attempts from UI

2019-01-03 Thread GitBox
pingzh commented on a change in pull request #4425: [AIRFLOW-3623] Support download logs by attempts from UI URL: https://github.com/apache/incubator-airflow/pull/4425#discussion_r245176465 ## File path: airflow/www/templates/airflow/dag.html ## @@ -320,6 +326,29 @@

[GitHub] pingzh commented on a change in pull request #4425: [AIRFLOW-3623] Support download logs by attempts from UI

2019-01-03 Thread GitBox
pingzh commented on a change in pull request #4425: [AIRFLOW-3623] Support download logs by attempts from UI URL: https://github.com/apache/incubator-airflow/pull/4425#discussion_r245176678 ## File path: airflow/www_rbac/templates/airflow/dag.html ## @@ -314,12 +320,35 @@

[GitHub] pingzh commented on a change in pull request #4425: [AIRFLOW-3623] Support download logs by attempts from UI

2019-01-03 Thread GitBox
pingzh commented on a change in pull request #4425: [AIRFLOW-3623] Support download logs by attempts from UI URL: https://github.com/apache/incubator-airflow/pull/4425#discussion_r245176609 ## File path: airflow/www/templates/airflow/dag.html ## @@ -320,6 +326,29 @@

[GitHub] pingzh commented on a change in pull request #4425: [AIRFLOW-3623] Support download logs by attempts from UI

2019-01-03 Thread GitBox
pingzh commented on a change in pull request #4425: [AIRFLOW-3623] Support download logs by attempts from UI URL: https://github.com/apache/incubator-airflow/pull/4425#discussion_r245176403 ## File path: airflow/utils/helpers.py ## @@ -297,3 +297,16 @@ def

[GitHub] feng-tao commented on a change in pull request #4309: [AIRFLOW-3504] Extend/refine the functionality of "/health" endpoint

2019-01-03 Thread GitBox
feng-tao commented on a change in pull request #4309: [AIRFLOW-3504] Extend/refine the functionality of "/health" endpoint URL: https://github.com/apache/incubator-airflow/pull/4309#discussion_r245172751 ## File path: airflow/www/blueprints.py ## @@ -32,6 +37,26 @@ def

[GitHub] feng-tao commented on a change in pull request #4309: [AIRFLOW-3504] Extend/refine the functionality of "/health" endpoint

2019-01-03 Thread GitBox
feng-tao commented on a change in pull request #4309: [AIRFLOW-3504] Extend/refine the functionality of "/health" endpoint URL: https://github.com/apache/incubator-airflow/pull/4309#discussion_r245173641 ## File path: airflow/www_rbac/views.py ## @@ -147,6 +147,33 @@ def

[GitHub] feng-tao commented on a change in pull request #4309: [AIRFLOW-3504] Extend/refine the functionality of "/health" endpoint

2019-01-03 Thread GitBox
feng-tao commented on a change in pull request #4309: [AIRFLOW-3504] Extend/refine the functionality of "/health" endpoint URL: https://github.com/apache/incubator-airflow/pull/4309#discussion_r245173229 ## File path: airflow/www/blueprints.py ## @@ -32,6 +37,26 @@ def

[GitHub] feng-tao commented on a change in pull request #4309: [AIRFLOW-3504] Extend/refine the functionality of "/health" endpoint

2019-01-03 Thread GitBox
feng-tao commented on a change in pull request #4309: [AIRFLOW-3504] Extend/refine the functionality of "/health" endpoint URL: https://github.com/apache/incubator-airflow/pull/4309#discussion_r245173540 ## File path: airflow/www_rbac/blueprints.py ## @@ -17,19 +17,11 @@

[GitHub] feng-tao commented on a change in pull request #4425: [AIRFLOW-3623] Support download logs by attempts from UI

2019-01-03 Thread GitBox
feng-tao commented on a change in pull request #4425: [AIRFLOW-3623] Support download logs by attempts from UI URL: https://github.com/apache/incubator-airflow/pull/4425#discussion_r245168034 ## File path: airflow/www/templates/airflow/dag.html ## @@ -320,6 +326,29 @@

[GitHub] feng-tao commented on a change in pull request #4425: [AIRFLOW-3623] Support download logs by attempts from UI

2019-01-03 Thread GitBox
feng-tao commented on a change in pull request #4425: [AIRFLOW-3623] Support download logs by attempts from UI URL: https://github.com/apache/incubator-airflow/pull/4425#discussion_r245167349 ## File path: airflow/utils/helpers.py ## @@ -297,3 +297,16 @@ def

[GitHub] feng-tao commented on a change in pull request #4425: [AIRFLOW-3623] Support download logs by attempts from UI

2019-01-03 Thread GitBox
feng-tao commented on a change in pull request #4425: [AIRFLOW-3623] Support download logs by attempts from UI URL: https://github.com/apache/incubator-airflow/pull/4425#discussion_r245167996 ## File path: airflow/www/templates/airflow/dag.html ## @@ -320,6 +326,29 @@

[GitHub] griff122 commented on issue #4423: [AIRFLOW-3618] - Fix models.connection.Connection get_hook function

2019-01-03 Thread GitBox
griff122 commented on issue #4423: [AIRFLOW-3618] - Fix models.connection.Connection get_hook function URL: https://github.com/apache/incubator-airflow/pull/4423#issuecomment-451317740 Absolutely, that is a great idea! This

[GitHub] feng-tao commented on a change in pull request #4425: [AIRFLOW-3623] Support download logs by attempts from UI

2019-01-03 Thread GitBox
feng-tao commented on a change in pull request #4425: [AIRFLOW-3623] Support download logs by attempts from UI URL: https://github.com/apache/incubator-airflow/pull/4425#discussion_r245168256 ## File path: airflow/www/views.py ## @@ -770,7 +774,12 @@ def

[GitHub] feng-tao commented on a change in pull request #4425: [AIRFLOW-3623] Support download logs by attempts from UI

2019-01-03 Thread GitBox
feng-tao commented on a change in pull request #4425: [AIRFLOW-3623] Support download logs by attempts from UI URL: https://github.com/apache/incubator-airflow/pull/4425#discussion_r245168050 ## File path: airflow/www/templates/airflow/dag.html ## @@ -320,6 +326,29 @@

[GitHub] feng-tao commented on a change in pull request #4425: [AIRFLOW-3623] Support download logs by attempts from UI

2019-01-03 Thread GitBox
feng-tao commented on a change in pull request #4425: [AIRFLOW-3623] Support download logs by attempts from UI URL: https://github.com/apache/incubator-airflow/pull/4425#discussion_r245168502 ## File path: airflow/www_rbac/templates/airflow/dag.html ## @@ -314,12 +320,35

[GitHub] codecov-io edited a comment on issue #4294: [AIRFLOW-3451] Add UI button to refresh all dags

2019-01-03 Thread GitBox
codecov-io edited a comment on issue #4294: [AIRFLOW-3451] Add UI button to refresh all dags URL: https://github.com/apache/incubator-airflow/pull/4294#issuecomment-445349042 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4294?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #4294: [AIRFLOW-3451] Add UI button to refresh all dags

2019-01-03 Thread GitBox
codecov-io edited a comment on issue #4294: [AIRFLOW-3451] Add UI button to refresh all dags URL: https://github.com/apache/incubator-airflow/pull/4294#issuecomment-445349042 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4294?src=pr=h1) Report > Merging

[jira] [Resolved] (AIRFLOW-3316) GCS to BQ operator leaves schema_fields operator unset when autodetect=True

2019-01-03 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik resolved AIRFLOW-3316. - Resolution: Fixed Fix Version/s: 1.10.2 Resolved by

[GitHub] kaxil closed pull request #4430: AIRFLOW-3316 be sure to initialize schema_fields variable

2019-01-03 Thread GitBox
kaxil closed pull request #4430: AIRFLOW-3316 be sure to initialize schema_fields variable URL: https://github.com/apache/incubator-airflow/pull/4430 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[jira] [Resolved] (AIRFLOW-3583) wasb_hook.py needs updated updated AirflowException

2019-01-03 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik resolved AIRFLOW-3583. - Resolution: Fixed Fix Version/s: 1.10.2 Resolved by

[jira] [Commented] (AIRFLOW-3153) send dag last_run to statsd

2019-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733604#comment-16733604 ] ASF GitHub Bot commented on AIRFLOW-3153: - feng-tao commented on pull request #3997:

[GitHub] feng-tao opened a new pull request #3997: [AIRFLOW-3153] send dag last_run to statsd

2019-01-03 Thread GitBox
feng-tao opened a new pull request #3997: [AIRFLOW-3153] send dag last_run to statsd URL: https://github.com/apache/incubator-airflow/pull/3997 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[GitHub] feng-tao commented on issue #3656: [AIRFLOW-2803] Fix all ESLint issues

2019-01-03 Thread GitBox
feng-tao commented on issue #3656: [AIRFLOW-2803] Fix all ESLint issues URL: https://github.com/apache/incubator-airflow/pull/3656#issuecomment-451301693 @tedmiston , any update on this pr? Are you still planning on working on fixing the issue?

[jira] [Resolved] (AIRFLOW-3578) BigQueryOperator Type Error

2019-01-03 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik resolved AIRFLOW-3578. - Resolution: Fixed > BigQueryOperator Type Error > --- > >

[jira] [Reopened] (AIRFLOW-3578) BigQueryOperator Type Error

2019-01-03 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik reopened AIRFLOW-3578: - > BigQueryOperator Type Error > --- > > Key: AIRFLOW-3578

[GitHub] jgao54 commented on issue #4423: [AIRFLOW-3618] - Fix models.connection.Connection get_hook function

2019-01-03 Thread GitBox
jgao54 commented on issue #4423: [AIRFLOW-3618] - Fix models.connection.Connection get_hook function URL: https://github.com/apache/incubator-airflow/pull/4423#issuecomment-451297332 great! it does look like we are short of an input validation check for CLI that could have made this a

[GitHub] codecov-io edited a comment on issue #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators

2019-01-03 Thread GitBox
codecov-io edited a comment on issue #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators URL: https://github.com/apache/incubator-airflow/pull/4353#issuecomment-449454398 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4353?src=pr=h1) Report > Merging

[GitHub] kaxil removed a comment on issue #4359: [AIRFLOW-3150] Make execution_date templated in TriggerDagRunOperator

2019-01-03 Thread GitBox
kaxil removed a comment on issue #4359: [AIRFLOW-3150] Make execution_date templated in TriggerDagRunOperator URL: https://github.com/apache/incubator-airflow/pull/4359#issuecomment-450831416 @Fokko Done :) This is an

[GitHub] kaxil commented on issue #4359: [AIRFLOW-3150] Make execution_date templated in TriggerDagRunOperator

2019-01-03 Thread GitBox
kaxil commented on issue #4359: [AIRFLOW-3150] Make execution_date templated in TriggerDagRunOperator URL: https://github.com/apache/incubator-airflow/pull/4359#issuecomment-451270935 @Fokko Done :) This is an automated

[GitHub] kaxil commented on issue #4227: [AIRFLOW-3384] Allow higher versions of Sqlalchemy and Jinja2

2019-01-03 Thread GitBox
kaxil commented on issue #4227: [AIRFLOW-3384] Allow higher versions of Sqlalchemy and Jinja2 URL: https://github.com/apache/incubator-airflow/pull/4227#issuecomment-451270640 @ncrocfer Yes this will be available in the next release :) - 1.10.2

[jira] [Commented] (AIRFLOW-2641) Fix MySqlToHiveTransfer to handle MySQL DECIMAL correctly

2019-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733494#comment-16733494 ] ASF GitHub Bot commented on AIRFLOW-2641: - kaxil commented on pull request #4302:

[jira] [Resolved] (AIRFLOW-2641) Fix MySqlToHiveTransfer to handle MySQL DECIMAL correctly

2019-01-03 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik resolved AIRFLOW-2641. - Resolution: Fixed Fix Version/s: 2.0.0 > Fix MySqlToHiveTransfer to handle MySQL

[GitHub] kaxil closed pull request #4302: [AIRFLOW-2641] Fix MySqlToHiveTransfer to handle MySQL DECIMAL correctly

2019-01-03 Thread GitBox
kaxil closed pull request #4302: [AIRFLOW-2641] Fix MySqlToHiveTransfer to handle MySQL DECIMAL correctly URL: https://github.com/apache/incubator-airflow/pull/4302 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] kaxil commented on issue #4351: [AIRFLOW-3554] Remove contrib folder from code cov omit list

2019-01-03 Thread GitBox
kaxil commented on issue #4351: [AIRFLOW-3554] Remove contrib folder from code cov omit list URL: https://github.com/apache/incubator-airflow/pull/4351#issuecomment-451265852 +1 from my side, we are anyway maintaining the entire codebase. But want to hear thought from other committers as

[GitHub] kaxil commented on a change in pull request #4298: [AIRFLOW-3478] Make sure that the session is closed

2019-01-03 Thread GitBox
kaxil commented on a change in pull request #4298: [AIRFLOW-3478] Make sure that the session is closed URL: https://github.com/apache/incubator-airflow/pull/4298#discussion_r245121034 ## File path: airflow/bin/cli.py ## @@ -423,14 +418,11 @@ def unpause(args, dag=None):

[GitHub] kaxil commented on a change in pull request #4298: [AIRFLOW-3478] Make sure that the session is closed

2019-01-03 Thread GitBox
kaxil commented on a change in pull request #4298: [AIRFLOW-3478] Make sure that the session is closed URL: https://github.com/apache/incubator-airflow/pull/4298#discussion_r245121034 ## File path: airflow/bin/cli.py ## @@ -423,14 +418,11 @@ def unpause(args, dag=None):

[GitHub] kaxil commented on a change in pull request #4298: [AIRFLOW-3478] Make sure that the session is closed

2019-01-03 Thread GitBox
kaxil commented on a change in pull request #4298: [AIRFLOW-3478] Make sure that the session is closed URL: https://github.com/apache/incubator-airflow/pull/4298#discussion_r245119909 ## File path: airflow/api/common/experimental/mark_tasks.py ## @@ -180,18 +180,15 @@ def

[jira] [Updated] (AIRFLOW-3191) Fix not being able to specify execution_date when creating dagrun

2019-01-03 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik updated AIRFLOW-3191: Fix Version/s: 1.10.2 > Fix not being able to specify execution_date when creating dagrun >

[GitHub] kaxil commented on a change in pull request #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators

2019-01-03 Thread GitBox
kaxil commented on a change in pull request #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators URL: https://github.com/apache/incubator-airflow/pull/4354#discussion_r245115365 ## File path: airflow/contrib/operators/gcp_bigtable_operator.py ## @@ -0,0 +1,424 @@ +#

[GitHub] kaxil commented on a change in pull request #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators

2019-01-03 Thread GitBox
kaxil commented on a change in pull request #4354: [AIRFLOW-3446] Add Google Cloud BigTable operators URL: https://github.com/apache/incubator-airflow/pull/4354#discussion_r245114534 ## File path: airflow/contrib/example_dags/example_gcp_bigtable_operators.py ## @@ -0,0

[GitHub] potiuk commented on a change in pull request #4350: [AIRFLOW-3527] Cloud SQL Proxy has shorter path for UNIX socket

2019-01-03 Thread GitBox
potiuk commented on a change in pull request #4350: [AIRFLOW-3527] Cloud SQL Proxy has shorter path for UNIX socket URL: https://github.com/apache/incubator-airflow/pull/4350#discussion_r245113784 ## File path: airflow/contrib/hooks/gcp_sql_hook.py ## @@ -437,8 +442,8 @@

[GitHub] kaxil commented on a change in pull request #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators

2019-01-03 Thread GitBox
kaxil commented on a change in pull request #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators URL: https://github.com/apache/incubator-airflow/pull/4353#discussion_r245113466 ## File path: airflow/contrib/operators/gcp_spanner_operator.py ## @@ -197,3

[GitHub] kaxil commented on a change in pull request #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators

2019-01-03 Thread GitBox
kaxil commented on a change in pull request #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators URL: https://github.com/apache/incubator-airflow/pull/4353#discussion_r245112323 ## File path: airflow/contrib/hooks/gcp_spanner_hook.py ## @@ -41,11 +42,12 @@

[GitHub] kaxil commented on a change in pull request #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators

2019-01-03 Thread GitBox
kaxil commented on a change in pull request #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators URL: https://github.com/apache/incubator-airflow/pull/4353#discussion_r245112801 ## File path: airflow/contrib/hooks/gcp_spanner_hook.py ## @@ -168,39 +168,175 @@

[GitHub] kaxil commented on a change in pull request #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators

2019-01-03 Thread GitBox
kaxil commented on a change in pull request #4353: [AIRFLOW-3480] Add Database Deploy/Update/Delete operators URL: https://github.com/apache/incubator-airflow/pull/4353#discussion_r245113059 ## File path: airflow/contrib/operators/gcp_spanner_operator.py ## @@ -197,3

[GitHub] potiuk commented on a change in pull request #4350: [AIRFLOW-3527] Cloud SQL Proxy has shorter path for UNIX socket

2019-01-03 Thread GitBox
potiuk commented on a change in pull request #4350: [AIRFLOW-3527] Cloud SQL Proxy has shorter path for UNIX socket URL: https://github.com/apache/incubator-airflow/pull/4350#discussion_r245112035 ## File path: airflow/contrib/hooks/gcp_sql_hook.py ## @@ -437,8 +442,8 @@

[jira] [Closed] (AIRFLOW-3618) airflow.models.connection.Connection class function get_hook doesn't work

2019-01-03 Thread Ryan Griffin (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Griffin closed AIRFLOW-3618. - Resolution: Not A Problem The issue was that I was adding the connections through the CLI:

[GitHub] potiuk commented on a change in pull request #4350: [AIRFLOW-3527] Cloud SQL Proxy has shorter path for UNIX socket

2019-01-03 Thread GitBox
potiuk commented on a change in pull request #4350: [AIRFLOW-3527] Cloud SQL Proxy has shorter path for UNIX socket URL: https://github.com/apache/incubator-airflow/pull/4350#discussion_r245111924 ## File path: airflow/contrib/hooks/gcp_sql_hook.py ## @@ -437,8 +442,8 @@

[GitHub] kaxil commented on a change in pull request #4350: [AIRFLOW-3527] Cloud SQL Proxy has shorter path for UNIX socket

2019-01-03 Thread GitBox
kaxil commented on a change in pull request #4350: [AIRFLOW-3527] Cloud SQL Proxy has shorter path for UNIX socket URL: https://github.com/apache/incubator-airflow/pull/4350#discussion_r245111422 ## File path: airflow/contrib/hooks/gcp_sql_hook.py ## @@ -437,8 +442,8 @@

[jira] [Commented] (AIRFLOW-3618) airflow.models.connection.Connection class function get_hook doesn't work

2019-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733437#comment-16733437 ] ASF GitHub Bot commented on AIRFLOW-3618: - griff122 commented on pull request #4423:

[GitHub] griff122 commented on issue #4423: [AIRFLOW-3618] - Fix models.connection.Connection get_hook function

2019-01-03 Thread GitBox
griff122 commented on issue #4423: [AIRFLOW-3618] - Fix models.connection.Connection get_hook function URL: https://github.com/apache/incubator-airflow/pull/4423#issuecomment-451254464 @jgao54 - Ahhh, you are correct! I add the airflow connections from the command line during setup:

[GitHub] griff122 closed pull request #4423: [AIRFLOW-3618] - Fix models.connection.Connection get_hook function

2019-01-03 Thread GitBox
griff122 closed pull request #4423: [AIRFLOW-3618] - Fix models.connection.Connection get_hook function URL: https://github.com/apache/incubator-airflow/pull/4423 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] feng-tao closed pull request #4426: [AIRFLOW-XXX] Add a doc on how to add a new role in RBAC UI

2019-01-03 Thread GitBox
feng-tao closed pull request #4426: [AIRFLOW-XXX] Add a doc on how to add a new role in RBAC UI URL: https://github.com/apache/incubator-airflow/pull/4426 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] codecov-io edited a comment on issue #4426: [AIRFLOW-XXX] Add a doc on how to add a new role in RBAC UI

2019-01-03 Thread GitBox
codecov-io edited a comment on issue #4426: [AIRFLOW-XXX] Add a doc on how to add a new role in RBAC UI URL: https://github.com/apache/incubator-airflow/pull/4426#issuecomment-451078091 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4426?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #4426: [AIRFLOW-XXX] Add a doc on how to add a new role in RBAC UI

2019-01-03 Thread GitBox
codecov-io edited a comment on issue #4426: [AIRFLOW-XXX] Add a doc on how to add a new role in RBAC UI URL: https://github.com/apache/incubator-airflow/pull/4426#issuecomment-451078091 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4426?src=pr=h1) Report > Merging

[GitHub] feng-tao commented on issue #4426: [AIRFLOW-XXX] Add a doc on how to add a new role in RBAC UI

2019-01-03 Thread GitBox
feng-tao commented on issue #4426: [AIRFLOW-XXX] Add a doc on how to add a new role in RBAC UI URL: https://github.com/apache/incubator-airflow/pull/4426#issuecomment-451240122 PTAL @jgao54 , doc updated. This is an

[GitHub] codecov-io edited a comment on issue #4350: [AIRFLOW-3527] Cloud SQL Proxy has shorter path for UNIX socket

2019-01-03 Thread GitBox
codecov-io edited a comment on issue #4350: [AIRFLOW-3527] Cloud SQL Proxy has shorter path for UNIX socket URL: https://github.com/apache/incubator-airflow/pull/4350#issuecomment-449404187 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4350?src=pr=h1) Report >

[GitHub] codecov-io edited a comment on issue #4350: [AIRFLOW-3527] Cloud SQL Proxy has shorter path for UNIX socket

2019-01-03 Thread GitBox
codecov-io edited a comment on issue #4350: [AIRFLOW-3527] Cloud SQL Proxy has shorter path for UNIX socket URL: https://github.com/apache/incubator-airflow/pull/4350#issuecomment-449404187 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4350?src=pr=h1) Report >

[GitHub] codecov-io edited a comment on issue #4350: [AIRFLOW-3527] Cloud SQL Proxy has shorter path for UNIX socket

2019-01-03 Thread GitBox
codecov-io edited a comment on issue #4350: [AIRFLOW-3527] Cloud SQL Proxy has shorter path for UNIX socket URL: https://github.com/apache/incubator-airflow/pull/4350#issuecomment-449404187 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4350?src=pr=h1) Report >

[GitHub] feng-tao commented on a change in pull request #4426: [AIRFLOW-XXX] Add a doc on how to add a new role in RBAC UI

2019-01-03 Thread GitBox
feng-tao commented on a change in pull request #4426: [AIRFLOW-XXX] Add a doc on how to add a new role in RBAC UI URL: https://github.com/apache/incubator-airflow/pull/4426#discussion_r245092133 ## File path: docs/howto/add-new-role.rst ## @@ -0,0 +1,33 @@ +.. Licensed

[GitHub] codecov-io edited a comment on issue #4350: [AIRFLOW-3527] Cloud SQL Proxy has shorter path for UNIX socket

2019-01-03 Thread GitBox
codecov-io edited a comment on issue #4350: [AIRFLOW-3527] Cloud SQL Proxy has shorter path for UNIX socket URL: https://github.com/apache/incubator-airflow/pull/4350#issuecomment-449404187 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4350?src=pr=h1) Report >

[GitHub] bryantbiggs commented on a change in pull request #3815: [AIRFLOW-2973] Add Python 3.6 to Supported Prog Langs

2019-01-03 Thread GitBox
bryantbiggs commented on a change in pull request #3815: [AIRFLOW-2973] Add Python 3.6 to Supported Prog Langs URL: https://github.com/apache/incubator-airflow/pull/3815#discussion_r245086284 ## File path: setup.py ## @@ -398,6 +398,7 @@ def do_setup():

[jira] [Commented] (AIRFLOW-3468) Refactor: Move KnownEventType out of models.py

2019-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733313#comment-16733313 ] ASF GitHub Bot commented on AIRFLOW-3468: - BasPH commented on pull request #4381:

[GitHub] holdenk commented on issue #3815: [AIRFLOW-2973] Add Python 3.6 to Supported Prog Langs

2019-01-03 Thread GitBox
holdenk commented on issue #3815: [AIRFLOW-2973] Add Python 3.6 to Supported Prog Langs URL: https://github.com/apache/incubator-airflow/pull/3815#issuecomment-451228263 Hi @gerardo I did some looking into tests.operators.test_virtualenv_operator.test_string_args as well. Looking at

[GitHub] BasPH closed pull request #4381: [AIRFLOW-3468] Move KnownEventType out of models.py

2019-01-03 Thread GitBox
BasPH closed pull request #4381: [AIRFLOW-3468] Move KnownEventType out of models.py URL: https://github.com/apache/incubator-airflow/pull/4381 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[jira] [Commented] (AIRFLOW-3468) Refactor: Move KnownEventType out of models.py

2019-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733309#comment-16733309 ] ASF GitHub Bot commented on AIRFLOW-3468: - BasPH commented on pull request #4381:

[jira] [Commented] (AIRFLOW-3469) Refactor: Move KnownEvent out of models.py

2019-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733310#comment-16733310 ] ASF GitHub Bot commented on AIRFLOW-3469: - BasPH commented on pull request #4382:

[GitHub] BasPH closed pull request #4382: [AIRFLOW-3469] Move KnownEvent out of models.py

2019-01-03 Thread GitBox
BasPH closed pull request #4382: [AIRFLOW-3469] Move KnownEvent out of models.py URL: https://github.com/apache/incubator-airflow/pull/4382 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] BasPH commented on issue #4382: [AIRFLOW-3469] Move KnownEvent out of models.py

2019-01-03 Thread GitBox
BasPH commented on issue #4382: [AIRFLOW-3469] Move KnownEvent out of models.py URL: https://github.com/apache/incubator-airflow/pull/4382#issuecomment-451227670 Closing because https://github.com/apache/incubator-airflow/pull/4421.

[GitHub] BasPH closed pull request #4381: [AIRFLOW-3468] Move KnownEventType out of models.py

2019-01-03 Thread GitBox
BasPH closed pull request #4381: [AIRFLOW-3468] Move KnownEventType out of models.py URL: https://github.com/apache/incubator-airflow/pull/4381 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

  1   2   >