[GitHub] yohei1126 commented on issue #4448: WIP [AIRFLOW-3601] add location support to BigQuery operators

2019-01-06 Thread GitBox
yohei1126 commented on issue #4448: WIP [AIRFLOW-3601] add location support to BigQuery operators URL: https://github.com/apache/airflow/pull/4448#issuecomment-451841742 only this test failed. the master branch has some issues. ``` =

[GitHub] feng-tao commented on a change in pull request #4436: [AIRFLOW-3631] Update flake8 and fix lint.

2019-01-06 Thread GitBox
feng-tao commented on a change in pull request #4436: [AIRFLOW-3631] Update flake8 and fix lint. URL: https://github.com/apache/airflow/pull/4436#discussion_r245550275 ## File path: setup.py ## @@ -262,7 +262,7 @@ def write_version(filename=os.path.join(*['airflow', '

[GitHub] feng-tao commented on a change in pull request #4436: [AIRFLOW-3631] Update flake8 and fix lint.

2019-01-06 Thread GitBox
feng-tao commented on a change in pull request #4436: [AIRFLOW-3631] Update flake8 and fix lint. URL: https://github.com/apache/airflow/pull/4436#discussion_r245550117 ## File path: .flake8 ## @@ -1,3 +1,3 @@ [flake8] max-line-length = 110 -ignore = E731 +ignore = E731,W

[GitHub] feng-tao closed pull request #4453: [AIRFLOW-XXX] Fix existing flake8 errors

2019-01-06 Thread GitBox
feng-tao closed pull request #4453: [AIRFLOW-XXX] Fix existing flake8 errors URL: https://github.com/apache/airflow/pull/4453 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pu

[GitHub] feng-tao commented on issue #4453: [AIRFLOW-XXX] Fix existing flake8 errors

2019-01-06 Thread GitBox
feng-tao commented on issue #4453: [AIRFLOW-XXX] Fix existing flake8 errors URL: https://github.com/apache/airflow/pull/4453#issuecomment-451820750 Flake8 is fixed now. Will merge this pr. This is an automated message from the

[GitHub] feng-tao commented on issue #4407: [AIRFLOW-3600] Remove dagbag from trigger

2019-01-06 Thread GitBox
feng-tao commented on issue #4407: [AIRFLOW-3600] Remove dagbag from trigger URL: https://github.com/apache/airflow/pull/4407#issuecomment-451820642 @ffinfo , @Fokko , it seems that trigger_dag test is quite flaky(test_trigger_dag_button), I have seen it fails in couples of prs(e.g: https:

[GitHub] kppullin commented on issue #4454: [AIRFLOW-3402] Port PR #4247 to 1.10-test

2019-01-06 Thread GitBox
kppullin commented on issue #4454: [AIRFLOW-3402] Port PR #4247 to 1.10-test URL: https://github.com/apache/airflow/pull/4454#issuecomment-451815300 @kaxil - Per your request in #4247, I've done a manual merge to the v1-10-test branch. As noted above, the CI test run is currently fai

[jira] [Commented] (AIRFLOW-3402) Set default kubernetes affinity and toleration settings in airflow.cfg

2019-01-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735435#comment-16735435 ] ASF GitHub Bot commented on AIRFLOW-3402: - kppullin commented on pull request #

[GitHub] kppullin opened a new pull request #4454: [AIRFLOW-3402] Port PR #4247 to 1.10-test

2019-01-06 Thread GitBox
kppullin opened a new pull request #4454: [AIRFLOW-3402] Port PR #4247 to 1.10-test URL: https://github.com/apache/airflow/pull/4454 ### Jira - [X] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR titl

[GitHub] jmcarp commented on a change in pull request #4436: [AIRFLOW-3631] Update flake8 and fix lint.

2019-01-06 Thread GitBox
jmcarp commented on a change in pull request #4436: [AIRFLOW-3631] Update flake8 and fix lint. URL: https://github.com/apache/airflow/pull/4436#discussion_r245541222 ## File path: .flake8 ## @@ -1,3 +1,3 @@ [flake8] max-line-length = 110 -ignore = E731 +ignore = E731,W50

[GitHub] jmcarp commented on a change in pull request #4436: [AIRFLOW-3631] Update flake8 and fix lint.

2019-01-06 Thread GitBox
jmcarp commented on a change in pull request #4436: [AIRFLOW-3631] Update flake8 and fix lint. URL: https://github.com/apache/airflow/pull/4436#discussion_r245537896 ## File path: airflow/settings.py ## @@ -90,7 +90,7 @@ def timing(cls, stat, dt): /| |_ /__ ___/_

[GitHub] jmcarp commented on a change in pull request #4436: [AIRFLOW-3631] Update flake8 and fix lint.

2019-01-06 Thread GitBox
jmcarp commented on a change in pull request #4436: [AIRFLOW-3631] Update flake8 and fix lint. URL: https://github.com/apache/airflow/pull/4436#discussion_r245537760 ## File path: airflow/contrib/executors/kubernetes_executor.py ## @@ -453,7 +453,7 @@ def _make_safe_pod_id

[GitHub] XD-DENG commented on a change in pull request #4436: [AIRFLOW-3631] Update flake8 and fix lint.

2019-01-06 Thread GitBox
XD-DENG commented on a change in pull request #4436: [AIRFLOW-3631] Update flake8 and fix lint. URL: https://github.com/apache/airflow/pull/4436#discussion_r245534313 ## File path: airflow/utils/helpers.py ## @@ -195,7 +195,7 @@ def cross_downstream(from_tasks, to_tasks):

[GitHub] XD-DENG commented on a change in pull request #4436: [AIRFLOW-3631] Update flake8 and fix lint.

2019-01-06 Thread GitBox
XD-DENG commented on a change in pull request #4436: [AIRFLOW-3631] Update flake8 and fix lint. URL: https://github.com/apache/airflow/pull/4436#discussion_r245534288 ## File path: airflow/settings.py ## @@ -90,7 +90,7 @@ def timing(cls, stat, dt): /| |_ /__ ___/_

[GitHub] odracci edited a comment on issue #4444: [AIRFLOW-3281] Fix Kubernetes operator with git-sync

2019-01-06 Thread GitBox
odracci edited a comment on issue #: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/airflow/pull/#issuecomment-451795682 @kaxil @dimberman The missing piece is #3772 I cherry-picked that PR in my branch but I still see (less) flake8 issues.

[GitHub] odracci commented on issue #4444: [AIRFLOW-3281] Fix Kubernetes operator with git-sync

2019-01-06 Thread GitBox
odracci commented on issue #: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/airflow/pull/#issuecomment-451795682 @kaxil @dimberman The missing piece is #3772 I cherry-picked that PR in my branch but I still see (less) flake8 issues. Probl

[GitHub] feng-tao commented on issue #4412: [AIRFLOW-3605] Load plugins from entry_points

2019-01-06 Thread GitBox
feng-tao commented on issue #4412: [AIRFLOW-3605] Load plugins from entry_points URL: https://github.com/apache/airflow/pull/4412#issuecomment-451791915 @drewsonne , this is an interesting change. I will take a look. This is

[GitHub] feng-tao commented on issue #4453: [AIRFLOW-XXX] Fix existing flake8 errors

2019-01-06 Thread GitBox
feng-tao commented on issue #4453: [AIRFLOW-XXX] Fix existing flake8 errors URL: https://github.com/apache/airflow/pull/4453#issuecomment-451791518 PTAL @kaxil This is an automated message from the Apache Git Service. To resp

[GitHub] feng-tao commented on a change in pull request #4436: [AIRFLOW-3631] Update flake8 and fix lint.

2019-01-06 Thread GitBox
feng-tao commented on a change in pull request #4436: [AIRFLOW-3631] Update flake8 and fix lint. URL: https://github.com/apache/airflow/pull/4436#discussion_r245357799 ## File path: airflow/contrib/executors/kubernetes_executor.py ## @@ -453,7 +453,7 @@ def _make_safe_pod_

[GitHub] feng-tao commented on a change in pull request #4436: [AIRFLOW-3631] Update flake8 and fix lint.

2019-01-06 Thread GitBox
feng-tao commented on a change in pull request #4436: [AIRFLOW-3631] Update flake8 and fix lint. URL: https://github.com/apache/airflow/pull/4436#discussion_r245357658 ## File path: .flake8 ## @@ -1,3 +1,3 @@ [flake8] max-line-length = 110 -ignore = E731 +ignore = E731,W

[GitHub] feng-tao opened a new pull request #4453: [AIRFLOW-XXX] Fix existing flake8 errors

2019-01-06 Thread GitBox
feng-tao opened a new pull request #4453: [AIRFLOW-XXX] Fix existing flake8 errors URL: https://github.com/apache/airflow/pull/4453 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/

[GitHub] dimberman commented on issue #4444: [AIRFLOW-3281] Fix Kubernetes operator with git-sync

2019-01-06 Thread GitBox
dimberman commented on issue #: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/airflow/pull/#issuecomment-451786254 Great! I'll have time for that either tonight or tomorrow night (@odracci you're also welcome to take a stab at it should be pret

[GitHub] kaxil commented on issue #4444: [AIRFLOW-3281] Fix Kubernetes operator with git-sync

2019-01-06 Thread GitBox
kaxil commented on issue #: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/airflow/pull/#issuecomment-451785153 It is fine to add flake8 commit as it just changes code formatting. The next release would be 1.11 or 2.0 which would be a direct bra

[GitHub] dimberman commented on issue #4444: [AIRFLOW-3281] Fix Kubernetes operator with git-sync

2019-01-06 Thread GitBox
dimberman commented on issue #: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/airflow/pull/#issuecomment-451784217 I'm fine to fix the flake8 with an extra commit but also don't know whether we want to add in commits that aren't in master to th

[GitHub] dimberman commented on issue #4444: [AIRFLOW-3281] Fix Kubernetes operator with git-sync

2019-01-06 Thread GitBox
dimberman commented on issue #: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/airflow/pull/#issuecomment-451783199 @kaxil I'm seeing a lot of flake8 issues. Is it possible that some commit changed our flake standards from when these PRs were ma

[jira] [Created] (AIRFLOW-3643) Add shebang to docs/start_doc_server.sh

2019-01-06 Thread Kengo Seki (JIRA)
Kengo Seki created AIRFLOW-3643: --- Summary: Add shebang to docs/start_doc_server.sh Key: AIRFLOW-3643 URL: https://issues.apache.org/jira/browse/AIRFLOW-3643 Project: Apache Airflow Issue Type:

[jira] [Created] (AIRFLOW-3642) Fix macOS specific command in CONTRIBUTING.md

2019-01-06 Thread Kengo Seki (JIRA)
Kengo Seki created AIRFLOW-3642: --- Summary: Fix macOS specific command in CONTRIBUTING.md Key: AIRFLOW-3642 URL: https://issues.apache.org/jira/browse/AIRFLOW-3642 Project: Apache Airflow Issue

[jira] [Created] (AIRFLOW-3641) Fix DagModel edit icons in the DAGs page to work

2019-01-06 Thread Kengo Seki (JIRA)
Kengo Seki created AIRFLOW-3641: --- Summary: Fix DagModel edit icons in the DAGs page to work Key: AIRFLOW-3641 URL: https://issues.apache.org/jira/browse/AIRFLOW-3641 Project: Apache Airflow Iss

[jira] [Updated] (AIRFLOW-3640) Enable other operator than python_operator to push custom key-values to xcom and not only XCOM_RETURN_KEY

2019-01-06 Thread Alpesh (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alpesh updated AIRFLOW-3640: Issue Type: Bug (was: Improvement) > Enable other operator than python_operator to push custom key-value

[jira] [Updated] (AIRFLOW-3640) Enable other operator than python_operator to push custom key-values to xcom and not only XCOM_RETURN_KEY

2019-01-06 Thread Alpesh (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alpesh updated AIRFLOW-3640: Flags: Patch,Important Labels: features ready-to-commit (was: ) > Enable other operator than python

[jira] [Commented] (AIRFLOW-3419) S3_hook.select_key is broken on Python3

2019-01-06 Thread Kengo Seki (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735353#comment-16735353 ] Kengo Seki commented on AIRFLOW-3419: - I think {{S3Hook.select_key}} should be fixe

[jira] [Created] (AIRFLOW-3640) Enable other operator than python_operator to push custom key-values to xcom and not only XCOM_RETURN_KEY

2019-01-06 Thread Alpesh (JIRA)
Alpesh created AIRFLOW-3640: --- Summary: Enable other operator than python_operator to push custom key-values to xcom and not only XCOM_RETURN_KEY Key: AIRFLOW-3640 URL: https://issues.apache.org/jira/browse/AIRFLOW-3640

[jira] [Work started] (AIRFLOW-3640) Enable other operator than python_operator to push custom key-values to xcom and not only XCOM_RETURN_KEY

2019-01-06 Thread Alpesh (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on AIRFLOW-3640 started by Alpesh. --- > Enable other operator than python_operator to push custom key-values to xcom > and no

[GitHub] kaxil commented on issue #4293: [AIRFLOW-3284] Add Azure Batch AI Operator

2019-01-06 Thread GitBox
kaxil commented on issue #4293: [AIRFLOW-3284] Add Azure Batch AI Operator URL: https://github.com/apache/airflow/pull/4293#issuecomment-451780402 Can you resolve the conflicts, please? This is an automated message from the Ap

[GitHub] feluelle commented on a change in pull request #4449: [AIRFLOW-3638] Add tests for PrestoToMySqlTransfer

2019-01-06 Thread GitBox
feluelle commented on a change in pull request #4449: [AIRFLOW-3638] Add tests for PrestoToMySqlTransfer URL: https://github.com/apache/airflow/pull/4449#discussion_r245524618 ## File path: tests/operators/test_presto_to_mysql.py ## @@ -0,0 +1,37 @@ +import unittest Rev

[jira] [Resolved] (AIRFLOW-2082) Password Web Authentication is not working

2019-01-06 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik resolved AIRFLOW-2082. - Resolution: Fixed Fix Version/s: 1.10.2 > Password Web Authentication is not working > -

[GitHub] kaxil commented on issue #4442: Update README.md

2019-01-06 Thread GitBox
kaxil commented on issue #4442: Update README.md URL: https://github.com/apache/airflow/pull/4442#issuecomment-451779106 @villoro Thanks for your kind words and using Airflow :-) This is an automated message from the Apache Gi

[GitHub] kaxil closed pull request #4442: Update README.md

2019-01-06 Thread GitBox
kaxil closed pull request #4442: Update README.md URL: https://github.com/apache/airflow/pull/4442 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), t

[GitHub] kaxil closed pull request #4343: [AIRFLOW-2082] Resolve a bug in adding password_auth to API as auth method

2019-01-06 Thread GitBox
kaxil closed pull request #4343: [AIRFLOW-2082] Resolve a bug in adding password_auth to API as auth method URL: https://github.com/apache/airflow/pull/4343 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of prov

[jira] [Commented] (AIRFLOW-2082) Password Web Authentication is not working

2019-01-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735346#comment-16735346 ] ASF GitHub Bot commented on AIRFLOW-2082: - kaxil commented on pull request #434

[jira] [Resolved] (AIRFLOW-3610) Set AWS Region when creating an EMR job flow via EmrCreateJobFlowOperator

2019-01-06 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik resolved AIRFLOW-3610. - Resolution: Fixed Fix Version/s: 1.10.2 > Set AWS Region when creating an EMR job flow v

[jira] [Commented] (AIRFLOW-3610) Set AWS Region when creating an EMR job flow via EmrCreateJobFlowOperator

2019-01-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735344#comment-16735344 ] ASF GitHub Bot commented on AIRFLOW-3610: - kaxil commented on pull request #441

[GitHub] kaxil closed pull request #4418: [AIRFLOW-3610] Add region param for EMR jobflow creation

2019-01-06 Thread GitBox
kaxil closed pull request #4418: [AIRFLOW-3610] Add region param for EMR jobflow creation URL: https://github.com/apache/airflow/pull/4418 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this i

[GitHub] kaxil commented on a change in pull request #4449: [AIRFLOW-3638] Add tests for PrestoToMySqlTransfer

2019-01-06 Thread GitBox
kaxil commented on a change in pull request #4449: [AIRFLOW-3638] Add tests for PrestoToMySqlTransfer URL: https://github.com/apache/airflow/pull/4449#discussion_r245523831 ## File path: tests/operators/test_presto_to_mysql.py ## @@ -0,0 +1,37 @@ +import unittest Review

[jira] [Commented] (AIRFLOW-3531) Add gcs to gcs transfer operator

2019-01-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735340#comment-16735340 ] ASF GitHub Bot commented on AIRFLOW-3531: - kaxil commented on pull request #445

[jira] [Commented] (AIRFLOW-3531) Add gcs to gcs transfer operator

2019-01-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735341#comment-16735341 ] ASF GitHub Bot commented on AIRFLOW-3531: - kaxil commented on pull request #445

[GitHub] kaxil closed pull request #4452: [AIRFLOW-3531] Fix test for GCS to GCS Transfer Hook

2019-01-06 Thread GitBox
kaxil closed pull request #4452: [AIRFLOW-3531] Fix test for GCS to GCS Transfer Hook URL: https://github.com/apache/airflow/pull/4452 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] kaxil opened a new pull request #4452: [AIRFLOW-3531] Fix test for GCS to GCS Transfer Hook

2019-01-06 Thread GitBox
kaxil opened a new pull request #4452: [AIRFLOW-3531] Fix test for GCS to GCS Transfer Hook URL: https://github.com/apache/airflow/pull/4452 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jir

[jira] [Commented] (AIRFLOW-3630) Google Cloud SQL query Operator cleanup will not close the connection on error

2019-01-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735312#comment-16735312 ] ASF GitHub Bot commented on AIRFLOW-3630: - potiuk commented on pull request #44

[GitHub] potiuk opened a new pull request #4451: [AIRFLOW-3630] Cleanup of generated connection is done also on exception

2019-01-06 Thread GitBox
potiuk opened a new pull request #4451: [AIRFLOW-3630] Cleanup of generated connection is done also on exception URL: https://github.com/apache/airflow/pull/4451 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow Jira](https://

[GitHub] kaxil commented on a change in pull request #4362: [AIRFLOW-3559] Add missing options to DatadogHook.

2019-01-06 Thread GitBox
kaxil commented on a change in pull request #4362: [AIRFLOW-3559] Add missing options to DatadogHook. URL: https://github.com/apache/airflow/pull/4362#discussion_r245520403 ## File path: airflow/contrib/hooks/datadog_hook.py ## @@ -47,26 +47,15 @@ def __init__(self, datado

[jira] [Resolved] (AIRFLOW-3531) Add gcs to gcs transfer operator

2019-01-06 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik resolved AIRFLOW-3531. - Resolution: Fixed Fix Version/s: 1.10.2 > Add gcs to gcs transfer operator > ---

[jira] [Commented] (AIRFLOW-3531) Add gcs to gcs transfer operator

2019-01-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735291#comment-16735291 ] ASF GitHub Bot commented on AIRFLOW-3531: - kaxil commented on pull request #433

[GitHub] kaxil closed pull request #4331: [AIRFLOW-3531] Add gcs to gcs transfer operator.

2019-01-06 Thread GitBox
kaxil closed pull request #4331: [AIRFLOW-3531] Add gcs to gcs transfer operator. URL: https://github.com/apache/airflow/pull/4331 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fore

[GitHub] kaxil commented on issue #4444: Fix merge conflicts for [AIRFLOW-3281]

2019-01-06 Thread GitBox
kaxil commented on issue #: Fix merge conflicts for [AIRFLOW-3281] URL: https://github.com/apache/airflow/pull/#issuecomment-451767881 Thank you guys, yes @dimberman you can just change it to the name/description of #3770? And yup docker-compose stuff is not in this branch

[jira] [Commented] (AIRFLOW-3624) Add masterType parameter to MLEngineTrainingOperator

2019-01-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735274#comment-16735274 ] ASF GitHub Bot commented on AIRFLOW-3624: - jgao54 commented on pull request #44

[GitHub] jgao54 closed pull request #4428: [AIRFLOW-3624] Add masterType parameter to MLEngineTrainingOperator

2019-01-06 Thread GitBox
jgao54 closed pull request #4428: [AIRFLOW-3624] Add masterType parameter to MLEngineTrainingOperator URL: https://github.com/apache/airflow/pull/4428 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance

[GitHub] jmcarp commented on issue #4436: [AIRFLOW-3631] Update flake8 and fix lint.

2019-01-06 Thread GitBox
jmcarp commented on issue #4436: [AIRFLOW-3631] Update flake8 and fix lint. URL: https://github.com/apache/airflow/pull/4436#issuecomment-451762085 I see @XD-DENG and @Fokko have been fixing flake8 lint, so pinging you both here.

[GitHub] jmcarp commented on issue #4390: [AIRFLOW-3584] Use ORM DAGs for index view.

2019-01-06 Thread GitBox
jmcarp commented on issue #4390: [AIRFLOW-3584] Use ORM DAGs for index view. URL: https://github.com/apache/airflow/pull/4390#issuecomment-451762025 PTAL @ffinfo @Fokko This is an automated message from the Apache Git Service

[GitHub] jmcarp commented on issue #4362: [AIRFLOW-3559] Add missing options to DatadogHook.

2019-01-06 Thread GitBox
jmcarp commented on issue #4362: [AIRFLOW-3559] Add missing options to DatadogHook. URL: https://github.com/apache/airflow/pull/4362#issuecomment-451761923 PTAL when you have time @kaxil This is an automated message from the

[GitHub] jmcarp commented on issue #4331: [AIRFLOW-3531] Add gcs to gcs transfer operator.

2019-01-06 Thread GitBox
jmcarp commented on issue #4331: [AIRFLOW-3531] Add gcs to gcs transfer operator. URL: https://github.com/apache/airflow/pull/4331#issuecomment-451761860 Ready for another look when you have time @kaxil This is an automated

[GitHub] odracci commented on issue #4444: Fix merge conflicts for [AIRFLOW-3281]

2019-01-06 Thread GitBox
odracci commented on issue #: Fix merge conflicts for [AIRFLOW-3281] URL: https://github.com/apache/airflow/pull/#issuecomment-451759433 @dimberman I tried to merge #3770 into `1.10-test` in this branch https://github.com/odracci/incubator-airflow/tree/1-10-with-git-sync-v2 The b

[GitHub] aliceabe commented on issue #4447: [AIRFLOW-3637] Fix test for HiveToMySqlTransfer Operator

2019-01-06 Thread GitBox
aliceabe commented on issue #4447: [AIRFLOW-3637] Fix test for HiveToMySqlTransfer Operator URL: https://github.com/apache/airflow/pull/4447#issuecomment-451750281 Thank you @feng-tao This is an automated message from the Ap

[jira] [Commented] (AIRFLOW-3639) Jenkins Operator does not set up "Authorization" header correctly

2019-01-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735184#comment-16735184 ] ASF GitHub Bot commented on AIRFLOW-3639: - vapiravfif commented on pull request

[GitHub] vapiravfif opened a new pull request #4450: [AIRFLOW-3639] Fix request creation in Jenkins Operator

2019-01-06 Thread GitBox
vapiravfif opened a new pull request #4450: [AIRFLOW-3639] Fix request creation in Jenkins Operator URL: https://github.com/apache/airflow/pull/4450 ### Jira - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references

[jira] [Created] (AIRFLOW-3639) Jenkins Operator does not set up "Authorization" header correctly

2019-01-06 Thread Maria Rebelka (JIRA)
Maria Rebelka created AIRFLOW-3639: -- Summary: Jenkins Operator does not set up "Authorization" header correctly Key: AIRFLOW-3639 URL: https://issues.apache.org/jira/browse/AIRFLOW-3639 Project: Apac

[GitHub] yohei1126 edited a comment on issue #4446: [AIRFLOW-3636] Fix a test introduced in #4425

2019-01-06 Thread GitBox
yohei1126 edited a comment on issue #4446: [AIRFLOW-3636] Fix a test introduced in #4425 URL: https://github.com/apache/airflow/pull/4446#issuecomment-451734862 This test failed on the latest master branch. Would you check it? https://travis-ci.org/apache/airflow/builds/475904686 ```

[GitHub] yohei1126 commented on issue #4446: [AIRFLOW-3636] Fix a test introduced in #4425

2019-01-06 Thread GitBox
yohei1126 commented on issue #4446: [AIRFLOW-3636] Fix a test introduced in #4425 URL: https://github.com/apache/airflow/pull/4446#issuecomment-451734862 This test failed on the latest master branch. Would you check it? ``` =

[jira] [Closed] (AIRFLOW-3580) Add tests for HiveToMySqlOperator

2019-01-06 Thread Felix Uellendall (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Uellendall closed AIRFLOW-3580. - Resolution: Fixed > Add tests for HiveToMySqlOperator > ---

[jira] [Closed] (AIRFLOW-3595) Add tests for HiveToSambaOperator

2019-01-06 Thread Felix Uellendall (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Uellendall closed AIRFLOW-3595. - Resolution: Fixed > Add tests for HiveToSambaOperator > ---

[jira] [Commented] (AIRFLOW-3638) Add tests for PrestoToMySqlTransfer

2019-01-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735148#comment-16735148 ] ASF GitHub Bot commented on AIRFLOW-3638: - feluelle commented on pull request #

[GitHub] feluelle opened a new pull request #4449: [AIRFLOW-3638] Add tests for PrestoToMySqlTransfer

2019-01-06 Thread GitBox
feluelle opened a new pull request #4449: [AIRFLOW-3638] Add tests for PrestoToMySqlTransfer URL: https://github.com/apache/airflow/pull/4449 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/ji

[jira] [Created] (AIRFLOW-3638) Add tests for PrestoToMySqlTransfer

2019-01-06 Thread Felix Uellendall (JIRA)
Felix Uellendall created AIRFLOW-3638: - Summary: Add tests for PrestoToMySqlTransfer Key: AIRFLOW-3638 URL: https://issues.apache.org/jira/browse/AIRFLOW-3638 Project: Apache Airflow Issu

[GitHub] XD-DENG commented on a change in pull request #4309: [AIRFLOW-3504] Extend/refine the functionality of "/health" endpoint

2019-01-06 Thread GitBox
XD-DENG commented on a change in pull request #4309: [AIRFLOW-3504] Extend/refine the functionality of "/health" endpoint URL: https://github.com/apache/airflow/pull/4309#discussion_r245502264 ## File path: airflow/www/blueprints.py ## @@ -32,6 +37,26 @@ def index(): @r

[GitHub] XD-DENG commented on a change in pull request #4309: [AIRFLOW-3504] Extend/refine the functionality of "/health" endpoint

2019-01-06 Thread GitBox
XD-DENG commented on a change in pull request #4309: [AIRFLOW-3504] Extend/refine the functionality of "/health" endpoint URL: https://github.com/apache/airflow/pull/4309#discussion_r245502264 ## File path: airflow/www/blueprints.py ## @@ -32,6 +37,26 @@ def index(): @r

[GitHub] feluelle commented on issue #4399: [AIRFLOW-3594] Unify different License Header

2019-01-06 Thread GitBox
feluelle commented on issue #4399: [AIRFLOW-3594] Unify different License Header URL: https://github.com/apache/airflow/pull/4399#issuecomment-451727600 @Fokko would you mind restart the tests :) This is an automated message f

[GitHub] feluelle commented on issue #4405: [AIRFLOW-3598] Add tests for MsSqlToHiveTransfer

2019-01-06 Thread GitBox
feluelle commented on issue #4405: [AIRFLOW-3598] Add tests for MsSqlToHiveTransfer URL: https://github.com/apache/airflow/pull/4405#issuecomment-451727567 @Fokko would you mind restart the tests :) This is an automated messa

[GitHub] feluelle commented on a change in pull request #4447: [AIRFLOW-3637] Fix test for HiveToMySqlTransfer Operator

2019-01-06 Thread GitBox
feluelle commented on a change in pull request #4447: [AIRFLOW-3637] Fix test for HiveToMySqlTransfer Operator URL: https://github.com/apache/airflow/pull/4447#discussion_r245501705 ## File path: tests/operators/test_hive_to_mysql.py ## @@ -43,7 +43,7 @@ def test_execute(s

[GitHub] feng-tao commented on issue #4446: [AIRFLOW-3636] Fix a test introduced in #4425

2019-01-06 Thread GitBox
feng-tao commented on issue #4446: [AIRFLOW-3636] Fix a test introduced in #4425 URL: https://github.com/apache/airflow/pull/4446#issuecomment-451726896 @yohei1126 , the travis CI is broken which introduces some test failure in master branch. With the latest three commits in master branch,

[GitHub] yohei1126 commented on issue #4446: [AIRFLOW-3636] Fix a test introduced in #4425

2019-01-06 Thread GitBox
yohei1126 commented on issue #4446: [AIRFLOW-3636] Fix a test introduced in #4425 URL: https://github.com/apache/airflow/pull/4446#issuecomment-451726787 @feng-tao your build was failed https://travis-ci.org/apache/airflow/builds/475904686 -

[GitHub] yohei1126 edited a comment on issue #4446: [AIRFLOW-3636] Fix a test introduced in #4425

2019-01-06 Thread GitBox
yohei1126 edited a comment on issue #4446: [AIRFLOW-3636] Fix a test introduced in #4425 URL: https://github.com/apache/airflow/pull/4446#issuecomment-451726787 @pingzh @feng-tao your build was failed https://travis-ci.org/apache/airflow/builds/475904686 --

[jira] [Commented] (AIRFLOW-3601) update operators to BigQuery to support location

2019-01-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735124#comment-16735124 ] ASF GitHub Bot commented on AIRFLOW-3601: - yohei1126 commented on pull request

[jira] [Commented] (AIRFLOW-3601) update operators to BigQuery to support location

2019-01-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735123#comment-16735123 ] ASF GitHub Bot commented on AIRFLOW-3601: - yohei1126 commented on pull request

[GitHub] yohei1126 closed pull request #4409: WIP [AIRFLOW-3601] add location support to BigQuery operators

2019-01-06 Thread GitBox
yohei1126 closed pull request #4409: WIP [AIRFLOW-3601] add location support to BigQuery operators URL: https://github.com/apache/airflow/pull/4409 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] yohei1126 commented on issue #4409: WIP [AIRFLOW-3601] add location support to BigQuery operators

2019-01-06 Thread GitBox
yohei1126 commented on issue #4409: WIP [AIRFLOW-3601] add location support to BigQuery operators URL: https://github.com/apache/airflow/pull/4409#issuecomment-451724720 sorry recreated a PR https://github.com/apache/airflow/pull/4448 ---

[GitHub] yohei1126 opened a new pull request #4448: WIP [AIRFLOW-3601] add location support to BigQuery operators

2019-01-06 Thread GitBox
yohei1126 opened a new pull request #4448: WIP [AIRFLOW-3601] add location support to BigQuery operators URL: https://github.com/apache/airflow/pull/4448 ### Jira - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references

[GitHub] ffinfo commented on issue #4445: [AIRFLOW-3635] Fix incorrect logic in detele_dag (introduced in PR#4406)

2019-01-06 Thread GitBox
ffinfo commented on issue #4445: [AIRFLOW-3635] Fix incorrect logic in detele_dag (introduced in PR#4406) URL: https://github.com/apache/airflow/pull/4445#issuecomment-451724101 Sorry for this. Did maybe rely to much on the testing ;). Thanks for fixing this --