[GitHub] [airflow] feluelle edited a comment on issue #4810: [AIRFLOW-3985] Added unary + operator for easier linear DAG building

2019-03-05 Thread GitBox
feluelle edited a comment on issue #4810: [AIRFLOW-3985] Added unary + operator for easier linear DAG building URL: https://github.com/apache/airflow/pull/4810#issuecomment-469642996 The `+` operator for this kind of dependency chaining looks very strange to me. Otherwise I think your

[jira] [Commented] (AIRFLOW-3795) provide_context is not a passable parameter for PythonVirtualenvOperator

2019-03-05 Thread Sergio Soto (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785386#comment-16785386 ] Sergio Soto commented on AIRFLOW-3795: -- This bug is related with other > provide_context is not a

[jira] [Created] (AIRFLOW-4024) Improve local client tests

2019-03-05 Thread Peter van 't Hof (JIRA)
Peter van 't Hof created AIRFLOW-4024: - Summary: Improve local client tests Key: AIRFLOW-4024 URL: https://issues.apache.org/jira/browse/AIRFLOW-4024 Project: Apache Airflow Issue Type:

[GitHub] [airflow] ffinfo opened a new pull request #4850: [AIRFLOW-???] Improve local client tests

2019-03-05 Thread GitBox
ffinfo opened a new pull request #4850: [AIRFLOW-???] Improve local client tests URL: https://github.com/apache/airflow/pull/4850 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[GitHub] [airflow] feng-tao commented on issue #4849: [AIRFLOW-XXX] Avoid spamming the log from Airflow security manager

2019-03-05 Thread GitBox
feng-tao commented on issue #4849: [AIRFLOW-XXX] Avoid spamming the log from Airflow security manager URL: https://github.com/apache/airflow/pull/4849#issuecomment-469987974 cc @ashb this is part of today's pr discussion. Let me know if I need to create a jira.

[GitHub] [airflow] feng-tao opened a new pull request #4849: [AIRFLOW-XXX] Avoid spamming the log from Airflow security manager

2019-03-05 Thread GitBox
feng-tao opened a new pull request #4849: [AIRFLOW-XXX] Avoid spamming the log from Airflow security manager URL: https://github.com/apache/airflow/pull/4849 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[jira] [Commented] (AIRFLOW-3948) Operator list as templated field issue

2019-03-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785271#comment-16785271 ] ASF GitHub Bot commented on AIRFLOW-3948: - ryanyuan commented on pull request #4770:

[GitHub] [airflow] ryanyuan closed pull request #4770: [AIRFLOW-3948] GCSToBQOperator list as templating field issue

2019-03-05 Thread GitBox
ryanyuan closed pull request #4770: [AIRFLOW-3948] GCSToBQOperator list as templating field issue URL: https://github.com/apache/airflow/pull/4770 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (AIRFLOW-3948) Operator list as templated field issue

2019-03-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785267#comment-16785267 ] ASF GitHub Bot commented on AIRFLOW-3948: - ryanyuan commented on pull request #4848:

[GitHub] [airflow] ryanyuan opened a new pull request #4848: [AIRFLOW-3948] Operator list as templated field issue

2019-03-05 Thread GitBox
ryanyuan opened a new pull request #4848: [AIRFLOW-3948] Operator list as templated field issue URL: https://github.com/apache/airflow/pull/4848 Operator list as templated field This is a global fix for #4770 Make sure you have checked _all_ steps below. ### Jira

[GitHub] [airflow] XD-DENG commented on a change in pull request #4828: [AIRFLOW-4002] Optionally open debugger on errors in airflow test.

2019-03-05 Thread GitBox
XD-DENG commented on a change in pull request #4828: [AIRFLOW-4002] Optionally open debugger on errors in airflow test. URL: https://github.com/apache/airflow/pull/4828#discussion_r262805339 ## File path: airflow/bin/cli.py ## @@ -2032,6 +2047,11 @@ class

[GitHub] [airflow] XD-DENG commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag details

2019-03-05 Thread GitBox
XD-DENG commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag details URL: https://github.com/apache/airflow/pull/4569#issuecomment-469983947 @feng-tao sure. Maybe let me create a ticket for this later maybe. Will tag you then for our reference.

[jira] [Updated] (AIRFLOW-3948) Operator list as templated field issue

2019-03-05 Thread Ryan Yuan (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Yuan updated AIRFLOW-3948: --- Description: Fixing issue with operators' list as templated field issue   For example, with

[GitHub] [airflow] sasso commented on issue #4574: [AIRFLOW-3751] Ignore malformed ldap schema option

2019-03-05 Thread GitBox
sasso commented on issue #4574: [AIRFLOW-3751] Ignore malformed ldap schema option URL: https://github.com/apache/airflow/pull/4574#issuecomment-469983575 :pray: This is an automated message from the Apache Git Service. To

[GitHub] [airflow] feng-tao edited a comment on issue #4642: [AIRFLOW-2694] Declare permissions in DAG definition

2019-03-05 Thread GitBox
feng-tao edited a comment on issue #4642: [AIRFLOW-2694] Declare permissions in DAG definition URL: https://github.com/apache/airflow/pull/4642#issuecomment-469981324 There are so many different discussions today. Here is another long list(https://github.com/apache/airflow/pull/4569).

[GitHub] [airflow] feng-tao edited a comment on issue #4642: [AIRFLOW-2694] Declare permissions in DAG definition

2019-03-05 Thread GitBox
feng-tao edited a comment on issue #4642: [AIRFLOW-2694] Declare permissions in DAG definition URL: https://github.com/apache/airflow/pull/4642#issuecomment-469981324 There are so many different discussions today. Here is another long list(https://github.com/apache/airflow/pull/4569).

[GitHub] [airflow] feng-tao commented on issue #4642: [AIRFLOW-2694] Declare permissions in DAG definition

2019-03-05 Thread GitBox
feng-tao commented on issue #4642: [AIRFLOW-2694] Declare permissions in DAG definition URL: https://github.com/apache/airflow/pull/4642#issuecomment-469981324 There are so many different discussions today. Here is another long list(https://github.com/apache/airflow/pull/4569).

[GitHub] [airflow] feng-tao commented on issue #4685: [AIRFLOW-3862] Check types with mypy.

2019-03-05 Thread GitBox
feng-tao commented on issue #4685: [AIRFLOW-3862] Check types with mypy. URL: https://github.com/apache/airflow/pull/4685#issuecomment-469979194 side question, I thought mypy doesn't work with python 2.7? Or we won't do mypy when it is in py2.7?

[GitHub] [airflow] jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy.

2019-03-05 Thread GitBox
jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy. URL: https://github.com/apache/airflow/pull/4685#discussion_r262799908 ## File path: airflow/contrib/operators/adls_list_operator.py ## @@ -46,7 +48,7 @@ class

[GitHub] [airflow] feng-tao commented on issue #4712: [AIRFLOW-3892] Create Redis pub sub sensor

2019-03-05 Thread GitBox
feng-tao commented on issue #4712: [AIRFLOW-3892] Create Redis pub sub sensor URL: https://github.com/apache/airflow/pull/4712#issuecomment-469969811 @mans2singh , I think we are fine. But could we remove that example dag as I don't think we need that given the sensor is not complicated?

[GitHub] [airflow] mans2singh commented on issue #4712: [AIRFLOW-3892] Create Redis pub sub sensor

2019-03-05 Thread GitBox
mans2singh commented on issue #4712: [AIRFLOW-3892] Create Redis pub sub sensor URL: https://github.com/apache/airflow/pull/4712#issuecomment-469967564 @zhongjiajie - I kicked off another build and it is [passing](https://travis-ci.org/mans2singh/airflow/builds/502373240) but this

[jira] [Closed] (AIRFLOW-4023) Fix DataProcOperator templating field names

2019-03-05 Thread Ryan Yuan (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Yuan closed AIRFLOW-4023. -- Resolution: Not A Problem > Fix DataProcOperator templating field names >

[GitHub] [airflow] jmcarp commented on a change in pull request #4828: [AIRFLOW-4002] Optionally open debugger on errors in airflow test.

2019-03-05 Thread GitBox
jmcarp commented on a change in pull request #4828: [AIRFLOW-4002] Optionally open debugger on errors in airflow test. URL: https://github.com/apache/airflow/pull/4828#discussion_r262790267 ## File path: airflow/bin/cli.py ## @@ -2032,6 +2047,11 @@ class

[GitHub] [airflow] jmcarp commented on a change in pull request #4828: [AIRFLOW-4002] Optionally open debugger on errors in airflow test.

2019-03-05 Thread GitBox
jmcarp commented on a change in pull request #4828: [AIRFLOW-4002] Optionally open debugger on errors in airflow test. URL: https://github.com/apache/airflow/pull/4828#discussion_r262790183 ## File path: airflow/bin/cli.py ## @@ -686,10 +687,24 @@ def test(args,

[GitHub] [airflow] ryanyuan closed pull request #4847: [AIRFLOW-4023] Fix DataProcOperator templating field names

2019-03-05 Thread GitBox
ryanyuan closed pull request #4847: [AIRFLOW-4023] Fix DataProcOperator templating field names URL: https://github.com/apache/airflow/pull/4847 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (AIRFLOW-4023) Fix DataProcOperator templating field names

2019-03-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785216#comment-16785216 ] ASF GitHub Bot commented on AIRFLOW-4023: - ryanyuan commented on pull request #4847:

[GitHub] [airflow] XD-DENG commented on a change in pull request #4828: [AIRFLOW-4002] Optionally open debugger on errors in airflow test.

2019-03-05 Thread GitBox
XD-DENG commented on a change in pull request #4828: [AIRFLOW-4002] Optionally open debugger on errors in airflow test. URL: https://github.com/apache/airflow/pull/4828#discussion_r262787268 ## File path: airflow/bin/cli.py ## @@ -2032,6 +2047,11 @@ class

[GitHub] [airflow] XD-DENG commented on a change in pull request #4828: [AIRFLOW-4002] Optionally open debugger on errors in airflow test.

2019-03-05 Thread GitBox
XD-DENG commented on a change in pull request #4828: [AIRFLOW-4002] Optionally open debugger on errors in airflow test. URL: https://github.com/apache/airflow/pull/4828#discussion_r262787613 ## File path: airflow/bin/cli.py ## @@ -686,10 +687,24 @@ def test(args,

[jira] [Commented] (AIRFLOW-4023) Fix DataProcOperator templating field names

2019-03-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785188#comment-16785188 ] ASF GitHub Bot commented on AIRFLOW-4023: - ryanyuan commented on pull request #4847:

[jira] [Work started] (AIRFLOW-4023) Fix DataProcOperator templating field names

2019-03-05 Thread Ryan Yuan (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on AIRFLOW-4023 started by Ryan Yuan. -- > Fix DataProcOperator templating field names >

[GitHub] [airflow] ryanyuan opened a new pull request #4847: [AIRFLOW-4023] Fix DataProcOperator templating field names

2019-03-05 Thread GitBox
ryanyuan opened a new pull request #4847: [AIRFLOW-4023] Fix DataProcOperator templating field names URL: https://github.com/apache/airflow/pull/4847 Fix DataProcOperator templating field names Make sure you have checked _all_ steps below. ### Jira - [ ] My PR

[jira] [Created] (AIRFLOW-4023) Fix DataProcOperator templating field names

2019-03-05 Thread Ryan Yuan (JIRA)
Ryan Yuan created AIRFLOW-4023: -- Summary: Fix DataProcOperator templating field names Key: AIRFLOW-4023 URL: https://issues.apache.org/jira/browse/AIRFLOW-4023 Project: Apache Airflow Issue

[GitHub] [airflow] jmcarp commented on issue #4828: [AIRFLOW-4002] Optionally open debugger on errors in airflow test.

2019-03-05 Thread GitBox
jmcarp commented on issue #4828: [AIRFLOW-4002] Optionally open debugger on errors in airflow test. URL: https://github.com/apache/airflow/pull/4828#issuecomment-469947705 Added `ipdb` detection. Ready for review when you have time @ashb @XD-DENG @feng-tao.

[GitHub] [airflow] codecov-io edited a comment on issue #4828: [AIRFLOW-4002] Optionally open debugger on errors in airflow test.

2019-03-05 Thread GitBox
codecov-io edited a comment on issue #4828: [AIRFLOW-4002] Optionally open debugger on errors in airflow test. URL: https://github.com/apache/airflow/pull/4828#issuecomment-469055338 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4828?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #4828: [AIRFLOW-4002] Optionally open debugger on errors in airflow test.

2019-03-05 Thread GitBox
codecov-io edited a comment on issue #4828: [AIRFLOW-4002] Optionally open debugger on errors in airflow test. URL: https://github.com/apache/airflow/pull/4828#issuecomment-469055338 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4828?src=pr=h1) Report > Merging

[GitHub] [airflow] aoen commented on issue #4396: [AIRFLOW-3585] - Add edges to database

2019-03-05 Thread GitBox
aoen commented on issue #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#issuecomment-469942061 Sorry Ash, missed your reply. Kevin is correct, we should extend SimpleDag to contain edge information and store the serialized representation of

[GitHub] [airflow] XD-DENG edited a comment on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag details

2019-03-05 Thread GitBox
XD-DENG edited a comment on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag details URL: https://github.com/apache/airflow/pull/4569#issuecomment-469920279 > @XD-DENG , I don't think it will add 2000 entries to the db for admin role. It only adds the "all_dags" view-menu with

[GitHub] [airflow] jyothsnapk17 commented on issue #4835: [AIRFLOW-XXXX] Improvements to formatted content in documentation

2019-03-05 Thread GitBox
jyothsnapk17 commented on issue #4835: [AIRFLOW-] Improvements to formatted content in documentation URL: https://github.com/apache/airflow/pull/4835#issuecomment-469925927 @mik-laj , The build stalled on the Kubernetes tests. Does it necessarily have to be fixed with this PR?

[GitHub] [airflow] zhongjiajie commented on issue #4712: [AIRFLOW-3892] Create Redis pub sub sensor

2019-03-05 Thread GitBox
zhongjiajie commented on issue #4712: [AIRFLOW-3892] Create Redis pub sub sensor URL: https://github.com/apache/airflow/pull/4712#issuecomment-469923984 @mans2singh The CI currently flaky, If you could not find detail error, maybe you could submit and restart CI test again.

[GitHub] [airflow] mans2singh commented on issue #4712: [AIRFLOW-3892] Create Redis pub sub sensor

2019-03-05 Thread GitBox
mans2singh commented on issue #4712: [AIRFLOW-3892] Create Redis pub sub sensor URL: https://github.com/apache/airflow/pull/4712#issuecomment-469920927 Hi @feng-tao - I've rebased the code and the integration unit/tests for redis sensor are passing locally. It looks like [two

[GitHub] [airflow] XD-DENG edited a comment on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag details

2019-03-05 Thread GitBox
XD-DENG edited a comment on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag details URL: https://github.com/apache/airflow/pull/4569#issuecomment-469920279 > @XD-DENG , I don't think it will add 2000 entries to the db for admin role. It only adds the "all_dags" view-menu with

[GitHub] [airflow] XD-DENG commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag details

2019-03-05 Thread GitBox
XD-DENG commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag details URL: https://github.com/apache/airflow/pull/4569#issuecomment-469920279 > @XD-DENG , I don't think it will add 2000 entries to the db for admin role. It only adds the "all_dags" view-menu with the 2

[jira] [Commented] (AIRFLOW-3981) Make Airflow UI timezone aware

2019-03-05 Thread Tao Feng (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785079#comment-16785079 ] Tao Feng commented on AIRFLOW-3981: --- cc [~verdan] our Airflow UI expect   [~tronbabylove] I asked

[jira] [Updated] (AIRFLOW-4022) Airflow on Kubernetes tutorial fails at finding ./docker/compile.sh

2019-03-05 Thread Rob Schoenbeck (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Schoenbeck updated AIRFLOW-4022: Description: kubectl 1.11.8, client 1.13.3, minikube v0.34.1 Steps to reproduce: Simply

[jira] [Commented] (AIRFLOW-4022) Airflow on Kubernetes tutorial fails at finding ./docker/compile.sh

2019-03-05 Thread Rob Schoenbeck (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785052#comment-16785052 ] Rob Schoenbeck commented on AIRFLOW-4022: - Also apparently failing:

[GitHub] [airflow] codecov-io edited a comment on issue #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2019-03-05 Thread GitBox
codecov-io edited a comment on issue #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#issuecomment-466029246 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4751?src=pr=h1) Report > Merging

[GitHub] [airflow] pgagnon commented on issue #4648: [AIRFLOW-3274] Add run_as_user and fs_group options for Kubernetes

2019-03-05 Thread GitBox
pgagnon commented on issue #4648: [AIRFLOW-3274] Add run_as_user and fs_group options for Kubernetes URL: https://github.com/apache/airflow/pull/4648#issuecomment-469905909 @dmateusp In this PR I would be modifying slightly the functionality you added in #4777, specifically with regards

[jira] [Created] (AIRFLOW-4022) Airflow on Kubernetes fails at finding ./docker/compile.sh

2019-03-05 Thread Rob Schoenbeck (JIRA)
Rob Schoenbeck created AIRFLOW-4022: --- Summary: Airflow on Kubernetes fails at finding ./docker/compile.sh Key: AIRFLOW-4022 URL: https://issues.apache.org/jira/browse/AIRFLOW-4022 Project: Apache

[jira] [Updated] (AIRFLOW-4022) Airflow on Kubernetes tutorial fails at finding ./docker/compile.sh

2019-03-05 Thread Rob Schoenbeck (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Schoenbeck updated AIRFLOW-4022: Summary: Airflow on Kubernetes tutorial fails at finding ./docker/compile.sh (was:

[GitHub] [airflow] vsoch opened a new pull request #4846: [WIP] adding start to singularity for airflow

2019-03-05 Thread GitBox
vsoch opened a new pull request #4846: [WIP] adding start to singularity for airflow URL: https://github.com/apache/airflow/pull/4846 Hey airflow maintainers! I'm working on an operator for [Singularity containers](https://sylabs.io/guides/3.0/user-guide/), and I have a very basic

[jira] [Commented] (AIRFLOW-4020) remove viewer DAG edit permission

2019-03-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785026#comment-16785026 ] ASF GitHub Bot commented on AIRFLOW-4020: - feng-tao commented on pull request #4845:

[jira] [Resolved] (AIRFLOW-4020) remove viewer DAG edit permission

2019-03-05 Thread Tao Feng (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tao Feng resolved AIRFLOW-4020. --- Resolution: Fixed Fix Version/s: 1.10.3 > remove viewer DAG edit permission >

[jira] [Commented] (AIRFLOW-4020) remove viewer DAG edit permission

2019-03-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785027#comment-16785027 ] ASF subversion and git services commented on AIRFLOW-4020: -- Commit

[GitHub] [airflow] feng-tao merged pull request #4845: [AIRFLOW-4020] Remove viewer DAG edit permissions

2019-03-05 Thread GitBox
feng-tao merged pull request #4845: [AIRFLOW-4020] Remove viewer DAG edit permissions URL: https://github.com/apache/airflow/pull/4845 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] feng-tao edited a comment on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag details

2019-03-05 Thread GitBox
feng-tao edited a comment on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag details URL: https://github.com/apache/airflow/pull/4569#issuecomment-469834959 @ashb , I see. Your deploy is based on 1.10.2 not on master? I think I fail to get this pr into 1.10.2 as the release

[GitHub] [airflow] ashb commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag details

2019-03-05 Thread GitBox
ashb commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag details URL: https://github.com/apache/airflow/pull/4569#issuecomment-469896394 Oh thanks, I hadn't seen that diagram! This is an automated

[GitHub] [airflow] XD-DENG commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag details

2019-03-05 Thread GitBox
XD-DENG commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag details URL: https://github.com/apache/airflow/pull/4569#issuecomment-469896272 Thanks @feng-tao . let me double-check the code later today and will let you know if I still have confusion on it.

[GitHub] [airflow] feng-tao commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag details

2019-03-05 Thread GitBox
feng-tao commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag details URL: https://github.com/apache/airflow/pull/4569#issuecomment-469895639 @XD-DENG , I don't think it will add 2000 entries to the db for admin role. It only adds the "all_dags" view-menu with the 2

[GitHub] [airflow] XD-DENG commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag details

2019-03-05 Thread GitBox
XD-DENG commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag details URL: https://github.com/apache/airflow/pull/4569#issuecomment-469894456 I have a question to seek @feng-tao ‘s input given we have started the discussion on this: currently Admin’s permissions will

[jira] [Commented] (AIRFLOW-4021) Log file location in email alert incorrect

2019-03-05 Thread Kiran Gavali (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784983#comment-16784983 ] Kiran Gavali commented on AIRFLOW-4021: --- Would it be possible to use the following property in

[GitHub] [airflow] feng-tao edited a comment on issue #4627: [AIRFLOW-3258] K8S executor environment variables section.

2019-03-05 Thread GitBox
feng-tao edited a comment on issue #4627: [AIRFLOW-3258] K8S executor environment variables section. URL: https://github.com/apache/airflow/pull/4627#issuecomment-469891035 @davlum , a n00b question: do you know if it is desirable to have both env variable defined and annotation

[GitHub] [airflow] feng-tao commented on issue #4627: [AIRFLOW-3258] K8S executor environment variables section.

2019-03-05 Thread GitBox
feng-tao commented on issue #4627: [AIRFLOW-3258] K8S executor environment variables section. URL: https://github.com/apache/airflow/pull/4627#issuecomment-469891035 @davlum , a n00b question: do you know if it is desirable to have both env variable defined and annotation

[GitHub] [airflow] codecov-io commented on issue #4845: [AIRFLOW-4020] Remove viewer DAG edit permissions

2019-03-05 Thread GitBox
codecov-io commented on issue #4845: [AIRFLOW-4020] Remove viewer DAG edit permissions URL: https://github.com/apache/airflow/pull/4845#issuecomment-469889220 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4845?src=pr=h1) Report > Merging

[jira] [Closed] (AIRFLOW-3985) Adding linear DAG relationships with unary operator

2019-03-05 Thread Jarek Potiuk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk closed AIRFLOW-3985. - Resolution: Not A Problem > Adding linear DAG relationships with unary operator >

[jira] [Commented] (AIRFLOW-4019) AWS Athena Sensor's object has no attribute 'mode'

2019-03-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784971#comment-16784971 ] ASF GitHub Bot commented on AIRFLOW-4019: - feng-tao commented on pull request #4844:

[jira] [Commented] (AIRFLOW-3985) Adding linear DAG relationships with unary operator

2019-03-05 Thread Jarek Potiuk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784975#comment-16784975 ] Jarek Potiuk commented on AIRFLOW-3985: --- Closing following the discussion in 

[GitHub] [airflow] feng-tao commented on issue #4845: [AIRFLOW-4020] Remove viewer DAG edit permissions

2019-03-05 Thread GitBox
feng-tao commented on issue #4845: [AIRFLOW-4020] Remove viewer DAG edit permissions URL: https://github.com/apache/airflow/pull/4845#issuecomment-469881537 PTAL @ashb Tests pass This is an automated message from the

[GitHub] [airflow] potiuk closed pull request #4810: [AIRFLOW-3985] Added unary + operator for easier linear DAG building

2019-03-05 Thread GitBox
potiuk closed pull request #4810: [AIRFLOW-3985] Added unary + operator for easier linear DAG building URL: https://github.com/apache/airflow/pull/4810 This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (AIRFLOW-3985) Adding linear DAG relationships with unary operator

2019-03-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784974#comment-16784974 ] ASF GitHub Bot commented on AIRFLOW-3985: - potiuk commented on pull request #4810:

[GitHub] [airflow] potiuk commented on issue #4810: [AIRFLOW-3985] Added unary + operator for easier linear DAG building

2019-03-05 Thread GitBox
potiuk commented on issue #4810: [AIRFLOW-3985] Added unary + operator for easier linear DAG building URL: https://github.com/apache/airflow/pull/4810#issuecomment-469881001 Closing as this could be misleading This is an

[jira] [Commented] (AIRFLOW-4019) AWS Athena Sensor's object has no attribute 'mode'

2019-03-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784972#comment-16784972 ] ASF subversion and git services commented on AIRFLOW-4019: -- Commit

[GitHub] [airflow] feng-tao merged pull request #4844: [AIRFLOW-4019] Fix AWS Athena Sensor object has no attribute 'mode'

2019-03-05 Thread GitBox
feng-tao merged pull request #4844: [AIRFLOW-4019] Fix AWS Athena Sensor object has no attribute 'mode' URL: https://github.com/apache/airflow/pull/4844 This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] feng-tao commented on issue #4844: [AIRFLOW-4019] Fix AWS Athena Sensor object has no attribute 'mode'

2019-03-05 Thread GitBox
feng-tao commented on issue #4844: [AIRFLOW-4019] Fix AWS Athena Sensor object has no attribute 'mode' URL: https://github.com/apache/airflow/pull/4844#issuecomment-469879613 lgtm This is an automated message from the Apache

[jira] [Commented] (AIRFLOW-3802) Correct HiveServer2Hook documentation formatting

2019-03-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784931#comment-16784931 ] ASF subversion and git services commented on AIRFLOW-3802: -- Commit

[jira] [Commented] (AIRFLOW-3801) DagBag always import examples

2019-03-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784936#comment-16784936 ] ASF subversion and git services commented on AIRFLOW-3801: -- Commit

[jira] [Commented] (AIRFLOW-3821) Add replicas logic to GCP SQL example DAG

2019-03-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784938#comment-16784938 ] ASF subversion and git services commented on AIRFLOW-3821: -- Commit

[jira] [Commented] (AIRFLOW-2508) Handle non string types in render_template_from_field

2019-03-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784941#comment-16784941 ] ASF subversion and git services commented on AIRFLOW-2508: -- Commit

[jira] [Commented] (AIRFLOW-3547) Jinja templating is not enabled for some SparkSubmitOperator parameters.

2019-03-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784934#comment-16784934 ] ASF subversion and git services commented on AIRFLOW-3547: -- Commit

[jira] [Commented] (AIRFLOW-3547) Jinja templating is not enabled for some SparkSubmitOperator parameters.

2019-03-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784935#comment-16784935 ] ASF subversion and git services commented on AIRFLOW-3547: -- Commit

[jira] [Commented] (AIRFLOW-3647) Contributed SparkSubmitOperator doesn't honor --archives configuration

2019-03-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784932#comment-16784932 ] ASF subversion and git services commented on AIRFLOW-3647: -- Commit

[jira] [Commented] (AIRFLOW-3547) Jinja templating is not enabled for some SparkSubmitOperator parameters.

2019-03-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784933#comment-16784933 ] ASF subversion and git services commented on AIRFLOW-3547: -- Commit

[GitHub] [airflow] Fokko commented on a change in pull request #4810: [AIRFLOW-3985] Added unary + operator for easier linear DAG building

2019-03-05 Thread GitBox
Fokko commented on a change in pull request #4810: [AIRFLOW-3985] Added unary + operator for easier linear DAG building URL: https://github.com/apache/airflow/pull/4810#discussion_r262699628 ## File path: docs/concepts.rst ## @@ -263,6 +263,31 @@ and equivalent to:

[GitHub] [airflow] feng-tao commented on issue #4712: [AIRFLOW-3892] Create Redis pub sub sensor

2019-03-05 Thread GitBox
feng-tao commented on issue #4712: [AIRFLOW-3892] Create Redis pub sub sensor URL: https://github.com/apache/airflow/pull/4712#issuecomment-469866240 @mans2singh sorry for the late review. Overall lgtm. We recently upgrade redis client(https://github.com/apache/airflow/pull/4834). Could

[GitHub] [airflow] feng-tao merged pull request #4843: [AIRFLOW-XXX] Add note about backwards incompatible changes

2019-03-05 Thread GitBox
feng-tao merged pull request #4843: [AIRFLOW-XXX] Add note about backwards incompatible changes URL: https://github.com/apache/airflow/pull/4843 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (AIRFLOW-4012) Upgrade upper bound of tabulate to 0.8.3

2019-03-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784922#comment-16784922 ] ASF subversion and git services commented on AIRFLOW-4012: -- Commit

[GitHub] [airflow] ashb commented on issue #4368: [AIRFLOW-3561] Improve queries

2019-03-05 Thread GitBox
ashb commented on issue #4368: [AIRFLOW-3561] Improve queries URL: https://github.com/apache/airflow/pull/4368#issuecomment-469865539 We reverted this from master? Did it ever make it back in in any form? This is an automated

[GitHub] [airflow] feng-tao commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag details

2019-03-05 Thread GitBox
feng-tao commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag details URL: https://github.com/apache/airflow/pull/4569#issuecomment-469865060 @ashb https://flask-appbuilder.readthedocs.io/en/latest/diagrams.html FYI

[jira] [Commented] (AIRFLOW-4016) Make job tests more stateless

2019-03-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784926#comment-16784926 ] ASF subversion and git services commented on AIRFLOW-4016: -- Commit

[jira] [Commented] (AIRFLOW-4016) Make job tests more stateless

2019-03-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784925#comment-16784925 ] ASF GitHub Bot commented on AIRFLOW-4016: - Fokko commented on pull request #4839:

[jira] [Resolved] (AIRFLOW-4016) Make job tests more stateless

2019-03-05 Thread Fokko Driesprong (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong resolved AIRFLOW-4016. --- Resolution: Fixed Fix Version/s: 2.0.0 > Make job tests more stateless >

[jira] [Resolved] (AIRFLOW-4012) Upgrade upper bound of tabulate to 0.8.3

2019-03-05 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-4012. Resolution: Fixed Fix Version/s: 1.10.3 > Upgrade upper bound of tabulate

[GitHub] [airflow] Fokko merged pull request #4839: [AIRFLOW-4016] Clear runs for BackfillJobTest

2019-03-05 Thread GitBox
Fokko merged pull request #4839: [AIRFLOW-4016] Clear runs for BackfillJobTest URL: https://github.com/apache/airflow/pull/4839 This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (AIRFLOW-4012) Upgrade upper bound of tabulate to 0.8.3

2019-03-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784921#comment-16784921 ] ASF GitHub Bot commented on AIRFLOW-4012: - ashb commented on pull request #4838: [AIRFLOW-4012]

[GitHub] [airflow] ashb merged pull request #4838: [AIRFLOW-4012] - Upgrade tabulate to 0.8.3

2019-03-05 Thread GitBox
ashb merged pull request #4838: [AIRFLOW-4012] - Upgrade tabulate to 0.8.3 URL: https://github.com/apache/airflow/pull/4838 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] codecov-io edited a comment on issue #4838: [AIRFLOW-4012] - Upgrade tabulate to 0.8.3

2019-03-05 Thread GitBox
codecov-io edited a comment on issue #4838: [AIRFLOW-4012] - Upgrade tabulate to 0.8.3 URL: https://github.com/apache/airflow/pull/4838#issuecomment-469630748 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4838?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #4838: [AIRFLOW-4012] - Upgrade tabulate to 0.8.3

2019-03-05 Thread GitBox
codecov-io edited a comment on issue #4838: [AIRFLOW-4012] - Upgrade tabulate to 0.8.3 URL: https://github.com/apache/airflow/pull/4838#issuecomment-469630748 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4838?src=pr=h1) Report > Merging

[GitHub] [airflow] feng-tao commented on a change in pull request #4845: [AIRFLOW-4020] Remove viewer DAG edit permissions

2019-03-05 Thread GitBox
feng-tao commented on a change in pull request #4845: [AIRFLOW-4020] Remove viewer DAG edit permissions URL: https://github.com/apache/airflow/pull/4845#discussion_r262696111 ## File path: tests/www/test_views.py ## @@ -1566,6 +1566,14 @@ def

[jira] [Created] (AIRFLOW-4021) Log file location in email alert incorrect

2019-03-05 Thread Kiran Gavali (JIRA)
Kiran Gavali created AIRFLOW-4021: - Summary: Log file location in email alert incorrect Key: AIRFLOW-4021 URL: https://issues.apache.org/jira/browse/AIRFLOW-4021 Project: Apache Airflow

[GitHub] [airflow] ashb commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag details

2019-03-05 Thread GitBox
ashb commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag details URL: https://github.com/apache/airflow/pull/4569#issuecomment-469861187 I'm sort of picturing something like (very pseudo code): ```python from something import role_migrations as rm def

[GitHub] [airflow] ashb commented on issue #4819: [AIRFLOW-3997] Add getter to Variable that returns None instead of throwing

2019-03-05 Thread GitBox
ashb commented on issue #4819: [AIRFLOW-3997] Add getter to Variable that returns None instead of throwing URL: https://github.com/apache/airflow/pull/4819#issuecomment-469859676 Could you update your commit message subject to "[AIRFLOW-3997] Add getter to Variable that returns None

  1   2   3   >