[jira] [Commented] (AIRFLOW-1464) Improve performance on getting dag run tis in backfill job

2019-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847255#comment-16847255 ] ASF GitHub Bot commented on AIRFLOW-1464: - milton0825 commented on pull request #5323:

[GitHub] [airflow] milton0825 opened a new pull request #5323: [AIRFLOW-1464] Batch update task_instance state

2019-05-23 Thread GitBox
milton0825 opened a new pull request #5323: [AIRFLOW-1464] Batch update task_instance state URL: https://github.com/apache/airflow/pull/5323 Make sure you have checked _all_ steps below. ### Jira - [X] My PR addresses the following [Airflow

[GitHub] [airflow] milton0825 commented on a change in pull request #5321: [AIRFLOW-4565] instrument celery executor

2019-05-23 Thread GitBox
milton0825 commented on a change in pull request #5321: [AIRFLOW-4565] instrument celery executor URL: https://github.com/apache/airflow/pull/5321#discussion_r287217972 ## File path: airflow/executors/celery_executor.py ## @@ -182,10 +183,17 @@ def heartbeat(self):

[jira] [Commented] (AIRFLOW-4557) The get_sqlproxy_runner() method of the CloudSqlDatabaseHook requires you to use the google_cloud_default_connection

2019-05-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847242#comment-16847242 ] ASF subversion and git services commented on AIRFLOW-4557: -- Commit

[jira] [Commented] (AIRFLOW-4557) The get_sqlproxy_runner() method of the CloudSqlDatabaseHook requires you to use the google_cloud_default_connection

2019-05-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847222#comment-16847222 ] ASF subversion and git services commented on AIRFLOW-4557: -- Commit

[jira] [Commented] (AIRFLOW-4557) The get_sqlproxy_runner() method of the CloudSqlDatabaseHook requires you to use the google_cloud_default_connection

2019-05-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847224#comment-16847224 ] ASF subversion and git services commented on AIRFLOW-4557: -- Commit

[jira] [Resolved] (AIRFLOW-4557) The get_sqlproxy_runner() method of the CloudSqlDatabaseHook requires you to use the google_cloud_default_connection

2019-05-23 Thread Jarek Potiuk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk resolved AIRFLOW-4557. --- Resolution: Fixed Fix Version/s: 2.0.0 1.10.4 > The

[jira] [Commented] (AIRFLOW-4557) The get_sqlproxy_runner() method of the CloudSqlDatabaseHook requires you to use the google_cloud_default_connection

2019-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847221#comment-16847221 ] ASF GitHub Bot commented on AIRFLOW-4557: - potiuk commented on pull request #5314:

[jira] [Resolved] (AIRFLOW-4535) Breaks job.py into multiple files

2019-05-23 Thread Chao-Han Tsai (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chao-Han Tsai resolved AIRFLOW-4535. Resolution: Fixed > Breaks job.py into multiple files >

[GitHub] [airflow] potiuk commented on issue #5314: [AIRFLOW-4557] Add gcp_conn_id parameter to get_sqlproxy_runner

2019-05-23 Thread GitBox
potiuk commented on issue #5314: [AIRFLOW-4557] Add gcp_conn_id parameter to get_sqlproxy_runner URL: https://github.com/apache/airflow/pull/5314#issuecomment-495463996 Thanks @andrewhharmon ! Good catch  This is an

[GitHub] [airflow] potiuk merged pull request #5314: [AIRFLOW-4557] Add gcp_conn_id parameter to get_sqlproxy_runner

2019-05-23 Thread GitBox
potiuk merged pull request #5314: [AIRFLOW-4557] Add gcp_conn_id parameter to get_sqlproxy_runner URL: https://github.com/apache/airflow/pull/5314 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] nurikk commented on a change in pull request #5317: [AIRFLOW-4562 ] Fix missing try_number parameter in TaskInstance.log_filepath method

2019-05-23 Thread GitBox
nurikk commented on a change in pull request #5317: [AIRFLOW-4562 ] Fix missing try_number parameter in TaskInstance.log_filepath method URL: https://github.com/apache/airflow/pull/5317#discussion_r287188062 ## File path: airflow/models/taskinstance.py ## @@ -376,7 +379,8

[GitHub] [airflow] codecov-io edited a comment on issue #5079: [AIRFLOW-4285] Update task dependency context defination and usage

2019-05-23 Thread GitBox
codecov-io edited a comment on issue #5079: [AIRFLOW-4285] Update task dependency context defination and usage URL: https://github.com/apache/airflow/pull/5079#issuecomment-486600978 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5079?src=pr=h1) Report > Merging

[GitHub] [airflow] nurikk commented on a change in pull request #5317: [AIRFLOW-4562 ] Fix missing try_number parameter in TaskInstance.log_filepath method

2019-05-23 Thread GitBox
nurikk commented on a change in pull request #5317: [AIRFLOW-4562 ] Fix missing try_number parameter in TaskInstance.log_filepath method URL: https://github.com/apache/airflow/pull/5317#discussion_r287187868 ## File path: tests/models/test_taskinstance.py ## @@ -846,9

[GitHub] [airflow] codecov-io edited a comment on issue #5079: [AIRFLOW-4285] Update task dependency context defination and usage

2019-05-23 Thread GitBox
codecov-io edited a comment on issue #5079: [AIRFLOW-4285] Update task dependency context defination and usage URL: https://github.com/apache/airflow/pull/5079#issuecomment-486600978 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5079?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #5322: [AIRFLOW-4566] Document sla & sla_miss_callback task params

2019-05-23 Thread GitBox
codecov-io edited a comment on issue #5322: [AIRFLOW-4566] Document sla & sla_miss_callback task params URL: https://github.com/apache/airflow/pull/5322#issuecomment-495430402 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5322?src=pr=h1) Report > Merging

[jira] [Closed] (AIRFLOW-4566) Missing documentation around sla and sla_miss_callback

2019-05-23 Thread Siddharth Anand (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siddharth Anand closed AIRFLOW-4566. Resolution: Fixed > Missing documentation around sla and sla_miss_callback >

[jira] [Commented] (AIRFLOW-4566) Missing documentation around sla and sla_miss_callback

2019-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847153#comment-16847153 ] ASF GitHub Bot commented on AIRFLOW-4566: - r39132 commented on pull request #5322:

[jira] [Commented] (AIRFLOW-4566) Missing documentation around sla and sla_miss_callback

2019-05-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847154#comment-16847154 ] ASF subversion and git services commented on AIRFLOW-4566: -- Commit

[GitHub] [airflow] r39132 merged pull request #5322: [AIRFLOW-4566] Missing documentation around sla and sla_miss_callback

2019-05-23 Thread GitBox
r39132 merged pull request #5322: [AIRFLOW-4566] Missing documentation around sla and sla_miss_callback URL: https://github.com/apache/airflow/pull/5322 This is an automated message from the Apache Git Service. To respond

[jira] [Work started] (AIRFLOW-4566) Missing documentation around sla and sla_miss_callback

2019-05-23 Thread Bill DeRose (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on AIRFLOW-4566 started by Bill DeRose. > Missing documentation around sla and sla_miss_callback >

[GitHub] [airflow] r39132 commented on issue #5322: [AIRFLOW-4566] Missing documentation around sla and sla_miss_callback

2019-05-23 Thread GitBox
r39132 commented on issue #5322: [AIRFLOW-4566] Missing documentation around sla and sla_miss_callback URL: https://github.com/apache/airflow/pull/5322#issuecomment-495432488 +1 .. thx @wderose This is an automated message

[GitHub] [airflow] codecov-io edited a comment on issue #5322: [AIRFLOW-4566] Missing documentation around sla and sla_miss_callback

2019-05-23 Thread GitBox
codecov-io edited a comment on issue #5322: [AIRFLOW-4566] Missing documentation around sla and sla_miss_callback URL: https://github.com/apache/airflow/pull/5322#issuecomment-495430402 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5322?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #5322: [AIRFLOW-4566] Missing documentation around sla and sla_miss_callback

2019-05-23 Thread GitBox
codecov-io edited a comment on issue #5322: [AIRFLOW-4566] Missing documentation around sla and sla_miss_callback URL: https://github.com/apache/airflow/pull/5322#issuecomment-495430402 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5322?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #5322: [AIRFLOW-4566] Missing documentation around sla and sla_miss_callback

2019-05-23 Thread GitBox
codecov-io commented on issue #5322: [AIRFLOW-4566] Missing documentation around sla and sla_miss_callback URL: https://github.com/apache/airflow/pull/5322#issuecomment-495430401 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5322?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #5322: [AIRFLOW-4566] Missing documentation around sla and sla_miss_callback

2019-05-23 Thread GitBox
codecov-io commented on issue #5322: [AIRFLOW-4566] Missing documentation around sla and sla_miss_callback URL: https://github.com/apache/airflow/pull/5322#issuecomment-495430402 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5322?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #5321: [AIRFLOW-4565] instrument celery executor

2019-05-23 Thread GitBox
codecov-io edited a comment on issue #5321: [AIRFLOW-4565] instrument celery executor URL: https://github.com/apache/airflow/pull/5321#issuecomment-495425823 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5321?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #5321: [AIRFLOW-4565] instrument celery executor

2019-05-23 Thread GitBox
codecov-io commented on issue #5321: [AIRFLOW-4565] instrument celery executor URL: https://github.com/apache/airflow/pull/5321#issuecomment-495425823 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5321?src=pr=h1) Report > Merging

[GitHub] [airflow] wderose opened a new pull request #5322: [AIRFLOW-4566] Missing documentation around sla and sla_miss_callback

2019-05-23 Thread GitBox
wderose opened a new pull request #5322: [AIRFLOW-4566] Missing documentation around sla and sla_miss_callback URL: https://github.com/apache/airflow/pull/5322 ### Jira - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issue and

[jira] [Commented] (AIRFLOW-4566) Missing documentation around sla and sla_miss_callback

2019-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847142#comment-16847142 ] ASF GitHub Bot commented on AIRFLOW-4566: - wderose commented on pull request #5322:

[jira] [Created] (AIRFLOW-4566) Missing documentation around sla and sla_miss_callback

2019-05-23 Thread Bill DeRose (JIRA)
Bill DeRose created AIRFLOW-4566: Summary: Missing documentation around sla and sla_miss_callback Key: AIRFLOW-4566 URL: https://issues.apache.org/jira/browse/AIRFLOW-4566 Project: Apache Airflow

[jira] [Assigned] (AIRFLOW-4566) Missing documentation around sla and sla_miss_callback

2019-05-23 Thread Bill DeRose (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill DeRose reassigned AIRFLOW-4566: Assignee: Bill DeRose > Missing documentation around sla and sla_miss_callback >

[jira] [Commented] (AIRFLOW-4525) Trigger Dag Operator causes duplicate key exceptions and can cause runaway dag spawning as it is not atomic at the DB level (on Postgres at least.)

2019-05-23 Thread Tony Brookes (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847140#comment-16847140 ] Tony Brookes commented on AIRFLOW-4525: --- FYI, I have created a custom operator which basically

[jira] [Updated] (AIRFLOW-4525) Trigger Dag Operator causes duplicate key exceptions and can cause runaway dag spawning as it is not atomic at the DB level (on Postgres at least.)

2019-05-23 Thread Tony Brookes (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tony Brookes updated AIRFLOW-4525: -- Attachment: (was: trigger_dag_operator.py) > Trigger Dag Operator causes duplicate key

[jira] [Updated] (AIRFLOW-4525) Trigger Dag Operator causes duplicate key exceptions and can cause runaway dag spawning as it is not atomic at the DB level (on Postgres at least.)

2019-05-23 Thread Tony Brookes (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tony Brookes updated AIRFLOW-4525: -- Attachment: trigger_dag_operator.py > Trigger Dag Operator causes duplicate key exceptions

[jira] [Updated] (AIRFLOW-4565) CeleryExecutor does not gauge executor stats

2019-05-23 Thread Junda Yang (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junda Yang updated AIRFLOW-4565: Description: # of open slots + running/queued tasks was instrumented in 

[GitHub] [airflow] youngyjd opened a new pull request #5321: [AIRFLOW-4565] instrument celery executor

2019-05-23 Thread GitBox
youngyjd opened a new pull request #5321: [AIRFLOW-4565] instrument celery executor URL: https://github.com/apache/airflow/pull/5321 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[jira] [Commented] (AIRFLOW-4565) CeleryExecutor does not gauge executor stats

2019-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847133#comment-16847133 ] ASF GitHub Bot commented on AIRFLOW-4565: - youngyjd commented on pull request #5321:

[jira] [Created] (AIRFLOW-4565) CeleryExecutor does not gauge executor stats

2019-05-23 Thread Junda Yang (JIRA)
Junda Yang created AIRFLOW-4565: --- Summary: CeleryExecutor does not gauge executor stats Key: AIRFLOW-4565 URL: https://issues.apache.org/jira/browse/AIRFLOW-4565 Project: Apache Airflow Issue

[GitHub] [airflow] kunalyogenshah commented on issue #5320: [AIRFLOW-XXX] Updates docs for connecting ES frontend client.

2019-05-23 Thread GitBox
kunalyogenshah commented on issue #5320: [AIRFLOW-XXX] Updates docs for connecting ES frontend client. URL: https://github.com/apache/airflow/pull/5320#issuecomment-495400508 @mik-laj Is this what you had in mind? Let me know if it needs more explanation.

[GitHub] [airflow] kunalyogenshah opened a new pull request #5320: [AIRFLOW-XXX] Updates docs for connecting ES frontend client.

2019-05-23 Thread GitBox
kunalyogenshah opened a new pull request #5320: [AIRFLOW-XXX] Updates docs for connecting ES frontend client. URL: https://github.com/apache/airflow/pull/5320 Make sure you have checked _all_ steps below. ### Jira Documentation change only. ### Description Add a

[jira] [Commented] (AIRFLOW-3867) Unification of the subpackage's name for GCP

2019-05-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847088#comment-16847088 ] ASF subversion and git services commented on AIRFLOW-3867: -- Commit

[jira] [Resolved] (AIRFLOW-4554) run_unit_tests.sh uses sudo unconditionally

2019-05-23 Thread Jarek Potiuk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk resolved AIRFLOW-4554. --- Resolution: Fixed Fix Version/s: 2.0.0 1.10.4 >

[GitHub] [airflow] aliceabe commented on issue #5315: [AIRFLOW-4560] Fix Tez queue parameter name in mapred_queue

2019-05-23 Thread GitBox
aliceabe commented on issue #5315: [AIRFLOW-4560] Fix Tez queue parameter name in mapred_queue URL: https://github.com/apache/airflow/pull/5315#issuecomment-495399654 I see, makes sense @KevinYang21 . Thank you! This is an

[jira] [Commented] (AIRFLOW-4554) run_unit_tests.sh uses sudo unconditionally

2019-05-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847084#comment-16847084 ] ASF subversion and git services commented on AIRFLOW-4554: -- Commit

[jira] [Commented] (AIRFLOW-4554) run_unit_tests.sh uses sudo unconditionally

2019-05-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847089#comment-16847089 ] ASF subversion and git services commented on AIRFLOW-4554: -- Commit

[jira] [Commented] (AIRFLOW-4554) run_unit_tests.sh uses sudo unconditionally

2019-05-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847090#comment-16847090 ] ASF subversion and git services commented on AIRFLOW-4554: -- Commit

[jira] [Commented] (AIRFLOW-4554) run_unit_tests.sh uses sudo unconditionally

2019-05-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847085#comment-16847085 ] ASF subversion and git services commented on AIRFLOW-4554: -- Commit

[jira] [Commented] (AIRFLOW-4554) run_unit_tests.sh uses sudo unconditionally

2019-05-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847083#comment-16847083 ] ASF subversion and git services commented on AIRFLOW-4554: -- Commit

[jira] [Commented] (AIRFLOW-4554) run_unit_tests.sh uses sudo unconditionally

2019-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847081#comment-16847081 ] ASF GitHub Bot commented on AIRFLOW-4554: - potiuk commented on pull request #5310: [

[jira] [Commented] (AIRFLOW-4554) run_unit_tests.sh uses sudo unconditionally

2019-05-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847082#comment-16847082 ] ASF subversion and git services commented on AIRFLOW-4554: -- Commit

[GitHub] [airflow] potiuk merged pull request #5310: [ AIRFLOW-4554] Test for sudo command, add some other test docs

2019-05-23 Thread GitBox
potiuk merged pull request #5310: [ AIRFLOW-4554] Test for sudo command, add some other test docs URL: https://github.com/apache/airflow/pull/5310 This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (AIRFLOW-4564) Azure Container Instance misc. bugs

2019-05-23 Thread Asgeir Berland (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Asgeir Berland updated AIRFLOW-4564: Summary: Azure Container Instance misc. bugs (was: Azure Container Instance

[GitHub] [airflow] codecov-io commented on issue #5310: [ AIRFLOW-4554] Test for sudo command, add some other test docs

2019-05-23 Thread GitBox
codecov-io commented on issue #5310: [ AIRFLOW-4554] Test for sudo command, add some other test docs URL: https://github.com/apache/airflow/pull/5310#issuecomment-495393104 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5310?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #5310: [ AIRFLOW-4554] Test for sudo command, add some other test docs

2019-05-23 Thread GitBox
codecov-io edited a comment on issue #5310: [ AIRFLOW-4554] Test for sudo command, add some other test docs URL: https://github.com/apache/airflow/pull/5310#issuecomment-495393104 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5310?src=pr=h1) Report > Merging

[jira] [Commented] (AIRFLOW-4564) Azure Container Instance misc. bugs

2019-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847067#comment-16847067 ] ASF GitHub Bot commented on AIRFLOW-4564: - Trollgeir commented on pull request #5319:

[GitHub] [airflow] Trollgeir opened a new pull request #5319: [AIRFLOW-4564] Azure Container Instance improvements

2019-05-23 Thread GitBox
Trollgeir opened a new pull request #5319: [AIRFLOW-4564] Azure Container Instance improvements URL: https://github.com/apache/airflow/pull/5319 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[GitHub] [airflow] kunalyogenshah commented on issue #5164: [AIRFLOW-4396] Provide a link to external Elasticsearch logs in UI.

2019-05-23 Thread GitBox
kunalyogenshah commented on issue #5164: [AIRFLOW-4396] Provide a link to external Elasticsearch logs in UI. URL: https://github.com/apache/airflow/pull/5164#issuecomment-495391138 Hey @mik-laj . I can definitely write documentation if needed. Will send a followup PR.

[GitHub] [airflow] KevinYang21 commented on a change in pull request #5037: [AIRFLOW-4237] Including Try Number of Task in Gantt Chart

2019-05-23 Thread GitBox
KevinYang21 commented on a change in pull request #5037: [AIRFLOW-4237] Including Try Number of Task in Gantt Chart URL: https://github.com/apache/airflow/pull/5037#discussion_r287140378 ## File path: airflow/www/views.py ## @@ -1738,10 +1738,21 @@ def gantt(self,

[jira] [Work started] (AIRFLOW-4564) Azure Container Instance misc. bugs

2019-05-23 Thread Asgeir Berland (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on AIRFLOW-4564 started by Asgeir Berland. --- > Azure Container Instance misc. bugs >

[jira] [Assigned] (AIRFLOW-4525) Trigger Dag Operator causes duplicate key exceptions and can cause runaway dag spawning as it is not atomic at the DB level (on Postgres at least.)

2019-05-23 Thread Asgeir Berland (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Asgeir Berland reassigned AIRFLOW-4525: --- Assignee: (was: Asgeir Berland) > Trigger Dag Operator causes duplicate key

[jira] [Assigned] (AIRFLOW-4525) Trigger Dag Operator causes duplicate key exceptions and can cause runaway dag spawning as it is not atomic at the DB level (on Postgres at least.)

2019-05-23 Thread Asgeir Berland (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Asgeir Berland reassigned AIRFLOW-4525: --- Assignee: Asgeir Berland > Trigger Dag Operator causes duplicate key exceptions

[jira] [Created] (AIRFLOW-4564) Azure Container Instance improvement

2019-05-23 Thread Asgeir Berland (JIRA)
Asgeir Berland created AIRFLOW-4564: --- Summary: Azure Container Instance improvement Key: AIRFLOW-4564 URL: https://issues.apache.org/jira/browse/AIRFLOW-4564 Project: Apache Airflow Issue

[jira] [Commented] (AIRFLOW-3867) Unification of the subpackage's name for GCP

2019-05-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847055#comment-16847055 ] ASF subversion and git services commented on AIRFLOW-3867: -- Commit

[jira] [Commented] (AIRFLOW-4560) Tez queue parameter passed by mapred_queue is incorrect

2019-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847051#comment-16847051 ] ASF GitHub Bot commented on AIRFLOW-4560: - KevinYang21 commented on pull request #5315:

[jira] [Commented] (AIRFLOW-4560) Tez queue parameter passed by mapred_queue is incorrect

2019-05-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847052#comment-16847052 ] ASF subversion and git services commented on AIRFLOW-4560: -- Commit

[GitHub] [airflow] codecov-io edited a comment on issue #5314: [AIRFLOW-4557] Add gcp_conn_id parameter to get_sqlproxy_runner

2019-05-23 Thread GitBox
codecov-io edited a comment on issue #5314: [AIRFLOW-4557] Add gcp_conn_id parameter to get_sqlproxy_runner URL: https://github.com/apache/airflow/pull/5314#issuecomment-495363180 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5314?src=pr=h1) Report > Merging

[GitHub] [airflow] KevinYang21 merged pull request #5315: [AIRFLOW-4560] Fix Tez queue parameter name in mapred_queue

2019-05-23 Thread GitBox
KevinYang21 merged pull request #5315: [AIRFLOW-4560] Fix Tez queue parameter name in mapred_queue URL: https://github.com/apache/airflow/pull/5315 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] KevinYang21 commented on issue #5315: [AIRFLOW-4560] Fix Tez queue parameter name in mapred_queue

2019-05-23 Thread GitBox
KevinYang21 commented on issue #5315: [AIRFLOW-4560] Fix Tez queue parameter name in mapred_queue URL: https://github.com/apache/airflow/pull/5315#issuecomment-495384804 @aliceabe indeed we don't have unit tests on other parameters but it's hard to justify code change w/o unit test only

[GitHub] [airflow] codecov-io edited a comment on issue #3115: [AIRFLOW-2193] Add ROperator for using R

2019-05-23 Thread GitBox
codecov-io edited a comment on issue #3115: [AIRFLOW-2193] Add ROperator for using R URL: https://github.com/apache/airflow/pull/3115#issuecomment-466366329 # [Codecov](https://codecov.io/gh/apache/airflow/pull/3115?src=pr=h1) Report > Merging

[GitHub] [airflow] dossett commented on issue #5310: [ AIRFLOW-4554] Test for sudo command, add some other test docs

2019-05-23 Thread GitBox
dossett commented on issue #5310: [ AIRFLOW-4554] Test for sudo command, add some other test docs URL: https://github.com/apache/airflow/pull/5310#issuecomment-495376957 > Thanks for that @dossett ! I have some nit-pick comments though :) Thank you @potiuk. I reworked the pip

[GitHub] [airflow] dossett commented on a change in pull request #5310: [ AIRFLOW-4554] Test for sudo command, add some other test docs

2019-05-23 Thread GitBox
dossett commented on a change in pull request #5310: [ AIRFLOW-4554] Test for sudo command, add some other test docs URL: https://github.com/apache/airflow/pull/5310#discussion_r287124536 ## File path: run_unit_tests.sh ## @@ -61,8 +61,13 @@ if [ -f "${AIRFLOW_DB}" ];

[GitHub] [airflow] codecov-io edited a comment on issue #5314: [AIRFLOW-4557] Add gcp_conn_id parameter to get_sqlproxy_runner

2019-05-23 Thread GitBox
codecov-io edited a comment on issue #5314: [AIRFLOW-4557] Add gcp_conn_id parameter to get_sqlproxy_runner URL: https://github.com/apache/airflow/pull/5314#issuecomment-495363180 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5314?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #5314: [AIRFLOW-4557] Add gcp_conn_id parameter to get_sqlproxy_runner

2019-05-23 Thread GitBox
codecov-io edited a comment on issue #5314: [AIRFLOW-4557] Add gcp_conn_id parameter to get_sqlproxy_runner URL: https://github.com/apache/airflow/pull/5314#issuecomment-495363180 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5314?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #5314: [AIRFLOW-4557] Add gcp_conn_id parameter to get_sqlproxy_runner

2019-05-23 Thread GitBox
codecov-io edited a comment on issue #5314: [AIRFLOW-4557] Add gcp_conn_id parameter to get_sqlproxy_runner URL: https://github.com/apache/airflow/pull/5314#issuecomment-495363180 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5314?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #5314: [AIRFLOW-4557] Add gcp_conn_id parameter to get_sqlproxy_runner

2019-05-23 Thread GitBox
codecov-io edited a comment on issue #5314: [AIRFLOW-4557] Add gcp_conn_id parameter to get_sqlproxy_runner URL: https://github.com/apache/airflow/pull/5314#issuecomment-495363180 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5314?src=pr=h1) Report > Merging

[jira] [Resolved] (AIRFLOW-4089) pytz.utc has no attribute name

2019-05-23 Thread Jarek Potiuk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk resolved AIRFLOW-4089. --- Resolution: Fixed Fix Version/s: 2.0.0 1.10.4 > pytz.utc has no

[GitHub] [airflow] andrewhharmon commented on a change in pull request #5314: [AIRFLOW-4557] Add gcp_conn_id parameter to get_sqlproxy_runner

2019-05-23 Thread GitBox
andrewhharmon commented on a change in pull request #5314: [AIRFLOW-4557] Add gcp_conn_id parameter to get_sqlproxy_runner URL: https://github.com/apache/airflow/pull/5314#discussion_r287115847 ## File path: tests/hooks/test_gcp_sql_hook.py ## @@ -0,0 +1,58 @@ +# -*-

[jira] [Commented] (AIRFLOW-4089) pytz.utc has no attribute name

2019-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847015#comment-16847015 ] ASF GitHub Bot commented on AIRFLOW-4089: - potiuk commented on pull request #5316:

[GitHub] [airflow] reggieag commented on issue #5316: [AIRFLOW-4089] Remove pytz support from documentation

2019-05-23 Thread GitBox
reggieag commented on issue #5316: [AIRFLOW-4089] Remove pytz support from documentation URL: https://github.com/apache/airflow/pull/5316#issuecomment-495367438 No worries! Thanks for the review :) This is an automated

[GitHub] [airflow] mrshu commented on issue #5276: [AIRFLOW-4414] AWSAthenaOperator: Push QueryExecutionID to XCom

2019-05-23 Thread GitBox
mrshu commented on issue #5276: [AIRFLOW-4414] AWSAthenaOperator: Push QueryExecutionID to XCom URL: https://github.com/apache/airflow/pull/5276#issuecomment-495365289 Sure @feluelle, would you mind giving me some pointers as to what would be the best way of doing that? I can see

[GitHub] [airflow] potiuk commented on issue #5316: [AIRFLOW-4089] Remove pytz support from documentation

2019-05-23 Thread GitBox
potiuk commented on issue #5316: [AIRFLOW-4089] Remove pytz support from documentation URL: https://github.com/apache/airflow/pull/5316#issuecomment-495364510 Thanks! Sorry for nit-picking, but I think "explicit is better than implicit" as in python zen.

[GitHub] [airflow] potiuk merged pull request #5316: [AIRFLOW-4089] Remove pytz support from documentation

2019-05-23 Thread GitBox
potiuk merged pull request #5316: [AIRFLOW-4089] Remove pytz support from documentation URL: https://github.com/apache/airflow/pull/5316 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] potiuk commented on a change in pull request #5314: [AIRFLOW-4557] Add gcp_conn_id parameter to get_sqlproxy_runner

2019-05-23 Thread GitBox
potiuk commented on a change in pull request #5314: [AIRFLOW-4557] Add gcp_conn_id parameter to get_sqlproxy_runner URL: https://github.com/apache/airflow/pull/5314#discussion_r287111619 ## File path: tests/hooks/test_gcp_sql_hook.py ## @@ -0,0 +1,58 @@ +# -*- coding:

[GitHub] [airflow] codecov-io commented on issue #5314: [AIRFLOW-4557] Add gcp_conn_id parameter to get_sqlproxy_runner

2019-05-23 Thread GitBox
codecov-io commented on issue #5314: [AIRFLOW-4557] Add gcp_conn_id parameter to get_sqlproxy_runner URL: https://github.com/apache/airflow/pull/5314#issuecomment-495363180 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5314?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #5314: [AIRFLOW-4557] Add gcp_conn_id parameter to get_sqlproxy_runner

2019-05-23 Thread GitBox
codecov-io commented on issue #5314: [AIRFLOW-4557] Add gcp_conn_id parameter to get_sqlproxy_runner URL: https://github.com/apache/airflow/pull/5314#issuecomment-495363175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5314?src=pr=h1) Report > Merging

[GitHub] [airflow] aliceabe commented on issue #5315: [AIRFLOW-4560] Fix Tez queue parameter name in mapred_queue

2019-05-23 Thread GitBox
aliceabe commented on issue #5315: [AIRFLOW-4560] Fix Tez queue parameter name in mapred_queue URL: https://github.com/apache/airflow/pull/5315#issuecomment-495357116 @KevinYang21 None of the other queue parameters are currently under unit tests, so it seems out of scope for this diff.

[GitHub] [airflow] codecov-io edited a comment on issue #5316: [AIRFLOW-4089] Remove pytz support from documentation

2019-05-23 Thread GitBox
codecov-io edited a comment on issue #5316: [AIRFLOW-4089] Remove pytz support from documentation URL: https://github.com/apache/airflow/pull/5316#issuecomment-495034820 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5316?src=pr=h1) Report > Merging

[GitHub] [airflow] KevinYang21 commented on issue #5315: [AIRFLOW-4560] Fix Tez queue parameter name in mapred_queue

2019-05-23 Thread GitBox
KevinYang21 commented on issue #5315: [AIRFLOW-4560] Fix Tez queue parameter name in mapred_queue URL: https://github.com/apache/airflow/pull/5315#issuecomment-495352514 @aliceabe Thank you for the fix, is this something that we can cover by a unit test?

[GitHub] [airflow] milton0825 commented on a change in pull request #5314: [AIRFLOW-4557] Add gcp_conn_id parameter to get_sqlproxy_runner

2019-05-23 Thread GitBox
milton0825 commented on a change in pull request #5314: [AIRFLOW-4557] Add gcp_conn_id parameter to get_sqlproxy_runner URL: https://github.com/apache/airflow/pull/5314#discussion_r287083366 ## File path: tests/hooks/test_gcp_sql_hook.py ## @@ -0,0 +1,58 @@ +# -*- coding:

[GitHub] [airflow] reggieag commented on issue #5316: [AIRFLOW-4089] Remove pytz support from documentation

2019-05-23 Thread GitBox
reggieag commented on issue #5316: [AIRFLOW-4089] Remove pytz support from documentation URL: https://github.com/apache/airflow/pull/5316#issuecomment-495330601 Added a little bit more detail @potiuk. Let me know what you think.

[GitHub] [airflow] andrewhharmon commented on a change in pull request #5314: [AIRFLOW-4557] Add gcp_conn_id parameter to get_sqlproxy_runner

2019-05-23 Thread GitBox
andrewhharmon commented on a change in pull request #5314: [AIRFLOW-4557] Add gcp_conn_id parameter to get_sqlproxy_runner URL: https://github.com/apache/airflow/pull/5314#discussion_r287046944 ## File path: tests/hooks/test_gcp_sql_hook.py ## @@ -0,0 +1,58 @@ +# -*-

[GitHub] [airflow] XD-DENG commented on a change in pull request #5317: [AIRFLOW-4562 ] Fix missing try_number parameter in TaskInstance.log_filepath method

2019-05-23 Thread GitBox
XD-DENG commented on a change in pull request #5317: [AIRFLOW-4562 ] Fix missing try_number parameter in TaskInstance.log_filepath method URL: https://github.com/apache/airflow/pull/5317#discussion_r286979430 ## File path: tests/models/test_taskinstance.py ## @@ -846,9

[GitHub] [airflow] XD-DENG commented on a change in pull request #5317: [AIRFLOW-4562 ] Fix missing try_number parameter in TaskInstance.log_filepath method

2019-05-23 Thread GitBox
XD-DENG commented on a change in pull request #5317: [AIRFLOW-4562 ] Fix missing try_number parameter in TaskInstance.log_filepath method URL: https://github.com/apache/airflow/pull/5317#discussion_r286979430 ## File path: tests/models/test_taskinstance.py ## @@ -846,9

[GitHub] [airflow] codecov-io commented on issue #5317: [AIRFLOW-4562 ] Fix missing try_number parameter in TaskInstance.log_filepath method

2019-05-23 Thread GitBox
codecov-io commented on issue #5317: [AIRFLOW-4562 ] Fix missing try_number parameter in TaskInstance.log_filepath method URL: https://github.com/apache/airflow/pull/5317#issuecomment-495254414 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5317?src=pr=h1) Report > Merging

[GitHub] [airflow] XD-DENG commented on issue #5287: [AIRFLOW-XXX] Fix DaskExecutor formatting in Scheduler doc

2019-05-23 Thread GitBox
XD-DENG commented on issue #5287: [AIRFLOW-XXX] Fix DaskExecutor formatting in Scheduler doc URL: https://github.com/apache/airflow/pull/5287#issuecomment-495252090 Thanks @cooltoast @BasPH This is an automated message from

[GitHub] [airflow] XD-DENG merged pull request #5287: [AIRFLOW-XXX] Fix DaskExecutor formatting in Scheduler doc

2019-05-23 Thread GitBox
XD-DENG merged pull request #5287: [AIRFLOW-XXX] Fix DaskExecutor formatting in Scheduler doc URL: https://github.com/apache/airflow/pull/5287 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] XD-DENG commented on a change in pull request #5317: [AIRFLOW-4562 ] Fix missing try_number parameter in TaskInstance.log_filepath method

2019-05-23 Thread GitBox
XD-DENG commented on a change in pull request #5317: [AIRFLOW-4562 ] Fix missing try_number parameter in TaskInstance.log_filepath method URL: https://github.com/apache/airflow/pull/5317#discussion_r286979430 ## File path: tests/models/test_taskinstance.py ## @@ -846,9

[GitHub] [airflow] XD-DENG commented on a change in pull request #5317: [AIRFLOW-4562 ] Fix missing try_number parameter in TaskInstance.log_filepath method

2019-05-23 Thread GitBox
XD-DENG commented on a change in pull request #5317: [AIRFLOW-4562 ] Fix missing try_number parameter in TaskInstance.log_filepath method URL: https://github.com/apache/airflow/pull/5317#discussion_r286979242 ## File path: airflow/models/taskinstance.py ## @@ -376,7

[GitHub] [airflow] codecov-io edited a comment on issue #4277: [AIRFLOW-3217] Airflow log view and code view should wrap

2019-05-23 Thread GitBox
codecov-io edited a comment on issue #4277: [AIRFLOW-3217] Airflow log view and code view should wrap URL: https://github.com/apache/airflow/pull/4277#issuecomment-444199709 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4277?src=pr=h1) Report > Merging

  1   2   >