[jira] [Commented] (AIRFLOW-4148) form_choices in DagRunModelView may be wrong

2019-05-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848626#comment-16848626 ] ASF GitHub Bot commented on AIRFLOW-4148: - sumous commented on pull request #4969:

[GitHub] [airflow] sumous closed pull request #4969: [AIRFLOW-4148]form_choices in DagRunModelView may be wrong

2019-05-26 Thread GitBox
sumous closed pull request #4969: [AIRFLOW-4148]form_choices in DagRunModelView may be wrong URL: https://github.com/apache/airflow/pull/4969 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (AIRFLOW-4573) airflow_local_settings is imported before sys.path is populated

2019-05-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848580#comment-16848580 ] ASF GitHub Bot commented on AIRFLOW-4573: - pgagnon commented on pull request #5330:

[GitHub] [airflow] pgagnon opened a new pull request #5330: [AIRFLOW-4573] Import airflow_local_settings after prepare_classpath()

2019-05-26 Thread GitBox
pgagnon opened a new pull request #5330: [AIRFLOW-4573] Import airflow_local_settings after prepare_classpath() URL: https://github.com/apache/airflow/pull/5330 Make sure you have checked _all_ steps below. ### Jira - [X] https://issues.apache.org/jira/browse/AIRFLOW-4573

[GitHub] [airflow] reubenvanammers edited a comment on issue #4156: [AIRFLOW-3314] Changed auto inlets feature to work as described

2019-05-26 Thread GitBox
reubenvanammers edited a comment on issue #4156: [AIRFLOW-3314] Changed auto inlets feature to work as described URL: https://github.com/apache/airflow/pull/4156#issuecomment-496047904 > Thank you @reubenvanammers I started playing with the lineage and for a while I thought I'm getting

[GitHub] [airflow] reubenvanammers commented on issue #4156: [AIRFLOW-3314] Changed auto inlets feature to work as described

2019-05-26 Thread GitBox
reubenvanammers commented on issue #4156: [AIRFLOW-3314] Changed auto inlets feature to work as described URL: https://github.com/apache/airflow/pull/4156#issuecomment-496047904 > Thank you @reubenvanammers I started playing with the lineage and for a while I thought I'm getting crazy

[GitHub] [airflow] codecov-io commented on issue #5329: [AIRFLOW-XXX] Add .github/SECURITY.md

2019-05-26 Thread GitBox
codecov-io commented on issue #5329: [AIRFLOW-XXX] Add .github/SECURITY.md URL: https://github.com/apache/airflow/pull/5329#issuecomment-496034280 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5329?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #5329: [AIRFLOW-XXX] Add .github/SECURITY.md

2019-05-26 Thread GitBox
codecov-io edited a comment on issue #5329: [AIRFLOW-XXX] Add .github/SECURITY.md URL: https://github.com/apache/airflow/pull/5329#issuecomment-496034280 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5329?src=pr=h1) Report > Merging

[jira] [Commented] (AIRFLOW-3356) Scheduler gets stuck for certain DAGs

2019-05-26 Thread John Smodic (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848537#comment-16848537 ] John Smodic commented on AIRFLOW-3356: -- I think the root cause was S3FS, not Airflow. I switched

[jira] [Updated] (AIRFLOW-4572) Rename prepare_classpath() to prepare_syspath() in settings.py

2019-05-26 Thread Philippe Gagnon (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philippe Gagnon updated AIRFLOW-4572: - Description: {{settings.py}} currently defines a {{prepare_classpath()}} function that

[GitHub] [airflow] pgagnon opened a new pull request #5329: [AIRFLOW-XXX] Add .github/SECURITY.md

2019-05-26 Thread GitBox
pgagnon opened a new pull request #5329: [AIRFLOW-XXX] Add .github/SECURITY.md URL: https://github.com/apache/airflow/pull/5329 Make sure you have checked _all_ steps below. ### Jira - [X] My PR addresses the following [Airflow

[jira] [Updated] (AIRFLOW-4572) Rename prepare_classpath() to prepare_syspath() in settings.py

2019-05-26 Thread Philippe Gagnon (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philippe Gagnon updated AIRFLOW-4572: - Description: {{settings.py}} currently defines a {{prepare_classpath()}} function

[jira] [Updated] (AIRFLOW-4572) Rename prepare_classpath() to prepare_syspath() in settings.py

2019-05-26 Thread Philippe Gagnon (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philippe Gagnon updated AIRFLOW-4572: - Description: {{settings.py }}currently defines a {{prepare_classpath()}} function that

[jira] [Updated] (AIRFLOW-4573) airflow_local_settings is imported before sys.path is populated

2019-05-26 Thread Philippe Gagnon (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philippe Gagnon updated AIRFLOW-4573: - Description: {{settings.py}} imports the contents of {{airflow_local_settings.py}}

[jira] [Updated] (AIRFLOW-4573) airflow_local_settings is imported before sys.path is populated

2019-05-26 Thread Philippe Gagnon (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philippe Gagnon updated AIRFLOW-4573: - Summary: airflow_local_settings is imported before sys.path is populated (was:

[jira] [Created] (AIRFLOW-4573) airflow_local_settings is loaded before sys.path is populated

2019-05-26 Thread Philippe Gagnon (JIRA)
Philippe Gagnon created AIRFLOW-4573: Summary: airflow_local_settings is loaded before sys.path is populated Key: AIRFLOW-4573 URL: https://issues.apache.org/jira/browse/AIRFLOW-4573 Project:

[GitHub] [airflow] codecov-io commented on issue #5328: [AIRFLOW-4572] Rename prepare_classpath() to prepare_syspath()

2019-05-26 Thread GitBox
codecov-io commented on issue #5328: [AIRFLOW-4572] Rename prepare_classpath() to prepare_syspath() URL: https://github.com/apache/airflow/pull/5328#issuecomment-496028407 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5328?src=pr=h1) Report > Merging

[jira] [Commented] (AIRFLOW-4572) Rename prepare_classpath() to prepare_syspath() in settings.py

2019-05-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848511#comment-16848511 ] ASF GitHub Bot commented on AIRFLOW-4572: - pgagnon commented on pull request #5328:

[GitHub] [airflow] pgagnon opened a new pull request #5328: [AIRFLOW-4572] Rename prepare_classpath() to prepare_syspath()

2019-05-26 Thread GitBox
pgagnon opened a new pull request #5328: [AIRFLOW-4572] Rename prepare_classpath() to prepare_syspath() URL: https://github.com/apache/airflow/pull/5328 Make sure you have checked _all_ steps below. ### Jira - [ X ] My PR addresses the following [Airflow

[jira] [Created] (AIRFLOW-4572) Rename prepare_classpath() to prepare_syspath() in settings.py

2019-05-26 Thread Philippe Gagnon (JIRA)
Philippe Gagnon created AIRFLOW-4572: Summary: Rename prepare_classpath() to prepare_syspath() in settings.py Key: AIRFLOW-4572 URL: https://issues.apache.org/jira/browse/AIRFLOW-4572 Project:

[GitHub] [airflow] cixuuz edited a comment on issue #4991: [AIRFLOW-4170] Serialize non-str value by JSON when importing Variables

2019-05-26 Thread GitBox
cixuuz edited a comment on issue #4991: [AIRFLOW-4170] Serialize non-str value by JSON when importing Variables URL: https://github.com/apache/airflow/pull/4991#issuecomment-496015240 > LGTM but we should also update the code in `varimport` in `views.py` > > otherwise the CLI

[GitHub] [airflow] cixuuz commented on issue #4991: [AIRFLOW-4170] Serialize non-str value by JSON when importing Variables

2019-05-26 Thread GitBox
cixuuz commented on issue #4991: [AIRFLOW-4170] Serialize non-str value by JSON when importing Variables URL: https://github.com/apache/airflow/pull/4991#issuecomment-496015240 > LGTM but we should also update the code in `varimport` in `views.py` > > otherwise the CLI behaves

[GitHub] [airflow] codecov-io edited a comment on issue #4991: [AIRFLOW-4170] Serialize non-str value by JSON when importing Variables

2019-05-26 Thread GitBox
codecov-io edited a comment on issue #4991: [AIRFLOW-4170] Serialize non-str value by JSON when importing Variables URL: https://github.com/apache/airflow/pull/4991#issuecomment-496014690 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4991?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #4991: [AIRFLOW-4170] Serialize non-str value by JSON when importing Variables

2019-05-26 Thread GitBox
codecov-io commented on issue #4991: [AIRFLOW-4170] Serialize non-str value by JSON when importing Variables URL: https://github.com/apache/airflow/pull/4991#issuecomment-496014690 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4991?src=pr=h1) Report > Merging

[jira] [Commented] (AIRFLOW-3481) Add SFTP conn type

2019-05-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848464#comment-16848464 ] ASF GitHub Bot commented on AIRFLOW-3481: - cixuuz commented on pull request #4733:

[GitHub] [airflow] cixuuz edited a comment on issue #4733: [AIRFLOW-3481] Add SFTP in connection type

2019-05-26 Thread GitBox
cixuuz edited a comment on issue #4733: [AIRFLOW-3481] Add SFTP in connection type URL: https://github.com/apache/airflow/pull/4733#issuecomment-496009651 > > SFTPHook is different from SSHHook > > The Current implementation of `SFTPOperator` uses SSHHook or SSH Conn ID > >

[GitHub] [airflow] cixuuz commented on issue #4733: [AIRFLOW-3481] Add SFTP in connection type

2019-05-26 Thread GitBox
cixuuz commented on issue #4733: [AIRFLOW-3481] Add SFTP in connection type URL: https://github.com/apache/airflow/pull/4733#issuecomment-496009651 > > SFTPHook is different from SSHHook > > The Current implementation of `SFTPOperator` uses SSHHook or SSH Conn ID > > So, I

[GitHub] [airflow] cixuuz closed pull request #4733: [AIRFLOW-3481] Add SFTP in connection type

2019-05-26 Thread GitBox
cixuuz closed pull request #4733: [AIRFLOW-3481] Add SFTP in connection type URL: https://github.com/apache/airflow/pull/4733 This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (AIRFLOW-2868) Mesos Executor should use executor_config to specify CPU, Memory and Docker image on the task level

2019-05-26 Thread jack (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848428#comment-16848428 ] jack commented on AIRFLOW-2868: --- The ticket can be closed. Mesos was deprecated. > Mesos Executor should

[jira] [Commented] (AIRFLOW-3134) Add New Operator - MySQLToS3TransformOperator

2019-05-26 Thread jack (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848427#comment-16848427 ] jack commented on AIRFLOW-3134: --- I'm not sure.. This will open a window to many new operators (e.g

[GitHub] [airflow] OmerJog commented on issue #5319: [AIRFLOW-4564] Azure Container Instance improvements

2019-05-26 Thread GitBox
OmerJog commented on issue #5319: [AIRFLOW-4564] Azure Container Instance improvements URL: https://github.com/apache/airflow/pull/5319#issuecomment-495993078 @Trollgeir There is a failing test: ``` == 7) ERROR:

[GitHub] [airflow] nvtkaszpir commented on a change in pull request #4703: [AIRFLOW-3885] Improve Travis CI cycle time

2019-05-26 Thread GitBox
nvtkaszpir commented on a change in pull request #4703: [AIRFLOW-3885] Improve Travis CI cycle time URL: https://github.com/apache/airflow/pull/4703#discussion_r287591828 ## File path: scripts/ci/6-check-license.sh ## @@ -17,13 +16,29 @@ # limitations under the License.

[jira] [Commented] (AIRFLOW-4571) Add headers field to templated field for SimpleHttpOperator

2019-05-26 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848382#comment-16848382 ] ASF subversion and git services commented on AIRFLOW-4571: -- Commit

[jira] [Resolved] (AIRFLOW-4571) Add headers field to templated field for SimpleHttpOperator

2019-05-26 Thread Jarek Potiuk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk resolved AIRFLOW-4571. --- Resolution: Fixed Fix Version/s: 2.0.0 > Add headers field to templated field for

[jira] [Commented] (AIRFLOW-4571) Add headers field to templated field for SimpleHttpOperator

2019-05-26 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848381#comment-16848381 ] ASF subversion and git services commented on AIRFLOW-4571: -- Commit

[jira] [Commented] (AIRFLOW-4571) Add headers field to templated field for SimpleHttpOperator

2019-05-26 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848379#comment-16848379 ] ASF subversion and git services commented on AIRFLOW-4571: -- Commit

[jira] [Commented] (AIRFLOW-4571) Add headers field to templated field for SimpleHttpOperator

2019-05-26 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848378#comment-16848378 ] ASF subversion and git services commented on AIRFLOW-4571: -- Commit

[jira] [Commented] (AIRFLOW-4571) Add headers field to templated field for SimpleHttpOperator

2019-05-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848377#comment-16848377 ] ASF GitHub Bot commented on AIRFLOW-4571: - potiuk commented on pull request #5326:

[GitHub] [airflow] potiuk merged pull request #5326: [AIRFLOW-4571] Add headers to templated field for SimpleHttpOperator

2019-05-26 Thread GitBox
potiuk merged pull request #5326: [AIRFLOW-4571] Add headers to templated field for SimpleHttpOperator URL: https://github.com/apache/airflow/pull/5326 This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] BasPH commented on issue #5298: [WIP][AIRFLOW-4534] Remove redundant list around dict comprehensions

2019-05-26 Thread GitBox
BasPH commented on issue #5298: [WIP][AIRFLOW-4534] Remove redundant list around dict comprehensions URL: https://github.com/apache/airflow/pull/5298#issuecomment-495976711 Hmm turns out this is more difficult than expected. Looking specifically into `_update_counters()` now.

[GitHub] [airflow] OmerJog commented on issue #5176: [AIRFLOW-2636] Fix Nonetype error for task failure instance duration

2019-05-26 Thread GitBox
OmerJog commented on issue #5176: [AIRFLOW-2636] Fix Nonetype error for task failure instance duration URL: https://github.com/apache/airflow/pull/5176#issuecomment-495973005 @kaxil need also to close https://github.com/apache/airflow/pull/4032