[jira] [Commented] (AIRFLOW-5078) You should ask user locally whether to pull/build image when needed

2019-07-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896795#comment-16896795 ] ASF GitHub Bot commented on AIRFLOW-5078: - potiuk commented on pull request #5691:

[GitHub] [airflow] potiuk opened a new pull request #5691: [AIRFLOW-5078] User is asked if an image needs to be rebuild

2019-07-30 Thread GitBox
potiuk opened a new pull request #5691: [AIRFLOW-5078] User is asked if an image needs to be rebuild URL: https://github.com/apache/airflow/pull/5691 This is not happening when the user explicitely wants to build image or in CI environment (DockerHub always builds the image via

[jira] [Commented] (AIRFLOW-4811) Implement GCP DLP' Hook and Operators

2019-07-30 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896794#comment-16896794 ] ASF subversion and git services commented on AIRFLOW-4811: -- Commit

[jira] [Commented] (AIRFLOW-2891) Option to set container_name for DockerOperator

2019-07-30 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896785#comment-16896785 ] ASF subversion and git services commented on AIRFLOW-2891: -- Commit

[jira] [Commented] (AIRFLOW-2891) Option to set container_name for DockerOperator

2019-07-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896784#comment-16896784 ] ASF GitHub Bot commented on AIRFLOW-2891: - BasPH commented on pull request #5689:

[GitHub] [airflow] BasPH merged pull request #5689: [AIRFLOW-2891] Option to set container_name for DockerOperator

2019-07-30 Thread GitBox
BasPH merged pull request #5689: [AIRFLOW-2891] Option to set container_name for DockerOperator URL: https://github.com/apache/airflow/pull/5689 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (AIRFLOW-5077) CI builds gets slower when newer version of python gets released

2019-07-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896774#comment-16896774 ] ASF GitHub Bot commented on AIRFLOW-5077: - potiuk commented on pull request #5690:

[GitHub] [airflow] potiuk opened a new pull request #5690: [AIRFLOW-5077] Skip force pulling latest python in CI environment

2019-07-30 Thread GitBox
potiuk opened a new pull request #5690: [AIRFLOW-5077] Skip force pulling latest python in CI environment URL: https://github.com/apache/airflow/pull/5690 The latest python will only be pulled by DockerHub when building master/v1-10-test - which means that it will eventually catch up

[jira] [Created] (AIRFLOW-5078) You should ask user locally whether to pull/build image when needed

2019-07-30 Thread Jarek Potiuk (JIRA)
Jarek Potiuk created AIRFLOW-5078: - Summary: You should ask user locally whether to pull/build image when needed Key: AIRFLOW-5078 URL: https://issues.apache.org/jira/browse/AIRFLOW-5078 Project:

[jira] [Commented] (AIRFLOW-4811) Implement GCP DLP' Hook and Operators

2019-07-30 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896760#comment-16896760 ] ASF subversion and git services commented on AIRFLOW-4811: -- Commit

[jira] [Created] (AIRFLOW-5077) CI builds gets slower when newer version of python gets released

2019-07-30 Thread Jarek Potiuk (JIRA)
Jarek Potiuk created AIRFLOW-5077: - Summary: CI builds gets slower when newer version of python gets released Key: AIRFLOW-5077 URL: https://issues.apache.org/jira/browse/AIRFLOW-5077 Project: Apache

[jira] [Commented] (AIRFLOW-2891) Option to set container_name for DockerOperator

2019-07-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896688#comment-16896688 ] ASF GitHub Bot commented on AIRFLOW-2891: - rocketbitz commented on pull request #5689:

[GitHub] [airflow] rocketbitz opened a new pull request #5689: [AIRFLOW-2891] Option to set container_name for DockerOperator

2019-07-30 Thread GitBox
rocketbitz opened a new pull request #5689: [AIRFLOW-2891] Option to set container_name for DockerOperator URL: https://github.com/apache/airflow/pull/5689 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following: -

[GitHub] [airflow] milton0825 commented on issue #5498: [AIRFLOW-4509] SubDagOperator using scheduler instead of backfill

2019-07-30 Thread GitBox
milton0825 commented on issue #5498: [AIRFLOW-4509] SubDagOperator using scheduler instead of backfill URL: https://github.com/apache/airflow/pull/5498#issuecomment-516649293 @ashb just resolved the conflicts This is an

[GitHub] [airflow] milton0825 removed a comment on issue #5498: [AIRFLOW-4509] SubDagOperator using scheduler instead of backfill

2019-07-30 Thread GitBox
milton0825 removed a comment on issue #5498: [AIRFLOW-4509] SubDagOperator using scheduler instead of backfill URL: https://github.com/apache/airflow/pull/5498#issuecomment-516552402 @ashb just resolved the conflicts This

[GitHub] [airflow] codecov-io edited a comment on issue #5589: [AIRFLOW-4956] Fix LocalTaskJob heartbeat log spamming

2019-07-30 Thread GitBox
codecov-io edited a comment on issue #5589: [AIRFLOW-4956] Fix LocalTaskJob heartbeat log spamming URL: https://github.com/apache/airflow/pull/5589#issuecomment-511549148 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5589?src=pr=h1) Report > :exclamation: No coverage uploaded

[jira] [Commented] (AIRFLOW-5073) Change SQLSensor behavior returning 'success' for NULL result

2019-07-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896528#comment-16896528 ] ASF GitHub Bot commented on AIRFLOW-5073: - ToxaZ commented on pull request #5688:

[GitHub] [airflow] ToxaZ opened a new pull request #5688: [AIRFLOW-5073] Treat NULL as fail in SQL sensor

2019-07-30 Thread GitBox
ToxaZ opened a new pull request #5688: [AIRFLOW-5073] Treat NULL as fail in SQL sensor URL: https://github.com/apache/airflow/pull/5688 Change SQLSensor to treat NULL as fail. Add boolean allow_null parameter to support legacy behavior passing NULL as success. Make sure you have

[GitHub] [airflow] pgagnon commented on issue #5686: [AIRFLOW-5075] Let HttpHook handle connections with empty host fields

2019-07-30 Thread GitBox
pgagnon commented on issue #5686: [AIRFLOW-5075] Let HttpHook handle connections with empty host fields URL: https://github.com/apache/airflow/pull/5686#issuecomment-516593929 @ashb This is an automated message from the

[jira] [Commented] (AIRFLOW-5052) Add the include_deleted parameter to Salesforce Hook

2019-07-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896469#comment-16896469 ] ASF GitHub Bot commented on AIRFLOW-5052: - wmorris75 commented on pull request #5687:

[GitHub] [airflow] wmorris75 opened a new pull request #5687: [AIRFLOW-5052] Add include_deleted param to salesforce_hook. parent 6ef0e37a63f8c876342f5625ef14c6109efe8eab

2019-07-30 Thread GitBox
wmorris75 opened a new pull request #5687: [AIRFLOW-5052] Add include_deleted param to salesforce_hook. parent 6ef0e37a63f8c876342f5625ef14c6109efe8eab URL: https://github.com/apache/airflow/pull/5687 This is an automated

[GitHub] [airflow] eladkal commented on issue #5564: [AIRFLOW-4289] fix spark_binary argument being ignored in SparkSubmit…

2019-07-30 Thread GitBox
eladkal commented on issue #5564: [AIRFLOW-4289] fix spark_binary argument being ignored in SparkSubmit… URL: https://github.com/apache/airflow/pull/5564#issuecomment-516562245 Hi @ashb added another test and squashed all commits.

[jira] [Commented] (AIRFLOW-5065) Add colors to console log

2019-07-30 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896432#comment-16896432 ] ASF subversion and git services commented on AIRFLOW-5065: -- Commit

[jira] [Commented] (AIRFLOW-5022) DockerHook ignores connection port

2019-07-30 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896430#comment-16896430 ] ASF subversion and git services commented on AIRFLOW-5022: -- Commit

[jira] [Commented] (AIRFLOW-4961) SQL Error when writing Task Failure (using CockroachDB)

2019-07-30 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896429#comment-16896429 ] ASF subversion and git services commented on AIRFLOW-4961: -- Commit

[jira] [Commented] (AIRFLOW-5038) Pod deleted message is shown incorrectly when pod deletion is disabled

2019-07-30 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896428#comment-16896428 ] ASF subversion and git services commented on AIRFLOW-5038: -- Commit

[jira] [Commented] (AIRFLOW-4822) When clearing task instance of subdag, irrelevant tasks within parent dag might be cleared as well.

2019-07-30 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896431#comment-16896431 ] ASF subversion and git services commented on AIRFLOW-4822: -- Commit

[GitHub] [airflow] milton0825 commented on issue #5498: [AIRFLOW-4509] SubDagOperator using scheduler instead of backfill

2019-07-30 Thread GitBox
milton0825 commented on issue #5498: [AIRFLOW-4509] SubDagOperator using scheduler instead of backfill URL: https://github.com/apache/airflow/pull/5498#issuecomment-516552402 @ashb just resolved the conflicts This is an

[GitHub] [airflow] george-miller commented on a change in pull request #5475: [AIRFLOW-4846] Allow specification of an existing secret containing git credentials for init containers

2019-07-30 Thread GitBox
george-miller commented on a change in pull request #5475: [AIRFLOW-4846] Allow specification of an existing secret containing git credentials for init containers URL: https://github.com/apache/airflow/pull/5475#discussion_r308890544 ## File path:

[jira] [Created] (AIRFLOW-5076) Bug in airflow schedule DAG

2019-07-30 Thread Allyson (JIRA)
Allyson created AIRFLOW-5076: Summary: Bug in airflow schedule DAG Key: AIRFLOW-5076 URL: https://issues.apache.org/jira/browse/AIRFLOW-5076 Project: Apache Airflow Issue Type: Bug

[GitHub] [airflow] tooptoop4 commented on issue #5605: [AIRFLOW-4883] Kill hung file process managers

2019-07-30 Thread GitBox
tooptoop4 commented on issue #5605: [AIRFLOW-4883] Kill hung file process managers URL: https://github.com/apache/airflow/pull/5605#issuecomment-516530239 @ashb should https://issues.apache.org/jira/browse/AIRFLOW-4883 jira have fixversion=1.10.4 ?

[jira] [Updated] (AIRFLOW-5075) HttpHook cannot handle connections with an empty host field

2019-07-30 Thread Philippe Gagnon (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philippe Gagnon updated AIRFLOW-5075: - Description: {{HttpHook}} cannot handle connections with an empty {{host}} field:  

[GitHub] [airflow] pgagnon opened a new pull request #5686: [AIRFLOW-5075] Let HttpHook handle connections with empty host fields

2019-07-30 Thread GitBox
pgagnon opened a new pull request #5686: [AIRFLOW-5075] Let HttpHook handle connections with empty host fields URL: https://github.com/apache/airflow/pull/5686 Make sure you have checked _all_ steps below. ### Jira - [X] My PR addresses the following [Airflow

[jira] [Commented] (AIRFLOW-5075) HttpHook cannot handle connections with an empty host field

2019-07-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896359#comment-16896359 ] ASF GitHub Bot commented on AIRFLOW-5075: - pgagnon commented on pull request #5686:

[jira] [Commented] (AIRFLOW-5069) `airflow initdb` crashes when owner is set to None

2019-07-30 Thread Arsen Arutyunyan (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896335#comment-16896335 ] Arsen Arutyunyan commented on AIRFLOW-5069: --- [~ash] it does not, unfortunately. I've

[jira] [Commented] (AIRFLOW-5031) Tzlocal 2.0.0 has been released today and it breaks the build

2019-07-30 Thread Tylar Murray (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896332#comment-16896332 ] Tylar Murray commented on AIRFLOW-5031: --- I thought I might be able to close this if I

[jira] [Assigned] (AIRFLOW-5031) Tzlocal 2.0.0 has been released today and it breaks the build

2019-07-30 Thread Tylar Murray (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tylar Murray reassigned AIRFLOW-5031: - Assignee: Tylar Murray > Tzlocal 2.0.0 has been released today and it breaks the

[jira] [Created] (AIRFLOW-5075) HttpHook cannot handle connections with an empty host field

2019-07-30 Thread Philippe Gagnon (JIRA)
Philippe Gagnon created AIRFLOW-5075: Summary: HttpHook cannot handle connections with an empty host field Key: AIRFLOW-5075 URL: https://issues.apache.org/jira/browse/AIRFLOW-5075 Project:

[jira] [Comment Edited] (AIRFLOW-2978) Airflow deps breaking on ancient Python packages

2019-07-30 Thread Tylar Murray (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896327#comment-16896327 ] Tylar Murray edited comment on AIRFLOW-2978 at 7/30/19 5:03 PM: This

[jira] [Commented] (AIRFLOW-2978) Airflow deps breaking on ancient Python packages

2019-07-30 Thread Tylar Murray (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896327#comment-16896327 ] Tylar Murray commented on AIRFLOW-2978: --- This has been resolved on master by editing the line in

[GitHub] [airflow] OmerJog commented on issue #5685: [AIRFLOW-5072] gcs_hook's download() method should download only once

2019-07-30 Thread GitBox
OmerJog commented on issue #5685: [AIRFLOW-5072] gcs_hook's download() method should download only once URL: https://github.com/apache/airflow/pull/5685#issuecomment-516502524 You have pylint error to fix: `airflow/contrib/hooks/gcs_hook.py:157:4: R1710: Either all return statements in

[GitHub] [airflow] OmerJog commented on issue #5647: [AIRFLOW-3628] Add smtp_mime_from

2019-07-30 Thread GitBox
OmerJog commented on issue #5647: [AIRFLOW-3628] Add smtp_mime_from URL: https://github.com/apache/airflow/pull/5647#issuecomment-516502086 Test passed lets get this in as previous PR was stale long enough This is an

[jira] [Commented] (AIRFLOW-5022) DockerHook ignores connection port

2019-07-30 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896284#comment-16896284 ] ASF subversion and git services commented on AIRFLOW-5022: -- Commit

[jira] [Commented] (AIRFLOW-4822) When clearing task instance of subdag, irrelevant tasks within parent dag might be cleared as well.

2019-07-30 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896285#comment-16896285 ] ASF subversion and git services commented on AIRFLOW-4822: -- Commit

[jira] [Commented] (AIRFLOW-4961) SQL Error when writing Task Failure (using CockroachDB)

2019-07-30 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896283#comment-16896283 ] ASF subversion and git services commented on AIRFLOW-4961: -- Commit

[jira] [Commented] (AIRFLOW-5038) Pod deleted message is shown incorrectly when pod deletion is disabled

2019-07-30 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896282#comment-16896282 ] ASF subversion and git services commented on AIRFLOW-5038: -- Commit

[jira] [Commented] (AIRFLOW-5065) Add colors to console log

2019-07-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896265#comment-16896265 ] ASF GitHub Bot commented on AIRFLOW-5065: - ashb commented on pull request #5681: [AIRFLOW-5065]

[jira] [Commented] (AIRFLOW-5065) Add colors to console log

2019-07-30 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896268#comment-16896268 ] ASF subversion and git services commented on AIRFLOW-5065: -- Commit

[GitHub] [airflow] ashb merged pull request #5681: [AIRFLOW-5065] Add colors to console log

2019-07-30 Thread GitBox
ashb merged pull request #5681: [AIRFLOW-5065] Add colors to console log URL: https://github.com/apache/airflow/pull/5681 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] ashb commented on issue #5681: [AIRFLOW-5065] Add colors to console log

2019-07-30 Thread GitBox
ashb commented on issue #5681: [AIRFLOW-5065] Add colors to console log URL: https://github.com/apache/airflow/pull/5681#issuecomment-516484493 Boom, all green, merging! This is an automated message from the Apache Git

[GitHub] [airflow] nuclearpinguin commented on issue #5681: [AIRFLOW-5065] Add colors to console log

2019-07-30 Thread GitBox
nuclearpinguin commented on issue #5681: [AIRFLOW-5065] Add colors to console log URL: https://github.com/apache/airflow/pull/5681#issuecomment-516484060 > I pushed a fixup commit with this change directly to your branch, ack but that now conflicts. I'll fix that too. Thanks!

[jira] [Commented] (AIRFLOW-5052) Add the include_deleted parameter to Salesforce Hook

2019-07-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896244#comment-16896244 ] ASF GitHub Bot commented on AIRFLOW-5052: - wmorris75 commented on pull request #5683:

[GitHub] [airflow] wmorris75 closed pull request #5683: [AIRFLOW-5052] sf query include param fix

2019-07-30 Thread GitBox
wmorris75 closed pull request #5683: [AIRFLOW-5052] sf query include param fix URL: https://github.com/apache/airflow/pull/5683 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] ashb commented on issue #5681: [AIRFLOW-5065] Add colors to console log

2019-07-30 Thread GitBox
ashb commented on issue #5681: [AIRFLOW-5065] Add colors to console log URL: https://github.com/apache/airflow/pull/5681#issuecomment-516457823 I pushed a fixup commit with this change directly to your branch, ack but that now conflicts. I'll fix that too.

[jira] [Resolved] (AIRFLOW-4811) Implement GCP DLP' Hook and Operators

2019-07-30 Thread Jarek Potiuk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk resolved AIRFLOW-4811. --- Resolution: Fixed > Implement GCP DLP' Hook and Operators >

[GitHub] [airflow] ashb commented on issue #5681: [AIRFLOW-5065] Add colors to console log

2019-07-30 Thread GitBox
ashb commented on issue #5681: [AIRFLOW-5065] Add colors to console log URL: https://github.com/apache/airflow/pull/5681#issuecomment-516452427 Confirmed task logs look okay now, but I noticed that we have one file being written with ascii escapes in:

[jira] [Updated] (AIRFLOW-5072) gcs_hook causes out-of-memory error when downloading huge files

2019-07-30 Thread Tobias Kaymak (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Kaymak updated AIRFLOW-5072: --- Description: Possibly there is an "else" missing here, but the gcs_hook's `download`

[jira] [Commented] (AIRFLOW-5071) Thousand os Executor reports task instance X finished (success) although the task says its queued. Was the task killed externally?

2019-07-30 Thread msempere (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896195#comment-16896195 ] msempere commented on AIRFLOW-5071: --- Ash, I can confirm there's just one scheduler running. Let me

[jira] [Created] (AIRFLOW-5074) ExternalSensor with reschedule mode is set as failed on every retry

2019-07-30 Thread msempere (JIRA)
msempere created AIRFLOW-5074: - Summary: ExternalSensor with reschedule mode is set as failed on every retry Key: AIRFLOW-5074 URL: https://issues.apache.org/jira/browse/AIRFLOW-5074 Project: Apache

[jira] [Commented] (AIRFLOW-4811) Implement GCP DLP' Hook and Operators

2019-07-30 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896187#comment-16896187 ] ASF subversion and git services commented on AIRFLOW-4811: -- Commit

[jira] [Updated] (AIRFLOW-5057) Provide bucket name to functions in S3 Hook when none is specified

2019-07-30 Thread Felix Uellendall (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Uellendall updated AIRFLOW-5057: -- Fix Version/s: 2.0.0 > Provide bucket name to functions in S3 Hook when none is

[jira] [Updated] (AIRFLOW-5056) Add mail_filter argument to ImapHook when searching for attachments

2019-07-30 Thread Felix Uellendall (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Uellendall updated AIRFLOW-5056: -- Fix Version/s: (was: 1.10.5) 2.0.0 > Add mail_filter argument

[GitHub] [airflow] feluelle commented on issue #5674: [AIRFLOW-5057] Provide bucket name to functions in S3 Hook when none is specified

2019-07-30 Thread GitBox
feluelle commented on issue #5674: [AIRFLOW-5057] Provide bucket name to functions in S3 Hook when none is specified URL: https://github.com/apache/airflow/pull/5674#issuecomment-516435007 If **we** want to have it in 1.10.4 or .5 "+1" me and I will add a PR removing the "provide

[GitHub] [airflow] feluelle commented on issue #5674: [AIRFLOW-5057] Provide bucket name to functions in S3 Hook when none is specified

2019-07-30 Thread GitBox
feluelle commented on issue #5674: [AIRFLOW-5057] Provide bucket name to functions in S3 Hook when none is specified URL: https://github.com/apache/airflow/pull/5674#issuecomment-516433902 Totally agree.  This is an

[GitHub] [airflow] feluelle edited a comment on issue #5674: [AIRFLOW-5057] Provide bucket name to functions in S3 Hook when none is specified

2019-07-30 Thread GitBox
feluelle edited a comment on issue #5674: [AIRFLOW-5057] Provide bucket name to functions in S3 Hook when none is specified URL: https://github.com/apache/airflow/pull/5674#issuecomment-516431430 Yes, that's why I target 1.10.5 :P but ya probably 2.0 ? EDIT: nvm that was the

[GitHub] [airflow] ashb commented on issue #5674: [AIRFLOW-5057] Provide bucket name to functions in S3 Hook when none is specified

2019-07-30 Thread GitBox
ashb commented on issue #5674: [AIRFLOW-5057] Provide bucket name to functions in S3 Hook when none is specified URL: https://github.com/apache/airflow/pull/5674#issuecomment-516433415 2.0 unless you can support back-compat. (No breaking changes from 1.10.x to 1.10.y is my rule)

[GitHub] [airflow] feluelle commented on issue #5674: [AIRFLOW-5057] Provide bucket name to functions in S3 Hook when none is specified

2019-07-30 Thread GitBox
feluelle commented on issue #5674: [AIRFLOW-5057] Provide bucket name to functions in S3 Hook when none is specified URL: https://github.com/apache/airflow/pull/5674#issuecomment-516431430 Yes, that's why I target 1.10.5 :P but ya probably 2.0 ?

[GitHub] [airflow] ashb commented on issue #5674: [AIRFLOW-5057] Provide bucket name to functions in S3 Hook when none is specified

2019-07-30 Thread GitBox
ashb commented on issue #5674: [AIRFLOW-5057] Provide bucket name to functions in S3 Hook when none is specified URL: https://github.com/apache/airflow/pull/5674#issuecomment-516431160 We probably can't merge this in to 1.10.4 though cos of the ordering change.

[GitHub] [airflow] feluelle edited a comment on issue #5674: [AIRFLOW-5057] Provide bucket name to functions in S3 Hook when none is specified

2019-07-30 Thread GitBox
feluelle edited a comment on issue #5674: [AIRFLOW-5057] Provide bucket name to functions in S3 Hook when none is specified URL: https://github.com/apache/airflow/pull/5674#issuecomment-516430421 Did not expect that to be merged that fast :D (I hope I did not break backwards compatibility

[GitHub] [airflow] feluelle commented on issue #5674: [AIRFLOW-5057] Provide bucket name to functions in S3 Hook when none is specified

2019-07-30 Thread GitBox
feluelle commented on issue #5674: [AIRFLOW-5057] Provide bucket name to functions in S3 Hook when none is specified URL: https://github.com/apache/airflow/pull/5674#issuecomment-516430421 Did not expect that to be merged that fast :D The background behind this change is actually

[GitHub] [airflow] ashb commented on issue #5564: [AIRFLOW-4289] fix spark_binary argument being ignored in SparkSubmit…

2019-07-30 Thread GitBox
ashb commented on issue #5564: [AIRFLOW-4289] fix spark_binary argument being ignored in SparkSubmit… URL: https://github.com/apache/airflow/pull/5564#issuecomment-516430342 @eladkal No that test doesn't cover the case where both the spark_submit is specified both in the connection and in

[jira] [Commented] (AIRFLOW-5071) Thousand os Executor reports task instance X finished (success) although the task says its queued. Was the task killed externally?

2019-07-30 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896155#comment-16896155 ] Ash Berlin-Taylor commented on AIRFLOW-5071: Can you share the DAG file? That might be

[GitHub] [airflow] ashb commented on issue #5379: AIRFLOW-4316 Don't make automatically lower case every variable from …

2019-07-30 Thread GitBox
ashb commented on issue #5379: AIRFLOW-4316 Don't make automatically lower case every variable from … URL: https://github.com/apache/airflow/pull/5379#issuecomment-516428010 @mppetkov Could you rebase this on to latest master -- hopefully the tests will pass then.

[GitHub] [airflow] ashb commented on a change in pull request #5681: [AIRFLOW-5065] Add colors to console log

2019-07-30 Thread GitBox
ashb commented on a change in pull request #5681: [AIRFLOW-5065] Add colors to console log URL: https://github.com/apache/airflow/pull/5681#discussion_r308732275 ## File path: airflow/config_templates/default_airflow.cfg ## @@ -59,6 +59,11 @@ fab_logging_level = WARN

[jira] [Commented] (AIRFLOW-5071) Thousand os Executor reports task instance X finished (success) although the task says its queued. Was the task killed externally?

2019-07-30 Thread msempere (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896143#comment-16896143 ] msempere commented on AIRFLOW-5071: --- Are you looking for any specific parameter or property on that

[GitHub] [airflow] ashb merged pull request #5684: [AIRFLOW-XXX] Remove default/wrong values from test config.

2019-07-30 Thread GitBox
ashb merged pull request #5684: [AIRFLOW-XXX] Remove default/wrong values from test config. URL: https://github.com/apache/airflow/pull/5684 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] ashb commented on issue #5681: [AIRFLOW-5065] Add colors to console log

2019-07-30 Thread GitBox
ashb commented on issue #5681: [AIRFLOW-5065] Add colors to console log URL: https://github.com/apache/airflow/pull/5681#issuecomment-516421904 > colorlog and termcolor. Checked and those are both MIT so that's cool.

[jira] [Updated] (AIRFLOW-5071) Thousand os Executor reports task instance X finished (success) although the task says its queued. Was the task killed externally?

2019-07-30 Thread msempere (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] msempere updated AIRFLOW-5071: -- Description: I'm opening this issue because since I update to 1.10.3 I'm seeing thousands of daily

[GitHub] [airflow] ashb commented on a change in pull request #5681: [AIRFLOW-5065] Add colors to console log

2019-07-30 Thread GitBox
ashb commented on a change in pull request #5681: [AIRFLOW-5065] Add colors to console log URL: https://github.com/apache/airflow/pull/5681#discussion_r308722251 ## File path: airflow/config_templates/default_airflow.cfg ## @@ -59,6 +59,8 @@ fab_logging_level = WARN

[GitHub] [airflow] ashb commented on a change in pull request #5681: [AIRFLOW-5065] Add colors to console log

2019-07-30 Thread GitBox
ashb commented on a change in pull request #5681: [AIRFLOW-5065] Add colors to console log URL: https://github.com/apache/airflow/pull/5681#discussion_r308722627 ## File path: airflow/config_templates/default_airflow.cfg ## @@ -59,6 +59,8 @@ fab_logging_level = WARN

[jira] [Created] (AIRFLOW-5073) Change SQLSensor behavior returning 'success' for NULL result

2019-07-30 Thread Anton Zayniev (JIRA)
Anton Zayniev created AIRFLOW-5073: -- Summary: Change SQLSensor behavior returning 'success' for NULL result Key: AIRFLOW-5073 URL: https://issues.apache.org/jira/browse/AIRFLOW-5073 Project: Apache

[GitHub] [airflow] ashb commented on a change in pull request #5681: [AIRFLOW-5065] Add colors to console log

2019-07-30 Thread GitBox
ashb commented on a change in pull request #5681: [AIRFLOW-5065] Add colors to console log URL: https://github.com/apache/airflow/pull/5681#discussion_r308717784 ## File path: airflow/config_templates/airflow_local_settings.py ## @@ -72,8 +76,13 @@

[GitHub] [airflow] nuclearpinguin commented on issue #5681: [AIRFLOW-5065] Add colors to console log

2019-07-30 Thread GitBox
nuclearpinguin commented on issue #5681: [AIRFLOW-5065] Add colors to console log URL: https://github.com/apache/airflow/pull/5681#issuecomment-516416096 Finally I decided to extend `colorlog.TTYColoredFormatter` by adding colors to message's arguments and error traceback. The code is

[jira] [Resolved] (AIRFLOW-4901) Jinja2 dependency resolution

2019-07-30 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-4901. Resolution: Fixed Fix Version/s: 1.10.4 The version of Jinja we had in in

[jira] [Reopened] (AIRFLOW-4901) Jinja2 dependency resolution

2019-07-30 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor reopened AIRFLOW-4901: > Jinja2 dependency resolution > > >

[GitHub] [airflow] eladkal edited a comment on issue #5564: [AIRFLOW-4289] fix spark_binary argument being ignored in SparkSubmit…

2019-07-30 Thread GitBox
eladkal edited a comment on issue #5564: [AIRFLOW-4289] fix spark_binary argument being ignored in SparkSubmit… URL: https://github.com/apache/airflow/pull/5564#issuecomment-516411245 @ashb Isn't it already covered by `test_resolve_connection_spark_binary_set_connection` it takes

[GitHub] [airflow] ashb commented on issue #3758: [AIRFLOW-2908] Allow retries with KubernetesExecutor.

2019-07-30 Thread GitBox
ashb commented on issue #3758: [AIRFLOW-2908] Allow retries with KubernetesExecutor. URL: https://github.com/apache/airflow/pull/3758#issuecomment-516411274 @Devarajegowda Probably because it didn't used to work and no one investigated to see that it does _now_ work. If it does now work

[GitHub] [airflow] eladkal commented on issue #5564: [AIRFLOW-4289] fix spark_binary argument being ignored in SparkSubmit…

2019-07-30 Thread GitBox
eladkal commented on issue #5564: [AIRFLOW-4289] fix spark_binary argument being ignored in SparkSubmit… URL: https://github.com/apache/airflow/pull/5564#issuecomment-516411245 @ashb Isn't it already covered by `test_resolve_connection_spark_binary_set_connection` it takes

[jira] [Commented] (AIRFLOW-4901) Jinja2 dependency resolution

2019-07-30 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896113#comment-16896113 ] Ash Berlin-Taylor commented on AIRFLOW-4901: Ah yes, with 1.10 3 you will need to also

[jira] [Closed] (AIRFLOW-4874) Any py file containing the text DAG will be loaded as a DAG, even if DAG is in comments

2019-07-30 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor closed AIRFLOW-4874. -- Resolution: Information Provided

[jira] [Commented] (AIRFLOW-4915) Support backfill through Airflow UI

2019-07-30 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896110#comment-16896110 ] Ash Berlin-Taylor commented on AIRFLOW-4915: Backfill can be used to re-run over an

[GitHub] [airflow] ashb commented on issue #5653: [AIRFLOW-XXX] fix copy/pasta in k8s request factory extract resources

2019-07-30 Thread GitBox
ashb commented on issue #5653: [AIRFLOW-XXX] fix copy/pasta in k8s request factory extract resources URL: https://github.com/apache/airflow/pull/5653#issuecomment-516406459 (Got merged in #5657 ) This is an automated message

[GitHub] [airflow] ashb commented on issue #5605: [AIRFLOW-4883] Kill hung file process managers

2019-07-30 Thread GitBox
ashb commented on issue #5605: [AIRFLOW-4883] Kill hung file process managers URL: https://github.com/apache/airflow/pull/5605#issuecomment-516406106 Since we had to restart fix another bug anyway I did pull this (and the fix commits) in to the release branch.

[jira] [Commented] (AIRFLOW-5071) Thousand os Executor reports task instance X finished (success) although the task says its queued. Was the task killed externally?

2019-07-30 Thread msempere (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896103#comment-16896103 ] msempere commented on AIRFLOW-5071: --- Is a DAG (one-dag-to-one-py-file) that generates its upstream

[GitHub] [airflow] tkaymak opened a new pull request #5685: [AIRFLOW-5072] Fix gcs_hook's download() method downloading twice error

2019-07-30 Thread GitBox
tkaymak opened a new pull request #5685: [AIRFLOW-5072] Fix gcs_hook's download() method downloading twice error URL: https://github.com/apache/airflow/pull/5685 Make sure you have checked _all_ steps below. ### Jira - [X] My PR addresses the following [Airflow

[GitHub] [airflow] ryanyuan commented on issue #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators

2019-07-30 Thread GitBox
ryanyuan commented on issue #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators URL: https://github.com/apache/airflow/pull/5539#issuecomment-516404554 > @ryanyuan Can you add typehints in a separate PR? I have accepted the current version, because in 1.10.4 typehint is not

[GitHub] [airflow] ashb commented on a change in pull request #5564: [AIRFLOW-4289] fix spark_binary argument being ignored in SparkSubmit…

2019-07-30 Thread GitBox
ashb commented on a change in pull request #5564: [AIRFLOW-4289] fix spark_binary argument being ignored in SparkSubmit… URL: https://github.com/apache/airflow/pull/5564#discussion_r308696522 ## File path: airflow/contrib/hooks/spark_submit_hook.py ## @@ -206,9 +207,10 @@

[GitHub] [airflow] ashb commented on a change in pull request #5564: [AIRFLOW-4289] fix spark_binary argument being ignored in SparkSubmit…

2019-07-30 Thread GitBox
ashb commented on a change in pull request #5564: [AIRFLOW-4289] fix spark_binary argument being ignored in SparkSubmit… URL: https://github.com/apache/airflow/pull/5564#discussion_r308696326 ## File path: airflow/contrib/hooks/spark_submit_hook.py ## @@ -206,9 +207,10 @@

[jira] [Updated] (AIRFLOW-4811) Implement GCP DLP' Hook and Operators

2019-07-30 Thread Kamil Bregula (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil Bregula updated AIRFLOW-4811: --- Fix Version/s: 1.10.4 > Implement GCP DLP' Hook and Operators >

[jira] [Updated] (AIRFLOW-4811) Implement GCP DLP' Hook and Operators

2019-07-30 Thread Kamil Bregula (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil Bregula updated AIRFLOW-4811: --- Affects Version/s: (was: 2.0.0) 1.10.3 > Implement GCP DLP'

  1   2   >