szha commented on issue #9009:
URL: https://github.com/apache/airflow/issues/9009#issuecomment-636414596
HashiCorp recently added a clause to their [term of
evaluation](https://www.hashicorp.com/terms-of-evaluation) that forbids the
usage of their enterprise software in China. While this
tanjinP opened a new pull request #9079:
URL: https://github.com/apache/airflow/pull/9079
Closes #8970
Currently have an outline of the items mentioned
(`docs/howto/operator/kubernetes.rst`) in the issue and looking for feedback if
this is a good approach to take to build out this
[
https://issues.apache.org/jira/browse/AIRFLOW-578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120379#comment-17120379
]
ASF GitHub Bot commented on AIRFLOW-578:
stale[bot] closed pull request #6870:
URL:
stale[bot] closed pull request #6870:
URL: https://github.com/apache/airflow/pull/6870
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
eladkal commented on issue #9016:
URL: https://github.com/apache/airflow/issues/9016#issuecomment-636389926
The ability to render query from file exists in BaseOperator hence can be
used by all operators by specifying `template_ext`. This is not available in
Hooks as hooks don't get
[
https://issues.apache.org/jira/browse/AIRFLOW-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120372#comment-17120372
]
ASF GitHub Bot commented on AIRFLOW-6585:
-
stale[bot] closed pull request #7153:
URL:
[
https://issues.apache.org/jira/browse/AIRFLOW-6944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120371#comment-17120371
]
ASF GitHub Bot commented on AIRFLOW-6944:
-
stale[bot] closed pull request #7585:
URL:
stale[bot] closed pull request #7585:
URL: https://github.com/apache/airflow/pull/7585
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
stale[bot] closed pull request #7153:
URL: https://github.com/apache/airflow/pull/7153
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mik-laj commented on a change in pull request #9070:
URL: https://github.com/apache/airflow/pull/9070#discussion_r432888705
##
File path: airflow/cli/cli_parser.py
##
@@ -1326,8 +1347,11 @@ def _add_command(
subparsers: argparse._SubParsersAction, # pylint:
mik-laj commented on a change in pull request #9070:
URL: https://github.com/apache/airflow/pull/9070#discussion_r432888964
##
File path: airflow/cli/cli_parser.py
##
@@ -742,13 +722,15 @@ class ActionCommand(NamedTuple):
help: str
func: Callable
args:
mik-laj commented on a change in pull request #9070:
URL: https://github.com/apache/airflow/pull/9070#discussion_r432888933
##
File path: airflow/cli/cli_parser.py
##
@@ -742,13 +722,15 @@ class ActionCommand(NamedTuple):
help: str
func: Callable
args:
mik-laj commented on a change in pull request #9070:
URL: https://github.com/apache/airflow/pull/9070#discussion_r432888705
##
File path: airflow/cli/cli_parser.py
##
@@ -1326,8 +1347,11 @@ def _add_command(
subparsers: argparse._SubParsersAction, # pylint:
mik-laj commented on a change in pull request #9070:
URL: https://github.com/apache/airflow/pull/9070#discussion_r432888705
##
File path: airflow/cli/cli_parser.py
##
@@ -1326,8 +1347,11 @@ def _add_command(
subparsers: argparse._SubParsersAction, # pylint:
samuelkhtu commented on a change in pull request #8942:
URL: https://github.com/apache/airflow/pull/8942#discussion_r432887660
##
File path: airflow/operators/sql_branch_operator.py
##
@@ -0,0 +1,174 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
samuelkhtu commented on a change in pull request #8942:
URL: https://github.com/apache/airflow/pull/8942#discussion_r432887517
##
File path: airflow/operators/sql_branch_operator.py
##
@@ -0,0 +1,174 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
mik-laj commented on pull request #9078:
URL: https://github.com/apache/airflow/pull/9078#issuecomment-636381764
We create modules that do not contain any content. They are only added to
sys.modules, but they cannot be used in any way. I care about it because it
makes it difficult to
potiuk commented on a change in pull request #8942:
URL: https://github.com/apache/airflow/pull/8942#discussion_r432884511
##
File path: airflow/operators/sql_branch_operator.py
##
@@ -0,0 +1,174 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
samuelkhtu commented on a change in pull request #8942:
URL: https://github.com/apache/airflow/pull/8942#discussion_r432884495
##
File path: airflow/operators/sql_branch_operator.py
##
@@ -0,0 +1,174 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
potiuk commented on a change in pull request #8942:
URL: https://github.com/apache/airflow/pull/8942#discussion_r432884462
##
File path: airflow/operators/sql_branch_operator.py
##
@@ -0,0 +1,174 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
samuelkhtu commented on a change in pull request #8942:
URL: https://github.com/apache/airflow/pull/8942#discussion_r432884263
##
File path: airflow/operators/sql_branch_operator.py
##
@@ -0,0 +1,174 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
notatallshaw commented on pull request #9057:
URL: https://github.com/apache/airflow/pull/9057#issuecomment-636379966
> Still some spaces at the end of lines :(.
Still working on it, got a spell check extension and fixed a spelling issue,
just figured out how to set-up
potiuk commented on pull request #9078:
URL: https://github.com/apache/airflow/pull/9078#issuecomment-636379607
Some explanation pls :)?
This is an automated message from the Apache Git Service.
To respond to the message,
mik-laj opened a new pull request #9078:
URL: https://github.com/apache/airflow/pull/9078
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [X] Unit tests coverage for changes (not needed for documentation
mik-laj merged pull request #9002:
URL: https://github.com/apache/airflow/pull/9002
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
kamilbregula pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/master by this push:
new 2b1dc1b Support properties in plugins
potiuk merged pull request #9076:
URL: https://github.com/apache/airflow/pull/9076
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/master by this push:
new 88c8edb Prevents failure on fixing
potiuk commented on pull request #9057:
URL: https://github.com/apache/airflow/pull/9057#issuecomment-636371176
Still some spaces at the end of lines :(.
This is an automated message from the Apache Git Service.
To respond
potiuk merged pull request #9075:
URL: https://github.com/apache/airflow/pull/9075
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/master by this push:
new db42974 Adds hive as extra in pyhive (#9075)
potiuk closed issue #8933:
URL: https://github.com/apache/airflow/issues/8933
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mik-laj edited a comment on pull request #9070:
URL: https://github.com/apache/airflow/pull/9070#issuecomment-636314422
You could also split the description of the `airflow rotate_fernet_key` and
`airflow celery` command. Links should be in extended help.
```
usage: airflow [-h]
mik-laj commented on pull request #9070:
URL: https://github.com/apache/airflow/pull/9070#issuecomment-636369265
> How about the --subdir argument? Should I work on it?
It's not perfect, but I have no idea.
Could you look at `airflow dags test --help` command? The argument
mik-laj opened a new pull request #9077:
URL: https://github.com/apache/airflow/pull/9077
Before:
```
usage: airflow [-h]
{celery,config,connections,dags,db,info,kerberos,pools,roles,rotate_fernet_key,scheduler,sync_perm,tasks,users,variables,version,webserver}
potiuk commented on a change in pull request #8721:
URL: https://github.com/apache/airflow/pull/8721#discussion_r432876257
##
File path: openapi.yaml
##
@@ -0,0 +1,2412 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.
Acehaidrey commented on pull request #8680:
URL: https://github.com/apache/airflow/pull/8680#issuecomment-636365468
@turbaszek my apologies - check now ( once build is successful that is )
This is an automated message
mik-laj commented on a change in pull request #9070:
URL: https://github.com/apache/airflow/pull/9070#discussion_r432874518
##
File path: airflow/cli/cli_parser.py
##
@@ -1226,7 +1235,8 @@ class GroupCommand(NamedTuple):
ActionCommand(
name='rotate_fernet_key',
turbaszek commented on a change in pull request #9037:
URL: https://github.com/apache/airflow/pull/9037#discussion_r432873891
##
File path: docs/howto/operator/gcp/dataproc.rst
##
@@ -0,0 +1,188 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more
turbaszek commented on a change in pull request #9037:
URL: https://github.com/apache/airflow/pull/9037#discussion_r432873891
##
File path: docs/howto/operator/gcp/dataproc.rst
##
@@ -0,0 +1,188 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more
turbaszek edited a comment on issue #9071:
URL: https://github.com/apache/airflow/issues/9071#issuecomment-636361911
I'm not familiar with MySQL but maybe @feluelle knows more?
I was not able to replicate this in breeze using:
```
./breeze --install-airflow-version 1.10.10
potiuk opened a new pull request #9076:
URL: https://github.com/apache/airflow/pull/9076
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation
turbaszek commented on issue #9071:
URL: https://github.com/apache/airflow/issues/9071#issuecomment-636361911
I thought that this was fixed in 1.10.10 樂 I'm not familiar with MySQL but
maybe @feluelle knows more?
This is an
potiuk commented on pull request #9075:
URL: https://github.com/apache/airflow/pull/9075#issuecomment-636361481
CC: @snazzyfox @eladkal
This is an automated message from the Apache Git Service.
To respond to the message,
potiuk opened a new pull request #9075:
URL: https://github.com/apache/airflow/pull/9075
Seems that apache hive needs to install [hive] extra of pyhive
in order to be usable ¯\_(ツ)_/¯.
Fixes: #8933
---
Make sure to mark the boxes below before creating PR: [x]
-
joppevos commented on a change in pull request #9037:
URL: https://github.com/apache/airflow/pull/9037#discussion_r432872432
##
File path: docs/howto/operator/gcp/dataproc.rst
##
@@ -0,0 +1,188 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more
randr97 closed issue #8890:
URL: https://github.com/apache/airflow/issues/8890
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kaxil merged pull request #8739:
URL: https://github.com/apache/airflow/pull/8739
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
kaxilnaik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/master by this push:
new 735bf45 Test that DagFileProcessor can
snazzyfox commented on issue #8933:
URL: https://github.com/apache/airflow/issues/8933#issuecomment-636354348
Glad to hear that system tests will be coming! We should definitely still
add it to the dependencies because that would actually fix it. System tests
would only help catch the
This is an automated email from the ASF dual-hosted git repository.
turbaszek pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 93eda7a Remove not-existing files in pylint_todo.txt (#9073)
add 7f026d1 Remove Travis CI badge from
turbaszek merged pull request #9074:
URL: https://github.com/apache/airflow/pull/9074
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
turbaszek commented on a change in pull request #9074:
URL: https://github.com/apache/airflow/pull/9074#discussion_r432865899
##
File path: README.md
##
@@ -20,9 +20,9 @@
[](https://badge.fury.io/py/apache-airflow)
mik-laj commented on a change in pull request #9074:
URL: https://github.com/apache/airflow/pull/9074#discussion_r432865389
##
File path: README.md
##
@@ -20,9 +20,9 @@
[](https://badge.fury.io/py/apache-airflow)
This is an automated email from the ASF dual-hosted git repository.
turbaszek pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 05e4c39 Provide_context coma is added only when there is not one
already (#9064)
add 93eda7a Remove
turbaszek merged pull request #9073:
URL: https://github.com/apache/airflow/pull/9073
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
turbaszek opened a new pull request #9074:
URL: https://github.com/apache/airflow/pull/9074
Since we abandoned Travis there's no reason to keep this badge. I've also
split badges to two lines for a better look.
---
Make sure to mark the boxes below before creating PR: [x]
turbaszek merged pull request #9064:
URL: https://github.com/apache/airflow/pull/9064
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
turbaszek pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 3435e6e Improve SchedulerJob code style (#9018)
add 05e4c39 Provide_context coma is added only when there
This is an automated email from the ASF dual-hosted git repository.
turbaszek pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from e9ecf0a Improve test for the next_execution cli command (#9058)
add 3435e6e Improve SchedulerJob code
turbaszek merged pull request #9018:
URL: https://github.com/apache/airflow/pull/9018
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mik-laj commented on pull request #9068:
URL: https://github.com/apache/airflow/pull/9068#issuecomment-636344030
I agree too, but I wanted to share my concerns about deleting the code.
Even if a lot of people don't use it directly, the indirect profit is big in
this case. We should move
BasPH opened a new pull request #9073:
URL: https://github.com/apache/airflow/pull/9073
This PR removes files from pylint_todo.txt which don't exist anymore.
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
mik-laj commented on a change in pull request #9072:
URL: https://github.com/apache/airflow/pull/9072#discussion_r432857367
##
File path: airflow/cli/cli_parser.py
##
@@ -182,6 +182,13 @@ def add_to_parser(self, parser: argparse.ArgumentParser):
("--limit",),
mik-laj commented on a change in pull request #9072:
URL: https://github.com/apache/airflow/pull/9072#discussion_r432854903
##
File path: tests/cli/commands/test_dag_command.py
##
@@ -249,36 +248,41 @@ def test_next_execution(self):
dr =
mik-laj commented on a change in pull request #9072:
URL: https://github.com/apache/airflow/pull/9072#discussion_r432854430
##
File path: airflow/cli/commands/dag_command.py
##
@@ -277,15 +277,24 @@ def dag_next_execution(args):
if dag.get_is_paused():
BasPH commented on pull request #9068:
URL: https://github.com/apache/airflow/pull/9068#issuecomment-636342046
Agree with @potiuk - I'd even be fine with just examples of how to implement
and use your own macros in the docs and removing the code from `/airflow`.
Let's try to keep the
potiuk commented on a change in pull request #8942:
URL: https://github.com/apache/airflow/pull/8942#discussion_r432845070
##
File path: airflow/operators/sql_branch_operator.py
##
@@ -0,0 +1,174 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
potiuk commented on a change in pull request #8868:
URL: https://github.com/apache/airflow/pull/8868#discussion_r432844561
##
File path: tests/providers/google/cloud/operators/test_bigquery.py
##
@@ -788,3 +789,65 @@ def test_execute(self, mock_hook):
turbaszek edited a comment on pull request #8805:
URL: https://github.com/apache/airflow/pull/8805#issuecomment-636334773
I did a simple test:
```python
from datetime import datetime
from airflow import DAG
from airflow.operators.dummy_operator import DummyOperator
from
turbaszek edited a comment on pull request #8805:
URL: https://github.com/apache/airflow/pull/8805#issuecomment-636334773
I did a simple test:
```python
from datetime import datetime
from airflow import DAG
from airflow.operators.dummy_operator import DummyOperator
from
turbaszek edited a comment on pull request #8805:
URL: https://github.com/apache/airflow/pull/8805#issuecomment-636334773
I did a simple test:
```python
from datetime import datetime
from airflow import DAG
from airflow.operators.dummy_operator import DummyOperator
from
turbaszek edited a comment on pull request #8805:
URL: https://github.com/apache/airflow/pull/8805#issuecomment-636334773
I did a simple test:
```python
from datetime import datetime
from airflow import DAG
from airflow.operators.dummy_operator import DummyOperator
from
turbaszek commented on pull request #8805:
URL: https://github.com/apache/airflow/pull/8805#issuecomment-636334773
I did some simple test:
```python
from datetime import datetime
from airflow import DAG
from airflow.operators.dummy_operator import DummyOperator
from
turbaszek edited a comment on pull request #8805:
URL: https://github.com/apache/airflow/pull/8805#issuecomment-636329264
> we could let it work when setting _any_ attribute to an XComArg, which
would be nice
That would mean that if we set 20 attributes in `__init__` then we run
turbaszek commented on pull request #8868:
URL: https://github.com/apache/airflow/pull/8868#issuecomment-636329897
@potiuk @mik-laj @olchas would you mind taking a look?
This is an automated message from the Apache Git
turbaszek edited a comment on pull request #8805:
URL: https://github.com/apache/airflow/pull/8805#issuecomment-636329264
> we could let it work when setting _any_ attribute to an XComArg, which
would be nice
That would mean that if we set 20 attributes in `__init__` then we run
turbaszek commented on pull request #8805:
URL: https://github.com/apache/airflow/pull/8805#issuecomment-636329264
> we could let it work when setting _any_ attribute to an XComArg, which
would be nice
That would mean that if we set 20 attributes in `__init__` then we run
ashb commented on pull request #8805:
URL: https://github.com/apache/airflow/pull/8805#issuecomment-636328816
No comment on performance or not, but an observation: we don't need to check
for just template fields if we are doing that - we could let it work when
setting _any_ attribute to
turbaszek edited a comment on pull request #8805:
URL: https://github.com/apache/airflow/pull/8805#issuecomment-636327497
@ashb I forgot what was the problem with metaclass:
```python
with DAG(dag_id='xcomargs_test', default_args={"start_date":
datetime.today()}):
turbaszek commented on pull request #8805:
URL: https://github.com/apache/airflow/pull/8805#issuecomment-636327497
@ashb I forgot what was the problem with metaclass:
```python
with DAG(dag_id='xcomargs_test', default_args={"start_date":
datetime.today()}):
turbaszek removed a comment on pull request #8805:
URL: https://github.com/apache/airflow/pull/8805#issuecomment-636327033
> > Could we use the **exit** from the dag to fix this one case (but there
are others that wouldn't be caught by that.
>
> Exactly
>
> > Given how rare
turbaszek closed pull request #8805:
URL: https://github.com/apache/airflow/pull/8805
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
turbaszek commented on pull request #8805:
URL: https://github.com/apache/airflow/pull/8805#issuecomment-636327033
> > Could we use the **exit** from the dag to fix this one case (but there
are others that wouldn't be caught by that.
>
> Exactly
>
> > Given how rare
ephraimbuddy commented on pull request #9070:
URL: https://github.com/apache/airflow/pull/9070#issuecomment-636326235
How about the --subdir argument? Should I work on it?
This is an automated message from the Apache Git
mik-laj commented on pull request #9070:
URL: https://github.com/apache/airflow/pull/9070#issuecomment-636325975
This change only one file. I doubt that this change could drastically
increase its size. On the other hand, it will allow us to standardize texts.
One big PR will facilitate
mik-laj commented on pull request #9068:
URL: https://github.com/apache/airflow/pull/9068#issuecomment-636325182
@BasPH These macros are part of public API.
https://airflow.readthedocs.io/en/latest/macros-ref.html
There are no references to these methods in the code, but users can use
potiuk commented on issue #8933:
URL: https://github.com/apache/airflow/issues/8933#issuecomment-636322845
> Wait, pyhive has an extra called hive?
>
> That would be amazing, yes, but would make our test suite take days to run
to completion.
>
> Still, might be something
turbaszek commented on pull request #8805:
URL: https://github.com/apache/airflow/pull/8805#issuecomment-636322533
> Could we use the __exit__ from the dag to fix this one case (but there are
others that wouldn't be caught by that.
Exactly
> Given how rare metaprogramming is
mdediana opened a new pull request #9072:
URL: https://github.com/apache/airflow/pull/9072
Add `--num-executions` option to the `dags next_execution` sub-command. If
the option is not present it defaults to 1, which is the command's current
behavior. This option is particularly useful
jkoscialkowski commented on issue #9071:
URL: https://github.com/apache/airflow/issues/9071#issuecomment-636321475
Have you tried using different MySQL adapters (e.g. `mysqlclient`) as
suggested in the edits to my SO question you linked? I know it is not a full
solution, but I was able to
potiuk commented on pull request #9070:
URL: https://github.com/apache/airflow/pull/9070#issuecomment-636321374
Agree in general @mik-laj But should not we do it in separate PRs to avoid
one BIG PR with many many changes ?
potiuk commented on pull request #9068:
URL: https://github.com/apache/airflow/pull/9068#issuecomment-636321195
@BasPH -> agree with user defined macros approach. I think it should be
enough indeed.
This is an automated
BasPH commented on pull request #9068:
URL: https://github.com/apache/airflow/pull/9068#issuecomment-636320359
Remove _and deprecate_, that's what I meant :-)
My 2c on the macros: I understand they can be useful, but have the same
feeling about them as "helpers" and "utils" (i.e. a
[
https://issues.apache.org/jira/browse/AIRFLOW-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120228#comment-17120228
]
ASF GitHub Bot commented on AIRFLOW-4355:
-
turbaszek commented on pull request #8082:
URL:
turbaszek commented on pull request #8082:
URL: https://github.com/apache/airflow/pull/8082#issuecomment-636319661
@tooptoop4 can you please rebase?
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/AIRFLOW-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120226#comment-17120226
]
ASF GitHub Bot commented on AIRFLOW-2644:
-
stale[bot] commented on pull request #8098:
URL:
1 - 100 of 124 matches
Mail list logo
