[GitHub] [airflow-site] ad-m opened a new issue #270: Versio dropdown does not include master

2020-07-06 Thread GitBox
ad-m opened a new issue #270: URL: https://github.com/apache/airflow-site/issues/270 Hello, I suggest add to dropdown of version link to master version ( https://airflow.readthedocs.io/en/latest/ ) of documentation:

[GitHub] [airflow] tanjinP commented on a change in pull request #9079: WIP: [8970] Improve KubernetesPodOperator guide

2020-07-06 Thread GitBox
tanjinP commented on a change in pull request #9079: URL: https://github.com/apache/airflow/pull/9079#discussion_r450571991 ## File path: docs/howto/operator/kubernetes.rst ## @@ -25,180 +25,90 @@ KubernetesPodOperator The

[GitHub] [airflow] boring-cyborg[bot] commented on issue #9703: Schedule Interval Last Thursday of every month

2020-07-06 Thread GitBox
boring-cyborg[bot] commented on issue #9703: URL: https://github.com/apache/airflow/issues/9703#issuecomment-654550260 Thanks for opening your first issue here! Be sure to follow the issue template! This is an automated

[GitHub] [airflow] hlokired opened a new issue #9703: Schedule Interval Last Thursday of every month

2020-07-06 Thread GitBox
hlokired opened a new issue #9703: URL: https://github.com/apache/airflow/issues/9703 Hi Team, We have a requirement that we need to schedule a Airflow Job on last Thursday of every month. So basically we might have 4 or 5 Thursdays depends on the month. how can it be

[GitHub] [airflow] chipmyersjr opened a new pull request #9702: Add unit tests for mlengine_operator_utils

2020-07-06 Thread GitBox
chipmyersjr opened a new pull request #9702: URL: https://github.com/apache/airflow/pull/9702 Add unit test for mlengine_operator_utils.py. Mentioned as missing unit test in issue #8278 --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above

[jira] [Commented] (AIRFLOW-4484) CeleryExecutor#sync timesout when fetching celery task state

2020-07-06 Thread Sandish Kumar HN (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152372#comment-17152372 ] Sandish Kumar HN commented on AIRFLOW-4484: --- Hi Everyone, We are facing the same issue. here

[GitHub] [airflow] manesioz commented on pull request #9698: feat: CloudVisionDeleteReferenceImageOperator

2020-07-06 Thread GitBox
manesioz commented on pull request #9698: URL: https://github.com/apache/airflow/pull/9698#issuecomment-654505904 @mik-laj Yep! Good catch, done. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] mik-laj commented on issue #9700: _mysql_exceptions.OperationalError: (1071, 'Specified key was too long; max key length is 767 bytes')

2020-07-06 Thread GitBox
mik-laj commented on issue #9700: URL: https://github.com/apache/airflow/issues/9700#issuecomment-654503157 Here is fix: https://github.com/apache/airflow/pull/7570 This is an automated message from the Apache Git Service.

[GitHub] [airflow] mik-laj commented on pull request #9651: Documentation for Google Cloud Data Loss Prevention

2020-07-06 Thread GitBox
mik-laj commented on pull request #9651: URL: https://github.com/apache/airflow/pull/9651#issuecomment-654496647 @OmairK Example tasks for the rest operators will be helpful. This is an automated message from the Apache Git

[GitHub] [airflow] mik-laj commented on issue #8111: Authentication in API

2020-07-06 Thread GitBox
mik-laj commented on issue #8111: URL: https://github.com/apache/airflow/issues/8111#issuecomment-654495870 Yes. We can discuss it here. If we want to have more opinions, we can ask on the mailing list later. For non-key design discussions, Github is a good place. If you prefer, you can

[GitHub] [airflow] OmairK commented on pull request #9651: Documentation for Google Cloud Data Loss Prevention

2020-07-06 Thread GitBox
OmairK commented on pull request #9651: URL: https://github.com/apache/airflow/pull/9651#issuecomment-654495526 > I have the impression that there are more DLP operators but they are not covered in the example DAG. I think we should add the documentation. I'm ok with not extending the DAG

[GitHub] [airflow] jhtimmins commented on issue #8111: Authentication in API

2020-07-06 Thread GitBox
jhtimmins commented on issue #8111: URL: https://github.com/apache/airflow/issues/8111#issuecomment-654493759 Gotcha, thanks. Is this issue the best place to discuss the design? Thinking I can design interface and 1-2 implementations.

[GitHub] [airflow] mik-laj commented on a change in pull request #9549: YAML file supports extra json parameters

2020-07-06 Thread GitBox
mik-laj commented on a change in pull request #9549: URL: https://github.com/apache/airflow/pull/9549#discussion_r450508757 ## File path: docs/howto/use-alternative-secrets-backend.rst ## @@ -118,9 +123,6 @@ The following is a sample JSON file. The YAML file structure is

[GitHub] [airflow] mik-laj commented on a change in pull request #9549: YAML file supports extra json parameters

2020-07-06 Thread GitBox
mik-laj commented on a change in pull request #9549: URL: https://github.com/apache/airflow/pull/9549#discussion_r450508575 ## File path: docs/howto/use-alternative-secrets-backend.rst ## @@ -92,10 +95,12 @@ file ``/files/my_conn.json`` when it looks for connections. The

[GitHub] [airflow] mik-laj commented on a change in pull request #9549: YAML file supports extra json parameters

2020-07-06 Thread GitBox
mik-laj commented on a change in pull request #9549: URL: https://github.com/apache/airflow/pull/9549#discussion_r450508103 ## File path: docs/howto/use-alternative-secrets-backend.rst ## @@ -92,10 +95,12 @@ file ``/files/my_conn.json`` when it looks for connections. The

[GitHub] [airflow] mik-laj commented on a change in pull request #9549: YAML file supports extra json parameters

2020-07-06 Thread GitBox
mik-laj commented on a change in pull request #9549: URL: https://github.com/apache/airflow/pull/9549#discussion_r450508103 ## File path: docs/howto/use-alternative-secrets-backend.rst ## @@ -92,10 +95,12 @@ file ``/files/my_conn.json`` when it looks for connections. The

[GitHub] [airflow] mik-laj commented on a change in pull request #9549: YAML file supports extra json parameters

2020-07-06 Thread GitBox
mik-laj commented on a change in pull request #9549: URL: https://github.com/apache/airflow/pull/9549#discussion_r450508103 ## File path: docs/howto/use-alternative-secrets-backend.rst ## @@ -92,10 +95,12 @@ file ``/files/my_conn.json`` when it looks for connections. The

[GitHub] [airflow] OmairK commented on pull request #9277: Health endpoint spec and implementation

2020-07-06 Thread GitBox
OmairK commented on pull request #9277: URL: https://github.com/apache/airflow/pull/9277#issuecomment-654492386 > Hiello. > We have updated FAB to v3, so we use marshmallow v3. Can you rebase on the latest master? > Thanks! Rebased and pushed :grinning:

[GitHub] [airflow] mik-laj commented on a change in pull request #9549: YAML file supports extra json parameters

2020-07-06 Thread GitBox
mik-laj commented on a change in pull request #9549: URL: https://github.com/apache/airflow/pull/9549#discussion_r450507440 ## File path: docs/howto/use-alternative-secrets-backend.rst ## @@ -68,6 +68,9 @@ This backend is especially useful in the following use cases: To use

[GitHub] [airflow] mik-laj commented on pull request #9473: Add Dag Runs CRUD endpoints

2020-07-06 Thread GitBox
mik-laj commented on pull request #9473: URL: https://github.com/apache/airflow/pull/9473#issuecomment-654487881 爛 I am waiting for CI results. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] mik-laj commented on pull request #9698: feat: CloudVisionDeleteReferenceImageOperator

2020-07-06 Thread GitBox
mik-laj commented on pull request #9698: URL: https://github.com/apache/airflow/pull/9698#issuecomment-654487591 Can you also update docs here? https://github.com/apache/airflow/blob/1d36b0303b8632fce6de78ca4e782ae26ee06fea/airflow/providers/google/cloud/hooks/vision.py#L428

[GitHub] [airflow] OmairK commented on pull request #9473: Add Dag Runs CRUD endpoints

2020-07-06 Thread GitBox
OmairK commented on pull request #9473: URL: https://github.com/apache/airflow/pull/9473#issuecomment-654487056 > Hiello. > We have updated FAB to v3, so we use marshmallow v3. Can you rebase on the latest master? > Thanks! Done :smile:

[GitHub] [airflow] mik-laj commented on issue #8111: Authentication in API

2020-07-06 Thread GitBox
mik-laj commented on issue #8111: URL: https://github.com/apache/airflow/issues/8111#issuecomment-654487020 @jhtimmins Authorization core, i.e. one authorization mechanism (e.g. via HTTP headers) and the ability to choose others using the configuration options.

[GitHub] [airflow] mik-laj edited a comment on issue #8111: Authentication in API

2020-07-06 Thread GitBox
mik-laj edited a comment on issue #8111: URL: https://github.com/apache/airflow/issues/8111#issuecomment-609051162 I think we can add a simple decorator that will call functions before handling requests. This function will be responsible for checking the credentials and setting the user

[GitHub] [airflow] jhtimmins commented on issue #8111: Authentication in API

2020-07-06 Thread GitBox
jhtimmins commented on issue #8111: URL: https://github.com/apache/airflow/issues/8111#issuecomment-654485175 @mik-laj Cool. Do you mean the core of authentication or the core of the API? This is an automated message from

[GitHub] [airflow] mik-laj commented on issue #8111: Authentication in API

2020-07-06 Thread GitBox
mik-laj commented on issue #8111: URL: https://github.com/apache/airflow/issues/8111#issuecomment-654484623 @jhtimmins I wanted to start working on the core today or Wednesday. However, if you have time, you can start working.

[GitHub] [airflow] jhtimmins commented on issue #8111: Authentication in API

2020-07-06 Thread GitBox
jhtimmins commented on issue #8111: URL: https://github.com/apache/airflow/issues/8111#issuecomment-654479575 @mik-laj I'm interested in taking over this task. Is the API at a stage where this would be helpful? This is an

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9701: Update Thumbtack points of contact for Airflow

2020-07-06 Thread GitBox
boring-cyborg[bot] commented on pull request #9701: URL: https://github.com/apache/airflow/pull/9701#issuecomment-654454430 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] dwjoss opened a new pull request #9701: Update Thumbtack points of contact for Airflow

2020-07-06 Thread GitBox
dwjoss opened a new pull request #9701: URL: https://github.com/apache/airflow/pull/9701 The previously-listed person is no longer at the company --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x]

[GitHub] [airflow] madison-ookla commented on issue #9655: Task failed because of Command exited with return code -9 due to RAM

2020-07-06 Thread GitBox
madison-ookla commented on issue #9655: URL: https://github.com/apache/airflow/issues/9655#issuecomment-654449416 From what we have seen, a -9 code indicates that it is an OOM issue. We have not seen a -9 occur in any other circumstances. It seems like for python, a -9 indicates a memory

[GitHub] [airflow] ephraimbuddy commented on pull request #9586: support new released version of sendgrid

2020-07-06 Thread GitBox
ephraimbuddy commented on pull request #9586: URL: https://github.com/apache/airflow/pull/9586#issuecomment-654443547 Can I close this? It seems not needed anymore because I didn't experience any related issue when I generated requirements recently.

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #9503: add date-time format validation for API spec

2020-07-06 Thread GitBox
ephraimbuddy commented on a change in pull request #9503: URL: https://github.com/apache/airflow/pull/9503#discussion_r450454551 ## File path: airflow/api_connexion/endpoints/dag_run_endpoint.py ## @@ -69,24 +61,24 @@ def get_dag_runs(session, dag_id, start_date_gte=None,

[GitHub] [airflow] ephraimbuddy closed pull request #9503: add date-time format validation for API spec

2020-07-06 Thread GitBox
ephraimbuddy closed pull request #9503: URL: https://github.com/apache/airflow/pull/9503 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (AIRFLOW-5266) AWS Athena Hook only returns first 1000 results

2020-07-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152279#comment-17152279 ] ASF GitHub Bot commented on AIRFLOW-5266: - lindsable commented on pull request #6075: URL:

[GitHub] [airflow] lindsable commented on pull request #6075: [AIRFLOW-5266] Allow aws_athena_hook to get all query results

2020-07-06 Thread GitBox
lindsable commented on pull request #6075: URL: https://github.com/apache/airflow/pull/6075#issuecomment-654433853 @ashb I'm sure things have been busy for you organizing the summit, but I'd really like to get this merged. Please let me know what I can do.

[airflow] branch master updated: Some Pylint fixes in airflow/models/taskinstance.py (#9674)

2020-07-06 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 631ac48 Some Pylint fixes in

[GitHub] [airflow] kaxil merged pull request #9674: Some Pylint fixes in airflow/models/taskinstance.py

2020-07-06 Thread GitBox
kaxil merged pull request #9674: URL: https://github.com/apache/airflow/pull/9674 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] mik-laj commented on a change in pull request #9503: add date-time format validation for API spec

2020-07-06 Thread GitBox
mik-laj commented on a change in pull request #9503: URL: https://github.com/apache/airflow/pull/9503#discussion_r450417748 ## File path: airflow/api_connexion/endpoints/dag_run_endpoint.py ## @@ -69,24 +61,24 @@ def get_dag_runs(session, dag_id, start_date_gte=None,

[GitHub] [airflow] mik-laj commented on a change in pull request #9503: add date-time format validation for API spec

2020-07-06 Thread GitBox
mik-laj commented on a change in pull request #9503: URL: https://github.com/apache/airflow/pull/9503#discussion_r450417748 ## File path: airflow/api_connexion/endpoints/dag_run_endpoint.py ## @@ -69,24 +61,24 @@ def get_dag_runs(session, dag_id, start_date_gte=None,

[jira] [Commented] (AIRFLOW-2143) Try number displays incorrect values in the web UI

2020-07-06 Thread Jake Puffer (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-2143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152260#comment-17152260 ] Jake Puffer commented on AIRFLOW-2143: -- I'm getting this exact behavior in Airflow 1.10.10, but in

[GitHub] [airflow] royberkoweee commented on pull request #9667: Allow `replace` flag in gcs_to_gcs operator.

2020-07-06 Thread GitBox
royberkoweee commented on pull request #9667: URL: https://github.com/apache/airflow/pull/9667#issuecomment-654415566 Hey, is the reason for these failures related to master? This is an automated message from the Apache Git

[GitHub] [airflow] potiuk edited a comment on issue #9324: How to create a role that can browse DAGs but not pause/unpause them?

2020-07-06 Thread GitBox
potiuk edited a comment on issue #9324: URL: https://github.com/apache/airflow/issues/9324#issuecomment-654410261 Heloy yes. The general issues and questions are not handled via the Github issue. It is actually stated when you try to open such issue. Apologise if it was not clear. I

[GitHub] [airflow] potiuk commented on issue #9324: How to create a role that can browse DAGs but not pause/unpause them?

2020-07-06 Thread GitBox
potiuk commented on issue #9324: URL: https://github.com/apache/airflow/issues/9324#issuecomment-654410261 Heloy yes. The general issues and questions are not handled via the Github issue. It is actually stated when you try to open such issue. Apologise if it was not clear. I closed a

[GitHub] [airflow] KayleMaster commented on issue #9324: How to create a role that can browse DAGs but not pause/unpause them?

2020-07-06 Thread GitBox
KayleMaster commented on issue #9324: URL: https://github.com/apache/airflow/issues/9324#issuecomment-654408684 Care to elaborate why this issue is closed? I can't find any help on the slack channel This is an automated

[GitHub] [airflow] mik-laj commented on a change in pull request #9503: add date-time format validation for API spec

2020-07-06 Thread GitBox
mik-laj commented on a change in pull request #9503: URL: https://github.com/apache/airflow/pull/9503#discussion_r450417748 ## File path: airflow/api_connexion/endpoints/dag_run_endpoint.py ## @@ -69,24 +61,24 @@ def get_dag_runs(session, dag_id, start_date_gte=None,

[GitHub] [airflow] potiuk commented on pull request #9648: Update FlaskAppBuilder to v3

2020-07-06 Thread GitBox
potiuk commented on pull request #9648: URL: https://github.com/apache/airflow/pull/9648#issuecomment-654406616 Fantastic! This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] mik-laj commented on pull request #9473: Add Dag Runs CRUD endpoints

2020-07-06 Thread GitBox
mik-laj commented on pull request #9473: URL: https://github.com/apache/airflow/pull/9473#issuecomment-654406329 Hiello. We have updated FAB to v3, so we use marshmallow v3. Can you rebase on the latest master? Thanks!

[GitHub] [airflow] mik-laj commented on pull request #9322: DAG Source endpoint

2020-07-06 Thread GitBox
mik-laj commented on pull request #9322: URL: https://github.com/apache/airflow/pull/9322#issuecomment-654406266 Hiello. We have updated FAB to v3, so we use marshmallow v3. Can you rebase on the latest master? Thanks!

[GitHub] [airflow] mik-laj commented on pull request #9277: Health endpoint spec and implementation

2020-07-06 Thread GitBox
mik-laj commented on pull request #9277: URL: https://github.com/apache/airflow/pull/9277#issuecomment-654406104 Hiello. We have updated FAB to v3, so we use marshmallow v3. Can you rebase on the latest master? Thanks!

[airflow] branch master updated: Update FlaskAppBuilder to v3 (#9648)

2020-07-06 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new e764ea5 Update FlaskAppBuilder to v3

[GitHub] [airflow] mik-laj merged pull request #9648: Update FlaskAppBuilder to v3

2020-07-06 Thread GitBox
mik-laj merged pull request #9648: URL: https://github.com/apache/airflow/pull/9648 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[airflow] branch master updated: Tests should also be triggered when there is just setup.py change (#9690)

2020-07-06 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 72abf82 Tests should also be triggered when

[GitHub] [airflow] potiuk merged pull request #9690: Tests should also be triggered when there is just setup.py change

2020-07-06 Thread GitBox
potiuk merged pull request #9690: URL: https://github.com/apache/airflow/pull/9690 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] mik-laj commented on pull request #9295: added mssql to oracle transfer operator

2020-07-06 Thread GitBox
mik-laj commented on pull request #9295: URL: https://github.com/apache/airflow/pull/9295#issuecomment-654400905 You need to add this package to index: https://github.com/apache/airflow/blob/master/docs/autoapi_templates/index.rst

[GitHub] [airflow] jkbngl commented on pull request #9295: added mssql to oracle transfer operator

2020-07-06 Thread GitBox
jkbngl commented on pull request #9295: URL: https://github.com/apache/airflow/pull/9295#issuecomment-654397085 Hi @mik-laj this actually helped a lot clarified a lot of things for me! Thank you very much! So what I understood is that transfer operators should go into the

[GitHub] [airflow] prasanthbangs2016 opened a new issue #9700: _mysql_exceptions.OperationalError: (1071, 'Specified key was too long; max key length is 767 bytes')

2020-07-06 Thread GitBox
prasanthbangs2016 opened a new issue #9700: URL: https://github.com/apache/airflow/issues/9700 PS C:\Users\prasanth\Desktop\p> docker logs -f 5b560ac952ff [2020-07-06 18:24:00,905] {{settings.py:253}} INFO - settings.configure_orm(): Using pool settings. pool_size=5, max_overflow=10,

[GitHub] [airflow] boring-cyborg[bot] commented on issue #9700: _mysql_exceptions.OperationalError: (1071, 'Specified key was too long; max key length is 767 bytes')

2020-07-06 Thread GitBox
boring-cyborg[bot] commented on issue #9700: URL: https://github.com/apache/airflow/issues/9700#issuecomment-654395483 Thanks for opening your first issue here! Be sure to follow the issue template! This is an automated

[GitHub] [airflow] mik-laj edited a comment on issue #8280: Missing example DAGs/system tests for Google services

2020-07-06 Thread GitBox
mik-laj edited a comment on issue #8280: URL: https://github.com/apache/airflow/issues/8280#issuecomment-654394285 @irvifa Some examples are still missing. I updated the first post. https://github.com/apache/airflow/blob/master/tests/test_project_structure.py#L125

[GitHub] [airflow] mik-laj commented on issue #8280: Missing example DAGs/system tests for Google services

2020-07-06 Thread GitBox
mik-laj commented on issue #8280: URL: https://github.com/apache/airflow/issues/8280#issuecomment-654394285 @irvifa Some examples are still missing https://github.com/apache/airflow/blob/master/tests/test_project_structure.py#L125

[GitHub] [airflow] irvifa commented on issue #8280: Missing example DAGs/system tests for Google services

2020-07-06 Thread GitBox
irvifa commented on issue #8280: URL: https://github.com/apache/airflow/issues/8280#issuecomment-654384993 I saw there's many PR that have been merged. Is this issue already closed then? This is an automated message from

[GitHub] [airflow] potiuk commented on pull request #9667: Allow `replace` flag in gcs_to_gcs operator.

2020-07-06 Thread GitBox
potiuk commented on pull request #9667: URL: https://github.com/apache/airflow/pull/9667#issuecomment-654377704 Not sure. I think it could be some Github Actions hiccup This is an automated message from the Apache Git

[GitHub] [airflow] madison-ookla commented on pull request #9671: Change Log to DEBUG level for SQL Statement in DBApiHook

2020-07-06 Thread GitBox
madison-ookla commented on pull request #9671: URL: https://github.com/apache/airflow/pull/9671#issuecomment-654346744 I agree with @mik-laj on this one, we have one instance where we have 4 dynamic dags that generate hundreds of DAGs with quite varied templated SQL. Viewing these queries

[GitHub] [airflow] dossett commented on a change in pull request #9593: Improve handling Dataproc cluster creation with ERROR state

2020-07-06 Thread GitBox
dossett commented on a change in pull request #9593: URL: https://github.com/apache/airflow/pull/9593#discussion_r450344785 ## File path: airflow/providers/google/cloud/operators/dataproc.py ## @@ -502,32 +506,79 @@ def __init__(self, self.timeout = timeout

[GitHub] [airflow] mik-laj commented on pull request #9618: Fix typos, older versions, and deprecated operators with AI platform example DAG

2020-07-06 Thread GitBox
mik-laj commented on pull request #9618: URL: https://github.com/apache/airflow/pull/9618#issuecomment-654341478 I sent DM to you. ;-) This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] royberkoweee commented on pull request #9667: Allow `replace` flag in gcs_to_gcs operator.

2020-07-06 Thread GitBox
royberkoweee commented on pull request #9667: URL: https://github.com/apache/airflow/pull/9667#issuecomment-654338741 Any reason for some checks being cancelled? This is an automated message from the Apache Git Service. To

[GitHub] [airflow] vuppalli commented on pull request #9618: Fix typos, older versions, and deprecated operators with AI platform example DAG

2020-07-06 Thread GitBox
vuppalli commented on pull request #9618: URL: https://github.com/apache/airflow/pull/9618#issuecomment-654336203 @mik-laj Yes, thank you! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] zikun opened a new pull request #9699: TimeSensor should consider the default_timezone config

2020-07-06 Thread GitBox
zikun opened a new pull request #9699: URL: https://github.com/apache/airflow/pull/9699 Fixes #9609 --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x] Unit tests coverage for changes (not needed for

[GitHub] [airflow] mik-laj commented on pull request #9618: Fix typos, older versions, and deprecated operators with AI platform example DAG

2020-07-06 Thread GitBox
mik-laj commented on pull request #9618: URL: https://github.com/apache/airflow/pull/9618#issuecomment-654334040 @vuppalli Are you available on our official Airflow Slack channel? https://apache-airflow-slack.herokuapp.com/ If you plan to contribute more to Airflow, we can coordinate my

[GitHub] [airflow] potiuk commented on issue #9558: Missing operator - CloudVisionReferenceImageCreateOperator

2020-07-06 Thread GitBox
potiuk commented on issue #9558: URL: https://github.com/apache/airflow/issues/9558#issuecomment-654334121 Go for it @manesioz ! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] zikun commented on issue #9609: TimeSensor triggers immediately when used over midnight (UTC)

2020-07-06 Thread GitBox
zikun commented on issue #9609: URL: https://github.com/apache/airflow/issues/9609#issuecomment-654331653 I just realize your case is a little different. You must have set `default_timezone` in the Airflow config. I think we should fix it in `TimeSensor` itself. I'll make a quick PR

[GitHub] [airflow] zhongjiajie commented on pull request #8231: Dag bulk_sync_to_db dag_tag only remove not exists

2020-07-06 Thread GitBox
zhongjiajie commented on pull request #8231: URL: https://github.com/apache/airflow/pull/8231#issuecomment-654326927 I think this patch could be accept. In L1529, we delete all tag in dag and in L1532 we create all new tag object and add all of them to `dag_tag` table. And this patch just

[GitHub] [airflow] manesioz opened a new pull request #9698: feat: CloudVisionDeleteReferenceImageOperator

2020-07-06 Thread GitBox
manesioz opened a new pull request #9698: URL: https://github.com/apache/airflow/pull/9698 Fixes #9558 --- Make sure to mark the boxes below before creating PR: [x] - [ ] Description above provides context of the change - [ ] Unit tests coverage for changes (not needed

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9698: feat: CloudVisionDeleteReferenceImageOperator

2020-07-06 Thread GitBox
boring-cyborg[bot] commented on pull request #9698: URL: https://github.com/apache/airflow/pull/9698#issuecomment-654326453 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] turbaszek commented on a change in pull request #9631: Add function to get current context

2020-07-06 Thread GitBox
turbaszek commented on a change in pull request #9631: URL: https://github.com/apache/airflow/pull/9631#discussion_r450318520 ## File path: airflow/task/context/current.py ## @@ -0,0 +1,69 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [airflow] casassg commented on a change in pull request #9631: Add function to get current context

2020-07-06 Thread GitBox
casassg commented on a change in pull request #9631: URL: https://github.com/apache/airflow/pull/9631#discussion_r450301293 ## File path: airflow/task/context/current.py ## @@ -0,0 +1,69 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review comment: I

[GitHub] [airflow] vuppalli commented on pull request #9618: Fix typos, older versions, and deprecated operators with AI platform example DAG

2020-07-06 Thread GitBox
vuppalli commented on pull request #9618: URL: https://github.com/apache/airflow/pull/9618#issuecomment-654305242 @mik-laj Thanks so much for your response. I am not sure which files are needed to run the tests so I do not know if they have changed. The only file I have contributed to is

[GitHub] [airflow] aneesh-joseph commented on pull request #9688: use the correct name in the webserver & configmap when using an existing volume claim

2020-07-06 Thread GitBox
aneesh-joseph commented on pull request #9688: URL: https://github.com/apache/airflow/pull/9688#issuecomment-654303406 @potiuk @dimberman - can you have a look at this one as well This is an automated message from the

[GitHub] [airflow] royberkoweee commented on pull request #9667: Allow `replace` flag in gcs_to_gcs operator.

2020-07-06 Thread GitBox
royberkoweee commented on pull request #9667: URL: https://github.com/apache/airflow/pull/9667#issuecomment-654303405 Done. Waiting for CI to run :) This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] zikun opened a new pull request #9697: Add DateTimeSensor

2020-07-06 Thread GitBox
zikun opened a new pull request #9697: URL: https://github.com/apache/airflow/pull/9697 Closes #9609 This handles some cases for which `TimeSensor` is not suited. For example, if a DAG is scheduled to run at 23:00 daily, but one of the tasks is required to run at 01:00 next day:

[GitHub] [airflow] manesioz commented on issue #9558: Missing operator - CloudVisionReferenceImageCreateOperator

2020-07-06 Thread GitBox
manesioz commented on issue #9558: URL: https://github.com/apache/airflow/issues/9558#issuecomment-654301476 I'd like to take a stab at it if no one else is working on it. This is an automated message from the Apache Git

[GitHub] [airflow] turbaszek commented on pull request #9631: Add function to get current context

2020-07-06 Thread GitBox
turbaszek commented on pull request #9631: URL: https://github.com/apache/airflow/pull/9631#issuecomment-654300299 @casassg @jonathanshir happy to get your reviews  This is an automated message from the Apache Git Service.

[GitHub] [airflow] turbaszek commented on pull request #8651: [AIRFLOW-8058] Add configurable execution context

2020-07-06 Thread GitBox
turbaszek commented on pull request #8651: URL: https://github.com/apache/airflow/pull/8651#issuecomment-654299368 Depends on #9631 This is an automated message from the Apache Git Service. To respond to the message, please

[airflow] branch v1-10-stable updated: re-adds airflow_local_settings.py mount

2020-07-06 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a commit to branch v1-10-stable in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/v1-10-stable by this push: new f55906c re-adds

[GitHub] [airflow] turbaszek commented on a change in pull request #9692: Fix _process_executor_events method to use in-memory try_number

2020-07-06 Thread GitBox
turbaszek commented on a change in pull request #9692: URL: https://github.com/apache/airflow/pull/9692#discussion_r450279545 ## File path: airflow/jobs/scheduler_job.py ## @@ -1486,13 +1486,16 @@ def _process_executor_events(self, simple_dag_bag, session=None): """

[GitHub] [airflow] mik-laj commented on a change in pull request #9692: Fix _process_executor_events method to use in-memory try_number

2020-07-06 Thread GitBox
mik-laj commented on a change in pull request #9692: URL: https://github.com/apache/airflow/pull/9692#discussion_r450275776 ## File path: airflow/jobs/scheduler_job.py ## @@ -1486,13 +1486,16 @@ def _process_executor_events(self, simple_dag_bag, session=None): """

[GitHub] [airflow] mik-laj commented on a change in pull request #9692: Fix _process_executor_events method to use in-memory try_number

2020-07-06 Thread GitBox
mik-laj commented on a change in pull request #9692: URL: https://github.com/apache/airflow/pull/9692#discussion_r450275776 ## File path: airflow/jobs/scheduler_job.py ## @@ -1486,13 +1486,16 @@ def _process_executor_events(self, simple_dag_bag, session=None): """

[GitHub] [airflow] turbaszek commented on issue #9689: Exception when executing execute_helper

2020-07-06 Thread GitBox
turbaszek commented on issue #9689: URL: https://github.com/apache/airflow/issues/9689#issuecomment-654284689 > How come we do not catch it with the tests :) I would say: mocking. There's `test_process_executor_events` test but there the in-memory and db state are the same

[GitHub] [airflow] kaxil edited a comment on pull request #9691: Print executor name on scheduler startup

2020-07-06 Thread GitBox
kaxil edited a comment on pull request #9691: URL: https://github.com/apache/airflow/pull/9691#issuecomment-654279700 We do get it now too on Airflow 1.10.10: ``` ❯ airflow scheduler _ |__( )_ __/__ / __

[GitHub] [airflow] kaxil edited a comment on pull request #9691: Print executor name on scheduler startup

2020-07-06 Thread GitBox
kaxil edited a comment on pull request #9691: URL: https://github.com/apache/airflow/pull/9691#issuecomment-654279700 We do get it now too on Airflow 1.10.10: ``` ❯ airflow scheduler _ |__( )_ __/__ / __

[GitHub] [airflow] kaxil commented on pull request #9691: Print executor name on scheduler startup

2020-07-06 Thread GitBox
kaxil commented on pull request #9691: URL: https://github.com/apache/airflow/pull/9691#issuecomment-654279700 We do get it now too: ``` ❯ airflow scheduler _ |__( )_ __/__ / __ /| |_ /__ ___/_ /_

[GitHub] [airflow] mik-laj commented on pull request #9648: Update FlaskAppBuilder to v3

2020-07-06 Thread GitBox
mik-laj commented on pull request #9648: URL: https://github.com/apache/airflow/pull/9648#issuecomment-654278028 It took me some time to check if the Javascript code was working correctly, but everything looks very good. Nice change!

[GitHub] [airflow] mik-laj removed a comment on pull request #9648: Update FlaskAppBuilder to v3

2020-07-06 Thread GitBox
mik-laj removed a comment on pull request #9648: URL: https://github.com/apache/airflow/pull/9648#issuecomment-654278028 It took me some time to check if the Javascript code was working correctly, but everything looks very good. Nice change!

[airflow] branch master updated: Remove XCom CUD endpoints (#9661)

2020-07-06 Thread turbaszek
This is an automated email from the ASF dual-hosted git repository. turbaszek pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 7888145 Remove XCom CUD endpoints (#9661)

[GitHub] [airflow] vuppalli closed pull request #9696: Ml example dag

2020-07-06 Thread GitBox
vuppalli closed pull request #9696: URL: https://github.com/apache/airflow/pull/9696 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] turbaszek merged pull request #9661: Remove XCOM CUD endpoints

2020-07-06 Thread GitBox
turbaszek merged pull request #9661: URL: https://github.com/apache/airflow/pull/9661 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] vuppalli opened a new pull request #9696: Ml example dag

2020-07-06 Thread GitBox
vuppalli opened a new pull request #9696: URL: https://github.com/apache/airflow/pull/9696 Fixed trailing white spaces as per comments on upstream PR. This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (AIRFLOW-3964) Consolidate and de-duplicate sensor tasks

2020-07-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152058#comment-17152058 ] ASF GitHub Bot commented on AIRFLOW-3964: - ryw commented on pull request #5499: URL:

[GitHub] [airflow] ryw commented on pull request #5499: [AIRFLOW-3964][AIP-17] Build smart sensor

2020-07-06 Thread GitBox
ryw commented on pull request #5499: URL: https://github.com/apache/airflow/pull/5499#issuecomment-654271475 @YingboWang is this PR ready to be reviewed/merged? This is an automated message from the Apache Git Service. To

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9695: Adding support for Remote logging to helm chart to be injected into a…

2020-07-06 Thread GitBox
boring-cyborg[bot] commented on pull request #9695: URL: https://github.com/apache/airflow/pull/9695#issuecomment-654263742 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] Datkros opened a new pull request #9695: Adding support for Remote logging to helm chart to be injected into a…

2020-07-06 Thread GitBox
Datkros opened a new pull request #9695: URL: https://github.com/apache/airflow/pull/9695 Added support to inject the remote logging configuration into the `airflow.cfg` configmap. I kept it backwards compatible with the current version of the chart by not dropping the

  1   2   3   >