[GitHub] [airflow-site] LeonY1 opened a new issue #275: The buttons for the Use Cases feel reversed

2020-08-05 Thread GitBox
LeonY1 opened a new issue #275: URL: https://github.com/apache/airflow-site/issues/275 In the Use Cases tab, if you click on one of the companies, it doesn't feel intuitive to press previous to move to the next company to the right and vice versa. This could be my personal opinion,

[GitHub] [airflow] mik-laj commented on issue #10179: Move relevant information from Commiter's guide to CONTRIBUTING.rst

2020-08-05 Thread GitBox
mik-laj commented on issue #10179: URL: https://github.com/apache/airflow/issues/10179#issuecomment-669669041 I think, we should move it to the "dev" part of the Airflow Repo. The CONTRIBUTING.rst file is for new contributors and is already quite long. I don't think we should extend it,

[GitHub] [airflow] mik-laj edited a comment on pull request #10163: Changes to all the constructors to remove the args argument

2020-08-05 Thread GitBox
mik-laj edited a comment on pull request #10163: URL: https://github.com/apache/airflow/pull/10163#issuecomment-669659635 *args cannot follow keyword arguments. This code is invalid and needs to be fixed. ```diff --- a/airflow/providers/qubole/operators/qubole_check.py +++

[GitHub] [airflow] mik-laj commented on pull request #10163: Changes to all the constructors to remove the args argument

2020-08-05 Thread GitBox
mik-laj commented on pull request #10163: URL: https://github.com/apache/airflow/pull/10163#issuecomment-669659635 *args cannot follow keyword arguments. This code is invalid and needs to be fixed. ``` --- a/airflow/providers/qubole/operators/qubole_check.py +++

[GitHub] [airflow] ccecora commented on issue #8665: subdag is not able to correctly render {{ next_ds }} jinja template when start_date uses timezone info.

2020-08-05 Thread GitBox
ccecora commented on issue #8665: URL: https://github.com/apache/airflow/issues/8665#issuecomment-669650362 @RajkotiyaDivyesh did you ever solve this issue? Experiencing the same on my end in airflow 1.10.10. This is an

[GitHub] [airflow] LeonY1 commented on pull request #10163: Changes to all the constructors to remove the args argument

2020-08-05 Thread GitBox
LeonY1 commented on pull request #10163: URL: https://github.com/apache/airflow/pull/10163#issuecomment-669648478 To fix the qubole error, would it be best to directly use the non-deprecated ValueCheckOperator? This is an

[GitHub] [airflow] feng-tao edited a comment on issue #8609: DAG's parameter access_control is not refreshing in the UI

2020-08-05 Thread GitBox
feng-tao edited a comment on issue #8609: URL: https://github.com/apache/airflow/issues/8609#issuecomment-669640525 @jdavidheiser haven't got pinged in Airflow for a while :) If I recall(~ 2 years ago), we first need this commit (https://github.com/apache/airflow/pull/4642/files) to be

[GitHub] [airflow] feng-tao edited a comment on issue #8609: DAG's parameter access_control is not refreshing in the UI

2020-08-05 Thread GitBox
feng-tao edited a comment on issue #8609: URL: https://github.com/apache/airflow/issues/8609#issuecomment-669640525 @jdavidheiser haven't got pinged in Airflow for a while :) If I recall(~ 2 years ago), we first need this commit (https://github.com/apache/airflow/pull/4642/files) to be

[GitHub] [airflow] feng-tao commented on issue #8609: DAG's parameter access_control is not refreshing in the UI

2020-08-05 Thread GitBox
feng-tao commented on issue #8609: URL: https://github.com/apache/airflow/issues/8609#issuecomment-669640525 @jdavidheiser haven't got pinged in Airflow for a while :) If I recall(~ 2 years ago), we first need this commit (https://github.com/apache/airflow/pull/4642/files) to be use

[GitHub] [airflow] jdavidheiser commented on issue #8609: DAG's parameter access_control is not refreshing in the UI

2020-08-05 Thread GitBox
jdavidheiser commented on issue #8609: URL: https://github.com/apache/airflow/issues/8609#issuecomment-669635838 This is still an issue, and at least two more people have run into it (per discussion in Airflow Slack). @feng-tao @astahlman per the comment on

[GitHub] [airflow] j-y-matsubara edited a comment on pull request #8867: Fixed BaseSensorOperator to make respect the trigger_rule in downstream tasks, when setting soft_fail="True"

2020-08-05 Thread GitBox
j-y-matsubara edited a comment on pull request #8867: URL: https://github.com/apache/airflow/pull/8867#issuecomment-669633044 Fixed conflicting! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] j-y-matsubara commented on a change in pull request #8867: Fixed BaseSensorOperator to make respect the trigger_rule in downstream tasks, when setting soft_fail="True"

2020-08-05 Thread GitBox
j-y-matsubara commented on a change in pull request #8867: URL: https://github.com/apache/airflow/pull/8867#discussion_r466097105 ## File path: UPDATING.md ## @@ -62,6 +62,18 @@ More tips can be found in the guide: https://developers.google.com/style/inclusive-documentation

[GitHub] [airflow] j-y-matsubara commented on pull request #8867: Fixed BaseSensorOperator to make respect the trigger_rule in downstream tasks, when setting soft_fail="True"

2020-08-05 Thread GitBox
j-y-matsubara commented on pull request #8867: URL: https://github.com/apache/airflow/pull/8867#issuecomment-669633044 Fix conflicting! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] LeonY1 commented on pull request #10163: Changes to all the constructors to remove the args argument

2020-08-05 Thread GitBox
LeonY1 commented on pull request #10163: URL: https://github.com/apache/airflow/pull/10163#issuecomment-669630525 @mik-laj I fixed the pylint issue This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] zikun commented on pull request #9730: DbApiHook: Support kwargs in get_pandas_df

2020-08-05 Thread GitBox
zikun commented on pull request #9730: URL: https://github.com/apache/airflow/pull/9730#issuecomment-669625368 @potiuk Added to all the overriding methods This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] j-y-matsubara commented on issue #8696: Skip task itself instead of all downstream tasks

2020-08-05 Thread GitBox
j-y-matsubara commented on issue #8696: URL: https://github.com/apache/airflow/issues/8696#issuecomment-669623006 @ccage-simp This PR has not been merged yet. What issues did you encounter? This is an automated

[GitHub] [airflow] houqp commented on a change in pull request #10096: prevent DAG callback exception from crashing scheduler

2020-08-05 Thread GitBox
houqp commented on a change in pull request #10096: URL: https://github.com/apache/airflow/pull/10096#discussion_r466081801 ## File path: airflow/models/dag.py ## @@ -686,7 +689,11 @@ def handle_callback(self, dagrun, success=True, reason=None, session=None):

[GitHub] [airflow] utkarsharma2 commented on a change in pull request #9907: Added feature to Import connections from a file.

2020-08-05 Thread GitBox
utkarsharma2 commented on a change in pull request #9907: URL: https://github.com/apache/airflow/pull/9907#discussion_r466072589 ## File path: airflow/cli/commands/connection_command.py ## @@ -153,3 +155,93 @@ def connections_delete(args): msg = '\n\tSuccessfully

[GitHub] [airflow] utkarsharma2 commented on a change in pull request #9907: Added feature to Import connections from a file.

2020-08-05 Thread GitBox
utkarsharma2 commented on a change in pull request #9907: URL: https://github.com/apache/airflow/pull/9907#discussion_r466072294 ## File path: airflow/cli/commands/connection_command.py ## @@ -153,3 +155,93 @@ def connections_delete(args): msg = '\n\tSuccessfully

[GitHub] [airflow] utkarsharma2 commented on a change in pull request #9907: Added feature to Import connections from a file.

2020-08-05 Thread GitBox
utkarsharma2 commented on a change in pull request #9907: URL: https://github.com/apache/airflow/pull/9907#discussion_r466072367 ## File path: airflow/cli/commands/connection_command.py ## @@ -153,3 +155,93 @@ def connections_delete(args): msg = '\n\tSuccessfully

[GitHub] [airflow] utkarsharma2 commented on a change in pull request #9907: Added feature to Import connections from a file.

2020-08-05 Thread GitBox
utkarsharma2 commented on a change in pull request #9907: URL: https://github.com/apache/airflow/pull/9907#discussion_r466072225 ## File path: airflow/cli/commands/connection_command.py ## @@ -153,3 +155,93 @@ def connections_delete(args): msg = '\n\tSuccessfully

[GitHub] [airflow] utkarsharma2 commented on a change in pull request #9907: Added feature to Import connections from a file.

2020-08-05 Thread GitBox
utkarsharma2 commented on a change in pull request #9907: URL: https://github.com/apache/airflow/pull/9907#discussion_r466071926 ## File path: airflow/cli/cli_parser.py ## @@ -626,6 +626,20 @@ def positive_int(value): ), action="store_true", default=False)

[GitHub] [airflow] utkarsharma2 commented on a change in pull request #9907: Added feature to Import connections from a file.

2020-08-05 Thread GitBox
utkarsharma2 commented on a change in pull request #9907: URL: https://github.com/apache/airflow/pull/9907#discussion_r466072118 ## File path: airflow/cli/cli_parser.py ## @@ -626,6 +626,20 @@ def positive_int(value): ), action="store_true", default=False)

[jira] [Commented] (AIRFLOW-6786) Adding KafkaConsumerHook, KafkaProducerHook, and KafkaSensor

2020-08-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171825#comment-17171825 ] ASF GitHub Bot commented on AIRFLOW-6786: - haidaraM commented on pull request #7407: URL:

[GitHub] [airflow] haidaraM commented on pull request #7407: [AIRFLOW-6786] Add KafkaConsumerHook, KafkaProduerHook and KafkaSensor

2020-08-05 Thread GitBox
haidaraM commented on pull request #7407: URL: https://github.com/apache/airflow/pull/7407#issuecomment-669594812 Agreed with @mik-laj . Looks like the PR got lot of unrelated changes somehow. This is an automated message

[GitHub] [airflow] pcandoalmeida commented on pull request #10162: Add Airflow UI site_title configuration option

2020-08-05 Thread GitBox
pcandoalmeida commented on pull request #10162: URL: https://github.com/apache/airflow/pull/10162#issuecomment-669577449 > Could you please add some documentation? I am thinking about a new page in the `howto` directory. > https://airflow.readthedocs.io/en/latest/howto/index.html >

[GitHub] [airflow] mik-laj commented on pull request #10162: Add Airflow UI site_title configuration option

2020-08-05 Thread GitBox
mik-laj commented on pull request #10162: URL: https://github.com/apache/airflow/pull/10162#issuecomment-669568873 Could you please add some documentation? I am thinking about a new page in the `howto` directory. https://airflow.readthedocs.io/en/latest/howto/index.html In my next

[GitHub] [airflow] dimberman commented on pull request #10084: Fix more PodMutationHook issues for backwards compatibility

2020-08-05 Thread GitBox
dimberman commented on pull request #10084: URL: https://github.com/apache/airflow/pull/10084#issuecomment-669554963 @kaxil everything is working except those random mongo_hook tests. Can you take a look? After that we just need to refactor. At the very least k8s stuff is WAY better

[GitHub] [airflow] pcandoalmeida commented on a change in pull request #10162: Add Airflow UI site_title configuration option

2020-08-05 Thread GitBox
pcandoalmeida commented on a change in pull request #10162: URL: https://github.com/apache/airflow/pull/10162#discussion_r466040341 ## File path: tests/www/test_views.py ## @@ -1022,6 +1022,18 @@ def log_name(self):

[GitHub] [airflow] odracci commented on pull request #9845: Fix PodGenerator to handle Kubernetes resources

2020-08-05 Thread GitBox
odracci commented on pull request #9845: URL: https://github.com/apache/airflow/pull/9845#issuecomment-669552380 > @odracci can you please rebase? I have the k8s tests passing done This is an automated message from

[GitHub] [airflow] tanjinP commented on pull request #10121: Google Cloud Memorystore Memcached Operators

2020-08-05 Thread GitBox
tanjinP commented on pull request #10121: URL: https://github.com/apache/airflow/pull/10121#issuecomment-669552389 > Hello @tanjinP. > @mschickien is on vacation until 10.08. Would you like us to process this change or would you rather wait until we get more feedback from a potential

[GitHub] [airflow] mik-laj commented on a change in pull request #10162: Add Airflow UI site_title configuration option

2020-08-05 Thread GitBox
mik-laj commented on a change in pull request #10162: URL: https://github.com/apache/airflow/pull/10162#discussion_r466037021 ## File path: tests/www/test_views.py ## @@ -1022,6 +1022,18 @@ def log_name(self): self.assertTrue(ctx['show_external_log_redirect'])

[jira] [Commented] (AIRFLOW-6786) Adding KafkaConsumerHook, KafkaProducerHook, and KafkaSensor

2020-08-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171799#comment-17171799 ] ASF GitHub Bot commented on AIRFLOW-6786: - mik-laj edited a comment on pull request #7407: URL:

[GitHub] [airflow] mik-laj edited a comment on pull request #7407: [AIRFLOW-6786] Add KafkaConsumerHook, KafkaProduerHook and KafkaSensor

2020-08-05 Thread GitBox
mik-laj edited a comment on pull request #7407: URL: https://github.com/apache/airflow/pull/7407#issuecomment-669535658 I think there is something wrong with this change because I can see too many files. My suggestion is to copy all the relevant files to a separate directory and then

[GitHub] [airflow] mik-laj commented on pull request #10121: Google Cloud Memorystore Memcached Operators

2020-08-05 Thread GitBox
mik-laj commented on pull request #10121: URL: https://github.com/apache/airflow/pull/10121#issuecomment-669547983 Hello @tanjinP. @mschickien is on vacation until 10.08. Would you like us to process this change or would you rather wait until we get more feedback from a potential

[GitHub] [airflow] odavid commented on pull request #10140: Remove items with None from requests & limits dicts in Kubernetes Resources

2020-08-05 Thread GitBox
odavid commented on pull request #10140: URL: https://github.com/apache/airflow/pull/10140#issuecomment-669544896 Hey @potiuk, I've rebased and also fixed all failed related tests, however, now the CI on mongo tests and other none related errors. I would be grateful to understand how do I

[jira] [Commented] (AIRFLOW-6786) Adding KafkaConsumerHook, KafkaProducerHook, and KafkaSensor

2020-08-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171790#comment-17171790 ] ASF GitHub Bot commented on AIRFLOW-6786: - mik-laj commented on pull request #7407: URL:

[GitHub] [airflow] mik-laj commented on pull request #7407: [AIRFLOW-6786] Add KafkaConsumerHook, KafkaProduerHook and KafkaSensor

2020-08-05 Thread GitBox
mik-laj commented on pull request #7407: URL: https://github.com/apache/airflow/pull/7407#issuecomment-669542839 @dferguson992 I would like to apologize that you have to wait so long for this change to be reviewed. Please post the progress of this change on the #development channel so

[jira] [Commented] (AIRFLOW-6786) Adding KafkaConsumerHook, KafkaProducerHook, and KafkaSensor

2020-08-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171787#comment-17171787 ] ASF GitHub Bot commented on AIRFLOW-6786: - mik-laj commented on pull request #7407: URL:

[GitHub] [airflow] mik-laj commented on pull request #7407: [AIRFLOW-6786] Add KafkaConsumerHook, KafkaProduerHook and KafkaSensor

2020-08-05 Thread GitBox
mik-laj commented on pull request #7407: URL: https://github.com/apache/airflow/pull/7407#issuecomment-669535658 I think there is something wrong with this change because I can see too many files. My suggestion is to copy all the relevant files to a separate directory and then create the

[GitHub] [airflow] codecov-commenter edited a comment on pull request #9295: added mssql to oracle transfer operator

2020-08-05 Thread GitBox
codecov-commenter edited a comment on pull request #9295: URL: https://github.com/apache/airflow/pull/9295#issuecomment-669476703 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] codecov-commenter commented on pull request #9295: added mssql to oracle transfer operator

2020-08-05 Thread GitBox
codecov-commenter commented on pull request #9295: URL: https://github.com/apache/airflow/pull/9295#issuecomment-669476703 # [Codecov](https://codecov.io/gh/apache/airflow/pull/9295?src=pr=h1) Report > Merging [#9295](https://codecov.io/gh/apache/airflow/pull/9295?src=pr=desc) into

[jira] [Commented] (AIRFLOW-6786) Adding KafkaConsumerHook, KafkaProducerHook, and KafkaSensor

2020-08-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171723#comment-17171723 ] ASF GitHub Bot commented on AIRFLOW-6786: - rhps edited a comment on pull request #7407: URL:

[GitHub] [airflow] rhps edited a comment on pull request #7407: [AIRFLOW-6786] Add KafkaConsumerHook, KafkaProduerHook and KafkaSensor

2020-08-05 Thread GitBox
rhps edited a comment on pull request #7407: URL: https://github.com/apache/airflow/pull/7407#issuecomment-669466430 Hi Guys, anyone can help with these issues? @ashb @mhbrown This is an automated message from the Apache Git

[GitHub] [airflow] rhps commented on pull request #7407: [AIRFLOW-6786] Add KafkaConsumerHook, KafkaProduerHook and KafkaSensor

2020-08-05 Thread GitBox
rhps commented on pull request #7407: URL: https://github.com/apache/airflow/pull/7407#issuecomment-669466430 Hi Guys, anyone can help with these issues? @ashb This is an automated message from the Apache Git Service. To

[jira] [Commented] (AIRFLOW-6786) Adding KafkaConsumerHook, KafkaProducerHook, and KafkaSensor

2020-08-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171722#comment-17171722 ] ASF GitHub Bot commented on AIRFLOW-6786: - rhps commented on pull request #7407: URL:

[GitHub] [airflow] mik-laj commented on pull request #10192: Deprecate BaseHook.get_connections method (#10135)

2020-08-05 Thread GitBox
mik-laj commented on pull request #10192: URL: https://github.com/apache/airflow/pull/10192#issuecomment-669461720 In the case of `airflow connections list --include-sectes`, I think we should now add a new command `airflow connection get` which will only let you download one entry.

[GitHub] [airflow] Hasan-J commented on a change in pull request #10192: Deprecate BaseHook.get_connections method (#10135)

2020-08-05 Thread GitBox
Hasan-J commented on a change in pull request #10192: URL: https://github.com/apache/airflow/pull/10192#discussion_r465965967 ## File path: airflow/hooks/base_hook.py ## @@ -44,17 +44,21 @@ def get_connections(cls, conn_id: str) -> List[Connection]: :param conn_id:

[GitHub] [airflow] mik-laj commented on a change in pull request #10192: Deprecate BaseHook.get_connections method (#10135)

2020-08-05 Thread GitBox
mik-laj commented on a change in pull request #10192: URL: https://github.com/apache/airflow/pull/10192#discussion_r465964827 ## File path: airflow/hooks/base_hook.py ## @@ -44,17 +44,21 @@ def get_connections(cls, conn_id: str) -> List[Connection]: :param conn_id:

[GitHub] [airflow] Hasan-J commented on issue #10135: Deprecate BaseHook.get_connections method

2020-08-05 Thread GitBox
Hasan-J commented on issue #10135: URL: https://github.com/apache/airflow/issues/10135#issuecomment-669459186 I opened a draft and need some confirmations. Please check the PR conversation when you have time :) This is

[GitHub] [airflow] Hasan-J edited a comment on pull request #10192: Deprecate BaseHook.get_connections method (#10135)

2020-08-05 Thread GitBox
Hasan-J edited a comment on pull request #10192: URL: https://github.com/apache/airflow/pull/10192#issuecomment-669442900 Still need to go over the tests and docs And wasn't sure if we should modify the hooks in a separate issue or not! -

[GitHub] [airflow] Hasan-J commented on pull request #10192: Deprecate BaseHook.get_connections method (#10135)

2020-08-05 Thread GitBox
Hasan-J commented on pull request #10192: URL: https://github.com/apache/airflow/pull/10192#issuecomment-669442900 Still need to go over the tests and docs And wasn't sure if we should modify the hooks in a separate issue or not! -

[GitHub] [airflow] Hasan-J opened a new pull request #10192: Deprecate BaseHook.get_connections method (#10135)

2020-08-05 Thread GitBox
Hasan-J opened a new pull request #10192: URL: https://github.com/apache/airflow/pull/10192 closes: #10135 Deprecates the use of `BaseHook.get_connections` - [ ] Unit tests coverage for changes - [ ] Relevant documentation is updated including usage instructions.

[GitHub] [airflow] odavid commented on pull request #10140: Remove items with None from requests & limits dicts in Kubernetes Resources

2020-08-05 Thread GitBox
odavid commented on pull request #10140: URL: https://github.com/apache/airflow/pull/10140#issuecomment-669431395 > I think you might need to rebase this one @odavid ! There was some problem with Github and it has way too many jobs. Thank you @potiuk - done

[GitHub] [airflow] mik-laj commented on a change in pull request #10052: Add impersonation to google operators

2020-08-05 Thread GitBox
mik-laj commented on a change in pull request #10052: URL: https://github.com/apache/airflow/pull/10052#discussion_r465942552 ## File path: airflow/providers/amazon/aws/transfers/google_api_to_s3.py ## @@ -68,17 +69,28 @@ class GoogleApiToS3Operator(BaseOperator): :type

[GitHub] [airflow] mik-laj commented on a change in pull request #10052: Add impersonation to google operators

2020-08-05 Thread GitBox
mik-laj commented on a change in pull request #10052: URL: https://github.com/apache/airflow/pull/10052#discussion_r465942263 ## File path: airflow/providers/amazon/aws/transfers/gcs_to_s3.py ## @@ -45,8 +45,8 @@ class GCSToS3Operator(GCSListObjectsOperator): :param

[GitHub] [airflow] mik-laj commented on a change in pull request #10081: Add CLI for connections export (#9856)

2020-08-05 Thread GitBox
mik-laj commented on a change in pull request #10081: URL: https://github.com/apache/airflow/pull/10081#discussion_r465940529 ## File path: airflow/cli/commands/connection_command.py ## @@ -67,6 +71,63 @@ def connections_list(args): print(msg) +def

[GitHub] [airflow] mik-laj commented on a change in pull request #10081: Add CLI for connections export (#9856)

2020-08-05 Thread GitBox
mik-laj commented on a change in pull request #10081: URL: https://github.com/apache/airflow/pull/10081#discussion_r465940529 ## File path: airflow/cli/commands/connection_command.py ## @@ -67,6 +71,63 @@ def connections_list(args): print(msg) +def

[GitHub] [airflow] LvffY opened a new issue #10191: Unable to log into an Azure blob storage

2020-08-05 Thread GitBox
LvffY opened a new issue #10191: URL: https://github.com/apache/airflow/issues/10191 **Apache Airflow version**: 1.10.10 **Environment**: Ubuntu 18.04.4 LTS (WSL) - **Cloud provider or hardware configuration**: Windows 10 Enterprise - **OS** (e.g. from

[GitHub] [airflow] mik-laj commented on pull request #10081: Add CLI for connections export (#9856)

2020-08-05 Thread GitBox
mik-laj commented on pull request #10081: URL: https://github.com/apache/airflow/pull/10081#issuecomment-669407484 It looks really good, but I think it's worth adding some documentation. https://airflow.readthedocs.io/en/latest/howto/connection/index.html

[GitHub] [airflow] potiuk commented on pull request #9593: Improve handling Dataproc cluster creation with ERROR state

2020-08-05 Thread GitBox
potiuk commented on pull request #9593: URL: https://github.com/apache/airflow/pull/9593#issuecomment-669407496 > @turbaszek yes this PR is good to go! > @potiuk indeed it would be good to make all the right decisions once :) (never seen so many smileys in a GH comment) I was

[GitHub] [airflow] boring-cyborg[bot] commented on issue #10191: Unable to log into an Azure blob storage

2020-08-05 Thread GitBox
boring-cyborg[bot] commented on issue #10191: URL: https://github.com/apache/airflow/issues/10191#issuecomment-669407576 Thanks for opening your first issue here! Be sure to follow the issue template! This is an

[GitHub] [airflow] jaketf commented on pull request #9593: Improve handling Dataproc cluster creation with ERROR state

2020-08-05 Thread GitBox
jaketf commented on pull request #9593: URL: https://github.com/apache/airflow/pull/9593#issuecomment-669405211 @turbaszek yes this PR is good to go! @potiuk indeed it would be good to make all the right decisions once :) (never seen so many smileys in a GH comment) cc:

[GitHub] [airflow] potiuk commented on pull request #10140: Remove items with None from requests & limits dicts in Kubernetes Resources

2020-08-05 Thread GitBox
potiuk commented on pull request #10140: URL: https://github.com/apache/airflow/pull/10140#issuecomment-669403241 I think you might need to rebase this one @odavid ! There was some problem with Github and it has way too many jobs.

[GitHub] [airflow] mik-laj commented on a change in pull request #10081: Add CLI for connections export (#9856)

2020-08-05 Thread GitBox
mik-laj commented on a change in pull request #10081: URL: https://github.com/apache/airflow/pull/10081#discussion_r465935540 ## File path: tests/cli/commands/test_connection_command.py ## @@ -111,6 +112,227 @@ def test_cli_connections_include_secrets(self):

[GitHub] [airflow] mik-laj commented on a change in pull request #10081: Add CLI for connections export (#9856)

2020-08-05 Thread GitBox
mik-laj commented on a change in pull request #10081: URL: https://github.com/apache/airflow/pull/10081#discussion_r465935540 ## File path: tests/cli/commands/test_connection_command.py ## @@ -111,6 +112,227 @@ def test_cli_connections_include_secrets(self):

[GitHub] [airflow] mik-laj commented on a change in pull request #10081: Add CLI for connections export (#9856)

2020-08-05 Thread GitBox
mik-laj commented on a change in pull request #10081: URL: https://github.com/apache/airflow/pull/10081#discussion_r465934738 ## File path: airflow/cli/commands/connection_command.py ## @@ -67,6 +71,63 @@ def connections_list(args): print(msg) +def

[GitHub] [airflow] mik-laj commented on a change in pull request #10081: Add CLI for connections export (#9856)

2020-08-05 Thread GitBox
mik-laj commented on a change in pull request #10081: URL: https://github.com/apache/airflow/pull/10081#discussion_r465934031 ## File path: airflow/cli/commands/connection_command.py ## @@ -67,6 +71,63 @@ def connections_list(args): print(msg) +def

[GitHub] [airflow] mik-laj commented on a change in pull request #10096: prevent DAG callback exception from crashing scheduler

2020-08-05 Thread GitBox
mik-laj commented on a change in pull request #10096: URL: https://github.com/apache/airflow/pull/10096#discussion_r465932695 ## File path: airflow/models/dag.py ## @@ -686,7 +689,11 @@ def handle_callback(self, dagrun, success=True, reason=None, session=None):

[airflow] branch master updated (9667314 -> 3b3287d)

2020-08-05 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 9667314 Add correct signatures for operators in amazon provider package (#10167) add 3b3287d Enforce

[airflow] branch master updated (9667314 -> 3b3287d)

2020-08-05 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 9667314 Add correct signatures for operators in amazon provider package (#10167) add 3b3287d Enforce

[airflow] branch master updated (1279731 -> 9667314)

2020-08-05 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 1279731 Add docs for airflow config command (#10177) add 9667314 Add correct signatures for operators

[GitHub] [airflow] mik-laj merged pull request #10170: Add correct signatures for operators in apache provider package

2020-08-05 Thread GitBox
mik-laj merged pull request #10170: URL: https://github.com/apache/airflow/pull/10170 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[airflow] branch master updated (1279731 -> 9667314)

2020-08-05 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 1279731 Add docs for airflow config command (#10177) add 9667314 Add correct signatures for operators

[GitHub] [airflow] mik-laj merged pull request #10167: Add correct signatures for operators in amazon provider package

2020-08-05 Thread GitBox
mik-laj merged pull request #10167: URL: https://github.com/apache/airflow/pull/10167 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] potiuk commented on pull request #9593: Improve handling Dataproc cluster creation with ERROR state

2020-08-05 Thread GitBox
potiuk commented on pull request #9593: URL: https://github.com/apache/airflow/pull/9593#issuecomment-669392106 Sure - we are good - it was offtop :) This is an automated message from the Apache Git Service. To respond to

[jira] [Comment Edited] (AIRFLOW-5071) Thousand os Executor reports task instance X finished (success) although the task says its queued. Was the task killed externally?

2020-08-05 Thread Szymon Grzemski (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171669#comment-17171669 ] Szymon Grzemski edited comment on AIRFLOW-5071 at 8/5/20, 6:41 PM: ---

[jira] [Comment Edited] (AIRFLOW-5071) Thousand os Executor reports task instance X finished (success) although the task says its queued. Was the task killed externally?

2020-08-05 Thread Szymon Grzemski (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171669#comment-17171669 ] Szymon Grzemski edited comment on AIRFLOW-5071 at 8/5/20, 6:37 PM: ---

[jira] [Comment Edited] (AIRFLOW-5071) Thousand os Executor reports task instance X finished (success) although the task says its queued. Was the task killed externally?

2020-08-05 Thread Szymon Grzemski (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171669#comment-17171669 ] Szymon Grzemski edited comment on AIRFLOW-5071 at 8/5/20, 6:37 PM: ---

[jira] [Commented] (AIRFLOW-5071) Thousand os Executor reports task instance X finished (success) although the task says its queued. Was the task killed externally?

2020-08-05 Thread Szymon Grzemski (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171669#comment-17171669 ] Szymon Grzemski commented on AIRFLOW-5071: -- In our case sensors are marked as a failed (even

[jira] [Commented] (AIRFLOW-2516) Deadlock found when trying to update task_instance table

2020-08-05 Thread Si Feng (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171667#comment-17171667 ] Si Feng commented on AIRFLOW-2516: -- I can confirm that the MySQL deadlock issue still exists in

[GitHub] [airflow] nie3e commented on issue #10189: Changing timezone in webserwer UI

2020-08-05 Thread GitBox
nie3e commented on issue #10189: URL: https://github.com/apache/airflow/issues/10189#issuecomment-669356974 > Dp you have RBAC UI enabled? You should have the following values in airflow.cfg to use RBAC. > > ``` > [webserver] > rbac = true > ``` > > Here is the

[GitHub] [airflow] nie3e closed issue #10189: Changing timezone in webserwer UI

2020-08-05 Thread GitBox
nie3e closed issue #10189: URL: https://github.com/apache/airflow/issues/10189 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] mik-laj merged pull request #10177: Add docs for airflow config command

2020-08-05 Thread GitBox
mik-laj merged pull request #10177: URL: https://github.com/apache/airflow/pull/10177 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[airflow] branch master updated (92869f0 -> 1279731)

2020-08-05 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 92869f0 Improve heading on Email Configuration page (#10175) add 1279731 Add docs for airflow config

[GitHub] [airflow] mik-laj commented on issue #10189: Changing timezone in webserwer UI

2020-08-05 Thread GitBox
mik-laj commented on issue #10189: URL: https://github.com/apache/airflow/issues/10189#issuecomment-669350838 Dp you have RBAC UI enabled? You should have the following values in airflow.cfg to use RBAC. ``` [webserver] rbac = true ``` Here is the migration guide:

[GitHub] [airflow] potiuk closed issue #10188: task_log_prefix_template configuration is not documented and doesn't work

2020-08-05 Thread GitBox
potiuk closed issue #10188: URL: https://github.com/apache/airflow/issues/10188 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] gardnerdev opened a new pull request #10190: Chart rbac modifications

2020-08-05 Thread GitBox
gardnerdev opened a new pull request #10190: URL: https://github.com/apache/airflow/pull/10190 I've tested it and in secured environments "ClusterRole" is often not allowed. What is the point of using here ClusterRole if for example in pod-cleanup-role.yaml is just a Role? It makes chart

[GitHub] [airflow] mik-laj commented on issue #10188: task_log_prefix_template configuration is not documented and doesn't work

2020-08-05 Thread GitBox
mik-laj commented on issue #10188: URL: https://github.com/apache/airflow/issues/10188#issuecomment-669346933 This configuration option is only available in the development version from the master branch. Here is the documentation for this option. You pasted the link to the

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10190: Chart rbac modifications

2020-08-05 Thread GitBox
boring-cyborg[bot] commented on pull request #10190: URL: https://github.com/apache/airflow/pull/10190#issuecomment-669347005 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] boring-cyborg[bot] commented on issue #10189: Changing timezone in webserwer UI

2020-08-05 Thread GitBox
boring-cyborg[bot] commented on issue #10189: URL: https://github.com/apache/airflow/issues/10189#issuecomment-669346671 Thanks for opening your first issue here! Be sure to follow the issue template! This is an

[GitHub] [airflow] nie3e opened a new issue #10189: Changing timezone in webserwer UI

2020-08-05 Thread GitBox
nie3e opened a new issue #10189: URL: https://github.com/apache/airflow/issues/10189 **Apache Airflow version**: 1.10.11 **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): **Environment**: - **Cloud provider or hardware configuration**:

[airflow] branch master updated (3903152 -> 92869f0)

2020-08-05 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 3903152 Remove stat_name_handler attribute in plugins.rst (#10174) add 92869f0 Improve heading on

[airflow] branch master updated (4bb32ca -> 3903152)

2020-08-05 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 4bb32ca Disable wiki. (#10173) add 3903152 Remove stat_name_handler attribute in plugins.rst (#10174)

[airflow] branch master updated (3903152 -> 92869f0)

2020-08-05 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 3903152 Remove stat_name_handler attribute in plugins.rst (#10174) add 92869f0 Improve heading on

[airflow] branch master updated (4bb32ca -> 3903152)

2020-08-05 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 4bb32ca Disable wiki. (#10173) add 3903152 Remove stat_name_handler attribute in plugins.rst (#10174)

[GitHub] [airflow] bellhea opened a new issue #10188: task_log_prefix_template configuration is not documented and doesn't work

2020-08-05 Thread GitBox
bellhea opened a new issue #10188: URL: https://github.com/apache/airflow/issues/10188 **Apache Airflow version**: 1.10.11 **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): 1.10.0 **Environment**: - **Cloud provider or

[GitHub] [airflow] mik-laj merged pull request #10174: Remove stat_name_handler attribute in plugins.rst

2020-08-05 Thread GitBox
mik-laj merged pull request #10174: URL: https://github.com/apache/airflow/pull/10174 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] boring-cyborg[bot] commented on issue #10188: task_log_prefix_template configuration is not documented and doesn't work

2020-08-05 Thread GitBox
boring-cyborg[bot] commented on issue #10188: URL: https://github.com/apache/airflow/issues/10188#issuecomment-669332352 Thanks for opening your first issue here! Be sure to follow the issue template! This is an

[GitHub] [airflow] mik-laj merged pull request #10175: Improve heading on Email Configuration page

2020-08-05 Thread GitBox
mik-laj merged pull request #10175: URL: https://github.com/apache/airflow/pull/10175 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

  1   2   3   >