[airflow] branch master updated: Add example DAGs to provider docs (#12528)

2020-11-21 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new f2569de Add example DAGs to provider docs (#12

[GitHub] [airflow] potiuk merged pull request #12528: Add example DAGs to provider docs

2020-11-21 Thread GitBox
potiuk merged pull request #12528: URL: https://github.com/apache/airflow/pull/12528 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] RosterIn commented on pull request #11332: SnowflakeToS3Operator

2020-11-21 Thread GitBox
RosterIn commented on pull request #11332: URL: https://github.com/apache/airflow/pull/11332#issuecomment-731711852 @JavierLopezT the checks are failing with `tests/providers/amazon/aws/transfers/test_snowflake_to_s3.py:43:8: E1125: Missing mandatory keyword argument 'query_or_table' in

[GitHub] [airflow] potiuk edited a comment on pull request #12511: Run pip check to verify production images

2020-11-21 Thread GitBox
potiuk edited a comment on pull request #12511: URL: https://github.com/apache/airflow/pull/12511#issuecomment-731711038 And we can also think about handling this case automatically. Selective checks should allow that: If setup.py or setup.cfg change would need to be done: if the setup.

[GitHub] [airflow] potiuk edited a comment on pull request #12511: Run pip check to verify production images

2020-11-21 Thread GitBox
potiuk edited a comment on pull request #12511: URL: https://github.com/apache/airflow/pull/12511#issuecomment-731711038 And we can also think about handling this case automatically. Selective checks should allow that: If setup.py or setup.cfg change would need to be done: if the setup.

[GitHub] [airflow] potiuk edited a comment on pull request #12511: Run pip check to verify production images

2020-11-21 Thread GitBox
potiuk edited a comment on pull request #12511: URL: https://github.com/apache/airflow/pull/12511#issuecomment-731711038 And we can also think about handling this case automatically. Selective checks should allow that: If setup.py or setup.cfg change would need to be done: if the setup.p

[GitHub] [airflow] potiuk edited a comment on pull request #12511: Run pip check to verify production images

2020-11-21 Thread GitBox
potiuk edited a comment on pull request #12511: URL: https://github.com/apache/airflow/pull/12511#issuecomment-731711038 And we can also think about handling this case automatically. Selective checks should allow that: If setup.py or setup.cfg change would need to be done: if the setup.p

[GitHub] [airflow] potiuk edited a comment on pull request #12511: Run pip check to verify production images

2020-11-21 Thread GitBox
potiuk edited a comment on pull request #12511: URL: https://github.com/apache/airflow/pull/12511#issuecomment-731711038 And we can also think about handling this case automatically. Selective checks should allow that: If setup.py or setup.cfg change would need to be done: if the setup.p

[GitHub] [airflow] potiuk commented on pull request #12511: Run pip check to verify production images

2020-11-21 Thread GitBox
potiuk commented on pull request #12511: URL: https://github.com/apache/airflow/pull/12511#issuecomment-731711038 And we can also think about handling this case automatically. Selective checks should allow that: If setup.py or setup.cfg change would need to be done: if the setup.py gets

[GitHub] [airflow] potiuk commented on pull request #12511: Run pip check to verify production images

2020-11-21 Thread GitBox
potiuk commented on pull request #12511: URL: https://github.com/apache/airflow/pull/12511#issuecomment-731710155 > So what should I do now? The setup.py was updated, the dependencies in image were not so the check is failing. And because it is failing we won't run tests Push the fo

[airflow] branch master updated: Fix line breaks in CeleryKubernetesExecutor docs (#12538)

2020-11-21 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 0d796e7 Fix line breaks in CeleryKubernetesExe

[GitHub] [airflow] potiuk merged pull request #12538: Fix line breaks in CeleryKubernetesExecutor docs

2020-11-21 Thread GitBox
potiuk merged pull request #12538: URL: https://github.com/apache/airflow/pull/12538 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] github-actions[bot] commented on pull request #12527: Move providers docs to separate package + Spell-check in a common job with docs-build

2020-11-21 Thread GitBox
github-actions[bot] commented on pull request #12527: URL: https://github.com/apache/airflow/pull/12527#issuecomment-731709389 The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it! --

[airflow] branch master updated: Support installing providers with no dependencies via extras (#12497)

2020-11-21 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 9eb92e7 Support installing providers with no d

[GitHub] [airflow] potiuk merged pull request #12497: Support installing providers with no dependencies via extras

2020-11-21 Thread GitBox
potiuk merged pull request #12497: URL: https://github.com/apache/airflow/pull/12497 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] potiuk commented on a change in pull request #12497: Support installing providers with no dependencies via extras

2020-11-21 Thread GitBox
potiuk commented on a change in pull request #12497: URL: https://github.com/apache/airflow/pull/12497#discussion_r528293774 ## File path: scripts/ci/pre_commit/pre_commit_check_setup_extra_packages_ref.py ## @@ -53,13 +53,16 @@ def get_extras_from_setup() -> Dict[str, List[str

[airflow] branch master updated (397d912 -> 597717d)

2020-11-21 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 397d912 Return nonzero exit codes on pool import errors. (#12095) add 597717d update broken link to cli-and-e

[GitHub] [airflow] potiuk merged pull request #12540: update broken link to cli-and-env-variables-ref

2020-11-21 Thread GitBox
potiuk merged pull request #12540: URL: https://github.com/apache/airflow/pull/12540 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #12540: update broken link to cli-and-env-variables-ref

2020-11-21 Thread GitBox
boring-cyborg[bot] commented on pull request #12540: URL: https://github.com/apache/airflow/pull/12540#issuecomment-731708616 Awesome work, congrats on your first merged pull request! This is an automated message from the

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #12540: update broken link to cli-and-env-variables-ref

2020-11-21 Thread GitBox
boring-cyborg[bot] commented on pull request #12540: URL: https://github.com/apache/airflow/pull/12540#issuecomment-731698351 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Con

[GitHub] [airflow] gflores1023 opened a new pull request #12540: update broken link to cli-and-env-variables-ref

2020-11-21 Thread GitBox
gflores1023 opened a new pull request #12540: URL: https://github.com/apache/airflow/pull/12540 Fix broken link --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidel

[GitHub] [airflow] jedcunningham commented on a change in pull request #12497: Support installing providers with no dependencies via extras

2020-11-21 Thread GitBox
jedcunningham commented on a change in pull request #12497: URL: https://github.com/apache/airflow/pull/12497#discussion_r528279950 ## File path: scripts/ci/pre_commit/pre_commit_check_setup_extra_packages_ref.py ## @@ -53,13 +53,16 @@ def get_extras_from_setup() -> Dict[str, L

[GitHub] [airflow] mik-laj edited a comment on issue #9414: Environment variables reference

2020-11-21 Thread GitBox
mik-laj edited a comment on issue #9414: URL: https://github.com/apache/airflow/issues/9414#issuecomment-731690403 @gflores1023 If you want to propose a change then you don't have a ticket. It is enough to create a PR. --

[GitHub] [airflow] mik-laj commented on issue #9414: Environment variables reference

2020-11-21 Thread GitBox
mik-laj commented on issue #9414: URL: https://github.com/apache/airflow/issues/9414#issuecomment-731690403 @gflores1023 If you want to propose a design change then you don't have a ticket. It is enough to create a PR. --

[airflow] tag nightly-master updated (f0b9aae -> 397d912)

2020-11-21 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to tag nightly-master in repository https://gitbox.apache.org/repos/asf/airflow.git. *** WARNING: tag nightly-master was modified! *** from f0b9aae (commit) to 397d912 (commit) from f0

[GitHub] [airflow] gflores1023 edited a comment on issue #9414: Environment variables reference

2020-11-21 Thread GitBox
gflores1023 edited a comment on issue #9414: URL: https://github.com/apache/airflow/issues/9414#issuecomment-731662150 Hi, came across this issue. There's now a broken link on [dag-run](https://airflow.readthedocs.io/en/latest/dag-run.html?highlight=catchup#backfill) - the link that points

[GitHub] [airflow] gflores1023 edited a comment on issue #9414: Environment variables reference

2020-11-21 Thread GitBox
gflores1023 edited a comment on issue #9414: URL: https://github.com/apache/airflow/issues/9414#issuecomment-731662150 Hi, came across this issue. There's now a broken link on [dag-run](https://airflow.readthedocs.io/en/latest/dag-run.html?highlight=catchup#backfill) - the link that points

[GitHub] [airflow] gflores1023 commented on issue #9414: Environment variables reference

2020-11-21 Thread GitBox
gflores1023 commented on issue #9414: URL: https://github.com/apache/airflow/issues/9414#issuecomment-731662150 Hi, came across this issue. There's now a broken link on [dag-run](https://airflow.readthedocs.io/en/latest/dag-run.html?highlight=catchup#backfill) - the link that points to: h

[airflow] branch master updated: Return nonzero exit codes on pool import errors. (#12095)

2020-11-21 Thread jmcarp
This is an automated email from the ASF dual-hosted git repository. jmcarp pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 397d912 Return nonzero exit codes on pool impo

[GitHub] [airflow] jmcarp merged pull request #12095: Return nonzero exit codes on pool import errors.

2020-11-21 Thread GitBox
jmcarp merged pull request #12095: URL: https://github.com/apache/airflow/pull/12095 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] mik-laj commented on a change in pull request #12188: Upgrade azure blob to v12

2020-11-21 Thread GitBox
mik-laj commented on a change in pull request #12188: URL: https://github.com/apache/airflow/pull/12188#discussion_r528257169 ## File path: docs/spelling_wordlist.txt ## @@ -1297,6 +1297,7 @@ uid umask un unarchived +uncommittedblobs Review comment: This will work if

[GitHub] [airflow] houqp commented on a change in pull request #12530: fix dag serialization crash caused by preset DagContext

2020-11-21 Thread GitBox
houqp commented on a change in pull request #12530: URL: https://github.com/apache/airflow/pull/12530#discussion_r528254977 ## File path: airflow/models/baseoperator.py ## @@ -1336,6 +1336,9 @@ def get_extra_links(self, dttm: datetime, link_name: str) -> Optional[Dict[str,

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #12188: Upgrade azure blob to v12

2020-11-21 Thread GitBox
ephraimbuddy commented on a change in pull request #12188: URL: https://github.com/apache/airflow/pull/12188#discussion_r528252804 ## File path: docs/spelling_wordlist.txt ## @@ -1297,6 +1297,7 @@ uid umask un unarchived +uncommittedblobs Review comment: The test won

[GitHub] [airflow] mik-laj commented on a change in pull request #12527: Move providers docs to separate package + Spell-check in a common job with docs-build

2020-11-21 Thread GitBox
mik-laj commented on a change in pull request #12527: URL: https://github.com/apache/airflow/pull/12527#discussion_r528251629 ## File path: airflow/providers/snowflake/provider.yaml ## @@ -29,7 +29,7 @@ integrations: external-doc-url: https://snowflake.com/ how-to-gui

[GitHub] [airflow] mik-laj commented on a change in pull request #12527: Move providers docs to separate package + Spell-check in a common job with docs-build

2020-11-21 Thread GitBox
mik-laj commented on a change in pull request #12527: URL: https://github.com/apache/airflow/pull/12527#discussion_r528251439 ## File path: CHANGELOG.txt ## @@ -946,7 +946,7 @@ Doc-only changes - [AIRFLOW-XXX] Fix typo - AWS DynamoDB Hook (#6319) - [AIRFLOW-XXX] Fix Documenta

[GitHub] [airflow] mik-laj edited a comment on pull request #12533: Troubleshooting moved to the installation page

2020-11-21 Thread GitBox
mik-laj edited a comment on pull request #12533: URL: https://github.com/apache/airflow/pull/12533#issuecomment-731645487 @XD-DENG How will this benefit us? I think this will only make it harder to find this section. At one of the [docs meetings](https://github.com/apache/airflow/di

[GitHub] [airflow] XD-DENG commented on pull request #12533: Troubleshooting moved to the installation page

2020-11-21 Thread GitBox
XD-DENG commented on pull request #12533: URL: https://github.com/apache/airflow/pull/12533#issuecomment-731645866 > @XD-DENG How will this benefit us? I think this will only make it harder to find this section. > > At one of the [docs meetings](https://github.com/apache/airflow/dis

[GitHub] [airflow] mik-laj commented on pull request #12533: Troubleshooting moved to the installation page

2020-11-21 Thread GitBox
mik-laj commented on pull request #12533: URL: https://github.com/apache/airflow/pull/12533#issuecomment-731645487 @XD-DENG How will this benefit us? I think this will only make it harder to find this section. At one of the [docs meetings](https://github.com/apache/airflow/discussio

[GitHub] [airflow] turbaszek edited a comment on issue #12500: Investigate removing pandas dependency from Core Airflow

2020-11-21 Thread GitBox
turbaszek edited a comment on issue #12500: URL: https://github.com/apache/airflow/issues/12500#issuecomment-731641985 > And no pandas means no numpy right? Yes, removing pandas will remove also numpy 👌 This is an aut

[GitHub] [airflow] turbaszek commented on issue #12500: Investigate removing pandas dependency from Core Airflow

2020-11-21 Thread GitBox
turbaszek commented on issue #12500: URL: https://github.com/apache/airflow/issues/12500#issuecomment-731641985 > And no pandas means no numpy right? Probably. I forgot check it but no idea where we would need it This

[GitHub] [airflow] jmcarp opened a new pull request #12539: Use html urls instead of onclick for dags view links.

2020-11-21 Thread GitBox
jmcarp opened a new pull request #12539: URL: https://github.com/apache/airflow/pull/12539 The dags view uses onclick events for dagrun and taskinstance links. This breaks url previews, copying urls, opening links in a new tab, etc. This patch uses svg anchors with href attributes inst

[GitHub] [airflow] turbaszek commented on issue #12519: Limit task concurrency per worker?

2020-11-21 Thread GitBox
turbaszek commented on issue #12519: URL: https://github.com/apache/airflow/issues/12519#issuecomment-731641729 Btw. I know that @mjpieters had some similar problem, not sure what was the final solution 😉 This is an automat

[GitHub] [airflow] ashb commented on issue #11423: Separate out documentation building and publishing per provider

2020-11-21 Thread GitBox
ashb commented on issue #11423: URL: https://github.com/apache/airflow/issues/11423#issuecomment-731641602 > > > Now I even think that publishing on Github Releases might be easier for us as we won't have to provide credentials. > > Yep - that's much better. Just remember thi

[GitHub] [airflow] ashb commented on issue #12500: Investigate removing pandas dependency from Core Airflow

2020-11-21 Thread GitBox
ashb commented on issue #12500: URL: https://github.com/apache/airflow/issues/12500#issuecomment-731641189 And no pandas means no numpy right? This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [airflow] ashb commented on issue #12500: Investigate removing pandas dependency from Core Airflow

2020-11-21 Thread GitBox
ashb commented on issue #12500: URL: https://github.com/apache/airflow/issues/12500#issuecomment-731641124 It probably used to be used more - in the old chart view I think, but we've removed those uses now. This is an automa

[GitHub] [airflow] turbaszek opened a new pull request #12538: Fix line breaks in CeleryKubernetesExecutor docs

2020-11-21 Thread GitBox
turbaszek opened a new pull request #12538: URL: https://github.com/apache/airflow/pull/12538 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more

[GitHub] [airflow] github-actions[bot] commented on pull request #12095: Return nonzero exit codes on pool import errors.

2020-11-21 Thread GitBox
github-actions[bot] commented on pull request #12095: URL: https://github.com/apache/airflow/pull/12095#issuecomment-731641007 The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests need

[GitHub] [airflow] turbaszek commented on issue #12519: Limit task concurrency per worker?

2020-11-21 Thread GitBox
turbaszek commented on issue #12519: URL: https://github.com/apache/airflow/issues/12519#issuecomment-731640640 > separate queue and a separate worker, where that worker has its celery.worker_concurrency set to 1 and listens to this separate queue I would say that this is the recomme

[GitHub] [airflow] pbotros commented on issue #12519: Limit task concurrency per worker?

2020-11-21 Thread GitBox
pbotros commented on issue #12519: URL: https://github.com/apache/airflow/issues/12519#issuecomment-731637656 Thinking about this more - I guess this can be implemented with a separate queue and a separate worker, where that worker has its celery.worker_concurrency set to 1 and listens to

[GitHub] [airflow] letyndr opened a new issue #12537: Mounting directories using docker operator on airflow is not working

2020-11-21 Thread GitBox
letyndr opened a new issue #12537: URL: https://github.com/apache/airflow/issues/12537 **Apache Airflow version**: apache-airflow==1.10.12 **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): Does not apply **Environment**:

[GitHub] [airflow] boring-cyborg[bot] commented on issue #12537: Mounting directories using docker operator on airflow is not working

2020-11-21 Thread GitBox
boring-cyborg[bot] commented on issue #12537: URL: https://github.com/apache/airflow/issues/12537#issuecomment-731637390 Thanks for opening your first issue here! Be sure to follow the issue template! This is an automate

[GitHub] [airflow] eladkal commented on issue #9738: Initial support for Mixpanel ETL applications

2020-11-21 Thread GitBox
eladkal commented on issue #9738: URL: https://github.com/apache/airflow/issues/9738#issuecomment-731634210 @shaneikennedy You are more than welcome to contribute. Can I assign this task to you? This is an automated message

[GitHub] [airflow] XD-DENG commented on pull request #12533: Troubleshooting moved to the installation page

2020-11-21 Thread GitBox
XD-DENG commented on pull request #12533: URL: https://github.com/apache/airflow/pull/12533#issuecomment-731633669 Does it suffice to have a paragraph redirecting users to the corresponding sections of FAQ? This is an automa

[GitHub] [airflow] eladkal closed issue #10036: airflow worker - ModuleNotFoundError: No module named 'sqla'

2020-11-21 Thread GitBox
eladkal closed issue #10036: URL: https://github.com/apache/airflow/issues/10036 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] eladkal commented on a change in pull request #11964: Add new datetime branch operator

2020-11-21 Thread GitBox
eladkal commented on a change in pull request #11964: URL: https://github.com/apache/airflow/pull/11964#discussion_r528238842 ## File path: airflow/operators/datetime_branch_operator.py ## @@ -0,0 +1,77 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review co

[GitHub] [airflow] jmcarp commented on a change in pull request #12095: Return nonzero exit codes on pool import errors.

2020-11-21 Thread GitBox
jmcarp commented on a change in pull request #12095: URL: https://github.com/apache/airflow/pull/12095#discussion_r528237803 ## File path: airflow/cli/commands/pool_command.py ## @@ -63,13 +64,14 @@ def pool_delete(args): @cli_utils.action_logging def pool_import(args):

[GitHub] [airflow] turbaszek edited a comment on pull request #12511: Run pip check to verify production images

2020-11-21 Thread GitBox
turbaszek edited a comment on pull request #12511: URL: https://github.com/apache/airflow/pull/12511#issuecomment-731627938 So what should I do now? The setup.py was updated, the dependencies in image were not so the check is failing. And because it is failing we won't run tests 😄 ---

[GitHub] [airflow] github-actions[bot] commented on pull request #12512: Implement reading provider information from packages/sources

2020-11-21 Thread GitBox
github-actions[bot] commented on pull request #12512: URL: https://github.com/apache/airflow/pull/12512#issuecomment-731628129 [The Workflow run](https://github.com/apache/airflow/actions/runs/376446566) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build

[GitHub] [airflow] turbaszek commented on pull request #12511: Run pip check to verify production images

2020-11-21 Thread GitBox
turbaszek commented on pull request #12511: URL: https://github.com/apache/airflow/pull/12511#issuecomment-731627938 So what should I do now? The setup.py was updated, the dependencies in image were not so the check is failing 😄 ---

[GitHub] [airflow] eladkal closed issue #8844: [SQSSensor] max_messages template field issue

2020-11-21 Thread GitBox
eladkal closed issue #8844: URL: https://github.com/apache/airflow/issues/8844 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [airflow] potiuk commented on issue #11423: Separate out documentation building and publishing per provider

2020-11-21 Thread GitBox
potiuk commented on issue #11423: URL: https://github.com/apache/airflow/issues/11423#issuecomment-731620568 > @potiuk The website and theme will share some files, more specifically you must have the site build output files to be able to build the theme. For this reason, moving this theme

[GitHub] [airflow] github-actions[bot] commented on pull request #12536: Add pre-commit hook for JSON schema validation

2020-11-21 Thread GitBox
github-actions[bot] commented on pull request #12536: URL: https://github.com/apache/airflow/pull/12536#issuecomment-731620007 The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it! --

[GitHub] [airflow] potiuk commented on issue #12509: Add support for using Cloud Build in breeze build-image

2020-11-21 Thread GitBox
potiuk commented on issue #12509: URL: https://github.com/apache/airflow/issues/12509#issuecomment-731619333 And 3.8 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] potiuk commented on issue #12509: Add support for using Cloud Build in breeze build-image

2020-11-21 Thread GitBox
potiuk commented on issue #12509: URL: https://github.com/apache/airflow/issues/12509#issuecomment-731617778 3.7 out This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [airflow] potiuk commented on issue #12509: Add support for using Cloud Build in breeze build-image

2020-11-21 Thread GitBox
potiuk commented on issue #12509: URL: https://github.com/apache/airflow/issues/12509#issuecomment-731617627 The 3.6 version (default) should be now fast to pull/build please try it out @turbaszek and let's observe it for a while to see if this is really working in a stable way I :crossed_

[airflow] branch master updated (370e7d0 -> 37548f0)

2020-11-21 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 370e7d0 Fix Python Docstring parameters (#12513) add 37548f0 Fixes unneeded docker-context-files added in CI

[GitHub] [airflow] potiuk closed issue #12509: Add support for using Cloud Build in breeze build-image

2020-11-21 Thread GitBox
potiuk closed issue #12509: URL: https://github.com/apache/airflow/issues/12509 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] potiuk merged pull request #12534: Fixes unneeded docker-context-files added in CI

2020-11-21 Thread GitBox
potiuk merged pull request #12534: URL: https://github.com/apache/airflow/pull/12534 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] potiuk edited a comment on pull request #12511: Run pip check to verify production images

2020-11-21 Thread GitBox
potiuk edited a comment on pull request #12511: URL: https://github.com/apache/airflow/pull/12511#issuecomment-731616523 So the process is simple: 1) we update limitations in setup.py 2) we get PR with those 3) we make the PR green 4) we merge it to master/v1-10-stable and af

[GitHub] [airflow] AleksaC opened a new pull request #12536: Add pre-commit hook for JSON schema validation

2020-11-21 Thread GitBox
AleksaC opened a new pull request #12536: URL: https://github.com/apache/airflow/pull/12536 closes: #12358 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #12536: Add pre-commit hook for JSON schema validation

2020-11-21 Thread GitBox
boring-cyborg[bot] commented on pull request #12536: URL: https://github.com/apache/airflow/pull/12536#issuecomment-731616554 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Con

[GitHub] [airflow] potiuk commented on pull request #12511: Run pip check to verify production images

2020-11-21 Thread GitBox
potiuk commented on pull request #12511: URL: https://github.com/apache/airflow/pull/12511#issuecomment-731616523 So the process is simple: 1) we update limitations in setup.py 2) we get PR with those 3) we make the PR green 4) we merge it to master/v1-10-stable and after it

[GitHub] [airflow] potiuk commented on pull request #12511: Run pip check to verify production images

2020-11-21 Thread GitBox
potiuk commented on pull request #12511: URL: https://github.com/apache/airflow/pull/12511#issuecomment-731616219 I think we will only find out if we have problems after running (and possibly fixing) all the tests (and then possibly running some system tests with real AWS. This is the "ind

[GitHub] [airflow] mpolatcan commented on issue #12341: KubernetesExecutor single task run error: Only works with the Celery or Kubernetes executors, sorry

2020-11-21 Thread GitBox
mpolatcan commented on issue #12341: URL: https://github.com/apache/airflow/issues/12341#issuecomment-731612982 Thanks @kaxil, I am awaiting Airflow version 1.10.13 😄 👍 This is an automated message from the Apache Git Servic

[GitHub] [airflow] rootcss commented on pull request #11850: Add Telegram hook and operator

2020-11-21 Thread GitBox
rootcss commented on pull request #11850: URL: https://github.com/apache/airflow/pull/11850#issuecomment-731606107 Thanks @mik-laj This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [airflow] turbaszek edited a comment on pull request #12511: Run pip check to verify production images

2020-11-21 Thread GitBox
turbaszek edited a comment on pull request #12511: URL: https://github.com/apache/airflow/pull/12511#issuecomment-731567839 > Upgrading boto3 should update the version of botocore we use Yup, using `boto3>=1.15.0` should use `botocore>=1.18.0` which does not require docutils. I updat

[GitHub] [airflow] AleksaC commented on issue #12358: Pre-commit for JSON schema validation

2020-11-21 Thread GitBox
AleksaC commented on issue #12358: URL: https://github.com/apache/airflow/issues/12358#issuecomment-731605885 Hi, can I work on this? This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] Avphy opened a new issue #12535: HttpHook: Unusable response object for slower REST API call

2020-11-21 Thread GitBox
Avphy opened a new issue #12535: URL: https://github.com/apache/airflow/issues/12535 **Apache Airflow version**: AIRFLOW_VERSION=1.10.12 **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): NA **Environment**: - **OS** (e.g. from /etc/o

[GitHub] [airflow] boring-cyborg[bot] commented on issue #12535: HttpHook: Unusable response object for slower REST API call

2020-11-21 Thread GitBox
boring-cyborg[bot] commented on issue #12535: URL: https://github.com/apache/airflow/issues/12535#issuecomment-731604290 Thanks for opening your first issue here! Be sure to follow the issue template! This is an automate

[GitHub] [airflow] github-actions[bot] commented on pull request #12534: Fixes unneeded docker-context-files added in CI

2020-11-21 Thread GitBox
github-actions[bot] commented on pull request #12534: URL: https://github.com/apache/airflow/pull/12534#issuecomment-731603323 The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it! --

[GitHub] [airflow] github-actions[bot] commented on pull request #11284: Improve GCSToSFTPOperator paths handling

2020-11-21 Thread GitBox
github-actions[bot] commented on pull request #11284: URL: https://github.com/apache/airflow/pull/11284#issuecomment-731599265 [The Workflow run](https://github.com/apache/airflow/actions/runs/376235777) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build

[GitHub] [airflow] tomasfarias commented on a change in pull request #11964: Add new datetime branch operator

2020-11-21 Thread GitBox
tomasfarias commented on a change in pull request #11964: URL: https://github.com/apache/airflow/pull/11964#discussion_r528210968 ## File path: tests/operators/test_datetime_branch_operator.py ## @@ -0,0 +1,281 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [airflow] mik-laj commented on pull request #11850: Add Telegram hook and operator

2020-11-21 Thread GitBox
mik-laj commented on pull request #11850: URL: https://github.com/apache/airflow/pull/11850#issuecomment-731593734 Building documentation for new providers does not work. I'm already working on it. See: https://github.com/apache/airflow/pull/12527 -

[GitHub] [airflow] github-actions[bot] commented on pull request #12527: Move providers docs to separate package + Spell-check in a common job with docs-build

2020-11-21 Thread GitBox
github-actions[bot] commented on pull request #12527: URL: https://github.com/apache/airflow/pull/12527#issuecomment-731592854 [The Workflow run](https://github.com/apache/airflow/actions/runs/376189649) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build

[GitHub] [airflow] potiuk commented on issue #12509: Add support for using Cloud Build in breeze build-image

2020-11-21 Thread GitBox
potiuk commented on issue #12509: URL: https://github.com/apache/airflow/issues/12509#issuecomment-731589794 Fix is in #12534. Once we merge it and I push the images it shoudl be rather fast to rebuild next time This is an a

[GitHub] [airflow] potiuk opened a new pull request #12534: Fixes unneeded docker-context-files added in CI

2020-11-21 Thread GitBox
potiuk opened a new pull request #12534: URL: https://github.com/apache/airflow/pull/12534 We do not need to add docker-context-files in CI before we run first "cache" PIP installation. Adding it might cause the effect that the cache will always be invalidated in case someone has a

[GitHub] [airflow] mik-laj edited a comment on pull request #12527: Move providers references to separate package + Spell-check in a common job with docs-build

2020-11-21 Thread GitBox
mik-laj edited a comment on pull request #12527: URL: https://github.com/apache/airflow/pull/12527#issuecomment-731568418 @potiuk The problem is that the spell check will fail because sphinx will not have the inventory file it needs. This file is only created when building documentation in

[GitHub] [airflow] github-actions[bot] commented on pull request #12512: Implement reading provider information from packages/sources

2020-11-21 Thread GitBox
github-actions[bot] commented on pull request #12512: URL: https://github.com/apache/airflow/pull/12512#issuecomment-731588111 [The Workflow run](https://github.com/apache/airflow/actions/runs/376156528) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build

[GitHub] [airflow] mik-laj commented on a change in pull request #12532: Minor changes in description of API docs

2020-11-21 Thread GitBox
mik-laj commented on a change in pull request #12532: URL: https://github.com/apache/airflow/pull/12532#discussion_r528200829 ## File path: airflow/api_connexion/openapi/v1.yaml ## @@ -2449,7 +2470,7 @@ components: properties: total_entries: type: int

[GitHub] [airflow] potiuk commented on issue #12509: Add support for using Cloud Build in breeze build-image

2020-11-21 Thread GitBox
potiuk commented on issue #12509: URL: https://github.com/apache/airflow/issues/12509#issuecomment-731584705 However It might not be needed . I have found one reason why the images after pulling might run a bit longer (docker-context-files were not empty when I built it last time), I am g

[GitHub] [airflow] mik-laj commented on pull request #12188: Upgrade azure blob to v12

2020-11-21 Thread GitBox
mik-laj commented on pull request #12188: URL: https://github.com/apache/airflow/pull/12188#issuecomment-731584448 > Manually tested with this dag: Can you add an automatic test? It shouldn't be difficult, and it will allow us to test this integration more easily. -

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #12532: Minor changes in description of API docs

2020-11-21 Thread GitBox
ephraimbuddy commented on a change in pull request #12532: URL: https://github.com/apache/airflow/pull/12532#discussion_r528200031 ## File path: airflow/api_connexion/openapi/v1.yaml ## @@ -2449,7 +2470,7 @@ components: properties: total_entries: type

[GitHub] [airflow] mik-laj commented on a change in pull request #12188: Upgrade azure blob to v12

2020-11-21 Thread GitBox
mik-laj commented on a change in pull request #12188: URL: https://github.com/apache/airflow/pull/12188#discussion_r528200052 ## File path: airflow/providers/microsoft/azure/hooks/wasb.py ## @@ -189,22 +328,16 @@ def delete_file( :param ignore_if_missing: if True, then

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #12532: Minor changes in description of API docs

2020-11-21 Thread GitBox
ephraimbuddy commented on a change in pull request #12532: URL: https://github.com/apache/airflow/pull/12532#discussion_r528200031 ## File path: airflow/api_connexion/openapi/v1.yaml ## @@ -2449,7 +2470,7 @@ components: properties: total_entries: type

[GitHub] [airflow] mik-laj commented on a change in pull request #12188: Upgrade azure blob to v12

2020-11-21 Thread GitBox
mik-laj commented on a change in pull request #12188: URL: https://github.com/apache/airflow/pull/12188#discussion_r52820 ## File path: airflow/providers/microsoft/azure/hooks/wasb.py ## @@ -163,11 +213,100 @@ def read_file(self, container_name: str, blob_name: str, **kwar

[GitHub] [airflow] mik-laj commented on a change in pull request #12188: Upgrade azure blob to v12

2020-11-21 Thread GitBox
mik-laj commented on a change in pull request #12188: URL: https://github.com/apache/airflow/pull/12188#discussion_r528199906 ## File path: airflow/providers/microsoft/azure/hooks/wasb.py ## @@ -115,12 +166,11 @@ def load_file(self, file_path: str, container_name: str, blob_na

[GitHub] [airflow] mik-laj commented on a change in pull request #12188: Upgrade azure blob to v12

2020-11-21 Thread GitBox
mik-laj commented on a change in pull request #12188: URL: https://github.com/apache/airflow/pull/12188#discussion_r528199888 ## File path: airflow/providers/microsoft/azure/hooks/wasb.py ## @@ -16,94 +16,145 @@ # specific language governing permissions and limitations # unde

[GitHub] [airflow] mik-laj commented on a change in pull request #12188: Upgrade azure blob to v12

2020-11-21 Thread GitBox
mik-laj commented on a change in pull request #12188: URL: https://github.com/apache/airflow/pull/12188#discussion_r528199853 ## File path: airflow/providers/microsoft/azure/hooks/wasb.py ## @@ -16,94 +16,145 @@ # specific language governing permissions and limitations # unde

[GitHub] [airflow] mik-laj commented on a change in pull request #12188: Upgrade azure blob to v12

2020-11-21 Thread GitBox
mik-laj commented on a change in pull request #12188: URL: https://github.com/apache/airflow/pull/12188#discussion_r528199826 ## File path: airflow/providers/microsoft/azure/hooks/wasb.py ## @@ -16,94 +16,145 @@ # specific language governing permissions and limitations # unde

[GitHub] [airflow] mik-laj commented on a change in pull request #12188: Upgrade azure blob to v12

2020-11-21 Thread GitBox
mik-laj commented on a change in pull request #12188: URL: https://github.com/apache/airflow/pull/12188#discussion_r528199809 ## File path: airflow/providers/microsoft/azure/hooks/wasb.py ## @@ -16,94 +16,145 @@ # specific language governing permissions and limitations # unde

  1   2   >