[GitHub] [airflow] ephraimbuddy commented on pull request #15537: Fix on_failure_callback when task receive SIGKILL

2021-04-29 Thread GitBox
ephraimbuddy commented on pull request #15537: URL: https://github.com/apache/airflow/pull/15537#issuecomment-829859217 > Can `test_process_kill_call_on_failure_callback` and `test_process_sigkill_call_on_failure_callback` be combined with `pytest.mark.parametrize()`? They look much too

[GitHub] [airflow] github-actions[bot] commented on pull request #14521: Add Asana Provider

2021-04-29 Thread GitBox
github-actions[bot] commented on pull request #14521: URL: https://github.com/apache/airflow/pull/14521#issuecomment-829798788 [The Workflow run](https://github.com/apache/airflow/actions/runs/798154750) is cancelling this PR. Building images for the PR has failed. Follow the workflow

[GitHub] [airflow] wolfier commented on pull request #15183: Move common pitfall documentation to Airflow docs

2021-04-29 Thread GitBox
wolfier commented on pull request #15183: URL: https://github.com/apache/airflow/pull/15183#issuecomment-829796839 @eladkal and @marcosmarxm and @kaxil, please review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #15609: Update s3.py

2021-04-29 Thread GitBox
boring-cyborg[bot] commented on pull request #15609: URL: https://github.com/apache/airflow/pull/15609#issuecomment-829761790 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] Isaacwhyuenac opened a new pull request #15609: Update s3.py

2021-04-29 Thread GitBox
Isaacwhyuenac opened a new pull request #15609: URL: https://github.com/apache/airflow/pull/15609 The changes improves the process of finding the S3 files and gives developer the freedom to list what they want. For example, suppose in s3 bucket there are ``` 2021-04-30

[GitHub] [airflow] luoyuliuyin opened a new issue #15608: airflow dag support multiple versions

2021-04-29 Thread GitBox
luoyuliuyin opened a new issue #15608: URL: https://github.com/apache/airflow/issues/15608 **Description** Suppose I created a dag yesterday, and Its structure is: task_a >> task_b Today I updated the structure of dag to: task_c >> task_d >> task_e I need to

[GitHub] [airflow] boring-cyborg[bot] commented on issue #15608: airflow dag support multiple versions

2021-04-29 Thread GitBox
boring-cyborg[bot] commented on issue #15608: URL: https://github.com/apache/airflow/issues/15608#issuecomment-829756085 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] jedcunningham commented on a change in pull request #15606: Use latest version of `git-sync` image

2021-04-29 Thread GitBox
jedcunningham commented on a change in pull request #15606: URL: https://github.com/apache/airflow/pull/15606#discussion_r623541860 ## File path: chart/values.yaml ## @@ -150,7 +150,7 @@ images: pullPolicy: IfNotPresent gitSync: repository: k8s.gcr.io/git-sync

[GitHub] [airflow] trollhe commented on issue #15607: airflow throws error: airflow.exceptions.SerializedDagNotFound: DAG 'dns-basic-1min' not found in serialized_dag table

2021-04-29 Thread GitBox
trollhe commented on issue #15607: URL: https://github.com/apache/airflow/issues/15607#issuecomment-829738425 only webserver and schedule service in one container,else have the error.but need modify dag file,i don`t know how can serialized_dag after dag file modify. -- This is an

[GitHub] [airflow] dimberman commented on issue #13643: Improve annotations customization in the chart

2021-04-29 Thread GitBox
dimberman commented on issue #13643: URL: https://github.com/apache/airflow/issues/13643#issuecomment-829737801 @FloChehab sounds good let me know where I can help! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[airflow] branch master updated: Fix parallelism after KubeExecutor pod adoption (#15555)

2021-04-29 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 9c296c9 Fix parallelism after KubeExecutor

[GitHub] [airflow] dimberman merged pull request #15555: Fix parallelism after KubeExecutor pod adoption

2021-04-29 Thread GitBox
dimberman merged pull request #1: URL: https://github.com/apache/airflow/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow] trollhe opened a new issue #15607: airflow throws error: airflow.exceptions.SerializedDagNotFound: DAG 'dns-basic-1min' not found in serialized_dag table

2021-04-29 Thread GitBox
trollhe opened a new issue #15607: URL: https://github.com/apache/airflow/issues/15607 hi,team: i deployment airflow 2.0.2 in docker by docker-compose,airflow service start just 1 minute have many dags,bug 1 minute after dag is none,and throws bellow error: already

[GitHub] [airflow] dimberman commented on issue #12813: Attempting to read an xcom produced by KubernetesPodOperator results in UnicodeDecodeError

2021-04-29 Thread GitBox
dimberman commented on issue #12813: URL: https://github.com/apache/airflow/issues/12813#issuecomment-829737575 Hi @Dr-Denzy @ephraimbuddy any update on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] github-actions[bot] closed pull request #14650: Fix the log level from error to info

2021-04-29 Thread GitBox
github-actions[bot] closed pull request #14650: URL: https://github.com/apache/airflow/pull/14650 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [airflow] kaxil opened a new pull request #15606: Use latest version of `git-sync` image

2021-04-29 Thread GitBox
kaxil opened a new pull request #15606: URL: https://github.com/apache/airflow/pull/15606 This commit changes `git-sync` container image from `3.1.6` to `3.3.0` (the latest version) https://github.com/kubernetes/git-sync/releases --- **^ Add meaningful description

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #15605: Update SimpleHttpOperator to take auth type object

2021-04-29 Thread GitBox
boring-cyborg[bot] commented on pull request #15605: URL: https://github.com/apache/airflow/pull/15605#issuecomment-829711871 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] github-actions[bot] commented on issue #14931: sqlite3.databaseerror database disk image is malformed in airflow

2021-04-29 Thread GitBox
github-actions[bot] commented on issue #14931: URL: https://github.com/apache/airflow/issues/14931#issuecomment-829707408 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] kaxil opened a new pull request #15603: Chart: Change default executor to ``CeleryExecutor``

2021-04-29 Thread GitBox
kaxil opened a new pull request #15603: URL: https://github.com/apache/airflow/pull/15603 ``CeleryExecutor`` is currently the most stable of all, so it should be the default when using the Helm Chart. --- **^ Add meaningful description above** Read the **[Pull

[GitHub] [airflow] fredthomsen commented on pull request #15605: Update SimpleHttpOperator to take auth type object

2021-04-29 Thread GitBox
fredthomsen commented on pull request #15605: URL: https://github.com/apache/airflow/pull/15605#issuecomment-829717194 This does address issue #259, although given it's age, I doubt that is relevant now. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] fredthomsen opened a new pull request #15605: Update SimpleHttpOperator to take auth type object

2021-04-29 Thread GitBox
fredthomsen opened a new pull request #15605: URL: https://github.com/apache/airflow/pull/15605 A requests.auth.AuthBase object is not passed through from the SimpleHttpOperator to the underlying HttpHook, thus if you want to use the SimpleHttpOperator but have a custom auth_type, you

[GitHub] [airflow] rpfernandezjr commented on issue #15580: KubernetesExecutor not deleting worker pods on completion.

2021-04-29 Thread GitBox
rpfernandezjr commented on issue #15580: URL: https://github.com/apache/airflow/issues/15580#issuecomment-829699581 Was messing with this today some more. If I set `AIRFLOW__KUBERNETES__POD_TEMPLATE_FILE` and point that to this template file ``` --- apiVersion: v1 kind:

[GitHub] [airflow] kaxil commented on a change in pull request #15093: Add support to create airflow pools from chart values

2021-04-29 Thread GitBox
kaxil commented on a change in pull request #15093: URL: https://github.com/apache/airflow/pull/15093#discussion_r623500301 ## File path: chart/templates/create-pools-job.yaml ## @@ -0,0 +1,90 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] boring-cyborg[bot] commented on issue #15604: BigQueryCreateExternalTableOperator table_resource parameter is impossible to use

2021-04-29 Thread GitBox
boring-cyborg[bot] commented on issue #15604: URL: https://github.com/apache/airflow/issues/15604#issuecomment-829710977 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[airflow] branch master updated: Fix KEDA Autoscaler ``connectionFromEnv`` (#15561)

2021-04-29 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 924af8d Fix KEDA Autoscaler

[GitHub] [airflow] github-actions[bot] closed issue #14931: sqlite3.databaseerror database disk image is malformed in airflow

2021-04-29 Thread GitBox
github-actions[bot] closed issue #14931: URL: https://github.com/apache/airflow/issues/14931 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [airflow] github-actions[bot] commented on pull request #14745: Make sure DAGs with tasks in shutdown state do get scheduled

2021-04-29 Thread GitBox
github-actions[bot] commented on pull request #14745: URL: https://github.com/apache/airflow/pull/14745#issuecomment-829707435 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank

[GitHub] [airflow] fredthomsen edited a comment on pull request #15605: Update SimpleHttpOperator to take auth type object

2021-04-29 Thread GitBox
fredthomsen edited a comment on pull request #15605: URL: https://github.com/apache/airflow/pull/15605#issuecomment-829717194 This does address issue #259, although given it's age, I doubt that is relevant now, which is why I did not include it above. -- This is an automated message

[GitHub] [airflow] kaxil merged pull request #15561: Fix KEDA Autoscaler connectionFromEnv

2021-04-29 Thread GitBox
kaxil merged pull request #15561: URL: https://github.com/apache/airflow/pull/15561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow] github-actions[bot] commented on pull request #14786: Running tests in parallel

2021-04-29 Thread GitBox
github-actions[bot] commented on pull request #14786: URL: https://github.com/apache/airflow/pull/14786#issuecomment-829707419 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #15561: Fix KEDA Autoscaler connectionFromEnv

2021-04-29 Thread GitBox
boring-cyborg[bot] commented on pull request #15561: URL: https://github.com/apache/airflow/pull/15561#issuecomment-829686358 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] dougpm opened a new issue #15604: BigQueryCreateExternalTableOperator table_resource parameter is impossible to use

2021-04-29 Thread GitBox
dougpm opened a new issue #15604: URL: https://github.com/apache/airflow/issues/15604 **Apache Airflow version**: 1.10.14 **What happened**: I specified the table_resource parameter in BigQueryCreateExternalTableOperator. **What you expected to happen**:

[GitHub] [airflow] pgzmnk opened a new pull request #15602: Update KylinHook docstring

2021-04-29 Thread GitBox
pgzmnk opened a new pull request #15602: URL: https://github.com/apache/airflow/pull/15602 Add short description to KylinHook. --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] anmtan opened a new issue #15601: Access is denied alert after successfully login using OIDC

2021-04-29 Thread GitBox
anmtan opened a new issue #15601: URL: https://github.com/apache/airflow/issues/15601 **Apache Airflow version**: 2.0.1 **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): 1.19 **Environment**: Kubernetes Executor, Okta OIDC

[GitHub] [airflow] boring-cyborg[bot] commented on issue #15601: Access is denied alert after successfully login using OIDC

2021-04-29 Thread GitBox
boring-cyborg[bot] commented on issue #15601: URL: https://github.com/apache/airflow/issues/15601#issuecomment-829655186 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] wolfier opened a new issue #15600: Sentry missing exception capture and captured exception missing tags

2021-04-29 Thread GitBox
wolfier opened a new issue #15600: URL: https://github.com/apache/airflow/issues/15600 **Apache Airflow version**: 2.0.0 **Executor**: KubernetesExecutor **What happened**: One of my tasks failed to have the task metadata as tags when the exception was captured by

[GitHub] [airflow] kaxil commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-29 Thread GitBox
kaxil commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r623453566 ## File path: chart/tests/test_rbac.py ## @@ -0,0 +1,294 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

[GitHub] [airflow] github-actions[bot] commented on pull request #15562: Fix changing the parent dag state on subdag clear

2021-04-29 Thread GitBox
github-actions[bot] commented on pull request #15562: URL: https://github.com/apache/airflow/pull/15562#issuecomment-829646280 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] kaxil commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-29 Thread GitBox
kaxil commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r623449476 ## File path: chart/tests/test_annotations.py ## @@ -0,0 +1,129 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [airflow] kaxil commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-29 Thread GitBox
kaxil commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r623447730 ## File path: chart/templates/statsd/statsd-serviceaccount.yaml ## @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [airflow] zarrarrana commented on pull request #15562: Fix changing the parent dag state on subdag clear

2021-04-29 Thread GitBox
zarrarrana commented on pull request #15562: URL: https://github.com/apache/airflow/pull/15562#issuecomment-829639213 @kaxil @ashb I accidently closed the PR, could you approve the CI workflow again. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] kaxil commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-29 Thread GitBox
kaxil commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r623445885 ## File path: chart/values.yaml ## @@ -427,6 +453,20 @@ scheduler: affinity: {} tolerations: [] +# Airflow migration and create user job settings

[GitHub] [airflow] kaxil commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-29 Thread GitBox
kaxil commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r623416129 ## File path: chart/templates/_helpers.yaml ## @@ -364,6 +383,105 @@ server_tls_key_file = /etc/pgbouncer/server.key {{ (printf "%s-airflow-config"

[airflow] branch master updated (ff4b7c4 -> 5045419)

2021-04-29 Thread dstandish
This is an automated email from the ASF dual-hosted git repository. dstandish pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from ff4b7c4 Adds log persistence to helm chart (#15595) add 5045419 Remove odbc dependency in microsoft.mssql

[GitHub] [airflow] dstandish merged pull request #15594: Remove odbc dependency in microsoft.mssql provider

2021-04-29 Thread GitBox
dstandish merged pull request #15594: URL: https://github.com/apache/airflow/pull/15594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow] github-actions[bot] commented on pull request #15599: Mask passwords

2021-04-29 Thread GitBox
github-actions[bot] commented on pull request #15599: URL: https://github.com/apache/airflow/pull/15599#issuecomment-829636244 [The Workflow run](https://github.com/apache/airflow/actions/runs/797647556) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static

[GitHub] [airflow] zarrarrana closed pull request #15562: Fix changing the parent dag state on subdag clear

2021-04-29 Thread GitBox
zarrarrana closed pull request #15562: URL: https://github.com/apache/airflow/pull/15562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow] zarrarrana commented on pull request #15562: Fix changing the parent dag state on subdag clear

2021-04-29 Thread GitBox
zarrarrana commented on pull request #15562: URL: https://github.com/apache/airflow/pull/15562#issuecomment-829636037 @ashb @kaxil please review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] kaxil commented on issue #8421: Hide sensitive data in UI

2021-04-29 Thread GitBox
kaxil commented on issue #8421: URL: https://github.com/apache/airflow/issues/8421#issuecomment-829630275 > What needs to be done to hide sensitive data in logs? There’s already permission to hide task logs (`RESOURCE_TASK_LOG`). See https://github.com/apache/airflow/pull/15599 --

[GitHub] [airflow] github-actions[bot] commented on pull request #15594: Remove odbc dependency in microsoft.mssql provider

2021-04-29 Thread GitBox
github-actions[bot] commented on pull request #15594: URL: https://github.com/apache/airflow/pull/15594#issuecomment-829622626 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[airflow] branch master updated (18ead33 -> ff4b7c4)

2021-04-29 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 18ead33 Change helm chart logging level back to default (INFO) (#15597) add ff4b7c4 Adds log persistence

[GitHub] [airflow] kaxil merged pull request #15595: Adds log persistence to helm chart

2021-04-29 Thread GitBox
kaxil merged pull request #15595: URL: https://github.com/apache/airflow/pull/15595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow] kaxil commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-29 Thread GitBox
kaxil commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r623417179 ## File path: chart/values.yaml ## @@ -427,6 +453,20 @@ scheduler: affinity: {} tolerations: [] +# Airflow migration and create user job settings

[GitHub] [airflow] kaxil commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-29 Thread GitBox
kaxil commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r623416129 ## File path: chart/templates/_helpers.yaml ## @@ -364,6 +383,105 @@ server_tls_key_file = /etc/pgbouncer/server.key {{ (printf "%s-airflow-config"

[GitHub] [airflow] malthe commented on pull request #15589: [Oracle] Add port to DSN

2021-04-29 Thread GitBox
malthe commented on pull request #15589: URL: https://github.com/apache/airflow/pull/15589#issuecomment-829608618 @potiuk I have cleaned up the docs and code to emphasize that _Host_ and _Schema_ (and the rest of the standard fields) are perfectly good for most users. If a user has

[GitHub] [airflow] ashb opened a new pull request #15599: Mask passwords

2021-04-29 Thread GitBox
ashb opened a new pull request #15599: URL: https://github.com/apache/airflow/pull/15599 Mask secret values from connections and variables This masks secret values in logs for Connections and Variables. It behaves as follows: - Connection

[airflow] branch master updated (df143ae -> 18ead33)

2021-04-29 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from df143ae An initial rework of the "Concepts" docs (#15444) add 18ead33 Change helm chart logging level

[GitHub] [airflow] kaxil merged pull request #15597: Change helm chart logging level back to default (INFO)

2021-04-29 Thread GitBox
kaxil merged pull request #15597: URL: https://github.com/apache/airflow/pull/15597 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow] github-actions[bot] commented on pull request #15595: Adds log persistence to helm chart

2021-04-29 Thread GitBox
github-actions[bot] commented on pull request #15595: URL: https://github.com/apache/airflow/pull/15595#issuecomment-829605752 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] kaxil commented on a change in pull request #15595: Adds log persistence to helm chart

2021-04-29 Thread GitBox
kaxil commented on a change in pull request #15595: URL: https://github.com/apache/airflow/pull/15595#discussion_r623409574 ## File path: docs/helm-chart/manage-logs.rst ## @@ -0,0 +1,89 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] [airflow] boring-cyborg[bot] commented on issue #15598: Qubole Hook Does Not Support 'include_headers'

2021-04-29 Thread GitBox
boring-cyborg[bot] commented on issue #15598: URL: https://github.com/apache/airflow/issues/15598#issuecomment-829593473 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] levyitay opened a new issue #15598: Qubole Hook Does Not Support 'include_headers'

2021-04-29 Thread GitBox
levyitay opened a new issue #15598: URL: https://github.com/apache/airflow/issues/15598 **Description** Qubole Hook and Operator do not support `include_header` param for getting results with headers Add Support for `include_header` get_results(... arguments=[True])

[GitHub] [airflow] DerekHeldtWerle commented on pull request #15238: adds airflowConfigAnnotations field to allow for the setting of the main configmaps annotations

2021-04-29 Thread GitBox
DerekHeldtWerle commented on pull request #15238: URL: https://github.com/apache/airflow/pull/15238#issuecomment-829593227 @FloChehab in our multi-tenant setup, airflow dags run in each teams namespace. With these annotations, we can easily replicate the airflow configmap to each

[GitHub] [airflow] malthe commented on pull request #15589: [Oracle] Add port to DSN

2021-04-29 Thread GitBox
malthe commented on pull request #15589: URL: https://github.com/apache/airflow/pull/15589#issuecomment-829590431 @potiuk just a quick question – the Oracle-specific fields in the connection documentation (e.g. "Sid" and "Service_name"), those don't make sense to me at all looking at:

[GitHub] [airflow] jedcunningham opened a new pull request #15597: Change helm chart logging level back to default (INFO)

2021-04-29 Thread GitBox
jedcunningham opened a new pull request #15597: URL: https://github.com/apache/airflow/pull/15597 The chart shouldn't default the logging level to DEBUG. Instead, we will elect DEBUG when we are running with breeze and let normal releases use the Airflow default of INFO. -- This is

[GitHub] [airflow] DerekHeldtWerle commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-29 Thread GitBox
DerekHeldtWerle commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r623386662 ## File path: chart/values.yaml ## @@ -427,6 +453,20 @@ scheduler: affinity: {} tolerations: [] +# Airflow migration and create user

[jira] [Commented] (AIRFLOW-6296) add mssql odbc hook

2021-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335812#comment-17335812 ] ASF GitHub Bot commented on AIRFLOW-6296: - dstandish edited a comment on pull request #6850:

[GitHub] [airflow] dstandish edited a comment on pull request #6850: [AIRFLOW-6296] add ODBC hook & deprecation warning for pymssql

2021-04-29 Thread GitBox
dstandish edited a comment on pull request #6850: URL: https://github.com/apache/airflow/pull/6850#issuecomment-829515009 @eladkal for background, the original thought was that we would deprecate support for pymssql and switch to pyodbc since the pymssql project, at the time, had been

[jira] [Commented] (AIRFLOW-6296) add mssql odbc hook

2021-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335811#comment-17335811 ] ASF GitHub Bot commented on AIRFLOW-6296: - dstandish commented on pull request #6850: URL:

[GitHub] [airflow] dstandish commented on pull request #6850: [AIRFLOW-6296] add ODBC hook & deprecation warning for pymssql

2021-04-29 Thread GitBox
dstandish commented on pull request #6850: URL: https://github.com/apache/airflow/pull/6850#issuecomment-829582644 OK @eladkal i think in #15594 i have successfully removed the interdependency while maintaining verification of _compatibility_ in the mssql operator test. Please take

[GitHub] [airflow] jscheffl commented on issue #15023: DAG task execution and API fails if dag_run.conf is provided with an array or string (instead of dict)

2021-04-29 Thread GitBox
jscheffl commented on issue #15023: URL: https://github.com/apache/airflow/issues/15023#issuecomment-829574269 Hi @ashb I saw that my proposed bugfix/PR was pushed from Airflow 2.0.2 to 2.0.3. Is there any reason why this is not merged yet? Lag in quality? Do I need to push something

[GitHub] [airflow] argibbs opened a new issue #15596: Using SLAs causes DagFileProcessorManager timeouts and prevents deleted dags from being recreated

2021-04-29 Thread GitBox
argibbs opened a new issue #15596: URL: https://github.com/apache/airflow/issues/15596 **Apache Airflow version**: 2.0.1 and 2.0.2 **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): N/A **Environment**: Celery executors, Redis + Postgres -

[GitHub] [airflow] boring-cyborg[bot] commented on issue #15596: Using SLAs causes DagFileProcessorManager timeouts and prevents deleted dags from being recreated

2021-04-29 Thread GitBox
boring-cyborg[bot] commented on issue #15596: URL: https://github.com/apache/airflow/issues/15596#issuecomment-829569460 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] ashb merged pull request #15444: An initial rework of the "Concepts" documentation

2021-04-29 Thread GitBox
ashb merged pull request #15444: URL: https://github.com/apache/airflow/pull/15444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow] jedcunningham opened a new pull request #15595: Adds log persistence to helm chart

2021-04-29 Thread GitBox
jedcunningham opened a new pull request #15595: URL: https://github.com/apache/airflow/pull/15595 This adds the option to use a PVC (one provisioned by the chart or an existing claim) to persist Airflow logs. This provides an executor agnostic way to persist all of the Airflow logs.

[GitHub] [airflow] dstandish opened a new pull request #15594: Put odbc import behind guard in MsSqlOperator

2021-04-29 Thread GitBox
dstandish opened a new pull request #15594: URL: https://github.com/apache/airflow/pull/15594 MsSqlOperator uses odbc hook when conn_type = 'odbc' The import here of OdbcHook, used only for type hinting, should be behind `TYPE_CHECKING` guard see:

[GitHub] [airflow] kaxil commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-29 Thread GitBox
kaxil commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r62603 ## File path: chart/values.yaml ## @@ -427,6 +453,20 @@ scheduler: affinity: {} tolerations: [] +# Airflow migration and create user job settings

[jira] [Commented] (AIRFLOW-6296) add mssql odbc hook

2021-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335784#comment-17335784 ] ASF GitHub Bot commented on AIRFLOW-6296: - dstandish edited a comment on pull request #6850:

[GitHub] [airflow] dstandish edited a comment on pull request #6850: [AIRFLOW-6296] add ODBC hook & deprecation warning for pymssql

2021-04-29 Thread GitBox
dstandish edited a comment on pull request #6850: URL: https://github.com/apache/airflow/pull/6850#issuecomment-829515009 @eladkal TLDR it seems like we should be able to remove that interdependency by putting this line behind an `if TYPE_CHECKING` guard:

[GitHub] [airflow] bensonnd commented on issue #15580: KubernetesExecutor not deleting worker pods on completion.

2021-04-29 Thread GitBox
bensonnd commented on issue #15580: URL: https://github.com/apache/airflow/issues/15580#issuecomment-829522449 Commenting to follow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (AIRFLOW-6296) add mssql odbc hook

2021-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335768#comment-17335768 ] ASF GitHub Bot commented on AIRFLOW-6296: - dstandish edited a comment on pull request #6850:

[GitHub] [airflow] dstandish edited a comment on pull request #6850: [AIRFLOW-6296] add ODBC hook & deprecation warning for pymssql

2021-04-29 Thread GitBox
dstandish edited a comment on pull request #6850: URL: https://github.com/apache/airflow/pull/6850#issuecomment-829515009 @eladkal TLDR it seems like we should be able to remove that interdependency by putting this line behind an `if TYPING` guard:

[jira] [Commented] (AIRFLOW-6296) add mssql odbc hook

2021-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335767#comment-17335767 ] ASF GitHub Bot commented on AIRFLOW-6296: - dstandish edited a comment on pull request #6850:

[jira] [Commented] (AIRFLOW-6296) add mssql odbc hook

2021-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335766#comment-17335766 ] ASF GitHub Bot commented on AIRFLOW-6296: - dstandish commented on pull request #6850: URL:

[GitHub] [airflow] dstandish edited a comment on pull request #6850: [AIRFLOW-6296] add ODBC hook & deprecation warning for pymssql

2021-04-29 Thread GitBox
dstandish edited a comment on pull request #6850: URL: https://github.com/apache/airflow/pull/6850#issuecomment-829515009 @eladkal TLDR it seems like we should be able to remove that interdependency by putting this line behind an `if TYPING` guard:

[GitHub] [airflow] dstandish commented on pull request #6850: [AIRFLOW-6296] add ODBC hook & deprecation warning for pymssql

2021-04-29 Thread GitBox
dstandish commented on pull request #6850: URL: https://github.com/apache/airflow/pull/6850#issuecomment-829515009 TLDR it seems like we should be able to remove that interdependency by putting this line behind an `if TYPING` guard:

[GitHub] [airflow] ahayasic commented on issue #12309: TaskGroup does not support dynamically generated tasks

2021-04-29 Thread GitBox
ahayasic commented on issue #12309: URL: https://github.com/apache/airflow/issues/12309#issuecomment-829507253 @ssiddiqui-apixio I'm having the same problem on Airflow 2.0.2. Any chance of the Issue being reopened for a new solution? -- This is an automated message from the Apache Git

[GitHub] [airflow] github-actions[bot] commented on pull request #15238: adds airflowConfigAnnotations field to allow for the setting of the main configmaps annotations

2021-04-29 Thread GitBox
github-actions[bot] commented on pull request #15238: URL: https://github.com/apache/airflow/pull/15238#issuecomment-829494527 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] kaxil commented on pull request #15238: adds airflowConfigAnnotations field to allow for the setting of the main configmaps annotations

2021-04-29 Thread GitBox
kaxil commented on pull request #15238: URL: https://github.com/apache/airflow/pull/15238#issuecomment-829493407 @DerekHeldtWerle Can you fix the failing static checks please: https://github.com/apache/airflow/pull/15238/checks?check_run_id=2301349726#step:10:245 ```diff diff

[GitHub] [airflow] turbaszek commented on a change in pull request #14521: Add Asana Provider

2021-04-29 Thread GitBox
turbaszek commented on a change in pull request #14521: URL: https://github.com/apache/airflow/pull/14521#discussion_r623285483 ## File path: airflow/providers/asana/hooks/asana.py ## @@ -0,0 +1,271 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] turbaszek commented on a change in pull request #14521: Add Asana Provider

2021-04-29 Thread GitBox
turbaszek commented on a change in pull request #14521: URL: https://github.com/apache/airflow/pull/14521#discussion_r623283331 ## File path: airflow/providers/asana/hooks/asana.py ## @@ -0,0 +1,271 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] potiuk opened a new pull request #15593: Add docker-context-files detection and cleanup flag.

2021-04-29 Thread GitBox
potiuk opened a new pull request #15593: URL: https://github.com/apache/airflow/pull/15593 When building images for production we are using docker-context-files where we build packages to install. However if those context files are not cleaned up, they unnecessary increase size and

[GitHub] [airflow] DerekHeldtWerle commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-29 Thread GitBox
DerekHeldtWerle commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r623262956 ## File path: chart/tests/test_annotations.py ## @@ -0,0 +1,129 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] DerekHeldtWerle commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-29 Thread GitBox
DerekHeldtWerle commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r623262956 ## File path: chart/tests/test_annotations.py ## @@ -0,0 +1,129 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[airflow] branch master updated: add an option to trigger a dag w/o changing conf (#15591)

2021-04-29 Thread ryanahamilton
This is an automated email from the ASF dual-hosted git repository. ryanahamilton pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 943e3ca add an option to trigger a dag

[GitHub] [airflow] ryanahamilton merged pull request #15591: Add ability to quickly trigger a DAG

2021-04-29 Thread GitBox
ryanahamilton merged pull request #15591: URL: https://github.com/apache/airflow/pull/15591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [airflow] potiuk edited a comment on pull request #15589: [Oracle] Add port to DSN

2021-04-29 Thread GitBox
potiuk edited a comment on pull request #15589: URL: https://github.com/apache/airflow/pull/15589#issuecomment-829428066 > So if we want host:port/ to be translated back to host:port/, then it seems conn.schema is the way to go. Hmm. I think this is not how (at least originally) the

[GitHub] [airflow] potiuk edited a comment on pull request #15589: [Oracle] Add port to DSN

2021-04-29 Thread GitBox
potiuk edited a comment on pull request #15589: URL: https://github.com/apache/airflow/pull/15589#issuecomment-829428066 > So if we want host:port/ to be translated back to host:port/, then it seems conn.schema is the way to go. Hmm. I think this is not how (at least originally) the

[GitHub] [airflow] potiuk edited a comment on pull request #15589: [Oracle] Add port to DSN

2021-04-29 Thread GitBox
potiuk edited a comment on pull request #15589: URL: https://github.com/apache/airflow/pull/15589#issuecomment-829428066 > So if we want host:port/ to be translated back to host:port/, then it seems conn.schema is the way to go. Hmm. I think this is not how (at least originally) the

[GitHub] [airflow] potiuk commented on pull request #15589: [Oracle] Add port to DSN

2021-04-29 Thread GitBox
potiuk commented on pull request #15589: URL: https://github.com/apache/airflow/pull/15589#issuecomment-829428066 > So if we want host:port/ to be translated back to host:port/, then it seems conn.schema is the way to go. Hmm. I think this is not how (at least originally) the oracle

  1   2   >