[airflow] branch main updated (dbeec89 -> 70bf1b1)

2021-06-10 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from dbeec89 Refactor: `SKIPPED` shouldn't be logged again as `SUCCESS`. (#14822) add 70bf1b1 Fix normalize-url

[airflow-client-python] branch master updated: Add NOTICE file (#25)

2021-06-10 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow-client-python.git The following commit(s) were added to refs/heads/master by this push: new bf439f3 Add NOTICE file

[airflow-client-python] branch kaxil-patch-1 updated (8ad3c66 -> 1d38b0b)

2021-06-10 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch kaxil-patch-1 in repository https://gitbox.apache.org/repos/asf/airflow-client-python.git. from 8ad3c66 Add NOTICE file add 1d38b0b Update setup.cfg No new revisions were added by

[GitHub] [airflow-client-python] kaxil opened a new pull request #25: Add NOTICE file

2021-06-10 Thread GitBox
kaxil opened a new pull request #25: URL: https://github.com/apache/airflow-client-python/pull/25 closes https://github.com/apache/airflow-client-python/issues/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[airflow-client-python] branch kaxil-patch-1 created (now 8ad3c66)

2021-06-10 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch kaxil-patch-1 in repository https://gitbox.apache.org/repos/asf/airflow-client-python.git. at 8ad3c66 Add NOTICE file This branch includes the following new commits: new 8ad3c66

[airflow-client-python] 01/01: Add NOTICE file

2021-06-10 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch kaxil-patch-1 in repository https://gitbox.apache.org/repos/asf/airflow-client-python.git commit 8ad3c66eba3bb6703ef590c06a8432537f61a739 Author: Kaxil Naik AuthorDate: Fri Jun 11 00:22:42

[GitHub] [airflow-client-python] kaxil opened a new issue #24: Add NOTICE file

2021-06-10 Thread GitBox
kaxil opened a new issue #24: URL: https://github.com/apache/airflow-client-python/issues/24 Add NOTICE file similar to https://github.com/apache/airflow/blob/main/chart/NOTICE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] github-actions[bot] commented on pull request #16327: Make job name check optional in SageMakerTrainingOperator

2021-06-10 Thread GitBox
github-actions[bot] commented on pull request #16327: URL: https://github.com/apache/airflow/pull/16327#issuecomment-859147260 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] SamWheating edited a comment on pull request #14306: Adding `only_active` parameter to /dags endpoint

2021-06-10 Thread GitBox
SamWheating edited a comment on pull request #14306: URL: https://github.com/apache/airflow/pull/14306#issuecomment-859116694 Ah, looks like the original issue leading to this PR was fixed in https://github.com/apache/airflow/pull/16318, which prevents the API endpoint from ever returning

[GitHub] [airflow] SamWheating edited a comment on pull request #14306: Adding `only_active` parameter to /dags endpoint

2021-06-10 Thread GitBox
SamWheating edited a comment on pull request #14306: URL: https://github.com/apache/airflow/pull/14306#issuecomment-859116694 Ah, looks like the original issue leading to this PR was fixed in https://github.com/apache/airflow/pull/16318, which prevents the API endpoint from ever returning

[GitHub] [airflow] SamWheating commented on pull request #14306: Adding `only_active` parameter to /dags endpoint

2021-06-10 Thread GitBox
SamWheating commented on pull request #14306: URL: https://github.com/apache/airflow/pull/14306#issuecomment-859116694 Ah, looks like the original issue leading to this PR was fixed in https://github.com/apache/airflow/pull/16318, which prevents the API endpoint from ever returning

[GitHub] [airflow] ephraimbuddy commented on pull request #16358: Only create dagruns when max_active_runs is not reached

2021-06-10 Thread GitBox
ephraimbuddy commented on pull request #16358: URL: https://github.com/apache/airflow/pull/16358#issuecomment-859116510 > I haven't looked into the details. But based on the idea I get from the PR subject, this may affect the DAGs whose 'catchup' is False It works fine in both I

[GitHub] [airflow] kaxil closed pull request #14440: Bump openapi-spec-validator to 0.3

2021-06-10 Thread GitBox
kaxil closed pull request #14440: URL: https://github.com/apache/airflow/pull/14440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow] kaxil commented on a change in pull request #16182: Do not queue tasks when the DAG file goes missing

2021-06-10 Thread GitBox
kaxil commented on a change in pull request #16182: URL: https://github.com/apache/airflow/pull/16182#discussion_r649565887 ## File path: airflow/models/dagbag.py ## @@ -166,6 +166,36 @@ def dag_ids(self) -> List[str]: """ return list(self.dags.keys()) +

[GitHub] [airflow] jedcunningham commented on a change in pull request #16368: Don't show stale Serialized DAGs if they are deleted in DB

2021-06-10 Thread GitBox
jedcunningham commented on a change in pull request #16368: URL: https://github.com/apache/airflow/pull/16368#discussion_r649565547 ## File path: airflow/models/dagbag.py ## @@ -199,7 +201,13 @@ def get_dag(self, dag_id, session: Session = None):

[GitHub] [airflow] kaxil commented on a change in pull request #16182: Do not queue tasks when the DAG file goes missing

2021-06-10 Thread GitBox
kaxil commented on a change in pull request #16182: URL: https://github.com/apache/airflow/pull/16182#discussion_r649564351 ## File path: airflow/jobs/scheduler_job.py ## @@ -1417,6 +1420,42 @@ def _clean_tis_without_dagrun(self, session): raise

[GitHub] [airflow] kaxil commented on a change in pull request #16182: Do not queue tasks when the DAG file goes missing

2021-06-10 Thread GitBox
kaxil commented on a change in pull request #16182: URL: https://github.com/apache/airflow/pull/16182#discussion_r649563576 ## File path: airflow/jobs/scheduler_job.py ## @@ -1417,6 +1420,42 @@ def _clean_tis_without_dagrun(self, session): raise

[GitHub] [airflow] kaxil commented on a change in pull request #16182: Do not queue tasks when the DAG file goes missing

2021-06-10 Thread GitBox
kaxil commented on a change in pull request #16182: URL: https://github.com/apache/airflow/pull/16182#discussion_r649563576 ## File path: airflow/jobs/scheduler_job.py ## @@ -1417,6 +1420,42 @@ def _clean_tis_without_dagrun(self, session): raise

[GitHub] [airflow] boring-cyborg[bot] commented on issue #16379: Airflow Stable REST API [GET api/v1/pools] issue

2021-06-10 Thread GitBox
boring-cyborg[bot] commented on issue #16379: URL: https://github.com/apache/airflow/issues/16379#issuecomment-859110898 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] rbohlmann1 opened a new issue #16379: Airflow Stable REST API [GET api/v1/pools] issue

2021-06-10 Thread GitBox
rbohlmann1 opened a new issue #16379: URL: https://github.com/apache/airflow/issues/16379 **Apache Airflow version**: v2.0.2 **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): N/A **Environment**: AWS - **Cloud provider or hardware

[GitHub] [airflow] ephraimbuddy commented on pull request #16358: Only create dagruns when max_active_runs is not reached

2021-06-10 Thread GitBox
ephraimbuddy commented on pull request #16358: URL: https://github.com/apache/airflow/pull/16358#issuecomment-859110569 > Does this PR literally restrict from staggering new dagruns of there's already running one? I don't think I understand you correctly but if you mean creating

[GitHub] [airflow] scrdest commented on pull request #11652: Support for sorting DAGs in the web UI

2021-06-10 Thread GitBox
scrdest commented on pull request #11652: URL: https://github.com/apache/airflow/pull/11652#issuecomment-859107901 > > > @scrdest can you fix these merge conflicts? If so we'll target 2.2 for this release. > > @ashb bumping since you requested changes I'm happy to in

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #16301: Fix task retries when they receive sigkill and have retries. Properly handle sigterm too

2021-06-10 Thread GitBox
ephraimbuddy commented on a change in pull request #16301: URL: https://github.com/apache/airflow/pull/16301#discussion_r649558802 ## File path: airflow/jobs/local_task_job.py ## @@ -80,14 +80,15 @@ def signal_handler(signum, frame): self.log.error("Received

[GitHub] [airflow] kaxil commented on pull request #14306: Adding `only_active` parameter to /dags endpoint

2021-06-10 Thread GitBox
kaxil commented on pull request #14306: URL: https://github.com/apache/airflow/pull/14306#issuecomment-859101221 @SamWheating can you rebase your PR once more and fix merge conflicts too please -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] kaxil commented on pull request #14822: `SKIPPED` shouldn't be logged again as `SUCCESS`.

2021-06-10 Thread GitBox
kaxil commented on pull request #14822: URL: https://github.com/apache/airflow/pull/14822#issuecomment-859100198 Static failure is fixed in master already -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[airflow] branch main updated: Refactor: `SKIPPED` shouldn't be logged again as `SUCCESS`. (#14822)

2021-06-10 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new dbeec89 Refactor: `SKIPPED` shouldn't be

[GitHub] [airflow] kaxil merged pull request #14822: `SKIPPED` shouldn't be logged again as `SUCCESS`.

2021-06-10 Thread GitBox
kaxil merged pull request #14822: URL: https://github.com/apache/airflow/pull/14822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[airflow] branch main updated: Fix broken static checks from #15915 (#16378)

2021-06-10 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new f2315bf Fix broken static checks from #15915

[GitHub] [airflow] kaxil merged pull request #16378: Fix broken static checks from #15915

2021-06-10 Thread GitBox
kaxil merged pull request #16378: URL: https://github.com/apache/airflow/pull/16378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow] github-actions[bot] commented on pull request #16378: Fix broken static checks from #15915

2021-06-10 Thread GitBox
github-actions[bot] commented on pull request #16378: URL: https://github.com/apache/airflow/pull/16378#issuecomment-859095470 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] jedcunningham opened a new pull request #16378: Fix broken static checks from #15915

2021-06-10 Thread GitBox
jedcunningham opened a new pull request #16378: URL: https://github.com/apache/airflow/pull/16378 This fixes the static checks in main that were accidentally broken in #15915. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] jedcunningham commented on issue #16060: apply_defaults doesn't run for decorated task

2021-06-10 Thread GitBox
jedcunningham commented on issue #16060: URL: https://github.com/apache/airflow/issues/16060#issuecomment-859084846 @Junnplus, did #16085 fix this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] jhtimmins merged pull request #16377: Swap out calls to find_permission_view_menu for get_permission wrapper.

2021-06-10 Thread GitBox
jhtimmins merged pull request #16377: URL: https://github.com/apache/airflow/pull/16377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[airflow] branch main updated: Swap out calls to find_permission_view_menu for get_permission wrapper. (#16377)

2021-06-10 Thread jhtimmins
This is an automated email from the ASF dual-hosted git repository. jhtimmins pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 11cf6f3 Swap out calls to

[airflow] 01/03: Ensure that we don't try to mask empty string in logs (#16057)

2021-06-10 Thread jhtimmins
This is an automated email from the ASF dual-hosted git repository. jhtimmins pushed a commit to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 789aacea36820e1e72c7962b539d57c36134910c Author: Ash Berlin-Taylor AuthorDate: Tue May 25 19:31:22 2021 +0100

[airflow] branch v2-1-test updated (779811e -> abc86c4)

2021-06-10 Thread jhtimmins
This is an automated email from the ASF dual-hosted git repository. jhtimmins pushed a change to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git. from 779811e Fill the "job_id" field for `airflow task run` without `--local`/`--raw` for KubeExecutor (#16108)

[airflow] 03/03: Don't fail to log if we can't redact something (#16118)

2021-06-10 Thread jhtimmins
This is an automated email from the ASF dual-hosted git repository. jhtimmins pushed a commit to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit abc86c4bd96318b40615f8f173e08208a4756905 Author: Ash Berlin-Taylor AuthorDate: Mon Jun 7 09:27:01 2021 +0100

[airflow] 02/03: set max tree width to 1200px (#16067)

2021-06-10 Thread jhtimmins
This is an automated email from the ASF dual-hosted git repository. jhtimmins pushed a commit to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit fb714d6db9e28de113014364365202c82eb0ce22 Author: Brent Bovenzi AuthorDate: Tue May 25 16:20:31 2021 -0400

[GitHub] [airflow] ephraimbuddy commented on pull request #16318: Fix API List DAGs inconsistent with UI/CLI

2021-06-10 Thread GitBox
ephraimbuddy commented on pull request #16318: URL: https://github.com/apache/airflow/pull/16318#issuecomment-859034744 Congrats on the PR @jpyen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] mik-laj commented on a change in pull request #16376: Set num of retries for google cloud connection to 3.

2021-06-10 Thread GitBox
mik-laj commented on a change in pull request #16376: URL: https://github.com/apache/airflow/pull/16376#discussion_r649480136 ## File path: airflow/utils/db.py ## @@ -277,6 +277,7 @@ def create_default_connections(session=None): conn_id="google_cloud_default",

[GitHub] [airflow] mik-laj commented on a change in pull request #16376: Set num of retries for google cloud connection to 3.

2021-06-10 Thread GitBox
mik-laj commented on a change in pull request #16376: URL: https://github.com/apache/airflow/pull/16376#discussion_r649480136 ## File path: airflow/utils/db.py ## @@ -277,6 +277,7 @@ def create_default_connections(session=None): conn_id="google_cloud_default",

[GitHub] [airflow] kaxil commented on a change in pull request #16345: Correctly handle None returns from Query.scalar()

2021-06-10 Thread GitBox
kaxil commented on a change in pull request #16345: URL: https://github.com/apache/airflow/pull/16345#discussion_r649475256 ## File path: airflow/jobs/scheduler_job.py ## @@ -1748,6 +1748,8 @@ def _schedule_dag_run( def _verify_integrity_if_dag_changed(self, dag_run:

[GitHub] [airflow] github-actions[bot] commented on pull request #16377: Swap out calls to find_permission_view_menu for get_permission wrapper.

2021-06-10 Thread GitBox
github-actions[bot] commented on pull request #16377: URL: https://github.com/apache/airflow/pull/16377#issuecomment-858971855 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] kaxil commented on a change in pull request #16345: Correctly handle None returns from Query.scalar()

2021-06-10 Thread GitBox
kaxil commented on a change in pull request #16345: URL: https://github.com/apache/airflow/pull/16345#discussion_r649475256 ## File path: airflow/jobs/scheduler_job.py ## @@ -1748,6 +1748,8 @@ def _schedule_dag_run( def _verify_integrity_if_dag_changed(self, dag_run:

[GitHub] [airflow] jhtimmins opened a new pull request #16377: Swap out calls to find_permission_view_menu for get_permission wrapper.

2021-06-10 Thread GitBox
jhtimmins opened a new pull request #16377: URL: https://github.com/apache/airflow/pull/16377 Part of the migration to the resource->action Permission naming scheme. Swap out calls find_permission_view_menu for it's wrapper method, get_permission. -- This is an automated message

[airflow] branch main updated (9ba796e -> 491c835)

2021-06-10 Thread jhtimmins
This is an automated email from the ASF dual-hosted git repository. jhtimmins pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 9ba796e Make REST API List DAGs endpoint consistent with UI/CLI behaviour (#16318) add 491c835 Docs:

[GitHub] [airflow] jhtimmins merged pull request #16369: Docs: Change 10 minutes to 100 minutes in ``worker_refresh_interval``

2021-06-10 Thread GitBox
jhtimmins merged pull request #16369: URL: https://github.com/apache/airflow/pull/16369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow] sshah90 commented on pull request #12925: [Loki log handler] - Integration with Grafana Loki

2021-06-10 Thread GitBox
sshah90 commented on pull request #12925: URL: https://github.com/apache/airflow/pull/12925#issuecomment-858928062 @ashb wondering if I can add hash key of `dag_name + task_name + execution_date + try_number` in each log stream with ` setFormatter(self.formatter)` function and

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #16343: Fix DAG run state not updated while DAG is paused

2021-06-10 Thread GitBox
ephraimbuddy commented on a change in pull request #16343: URL: https://github.com/apache/airflow/pull/16343#discussion_r649449800 ## File path: airflow/config_templates/default_airflow.cfg ## @@ -849,6 +849,10 @@ job_heartbeat_sec = 5 # that no longer have a matching DagRun

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #16343: Fix DAG run state not updated while DAG is paused

2021-06-10 Thread GitBox
ephraimbuddy commented on a change in pull request #16343: URL: https://github.com/apache/airflow/pull/16343#discussion_r649449578 ## File path: airflow/config_templates/config.yml ## @@ -1704,6 +1704,14 @@ type: float example: ~ default: "15.0" +-

[GitHub] [airflow] eladkal commented on issue #16135: Associate DagRun to Kubernetes Pod

2021-06-10 Thread GitBox
eladkal commented on issue #16135: URL: https://github.com/apache/airflow/issues/16135#issuecomment-858907871 @dimberman @jedcunningham WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] XD-DENG commented on pull request #16358: Only create dagruns when max_active_runs is not reached

2021-06-10 Thread GitBox
XD-DENG commented on pull request #16358: URL: https://github.com/apache/airflow/pull/16358#issuecomment-858887591 I haven't looked into the details. But based on the idea I get from the PR subject, this may affect the DAGs whose 'catchup' is False -- This is an automated message from

[GitHub] [airflow] ashb commented on a change in pull request #16110: Added windows extensions

2021-06-10 Thread GitBox
ashb commented on a change in pull request #16110: URL: https://github.com/apache/airflow/pull/16110#discussion_r649426106 ## File path: airflow/__main__.py ## @@ -34,6 +35,15 @@ def main(): os.environ['KRB5CCNAME'] = conf.get('kerberos', 'ccache')

[GitHub] [airflow] ashb commented on a change in pull request #16110: Added windows extensions

2021-06-10 Thread GitBox
ashb commented on a change in pull request #16110: URL: https://github.com/apache/airflow/pull/16110#discussion_r649426106 ## File path: airflow/__main__.py ## @@ -34,6 +35,15 @@ def main(): os.environ['KRB5CCNAME'] = conf.get('kerberos', 'ccache')

[GitHub] [airflow] ManiBharataraju commented on issue #14231: Quick start for Airflow on Mac OS

2021-06-10 Thread GitBox
ManiBharataraju commented on issue #14231: URL: https://github.com/apache/airflow/issues/14231#issuecomment-858878483 @mik-laj - I somehow managed to do all the steps in my mac to get the UI up but when I go to the UI I am unable to click on anything and see something weird like this.

[GitHub] [airflow] ashb commented on a change in pull request #16110: Added windows extensions

2021-06-10 Thread GitBox
ashb commented on a change in pull request #16110: URL: https://github.com/apache/airflow/pull/16110#discussion_r649426106 ## File path: airflow/__main__.py ## @@ -34,6 +35,15 @@ def main(): os.environ['KRB5CCNAME'] = conf.get('kerberos', 'ccache')

[GitHub] [airflow] ashb commented on a change in pull request #16089: [#16087]: Backfill shouldn't interfere with scheduled run fix

2021-06-10 Thread GitBox
ashb commented on a change in pull request #16089: URL: https://github.com/apache/airflow/pull/16089#discussion_r649424052 ## File path: airflow/jobs/backfill_job.py ## @@ -689,6 +688,9 @@ def tabulate_tis_set(set_tis: Set[TaskInstance]) -> str: return err +

[GitHub] [airflow] jpyen commented on pull request #16318: Fix API List DAGs inconsistent with UI/CLI

2021-06-10 Thread GitBox
jpyen commented on pull request #16318: URL: https://github.com/apache/airflow/pull/16318#issuecomment-858873132 Thanks @ephraimbuddy! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] eladkal commented on a change in pull request #16365: Implemented Tableau Hook connection through SSL

2021-06-10 Thread GitBox
eladkal commented on a change in pull request #16365: URL: https://github.com/apache/airflow/pull/16365#discussion_r649417418 ## File path: airflow/providers/tableau/hooks/tableau.py ## @@ -61,7 +61,9 @@ def __init__(self, site_id: Optional[str] = None, tableau_conn_id: str =

[GitHub] [airflow] eladkal commented on a change in pull request #16365: Implemented Tableau Hook connection through SSL

2021-06-10 Thread GitBox
eladkal commented on a change in pull request #16365: URL: https://github.com/apache/airflow/pull/16365#discussion_r649417418 ## File path: airflow/providers/tableau/hooks/tableau.py ## @@ -61,7 +61,9 @@ def __init__(self, site_id: Optional[str] = None, tableau_conn_id: str =

[GitHub] [airflow] eladkal commented on a change in pull request #16365: Implemented Tableau Hook connection through SSL

2021-06-10 Thread GitBox
eladkal commented on a change in pull request #16365: URL: https://github.com/apache/airflow/pull/16365#discussion_r649417418 ## File path: airflow/providers/tableau/hooks/tableau.py ## @@ -61,7 +61,9 @@ def __init__(self, site_id: Optional[str] = None, tableau_conn_id: str =

[GitHub] [airflow] ashb commented on issue #16303: Replace `execution_date` in `TI.generate_command` to send run_id instead

2021-06-10 Thread GitBox
ashb commented on issue #16303: URL: https://github.com/apache/airflow/issues/16303#issuecomment-858868501 @SamWheating See also https://github.com/apache/airflow/pull/7085 -- you might want to fold that in to this change. -- This is an automated message from the Apache Git Service. To

[airflow] branch main updated (9351e2a -> 9ba796e)

2021-06-10 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 9351e2a Depreciate private_key_pass in SFTPHook conn extra and rename to private_key_passphrase (#14028)

[GitHub] [airflow] eladkal commented on a change in pull request #16365: Implemented Tableau Hook connection through SSL

2021-06-10 Thread GitBox
eladkal commented on a change in pull request #16365: URL: https://github.com/apache/airflow/pull/16365#discussion_r649417418 ## File path: airflow/providers/tableau/hooks/tableau.py ## @@ -61,7 +61,9 @@ def __init__(self, site_id: Optional[str] = None, tableau_conn_id: str =

[GitHub] [airflow] ephraimbuddy merged pull request #16318: Fix API List DAGs inconsistent with UI/CLI

2021-06-10 Thread GitBox
ephraimbuddy merged pull request #16318: URL: https://github.com/apache/airflow/pull/16318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [airflow] ashb commented on pull request #15980: Always return a response in TI's action_clear view

2021-06-10 Thread GitBox
ashb commented on pull request #15980: URL: https://github.com/apache/airflow/pull/15980#issuecomment-858862521 @uranusjr I'm seeing this in the logs: ``` tests/www/views/test_views_tasks.py::test_task_instance_clear_failure XFAIL (until #15980 is merged)

[GitHub] [airflow] jpyen edited a comment on pull request #16318: Fix API List DAGs inconsistent with UI/CLI

2021-06-10 Thread GitBox
jpyen edited a comment on pull request #16318: URL: https://github.com/apache/airflow/pull/16318#issuecomment-858817951 @kaxil @ephraimbuddy Changes approved, checks passed and ready to merge. Thanks for the patience. -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] github-actions[bot] commented on pull request #16375: Fix normalize-url vulnerability

2021-06-10 Thread GitBox
github-actions[bot] commented on pull request #16375: URL: https://github.com/apache/airflow/pull/16375#issuecomment-858847814 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] ashb closed pull request #8651: [AIRFLOW-8058] Add configurable execution context

2021-06-10 Thread GitBox
ashb closed pull request #8651: URL: https://github.com/apache/airflow/pull/8651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow] ashb commented on pull request #8651: [AIRFLOW-8058] Add configurable execution context

2021-06-10 Thread GitBox
ashb commented on pull request #8651: URL: https://github.com/apache/airflow/pull/8651#issuecomment-858847804 I'm afraid I'm going to close this as Wont Fix -- it feels very broad and fragile to use this global config setting for the example you've given (GCP project) This is also

[GitHub] [airflow] msumit commented on a change in pull request #16233: Fix TI success/failure links

2021-06-10 Thread GitBox
msumit commented on a change in pull request #16233: URL: https://github.com/apache/airflow/pull/16233#discussion_r649408501 ## File path: airflow/www/views.py ## @@ -1803,54 +1804,104 @@ def _mark_task_instance_state( # pylint: disable=too-many-arguments

[GitHub] [airflow] uranusjr commented on a change in pull request #16233: Fix TI success/failure links

2021-06-10 Thread GitBox
uranusjr commented on a change in pull request #16233: URL: https://github.com/apache/airflow/pull/16233#discussion_r649406401 ## File path: airflow/www/views.py ## @@ -1803,54 +1804,104 @@ def _mark_task_instance_state( # pylint: disable=too-many-arguments

[GitHub] [airflow] ashb merged pull request #14967: Fix too specific parsing of `False` in LegacyUIDeprecated

2021-06-10 Thread GitBox
ashb merged pull request #14967: URL: https://github.com/apache/airflow/pull/14967 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[airflow] branch v1-10-stable updated: Fix too specific parsing of `False` in LegacyUIDeprecated (#14967)

2021-06-10 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a commit to branch v1-10-stable in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/v1-10-stable by this push: new 4a27689 Fix too specific parsing of

[GitHub] [airflow] ashb commented on pull request #12925: [Loki log handler] - Integration with Grafana Loki

2021-06-10 Thread GitBox
ashb commented on pull request #12925: URL: https://github.com/apache/airflow/pull/12925#issuecomment-858833643 For instance I wonder if you can use something like the JSON output format that ElasticSearch uses, and then combine it with

[GitHub] [airflow] bbovenzi commented on pull request #16141: Add a calendar field to choose the execution date of the DAG when triggering it

2021-06-10 Thread GitBox
bbovenzi commented on pull request #16141: URL: https://github.com/apache/airflow/pull/16141#issuecomment-858833624 @ashb or @ryanahamilton Can we restart the CI here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] dimon222 edited a comment on pull request #16358: Only create dagruns when max_active_runs is not reached

2021-06-10 Thread GitBox
dimon222 edited a comment on pull request #16358: URL: https://github.com/apache/airflow/pull/16358#issuecomment-858831825 Does this PR literally restrict from staggering new dagruns of there's already running one? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] ashb commented on a change in pull request #16345: Correctly handle None returns from Query.scalar()

2021-06-10 Thread GitBox
ashb commented on a change in pull request #16345: URL: https://github.com/apache/airflow/pull/16345#discussion_r649397260 ## File path: airflow/jobs/scheduler_job.py ## @@ -1748,6 +1748,8 @@ def _schedule_dag_run( def _verify_integrity_if_dag_changed(self, dag_run:

[GitHub] [airflow] dimon222 commented on pull request #16358: Only create dagruns when max_active_runs is not reached

2021-06-10 Thread GitBox
dimon222 commented on pull request #16358: URL: https://github.com/apache/airflow/pull/16358#issuecomment-858831825 Does this PR literally restrict from queuing new dagruns of there's already running one? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] ashb commented on pull request #12925: [Loki log handler] - Integration with Grafana Loki

2021-06-10 Thread GitBox
ashb commented on pull request #12925: URL: https://github.com/apache/airflow/pull/12925#issuecomment-858830114 Oh. try_number is going to confuse things too; The the start/end dates in the TI will be for the latest try only, so you'll need to look elsewhere (TaskFail table I think)

[GitHub] [airflow] ashb commented on pull request #12925: [Loki log handler] - Integration with Grafana Loki

2021-06-10 Thread GitBox
ashb commented on pull request #12925: URL: https://github.com/apache/airflow/pull/12925#issuecomment-858828896 You can have multiple tasks for different dag runs running concurrently, so filtering for logs between start and end date would not be a complete solution -- you would still get

[GitHub] [airflow] sshah90 commented on pull request #12925: [Loki log handler] - Integration with Grafana Loki

2021-06-10 Thread GitBox
sshah90 commented on pull request #12925: URL: https://github.com/apache/airflow/pull/12925#issuecomment-858826335 Hi @ashb, > Not including execution_date in the task labels is incorrect -- the execution date is needed to uniquely identify the task instance I agree, in some

[GitHub] [airflow] anitakar opened a new pull request #16376: Set num of retries for google cloud connection to 3.

2021-06-10 Thread GitBox
anitakar opened a new pull request #16376: URL: https://github.com/apache/airflow/pull/16376 Can be useful in case of a connection being kept alive for a very long time, for example because underneth it waits for a dataflow job. related: #1397 -- This is an automated

[GitHub] [airflow] uranusjr commented on a change in pull request #16110: Added windows extensions

2021-06-10 Thread GitBox
uranusjr commented on a change in pull request #16110: URL: https://github.com/apache/airflow/pull/16110#discussion_r649381846 ## File path: airflow/utils/process_utils.py ## @@ -79,7 +86,7 @@ def signal_procs(sig): else: raise -if pgid ==

[GitHub] [airflow] jpyen commented on pull request #16318: Fix API List DAGs inconsistent with UI/CLI

2021-06-10 Thread GitBox
jpyen commented on pull request #16318: URL: https://github.com/apache/airflow/pull/16318#issuecomment-858817951 @kaxil Changes approved, checks passed and ready to merge. Thanks for the patience. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] ephraimbuddy commented on pull request #16343: Fix DAG run state not updated while DAG is paused

2021-06-10 Thread GitBox
ephraimbuddy commented on pull request #16343: URL: https://github.com/apache/airflow/pull/16343#issuecomment-858810600 > > Nice but I think it may not work if the user disables mini scheduling? > > Yes, but we'll likely remove that setting in a version or two -- it was mostly an

[airflow] branch main updated (6e9e562 -> 9351e2a)

2021-06-10 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 6e9e562 Make task ID on legend have enough width and width of line chart to be 100%. (#15915) add 9351e2a

[GitHub] [airflow] ashb commented on pull request #16343: Fix DAG run state not updated while DAG is paused

2021-06-10 Thread GitBox
ashb commented on pull request #16343: URL: https://github.com/apache/airflow/pull/16343#issuecomment-858808709 > Nice but I think it may not work if the user disables mini scheduling? Yes, but we'll likely remove that setting in a version or two -- it was mostly an escape hatch in

[GitHub] [airflow] ashb merged pull request #14028: Depreciate private_key_pass extra param and rename to private_key_passphrase

2021-06-10 Thread GitBox
ashb merged pull request #14028: URL: https://github.com/apache/airflow/pull/14028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #14028: Depreciate private_key_pass extra param and rename to private_key_passphrase

2021-06-10 Thread GitBox
boring-cyborg[bot] commented on pull request #14028: URL: https://github.com/apache/airflow/pull/14028#issuecomment-858808056 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] ephraimbuddy commented on pull request #16343: Fix DAG run state not updated while DAG is paused

2021-06-10 Thread GitBox
ephraimbuddy commented on pull request #16343: URL: https://github.com/apache/airflow/pull/16343#issuecomment-858806028 > I wonder what is more efficient: doing this periodically (for paused dags, where the state is likely to never change) or expanding on the "mini scheduler run" to do a

[GitHub] [airflow] bbovenzi opened a new pull request #16375: Fix normalize-url vulnerability

2021-06-10 Thread GitBox
bbovenzi opened a new pull request #16375: URL: https://github.com/apache/airflow/pull/16375 Update two packages that used a highly vulnerable version of normalize-url See https://github.com/facebook/create-react-app/issues/11054 --- **^ Add meaningful description above**

[GitHub] [airflow] jhtimmins commented on pull request #16110: Added windows extensions

2021-06-10 Thread GitBox
jhtimmins commented on pull request #16110: URL: https://github.com/apache/airflow/pull/16110#issuecomment-858803535 @ashb can you take a look to see if your requested changes have been addressed? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] uranusjr commented on a change in pull request #16352: DagRun.date_interval_start and date_interval_start

2021-06-10 Thread GitBox
uranusjr commented on a change in pull request #16352: URL: https://github.com/apache/airflow/pull/16352#discussion_r649376333 ## File path: airflow/migrations/versions/142555e44c17_add_data_interval_start_end_to_dagrun.py ## @@ -0,0 +1,100 @@ +# +# Licensed to the Apache

[GitHub] [airflow] jhtimmins commented on pull request #15947: Applied permissions to self._error_file

2021-06-10 Thread GitBox
jhtimmins commented on pull request #15947: URL: https://github.com/apache/airflow/pull/15947#issuecomment-858802569 @kevinbsilva looks like these are legit test failures that need to be addressed https://github.com/apache/airflow/pull/15947/checks?check_run_id=2794600747#step:6:14114

[GitHub] [airflow] anitakar commented on a change in pull request #16311: Prevent running `airflow db init` migrations and setup in parallel.

2021-06-10 Thread GitBox
anitakar commented on a change in pull request #16311: URL: https://github.com/apache/airflow/pull/16311#discussion_r649373985 ## File path: airflow/utils/db.py ## @@ -561,10 +571,21 @@ def create_default_connections(session=None): ) -def initdb(): +@provide_session

[GitHub] [airflow] jhtimmins commented on pull request #11652: Support for sorting DAGs in the web UI

2021-06-10 Thread GitBox
jhtimmins commented on pull request #11652: URL: https://github.com/apache/airflow/pull/11652#issuecomment-858799643 @scrdest can you fix these merge conflicts? If so we'll target 2.2 for this release. @ashb bumping since you requested changes -- This is an automated message from

[GitHub] [airflow] ephraimbuddy commented on pull request #16358: Only create dagruns when max_active_runs is not reached

2021-06-10 Thread GitBox
ephraimbuddy commented on pull request #16358: URL: https://github.com/apache/airflow/pull/16358#issuecomment-858794233 > Tackling #16366 _may_ be less work, not sure, but it's certainly a better fix long term I have updated this PR and will start working on #16366. From my thinking

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #16358: Only create dagruns when max_active_runs is not reached

2021-06-10 Thread GitBox
ephraimbuddy commented on a change in pull request #16358: URL: https://github.com/apache/airflow/pull/16358#discussion_r649364776 ## File path: airflow/jobs/scheduler_job.py ## @@ -1593,7 +1592,9 @@ def _create_dag_runs(self, dag_models: Iterable[DagModel], session: Session)

[GitHub] [airflow] github-actions[bot] commented on pull request #14028: Depreciate private_key_pass extra param and rename to private_key_passphrase

2021-06-10 Thread GitBox
github-actions[bot] commented on pull request #14028: URL: https://github.com/apache/airflow/pull/14028#issuecomment-858782384 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

  1   2   3   >