[GitHub] [airflow] kaxil commented on issue #14396: Make context less nebulous

2021-10-06 Thread GitBox
kaxil commented on issue #14396: URL: https://github.com/apache/airflow/issues/14396#issuecomment-937472485 Yup we would not close it for sure :) . It's just that it hasn't fallen into priorities as yet. Anyone who is willing to work on the issue should take a stab at it and we are

[GitHub] [airflow] eladkal commented on pull request #18201: Add check for 403 code

2021-10-06 Thread GitBox
eladkal commented on pull request #18201: URL: https://github.com/apache/airflow/pull/18201#issuecomment-937461447 > Could you provide some reference and rationale behind this change? Both me and @xinbinhuang discussed it on the issue https://github.com/apache/airflow/issues/18111

[GitHub] [airflow] r-richmond edited a comment on issue #14396: Make context less nebulous

2021-10-06 Thread GitBox
r-richmond edited a comment on issue #14396: URL: https://github.com/apache/airflow/issues/14396#issuecomment-937445404 >I believe so far simply no-one else found it really useful or needed. What is the bar to clear here?.. i.e. 5 thumbs up on opening issue doesn't meet it so I'm

[GitHub] [airflow] r-richmond commented on issue #14396: Make context less nebulous

2021-10-06 Thread GitBox
r-richmond commented on issue #14396: URL: https://github.com/apache/airflow/issues/14396#issuecomment-937445404 >I believe so far simply no-one else found it really useful or needed. What is the bar to clear here?.. i.e. 5 thumbs up on opening issue doesn't meet it so I'm curious

[GitHub] [airflow] xinbinhuang edited a comment on issue #18111: HeadObject error when trying to upload file to S3

2021-10-06 Thread GitBox
xinbinhuang edited a comment on issue #18111: URL: https://github.com/apache/airflow/issues/18111#issuecomment-936953895 > I want it to be able to upload a file in any case (file already exists or not), I know about the `replace` flag, but I also want to cover the case when the file

[GitHub] [airflow] uranusjr commented on pull request #18201: Add check for 403 code

2021-10-06 Thread GitBox
uranusjr commented on pull request #18201: URL: https://github.com/apache/airflow/pull/18201#issuecomment-937422763 Could you provide some reference and rationale behind this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] uranusjr commented on pull request #18199: Create docker-operator-with-localexecutor-in-docker-compose.md

2021-10-06 Thread GitBox
uranusjr commented on pull request #18199: URL: https://github.com/apache/airflow/pull/18199#issuecomment-937422424 Gentle ping on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] chinwobble commented on issue #8125: Conditionally symlink 'latest' directory

2021-10-06 Thread GitBox
chinwobble commented on issue #8125: URL: https://github.com/apache/airflow/issues/8125#issuecomment-937421078 We are experiencing the same issue. Is it possible to turn off the symlink behaviour? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] michaelkhan3 commented on issue #15279: Error on logging empty line to Cloudwatch

2021-10-06 Thread GitBox
michaelkhan3 commented on issue #15279: URL: https://github.com/apache/airflow/issues/15279#issuecomment-937418131 > i've gotten around it by creating a `log_config.py` with the following: > > ``` > from copy import deepcopy > import logging > > from

[GitHub] [airflow] uranusjr opened a new pull request #18788: Accept custom run ID in TriggerDagRunOperator

2021-10-06 Thread GitBox
uranusjr opened a new pull request #18788: URL: https://github.com/apache/airflow/pull/18788 Fix #17438. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [airflow] uranusjr commented on issue #12851: Find a way to inform our users about deprecated extras

2021-10-06 Thread GitBox
uranusjr commented on issue #12851: URL: https://github.com/apache/airflow/issues/12851#issuecomment-937416195 A built-in way to handle extra deprecation could be a good feature addition to the packaging system though. Someone should raise it on discuss.python.org  -- This is an

[GitHub] [airflow] uranusjr commented on issue #12851: Find a way to inform our users about deprecated extras

2021-10-06 Thread GitBox
uranusjr commented on issue #12851: URL: https://github.com/apache/airflow/issues/12851#issuecomment-937415897 If the deprecated extras are merged into the main dependency list, they can simply be removed since unrecognised extras are automatically ignored (with a warning). But there's

[GitHub] [airflow] github-actions[bot] commented on pull request #17305: [Bug] Backfill job fails to run when there are tasks run into rescheduling state.

2021-10-06 Thread GitBox
github-actions[bot] commented on pull request #17305: URL: https://github.com/apache/airflow/pull/17305#issuecomment-937402224 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] uranusjr commented on issue #18304: User induced deadlock for DAGs with `depends_on_past`

2021-10-06 Thread GitBox
uranusjr commented on issue #18304: URL: https://github.com/apache/airflow/issues/18304#issuecomment-937399559 What's the actionable here? Since the deadlock is induced by the user, should we prevent this from happening by not allowing Task B to be cleared? Or do we somehow resolve that

[GitHub] [airflow] uranusjr commented on issue #17473: New view "Operator arguments" between "Task Instance Details" and "Rendered"

2021-10-06 Thread GitBox
uranusjr commented on issue #17473: URL: https://github.com/apache/airflow/issues/17473#issuecomment-937398844 Do you want `file_format` to show `globals_variables['file_format_csv']['es']` literally? I don't think it's possible. -- This is an automated message from the Apache Git

[GitHub] [airflow] uranusjr commented on pull request #16475: Add the ability to rerun success state task_instance in the Backfill API(#16452)

2021-10-06 Thread GitBox
uranusjr commented on pull request #16475: URL: https://github.com/apache/airflow/pull/16475#issuecomment-937394114 A couple of nitpicks, lgtm in general. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] uranusjr commented on a change in pull request #16475: Add the ability to rerun success state task_instance in the Backfill API(#16452)

2021-10-06 Thread GitBox
uranusjr commented on a change in pull request #16475: URL: https://github.com/apache/airflow/pull/16475#discussion_r723801733 ## File path: airflow/cli/commands/dag_command.py ## @@ -122,13 +123,15 @@ def dag_backfill(args, dag=None): verbose=args.verbose,

[GitHub] [airflow] uranusjr commented on a change in pull request #16475: Add the ability to rerun success state task_instance in the Backfill API(#16452)

2021-10-06 Thread GitBox
uranusjr commented on a change in pull request #16475: URL: https://github.com/apache/airflow/pull/16475#discussion_r723801595 ## File path: airflow/cli/cli_parser.py ## @@ -909,7 +917,9 @@ class GroupCommand(NamedTuple): "Run subsections of a DAG for a specified

[GitHub] [airflow] uranusjr commented on a change in pull request #18622: Use seconds for schedule_delay metric

2021-10-06 Thread GitBox
uranusjr commented on a change in pull request #18622: URL: https://github.com/apache/airflow/pull/18622#discussion_r723799273 ## File path: airflow/stats.py ## @@ -331,10 +332,12 @@ def gauge(self, stat, value, rate=1, delta=False, tags=None): return None

[GitHub] [airflow] uranusjr commented on a change in pull request #18622: Use seconds for schedule_delay metric

2021-10-06 Thread GitBox
uranusjr commented on a change in pull request #18622: URL: https://github.com/apache/airflow/pull/18622#discussion_r723799273 ## File path: airflow/stats.py ## @@ -331,10 +332,12 @@ def gauge(self, stat, value, rate=1, delta=False, tags=None): return None

[GitHub] [airflow] uranusjr commented on pull request #18568: [ISSUE-18468] add container option for SparkKubernetesSensor

2021-10-06 Thread GitBox
uranusjr commented on pull request #18568: URL: https://github.com/apache/airflow/pull/18568#issuecomment-937390238 Also, why is the current default value chosen? (The answer may be obvious but I know next to nothing about Spark and Kubernetes.) -- This is an automated message from the

[airflow] branch constraints-main updated: Updating constraints. Build id:1314305756

2021-10-06 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 7213d0c Updating

[GitHub] [airflow] uranusjr commented on pull request #18622: Use seconds for schedule_delay metric

2021-10-06 Thread GitBox
uranusjr commented on pull request #18622: URL: https://github.com/apache/airflow/pull/18622#issuecomment-937380123 [Function parameter annotations](https://www.python.org/dev/peps/pep-3107/#parameters). The functions are already partially annotated, but we should annotate `dt` with

[GitHub] [airflow] coinzerge commented on pull request #18622: Use seconds for schedule_delay metric

2021-10-06 Thread GitBox
coinzerge commented on pull request #18622: URL: https://github.com/apache/airflow/pull/18622#issuecomment-937378491 added test. what do you mean by `we should also add annotations`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] uranusjr commented on a change in pull request #18563: Test kubernetes refresh config

2021-10-06 Thread GitBox
uranusjr commented on a change in pull request #18563: URL: https://github.com/apache/airflow/pull/18563#discussion_r723789246 ## File path: tests/kubernetes/test_refresh_config.py ## @@ -35,3 +41,60 @@ def

[GitHub] [airflow] uranusjr commented on a change in pull request #17651: Create CMDExecutor for raising an exception in case of error during cmd execution

2021-10-06 Thread GitBox
uranusjr commented on a change in pull request #17651: URL: https://github.com/apache/airflow/pull/17651#discussion_r723788778 ## File path: tests/test_utils/gcp_system_helpers.py ## @@ -123,6 +123,11 @@ def provide_gcs_bucket(bucket_name: str):

[GitHub] [airflow] uranusjr commented on a change in pull request #17651: Create CMDExecutor for raising an exception in case of error during cmd execution

2021-10-06 Thread GitBox
uranusjr commented on a change in pull request #17651: URL: https://github.com/apache/airflow/pull/17651#discussion_r723788007 ## File path: tests/test_utils/logging_command_executor.py ## @@ -62,5 +62,39 @@ def check_output(self, cmd): return output +class

[GitHub] [airflow] uranusjr commented on pull request #18584: WIP: Pickling fix

2021-10-06 Thread GitBox
uranusjr commented on pull request #18584: URL: https://github.com/apache/airflow/pull/18584#issuecomment-937374645 How should the PR progress? From the discussion in the linked issue it seems we are not going down this route. -- This is an automated message from the Apache Git Service.

[GitHub] [airflow] dstandish commented on pull request #18447: Add RedshiftSQLHook, RedshiftSQLOperator

2021-10-06 Thread GitBox
dstandish commented on pull request #18447: URL: https://github.com/apache/airflow/pull/18447#issuecomment-937374301 This looks good to me. Anyone else want to give it a second look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] github-actions[bot] commented on pull request #17446: Add support of `path` parameter for GCloud Storage Transfer Service operators

2021-10-06 Thread GitBox
github-actions[bot] commented on pull request #17446: URL: https://github.com/apache/airflow/pull/17446#issuecomment-937372966 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] github-actions[bot] commented on pull request #18657: Cleanup of start_date and default arg use for Apache example DAGs

2021-10-06 Thread GitBox
github-actions[bot] commented on pull request #18657: URL: https://github.com/apache/airflow/pull/18657#issuecomment-937372117 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] uranusjr commented on a change in pull request #18657: Cleanup of start_date and default arg use for Apache example DAGs

2021-10-06 Thread GitBox
uranusjr commented on a change in pull request #18657: URL: https://github.com/apache/airflow/pull/18657#discussion_r723784424 ## File path: airflow/providers/apache/druid/example_dags/example_druid_dag.py ## @@ -19,22 +19,19 @@ """ Example Airflow DAG to submit Apache Druid

[GitHub] [airflow] uranusjr commented on issue #18777: [Quarantine] test_no_orphan_process_will_be_left

2021-10-06 Thread GitBox
uranusjr commented on issue #18777: URL: https://github.com/apache/airflow/issues/18777#issuecomment-937365630 Should this be closed since the PR is merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[airflow] branch main updated (dc45f97 -> 63ca12c)

2021-10-06 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from dc45f97 Adds CeleryKubernetesExecutor check to AirflowBaseView.run (#18441) add 63ca12c Open src and dst in

[GitHub] [airflow] uranusjr merged pull request #18752: Open src and dst in binary for samba copy

2021-10-06 Thread GitBox
uranusjr merged pull request #18752: URL: https://github.com/apache/airflow/pull/18752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] uranusjr commented on a change in pull request #18439: Check and run migration in commands if necessary

2021-10-06 Thread GitBox
uranusjr commented on a change in pull request #18439: URL: https://github.com/apache/airflow/pull/18439#discussion_r723779357 ## File path: airflow/utils/db.py ## @@ -626,27 +629,88 @@ def check_migrations(timeout): :param timeout: Timeout for the migration in seconds

[GitHub] [airflow] uranusjr commented on a change in pull request #18439: Check and run migration in commands if necessary

2021-10-06 Thread GitBox
uranusjr commented on a change in pull request #18439: URL: https://github.com/apache/airflow/pull/18439#discussion_r723779104 ## File path: airflow/utils/db.py ## @@ -626,27 +629,88 @@ def check_migrations(timeout): :param timeout: Timeout for the migration in seconds

[GitHub] [airflow] uranusjr commented on a change in pull request #18787: Show if an executor supports /run via duck-typing

2021-10-06 Thread GitBox
uranusjr commented on a change in pull request #18787: URL: https://github.com/apache/airflow/pull/18787#discussion_r723773701 ## File path: airflow/executors/kubernetes_executor.py ## @@ -419,9 +419,11 @@ def get_base_pod_from_template(pod_template_file: Optional[str],

[GitHub] [airflow] uranusjr opened a new pull request #18787: Show if an executor supports /run via duck-typing

2021-10-06 Thread GitBox
uranusjr opened a new pull request #18787: URL: https://github.com/apache/airflow/pull/18787 A follow-up to #18441 making the check more extendable in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] github-actions[bot] commented on pull request #18786: Docs: Move part of timetable guide to concepts

2021-10-06 Thread GitBox
github-actions[bot] commented on pull request #18786: URL: https://github.com/apache/airflow/pull/18786#issuecomment-937354638 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] jedcunningham commented on a change in pull request #18786: Docs: Move part of timetable guide to concepts

2021-10-06 Thread GitBox
jedcunningham commented on a change in pull request #18786: URL: https://github.com/apache/airflow/pull/18786#discussion_r723771612 ## File path: docs/apache-airflow/dag-run.rst ## @@ -22,7 +22,8 @@ A DAG Run is an object representing an instantiation of the DAG in time.

[GitHub] [airflow] uranusjr commented on a change in pull request #18786: Docs: Move part of timetable guide to concepts

2021-10-06 Thread GitBox
uranusjr commented on a change in pull request #18786: URL: https://github.com/apache/airflow/pull/18786#discussion_r723768339 ## File path: docs/apache-airflow/dag-run.rst ## @@ -22,7 +22,8 @@ A DAG Run is an object representing an instantiation of the DAG in time. Each DAG

[airflow] branch main updated (32947a4 -> dc45f97)

2021-10-06 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 32947a4 Fix deprecated default for ``fab_logging_level`` to ``WARNING`` (#18783) add dc45f97 Adds

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #18441: Adds CeleryKubernetesExecutor check to AirflowBaseView.run

2021-10-06 Thread GitBox
boring-cyborg[bot] commented on pull request #18441: URL: https://github.com/apache/airflow/pull/18441#issuecomment-937346192 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] uranusjr merged pull request #18441: Adds CeleryKubernetesExecutor check to AirflowBaseView.run

2021-10-06 Thread GitBox
uranusjr merged pull request #18441: URL: https://github.com/apache/airflow/pull/18441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] uranusjr closed issue #18440: Can't Run Tasks from UI when using CeleryKubernetesExecutor

2021-10-06 Thread GitBox
uranusjr closed issue #18440: URL: https://github.com/apache/airflow/issues/18440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] jedcunningham opened a new pull request #18786: Docs: Move part of timetable guide to concepts

2021-10-06 Thread GitBox
jedcunningham opened a new pull request #18786: URL: https://github.com/apache/airflow/pull/18786 It took me a while to find the docs for timetables. This proposes moving part of the guide into concepts. I considered moving part of the top level dag run page here also.

[GitHub] [airflow] uranusjr commented on a change in pull request #18755: Support mysql to s3 in parquet format

2021-10-06 Thread GitBox
uranusjr commented on a change in pull request #18755: URL: https://github.com/apache/airflow/pull/18755#discussion_r723766341 ## File path: airflow/providers/amazon/aws/transfers/mysql_to_s3.py ## @@ -92,15 +117,40 @@ def __init__( self.aws_conn_id = aws_conn_id

[GitHub] [airflow] uranusjr commented on a change in pull request #17927: Add example of TaskFlow to declare task dependencies

2021-10-06 Thread GitBox
uranusjr commented on a change in pull request #17927: URL: https://github.com/apache/airflow/pull/17927#discussion_r723765288 ## File path: docs/apache-airflow/concepts/tasks.rst ## @@ -36,16 +36,30 @@ Relationships The key part of using Tasks is defining how they relate

[GitHub] [airflow] uranusjr commented on a change in pull request #17927: Add example of TaskFlow to declare task dependencies

2021-10-06 Thread GitBox
uranusjr commented on a change in pull request #17927: URL: https://github.com/apache/airflow/pull/17927#discussion_r723764445 ## File path: docs/apache-airflow/concepts/tasks.rst ## @@ -36,16 +36,30 @@ Relationships The key part of using Tasks is defining how they relate

[GitHub] [airflow] github-actions[bot] commented on pull request #17178: Amazon EMR on Amazon EKS

2021-10-06 Thread GitBox
github-actions[bot] commented on pull request #17178: URL: https://github.com/apache/airflow/pull/17178#issuecomment-937336230 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank

[GitHub] [airflow] github-actions[bot] commented on pull request #17600: Fix wrong Postgres search_path set up instructions

2021-10-06 Thread GitBox
github-actions[bot] commented on pull request #17600: URL: https://github.com/apache/airflow/pull/17600#issuecomment-937336213 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank

[GitHub] [airflow] guotongfei commented on a change in pull request #18755: Support mysql to s3 in parquet format

2021-10-06 Thread GitBox
guotongfei commented on a change in pull request #18755: URL: https://github.com/apache/airflow/pull/18755#discussion_r723759306 ## File path: airflow/providers/amazon/aws/transfers/mysql_to_s3.py ## @@ -92,15 +117,34 @@ def __init__( self.aws_conn_id = aws_conn_id

[GitHub] [airflow] guotongfei commented on a change in pull request #18755: Support mysql to s3 in parquet format

2021-10-06 Thread GitBox
guotongfei commented on a change in pull request #18755: URL: https://github.com/apache/airflow/pull/18755#discussion_r723757667 ## File path: airflow/providers/amazon/aws/transfers/mysql_to_s3.py ## @@ -92,15 +117,34 @@ def __init__( self.aws_conn_id = aws_conn_id

[GitHub] [airflow] uranusjr commented on a change in pull request #18784: Make a separate hook for interacting with the Pagerduty Events API

2021-10-06 Thread GitBox
uranusjr commented on a change in pull request #18784: URL: https://github.com/apache/airflow/pull/18784#discussion_r723756897 ## File path: airflow/providers/pagerduty/hooks/pagerduty.py ## @@ -26,14 +27,31 @@ class PagerdutyHook(BaseHook): """ -Takes both

[GitHub] [airflow] uranusjr commented on a change in pull request #18690: Fixing tests that leave traces (users)

2021-10-06 Thread GitBox
uranusjr commented on a change in pull request #18690: URL: https://github.com/apache/airflow/pull/18690#discussion_r723747637 ## File path: tests/test_utils/api_connexion_utils.py ## @@ -14,26 +14,43 @@ # KIND, either express or implied. See the License for the # specific

[GitHub] [airflow] ferruzzi edited a comment on pull request #18645: Add AWS Fargate profile support

2021-10-06 Thread GitBox
ferruzzi edited a comment on pull request #18645: URL: https://github.com/apache/airflow/pull/18645#issuecomment-937326775 CI is failing due to the deprecation warnings that @mik-laj added, but I'm not sure why. The error message says pod name needs to be explicitly passed and lists

[GitHub] [airflow] guotongfei commented on a change in pull request #18755: Support mysql to s3 in parquet format

2021-10-06 Thread GitBox
guotongfei commented on a change in pull request #18755: URL: https://github.com/apache/airflow/pull/18755#discussion_r723755406 ## File path: airflow/providers/amazon/aws/transfers/mysql_to_s3.py ## @@ -92,15 +117,34 @@ def __init__( self.aws_conn_id = aws_conn_id

[GitHub] [airflow] ferruzzi edited a comment on pull request #18645: Add AWS Fargate profile support

2021-10-06 Thread GitBox
ferruzzi edited a comment on pull request #18645: URL: https://github.com/apache/airflow/pull/18645#issuecomment-937326775 CI is failing due to the deprecation warnings that @mik-laj added, but I'm not sure why. The error message says pod name needs to be explicitly passed and lists

[GitHub] [airflow] ferruzzi commented on pull request #18645: Add AWS Fargate profile support

2021-10-06 Thread GitBox
ferruzzi commented on pull request #18645: URL: https://github.com/apache/airflow/pull/18645#issuecomment-937326775 CI is failing due to the deprecation warnings that @mik-laj added, but I'm not sure why. The error message says pod name needs to be explicitly passed and lists three

[GitHub] [airflow] uranusjr closed issue #18779: Task status is not updating during run within TaskGroup on UI

2021-10-06 Thread GitBox
uranusjr closed issue #18779: URL: https://github.com/apache/airflow/issues/18779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] uranusjr commented on issue #18779: Task status is not updating during run within TaskGroup on UI

2021-10-06 Thread GitBox
uranusjr commented on issue #18779: URL: https://github.com/apache/airflow/issues/18779#issuecomment-937320978 Seems to be the case, yes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] uranusjr commented on a change in pull request #18718: Add hook_params in BaseSqlOperator

2021-10-06 Thread GitBox
uranusjr commented on a change in pull request #18718: URL: https://github.com/apache/airflow/pull/18718#discussion_r723745553 ## File path: airflow/models/connection.py ## @@ -289,8 +289,11 @@ def rotate_fernet_key(self): if self._extra and self.is_extra_encrypted:

[GitHub] [airflow] uranusjr commented on pull request #18622: Use seconds for schedule_delay metric

2021-10-06 Thread GitBox
uranusjr commented on pull request #18622: URL: https://github.com/apache/airflow/pull/18622#issuecomment-937318611 Could you add a test for this in `tests/core/test_stats.py`? And while we're at it, we should also add annotations to `dt` in the `stats` module to make it explicit it can

[GitHub] [airflow] alex-astronomer commented on issue #18714: Make it possible to delete a permission from a role using the stable REST API

2021-10-06 Thread GitBox
alex-astronomer commented on issue #18714: URL: https://github.com/apache/airflow/issues/18714#issuecomment-937292186 Heard that. I'll make that a part of this PR that I started working on for this. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] uranusjr commented on issue #18714: Make it possible to delete a permission from a role using the stable REST API

2021-10-06 Thread GitBox
uranusjr commented on issue #18714: URL: https://github.com/apache/airflow/issues/18714#issuecomment-937289868 We can, although the current PATCH behaviour is still somehow unintuitive and should at least be documented. -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] zachliu commented on pull request #17626: ECSOperator realtime logging

2021-10-06 Thread GitBox
zachliu commented on pull request #17626: URL: https://github.com/apache/airflow/pull/17626#issuecomment-937257582 @codenamestif i'm testing out this feature in our integration env right now. IT IS AWESOME! i'll soon move it to production so that we can really see

[GitHub] [airflow] john-jac opened a new pull request #18785: Amazon Athena Example

2021-10-06 Thread GitBox
john-jac opened a new pull request #18785: URL: https://github.com/apache/airflow/pull/18785 This example, and associated documentation, shows how to use Amazon Athena to read a table from a CSV file in an S3 bucket, read from that table, and clean up all resources. The S3

[GitHub] [airflow] alex-astronomer commented on issue #18714: Make it possible to delete a permission from a role using the stable REST API

2021-10-06 Thread GitBox
alex-astronomer commented on issue #18714: URL: https://github.com/apache/airflow/issues/18714#issuecomment-937177641 Maybe we make a new `PUT` endpoint that has the behavior that we expect? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] ferruzzi edited a comment on pull request #18645: Add AWS Fargate profile support

2021-10-06 Thread GitBox
ferruzzi edited a comment on pull request #18645: URL: https://github.com/apache/airflow/pull/18645#issuecomment-937150276 Rebased and added terminal state checks to the Sensors and sensor unit tests. I believe that all above concerns/comments have been addressed at this point. --

[GitHub] [airflow] ferruzzi commented on a change in pull request #18645: Add AWS Fargate profile support

2021-10-06 Thread GitBox
ferruzzi commented on a change in pull request #18645: URL: https://github.com/apache/airflow/pull/18645#discussion_r723681321 ## File path: airflow/providers/amazon/aws/sensors/eks.py ## @@ -77,6 +82,65 @@ def poke(self, context): return cluster_state ==

[GitHub] [airflow] ferruzzi commented on pull request #18645: Add AWS Fargate profile support

2021-10-06 Thread GitBox
ferruzzi commented on pull request #18645: URL: https://github.com/apache/airflow/pull/18645#issuecomment-937150276 Rebased and added terminal state checks to the Sensors and sensor unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] bbovenzi commented on issue #18732: Tooltip element is not removed and overlays another clickable elements

2021-10-06 Thread GitBox
bbovenzi commented on issue #18732: URL: https://github.com/apache/airflow/issues/18732#issuecomment-937143372 This is a weird issue. I can confirm it happens with "All, Paused, None". But at least most of our tooltips do not experience this behavior. I'm going to need to look into

[GitHub] [airflow] coinzerge edited a comment on pull request #18622: Use seconds for schedule_delay metric

2021-10-06 Thread GitBox
coinzerge edited a comment on pull request #18622: URL: https://github.com/apache/airflow/pull/18622#issuecomment-937142337 @ashb @uranusjr updated PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] coinzerge commented on pull request #18622: Use seconds for schedule_delay metric

2021-10-06 Thread GitBox
coinzerge commented on pull request #18622: URL: https://github.com/apache/airflow/pull/18622#issuecomment-937142337 @uranusjr updated PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] bbovenzi commented on issue #18779: Task status is not updating during run within TaskGroup on UI

2021-10-06 Thread GitBox
bbovenzi commented on issue #18779: URL: https://github.com/apache/airflow/issues/18779#issuecomment-937102128 I believe this is a duplicate of #18369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[airflow] branch main updated (e351ead -> 32947a4)

2021-10-06 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from e351ead Change the color for deferred status to mediumpurple (#18414) add 32947a4 Fix deprecated default

[GitHub] [airflow] kaxil merged pull request #18783: Fix deprecated default for ``fab_logging_level`` to ``WARNING``

2021-10-06 Thread GitBox
kaxil merged pull request #18783: URL: https://github.com/apache/airflow/pull/18783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] matsavage commented on a change in pull request #18773: updates pipeline_timeout CloudDataFusionStartPipelineOperator

2021-10-06 Thread GitBox
matsavage commented on a change in pull request #18773: URL: https://github.com/apache/airflow/pull/18773#discussion_r723626576 ## File path: airflow/providers/google/cloud/operators/datafusion.py ## @@ -826,10 +826,8 @@ def __init__( if success_states:

[GitHub] [airflow] matsavage commented on a change in pull request #18773: updates pipeline_timeout CloudDataFusionStartPipelineOperator

2021-10-06 Thread GitBox
matsavage commented on a change in pull request #18773: URL: https://github.com/apache/airflow/pull/18773#discussion_r723625899 ## File path: airflow/providers/google/cloud/operators/datafusion.py ## @@ -823,13 +823,12 @@ def __init__( self.delegate_to = delegate_to

[airflow] branch main updated: Change the color for deferred status to mediumpurple (#18414)

2021-10-06 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new e351ead Change the color for deferred status

[GitHub] [airflow] kaxil merged pull request #18414: Change the color for deferred status to mediumpurple

2021-10-06 Thread GitBox
kaxil merged pull request #18414: URL: https://github.com/apache/airflow/pull/18414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] kaxil closed issue #18245: Deferred status color not distinct enough

2021-10-06 Thread GitBox
kaxil closed issue #18245: URL: https://github.com/apache/airflow/issues/18245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] kaxil commented on pull request #18359: Session propagation for task_failed_deps command

2021-10-06 Thread GitBox
kaxil commented on pull request #18359: URL: https://github.com/apache/airflow/pull/18359#issuecomment-936994977 closed by https://github.com/apache/airflow/pull/18499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] kaxil closed pull request #18359: Session propagation for task_failed_deps command

2021-10-06 Thread GitBox
kaxil closed pull request #18359: URL: https://github.com/apache/airflow/pull/18359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] kaxil closed issue #16896: Deleting task instance from UI deletes Dag Run too

2021-10-06 Thread GitBox
kaxil closed issue #16896: URL: https://github.com/apache/airflow/issues/16896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] kaxil commented on issue #16896: Deleting task instance from UI deletes Dag Run too

2021-10-06 Thread GitBox
kaxil commented on issue #16896: URL: https://github.com/apache/airflow/issues/16896#issuecomment-936992647 closed by https://github.com/apache/airflow/pull/17719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #18773: updates pipeline_timeout CloudDataFusionStartPipelineOperator

2021-10-06 Thread GitBox
ephraimbuddy commented on a change in pull request #18773: URL: https://github.com/apache/airflow/pull/18773#discussion_r723621050 ## File path: airflow/providers/google/cloud/operators/datafusion.py ## @@ -826,10 +826,8 @@ def __init__( if success_states:

[airflow] branch main updated (5306a60 -> cfc2e1b)

2021-10-06 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 5306a60 Bump pre-commits: `black` and `pyupgrade` (#18782) add cfc2e1b Always run at least one backfill

[GitHub] [airflow] kaxil merged pull request #18742: Always run at least one backfill from BackfillJob

2021-10-06 Thread GitBox
kaxil merged pull request #18742: URL: https://github.com/apache/airflow/pull/18742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] kaxil closed issue #18473: CLI: `airflow dags test { dag w/ schedule_interval=None } ` error: "No run dates were found"

2021-10-06 Thread GitBox
kaxil closed issue #18473: URL: https://github.com/apache/airflow/issues/18473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (43f334f -> 5306a60)

2021-10-06 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 43f334f Move docker decorator example dag to docker provider (#18739) add 5306a60 Bump pre-commits: `black`

[GitHub] [airflow] kaxil merged pull request #18782: Bump pre-commits: `black` and `pyupgrade`

2021-10-06 Thread GitBox
kaxil merged pull request #18782: URL: https://github.com/apache/airflow/pull/18782 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] GuidoTournois opened a new pull request #18784: Make a separate hook for interacting with the Pagerduty Events API

2021-10-06 Thread GitBox
GuidoTournois opened a new pull request #18784: URL: https://github.com/apache/airflow/pull/18784 In order to make use of the PagerDuty Events API, you need to provide two API keys in the PagerdutyHook, eventhough one of them is not required. 1) token: used to access the general

[GitHub] [airflow] xinbinhuang edited a comment on issue #18111: HeadObject error when trying to upload file to S3

2021-10-06 Thread GitBox
xinbinhuang edited a comment on issue #18111: URL: https://github.com/apache/airflow/issues/18111#issuecomment-936953895 > I want it to be able to upload a file in any case (file already exists or not), I know about the `replace` flag, but I also want to cover the case when the file

[GitHub] [airflow] xinbinhuang commented on issue #18111: HeadObject error when trying to upload file to S3

2021-10-06 Thread GitBox
xinbinhuang commented on issue #18111: URL: https://github.com/apache/airflow/issues/18111#issuecomment-936953895 > I want it to be able to upload a file in any case (file already exists or not), I know about the `replace` flag, but I also want to cover the case when the file doesn't

[GitHub] [airflow] github-actions[bot] commented on pull request #18783: Fix deprecated default for ``fab_logging_level`` to ``WARNING``

2021-10-06 Thread GitBox
github-actions[bot] commented on pull request #18783: URL: https://github.com/apache/airflow/pull/18783#issuecomment-936938273 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] github-actions[bot] commented on pull request #18780: Update changelog with more changes since 2.2.0b2

2021-10-06 Thread GitBox
github-actions[bot] commented on pull request #18780: URL: https://github.com/apache/airflow/pull/18780#issuecomment-936932850 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] kaxil opened a new pull request #18783: Fix deprecated default for ``fab_logging_level`` to ``WARNING``

2021-10-06 Thread GitBox
kaxil opened a new pull request #18783: URL: https://github.com/apache/airflow/pull/18783 `WARN` is deprecated in favor of `WARNING` --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] github-actions[bot] commented on pull request #18782: Bump pre-commits: `black` and `pyupgrade`

2021-10-06 Thread GitBox
github-actions[bot] commented on pull request #18782: URL: https://github.com/apache/airflow/pull/18782#issuecomment-936902413 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

  1   2   3   >