jedcunningham commented on a change in pull request #18916:
URL: https://github.com/apache/airflow/pull/18916#discussion_r735062068
##
File path: airflow/cli/cli_parser.py
##
@@ -1381,6 +1388,18 @@ class GroupCommand(NamedTuple):
jedcunningham commented on a change in pull request #19183:
URL: https://github.com/apache/airflow/pull/19183#discussion_r735061451
##
File path: tests/models/test_taskinstance.py
##
@@ -481,18 +482,51 @@ def task_function(ti):
ti.refresh_from_db()
ti.state
github-actions[bot] closed pull request #17485:
URL: https://github.com/apache/airflow/pull/17485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
github-actions[bot] closed issue #16208:
URL: https://github.com/apache/airflow/issues/16208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
github-actions[bot] commented on issue #16208:
URL: https://github.com/apache/airflow/issues/16208#issuecomment-950235099
This issue has been closed because it has not received response from the
issue author.
--
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] commented on pull request #17986:
URL: https://github.com/apache/airflow/pull/17986#issuecomment-950235078
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank
josh-fell commented on issue #19158:
URL: https://github.com/apache/airflow/issues/19158#issuecomment-950230524
Yes, and the printed values match what's expected. Screenshots below of the
tasks logs from the most recent DAG run:
`print_current_date`
piorkowskiprzemyslaw commented on pull request #19009:
URL: https://github.com/apache/airflow/pull/19009#issuecomment-950229627
> Should we also add a test to
https://github.com/apache/airflow/blob/main/tests/operators/test_email.py ?
I have added assertion for `custom_headers` in
jedcunningham closed pull request #19166:
URL: https://github.com/apache/airflow/pull/19166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
potiuk opened a new pull request #19189:
URL: https://github.com/apache/airflow/pull/19189
Seems that the future direction of package installation for Python
is to always use virtualenvs to install dependencies. There was a
heated discussion about it in the issue here:
pdavis156879 commented on issue #19158:
URL: https://github.com/apache/airflow/issues/19158#issuecomment-950201500
@josh-fell thank you for your reply.
In my case the tasks did not throw an error either, in fact, they ran
succesfully. However, inspecting the Logs showed those
bruciebruce opened a new issue #19188:
URL: https://github.com/apache/airflow/issues/19188
### Official Helm Chart version
1.2.0 (latest released)
### Apache Airflow version
2.1.4 (latest released)
### Kubernetes Version
Client Version:
boring-cyborg[bot] commented on issue #19188:
URL: https://github.com/apache/airflow/issues/19188#issuecomment-950190222
Thanks for opening your first issue here! Be sure to follow the issue
template!
--
This is an automated message from the Apache Git Service.
To respond to the
uranusjr edited a comment on issue #18939:
URL: https://github.com/apache/airflow/issues/18939#issuecomment-944973055
I think you get what you see because MySQL lacks DDL transaction, so when
migration failed on line 140, the database is stuck in an awkward state that
the migration is
ReadytoRocc commented on pull request #19183:
URL: https://github.com/apache/airflow/pull/19183#issuecomment-950170393
- Updated tests to be parameterized per @jedcunningham's suggestion.
- Added `session.merge(self)` to failure case in `_run_raw_task` (if
`State.finished`) where we
boring-cyborg[bot] commented on pull request #19186:
URL: https://github.com/apache/airflow/pull/19186#issuecomment-950167168
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our
KianYang-Lee opened a new pull request #19186:
URL: https://github.com/apache/airflow/pull/19186
1. Added instructions on adding postgres connection.
2. Modified proper SQL syntax.
3. Remove redundant lines when writing to CSV.
4. Added QUOTE argument for copy_expert
--
This is
mik-laj commented on pull request #19175:
URL: https://github.com/apache/airflow/pull/19175#issuecomment-950166974
It looks like a flaky test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
jedcunningham pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new fe998a4 Fix airflow jobs check cmd for
jedcunningham merged pull request #19185:
URL: https://github.com/apache/airflow/pull/19185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
simplylizz commented on pull request #19175:
URL: https://github.com/apache/airflow/pull/19175#issuecomment-950163769
https://github.com/apache/airflow/runs/3984371457?check_suite_focus=true#step:8:4114
- @mik-laj I see one test is failing after merging. Should I bother with it or
they
github-actions[bot] commented on pull request #19185:
URL: https://github.com/apache/airflow/pull/19185#issuecomment-950159417
The PR most likely needs to run full matrix of tests because it modifies
parts of the core of Airflow. However, committers might decide to merge it
quickly and
jedcunningham commented on a change in pull request #18916:
URL: https://github.com/apache/airflow/pull/18916#discussion_r734969943
##
File path: airflow/cli/cli_parser.py
##
@@ -1381,6 +1388,18 @@ class GroupCommand(NamedTuple):
kibablu commented on a change in pull request #19184:
URL: https://github.com/apache/airflow/pull/19184#discussion_r734972707
##
File path: INSTALL
##
@@ -9,6 +9,12 @@ Linux (Debian Buster and Linux Mint Tricia):
sudo apt install build-essential python3-dev libsqlite3-dev
mik-laj opened a new pull request #19185:
URL: https://github.com/apache/airflow/pull/19185
The health checks for docker-compose is still broken.
When we try to use it we will see an error like below because the class must
be loaded first.
```
AssertionError: No such
uranusjr commented on a change in pull request #19184:
URL: https://github.com/apache/airflow/pull/19184#discussion_r734971446
##
File path: INSTALL
##
@@ -9,6 +9,12 @@ Linux (Debian Buster and Linux Mint Tricia):
sudo apt install build-essential python3-dev libsqlite3-dev
mik-laj edited a comment on pull request #19181:
URL: https://github.com/apache/airflow/pull/19181#issuecomment-950148723
We are now only missing a few types to have full and strict coverage.
Before:
```
$ cat chart/values.schema.json | jq 'recurse | objects | select(.type ==
mik-laj edited a comment on pull request #19181:
URL: https://github.com/apache/airflow/pull/19181#issuecomment-950148723
We are now only missing a few types to have full and strict coverage.
Before:
```
$ cat chart/values.schema.json | jq 'recurse | objects | select(.type ==
mik-laj edited a comment on pull request #19181:
URL: https://github.com/apache/airflow/pull/19181#issuecomment-950148723
We are now only missing a few types to have full and strict coverage.
Before:
```
$ cat chart/values.schema.json | jq 'recurse | objects | select(.type ==
mik-laj commented on pull request #19181:
URL: https://github.com/apache/airflow/pull/19181#issuecomment-950149788
CC: @simplylizz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
This is an automated email from the ASF dual-hosted git repository.
kamilbregula pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from d709094 Fix breeze docker version parsing (#19182)
add 6ad837c Add migration job resources (#19175)
No
boring-cyborg[bot] commented on pull request #19175:
URL: https://github.com/apache/airflow/pull/19175#issuecomment-950149606
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
mik-laj merged pull request #19175:
URL: https://github.com/apache/airflow/pull/19175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mik-laj edited a comment on pull request #19181:
URL: https://github.com/apache/airflow/pull/19181#issuecomment-950148723
We are now only missing a few types to have full and strict coverage.
Before:
```
$ cat chart/values.schema.json | jq 'recurse | objects | select(.type ==
mik-laj edited a comment on pull request #19181:
URL: https://github.com/apache/airflow/pull/19181#issuecomment-950148723
We are now only missing a few types to have full and strict coverage.
```
$ cat chart/values.schema.json | jq 'recurse | objects | select(.type ==
"array") |
mik-laj commented on pull request #19181:
URL: https://github.com/apache/airflow/pull/19181#issuecomment-950148723
We do not lack many types now to be fully covered with the structure.
```
$ cat chart/values.schema.json | jq 'recurse | objects | select(.type ==
"array") |
Bowrna edited a comment on pull request #19100:
URL: https://github.com/apache/airflow/pull/19100#issuecomment-950138865
@ephraimbuddy I have some doubts about the below command:
```
entry: bash -c 'echo "If you think that this failure is an error, consider
adding the word(s)
mik-laj commented on a change in pull request #19175:
URL: https://github.com/apache/airflow/pull/19175#discussion_r734959805
##
File path: chart/values.schema.json
##
@@ -1737,6 +1737,24 @@
}
}
},
+
Bowrna commented on pull request #19100:
URL: https://github.com/apache/airflow/pull/19100#issuecomment-950138865
@ephraimbuddy I have some doubts about the below command:
```
entry: bash -c 'echo "If you think that this failure is an error, consider
adding the word(s)
mik-laj commented on a change in pull request #19175:
URL: https://github.com/apache/airflow/pull/19175#discussion_r734959703
##
File path: chart/values.schema.json
##
@@ -1737,6 +1737,24 @@
}
}
},
+
kaxil commented on pull request #19166:
URL: https://github.com/apache/airflow/pull/19166#issuecomment-950137351
Well done
Looks like all SQLite tests are failing, I haven't looked at failures but
you might have to special case SQLite in some instances
--
This is an automated
potiuk commented on pull request #19184:
URL: https://github.com/apache/airflow/pull/19184#issuecomment-950136959
I think some extra whitespace needs to be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
github-actions[bot] commented on pull request #19184:
URL: https://github.com/apache/airflow/pull/19184#issuecomment-950136932
The PR is likely ready to be merged. No tests are needed as no important
environment files, nor python files were modified by it. However, committers
might decide
lanms commented on issue #19069:
URL: https://github.com/apache/airflow/issues/19069#issuecomment-950127081
The problem still exists and is normal in V2.1.4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
potiuk commented on pull request #19182:
URL: https://github.com/apache/airflow/pull/19182#issuecomment-950125298
Thanks! yeah. The space removal was accidental.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new d709094 Fix breeze docker version parsing
potiuk merged pull request #19182:
URL: https://github.com/apache/airflow/pull/19182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
potiuk commented on pull request #19065:
URL: https://github.com/apache/airflow/pull/19065#issuecomment-950124625
@jedcunningham - I cherry-picked it now to v2-2-test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch v2-2-test
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/v2-2-test by this push:
new dd65bb1 Remove incorrect type comment
potiuk commented on pull request #19065:
URL: https://github.com/apache/airflow/pull/19065#issuecomment-950123678
CC: @jedcunningham - if there is still time - might be good to cherry-pick
that one to 2.2.1 - it's 0-risk change that solves real issue of the users.
--
This is an
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 1fb4729 Remove incorrect type comment in
potiuk merged pull request #19065:
URL: https://github.com/apache/airflow/pull/19065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
potiuk edited a comment on pull request #19065:
URL: https://github.com/apache/airflow/pull/19065#issuecomment-950123505
We usually don't chenge vendored code. We could potentially exclude the
connexion package from `mypy` checks but (from what I understand) in this case
it is not
potiuk commented on pull request #19065:
URL: https://github.com/apache/airflow/pull/19065#issuecomment-950123505
We usually don't chenge vendored code. We could potentially exclude the
connection package from `mypy` checks but (from what I understand) in this case
it is not "airflow's"
eskarimov edited a comment on pull request #17446:
URL: https://github.com/apache/airflow/pull/17446#issuecomment-946657445
@uranusjr thank you so much for triggering the tests - I've missed the
static code checks unfortunately, so I had to fix failed checks (and also
properly setup
simplylizz commented on a change in pull request #19175:
URL: https://github.com/apache/airflow/pull/19175#discussion_r734942135
##
File path: chart/values.schema.json
##
@@ -1737,6 +1737,23 @@
}
}
},
+
56 matches
Mail list logo
