[GitHub] [airflow] pateash edited a comment on issue #15468: DAG state is Success even in case of intermediate Task Failure for TriggerRule.ALL_DONE

2021-10-26 Thread GitBox
pateash edited a comment on issue #15468: URL: https://github.com/apache/airflow/issues/15468#issuecomment-952550267 > I have similar use case but I don't cause the DAG itself to fail if EMR failed. Like you I run a task task to terminate the machine. Am I correct that what you are asking

[GitHub] [airflow] pateash commented on issue #15468: DAG state is Success even in case of intermediate Task Failure for TriggerRule.ALL_DONE

2021-10-26 Thread GitBox
pateash commented on issue #15468: URL: https://github.com/apache/airflow/issues/15468#issuecomment-952550267 > I have similar use case but I don't cause the DAG itself to fail if EMR failed. Like you I run a task task to terminate the machine. Am I correct that what you are asking is to

[GitHub] [airflow] anaynayak commented on pull request #19022: CloudwatchTaskHandler params to create log group/stream

2021-10-26 Thread GitBox
anaynayak commented on pull request #19022: URL: https://github.com/apache/airflow/pull/19022#issuecomment-952550205 I'll add a commit with the airflow_local_settings.py change. I like the idea that @uranusjr suggested, let me know if I should do that instead. -- This is an automated

[GitHub] [airflow] pateash commented on issue #15468: DAG state is Success even in case of intermediate Task Failure for TriggerRule.ALL_DONE

2021-10-26 Thread GitBox
pateash commented on issue #15468: URL: https://github.com/apache/airflow/issues/15468#issuecomment-952549412 @eladkal @potiuk @ashb @kaxil @mik-laj Does this requirement looks legit? I would like to work on it, if this looks ok. -- This is an automated message from the Apache

[GitHub] [airflow] MatrixManAtYrService edited a comment on issue #19096: Sets in parameters cause "TypeError: Object of type set is not JSON serializable"

2021-10-26 Thread GitBox
MatrixManAtYrService edited a comment on issue #19096: URL: https://github.com/apache/airflow/issues/19096#issuecomment-952400360 If my database contains dagruns from when this used to work (1.10.15 for instance) then I can still run the dag despite the error above. When I do, I get this

[GitHub] [airflow] MatrixManAtYrService commented on issue #19096: Sets in parameters cause "TypeError: Object of type set is not JSON serializable"

2021-10-26 Thread GitBox
MatrixManAtYrService commented on issue #19096: URL: https://github.com/apache/airflow/issues/19096#issuecomment-952536684 Using these DAGs: https://gist.github.com/MatrixManAtYrService/c56bb8b94e40064ece1a6662ce585670 I saw similar behavior, except instead the error was: ```

[GitHub] [airflow] uranusjr commented on issue #17498: Connection health check

2021-10-26 Thread GitBox
uranusjr commented on issue #17498: URL: https://github.com/apache/airflow/issues/17498#issuecomment-952506925 How should we proceed now 2.2 is released? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] ew-meetup commented on a change in pull request #19137: Add RedshiftDataHook

2021-10-26 Thread GitBox
ew-meetup commented on a change in pull request #19137: URL: https://github.com/apache/airflow/pull/19137#discussion_r737069619 ## File path: airflow/providers/amazon/aws/operators/redshift_data.py ## @@ -0,0 +1,127 @@ +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [airflow] ew-meetup commented on a change in pull request #19137: Add RedshiftDataHook

2021-10-26 Thread GitBox
ew-meetup commented on a change in pull request #19137: URL: https://github.com/apache/airflow/pull/19137#discussion_r737069619 ## File path: airflow/providers/amazon/aws/operators/redshift_data.py ## @@ -0,0 +1,127 @@ +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [airflow] ew-meetup commented on a change in pull request #19137: Add RedshiftDataHook

2021-10-26 Thread GitBox
ew-meetup commented on a change in pull request #19137: URL: https://github.com/apache/airflow/pull/19137#discussion_r737069619 ## File path: airflow/providers/amazon/aws/operators/redshift_data.py ## @@ -0,0 +1,127 @@ +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [airflow] uranusjr commented on issue #17734: Backfilling ignores task-level start_date and end_date

2021-10-26 Thread GitBox
uranusjr commented on issue #17734: URL: https://github.com/apache/airflow/issues/17734#issuecomment-952492930 I believe this difference originates in the dependency definitions for (manually-triggered) backfills and scheduler-triggered runs. In

[GitHub] [airflow] josh-fell opened a new pull request #19237: Cleanup of start_date and default arg use for Amazon example DAGs

2021-10-26 Thread GitBox
josh-fell opened a new pull request #19237: URL: https://github.com/apache/airflow/pull/19237 There is an ongoing effort to enhance example DAGs by setting static values for `start_date` (already complete for core example DAGs), cleaning up and/or implementing useful `default_args`, and

[GitHub] [airflow] bbovenzi commented on a change in pull request #19211: Fix Toggle Wrap on DAG code page

2021-10-26 Thread GitBox
bbovenzi commented on a change in pull request #19211: URL: https://github.com/apache/airflow/pull/19211#discussion_r737037149 ## File path: airflow/www/static/js/dag_code.js ## @@ -17,13 +17,19 @@ * under the License. */ -/* global $ */ +/* global window, $ */ import

[GitHub] [airflow] uranusjr commented on issue #18114: TaskFlow API DAGs not working when the files are inside a .zip file.

2021-10-26 Thread GitBox
uranusjr commented on issue #18114: URL: https://github.com/apache/airflow/issues/18114#issuecomment-952455826 @ephraimbuddy Is there anything left to be done here now #18243 is merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] uranusjr commented on a change in pull request #19030: Align EcsOperator with DockerOperator capabilities

2021-10-26 Thread GitBox
uranusjr commented on a change in pull request #19030: URL: https://github.com/apache/airflow/pull/19030#discussion_r737031463 ## File path: airflow/providers/amazon/aws/operators/ecs.py ## @@ -140,10 +141,13 @@ def get_last_log_messages(self, number_messages) -> list:

[GitHub] [airflow] uranusjr commented on issue #19204: TaskInstance.execution_date usage in query creates incorrect SQL syntax

2021-10-26 Thread GitBox
uranusjr commented on issue #19204: URL: https://github.com/apache/airflow/issues/19204#issuecomment-952449357 Is the _entire_ ORM interface documented as supported at all? When I did the database changes, I was under the impression (don't remember whether explicitly told) it's considered

[GitHub] [airflow] uranusjr commented on a change in pull request #19121: Use fab models

2021-10-26 Thread GitBox
uranusjr commented on a change in pull request #19121: URL: https://github.com/apache/airflow/pull/19121#discussion_r737025668 ## File path: airflow/www/fab_security/sqla/models.py ## @@ -0,0 +1,206 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] uranusjr commented on a change in pull request #19216: Typo fix

2021-10-26 Thread GitBox
uranusjr commented on a change in pull request #19216: URL: https://github.com/apache/airflow/pull/19216#discussion_r737012396 ## File path: CONTRIBUTORS_QUICK_START.rst ## @@ -147,29 +147,36 @@ Pyenv and setting up virtual-env 3. Add the lines suggested at the end of

[GitHub] [airflow] uranusjr commented on a change in pull request #17421: Add ShortCircuitOperator configurability for respecting downstream trigger rules

2021-10-26 Thread GitBox
uranusjr commented on a change in pull request #17421: URL: https://github.com/apache/airflow/pull/17421#discussion_r737011293 ## File path: airflow/operators/python.py ## @@ -185,16 +186,37 @@ def execute(self, context: Dict): class ShortCircuitOperator(PythonOperator,

[GitHub] [airflow] github-actions[bot] commented on pull request #15743: Redirect forked process output to logger

2021-10-26 Thread GitBox
github-actions[bot] commented on pull request #15743: URL: https://github.com/apache/airflow/pull/15743#issuecomment-952424287 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank

[GitHub] [airflow] github-actions[bot] commented on issue #13812: After migrating from version 1.10.12 to 2.0.0, SimpleHttpOperator produces the error "Data too long for column 'value' at row 1" when

2021-10-26 Thread GitBox
github-actions[bot] commented on issue #13812: URL: https://github.com/apache/airflow/issues/13812#issuecomment-952424314 This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further

[airflow] branch main updated (eba1b68 -> efdfd15)

2021-10-26 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from eba1b68 Update dataflow.py (#19231) add efdfd15 Dev: Clarify file naming in release verification doc

[GitHub] [airflow] kaxil merged pull request #19233: Clarify file naming in release verification doc

2021-10-26 Thread GitBox
kaxil merged pull request #19233: URL: https://github.com/apache/airflow/pull/19233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] MatrixManAtYrService commented on issue #19096: Sets in parameters cause "TypeError: Object of type set is not JSON serializable"

2021-10-26 Thread GitBox
MatrixManAtYrService commented on issue #19096: URL: https://github.com/apache/airflow/issues/19096#issuecomment-952400360 I tried this in 2.2.1 It no longer gives me an error at the top of the DAGs page, but now when I try to run it it takes me to an "Oops, something bad has

[GitHub] [airflow] jedcunningham commented on a change in pull request #19233: Clarify file naming in release verification doc

2021-10-26 Thread GitBox
jedcunningham commented on a change in pull request #19233: URL: https://github.com/apache/airflow/pull/19233#discussion_r736967454 ## File path: dev/README_RELEASE_PROVIDER_PACKAGES.md ## @@ -445,9 +445,8 @@ The files should be present in The following files should be

[GitHub] [airflow] uranusjr commented on a change in pull request #19203: Add release date for when an endpoint/field is added in the REST API

2021-10-26 Thread GitBox
uranusjr commented on a change in pull request #19203: URL: https://github.com/apache/airflow/pull/19203#discussion_r736964690 ## File path: airflow/api_connexion/openapi/v1.yaml ## @@ -372,6 +372,10 @@ paths: /connections/test: post: summary: Test a connection

[GitHub] [airflow] uranusjr commented on a change in pull request #19203: Add release date for when an endpoint/field is added in the REST API

2021-10-26 Thread GitBox
uranusjr commented on a change in pull request #19203: URL: https://github.com/apache/airflow/pull/19203#discussion_r736952598 ## File path: airflow/api_connexion/openapi/v1.yaml ## @@ -2700,20 +2860,29 @@ components: - $ref: '#/components/schemas/CollectionInfo'

[GitHub] [airflow] github-actions[bot] commented on pull request #19233: Clarify file naming in release verification doc

2021-10-26 Thread GitBox
github-actions[bot] commented on pull request #19233: URL: https://github.com/apache/airflow/pull/19233#issuecomment-952357276 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] uranusjr commented on a change in pull request #18981: Fix bug in Dataflow hook when no jobs are returned

2021-10-26 Thread GitBox
uranusjr commented on a change in pull request #18981: URL: https://github.com/apache/airflow/pull/18981#discussion_r736949240 ## File path: tests/providers/google/cloud/hooks/test_dataflow.py ## @@ -1697,6 +1697,27 @@ def test_fetch_list_job_messages_responses(self):

[GitHub] [airflow] dstandish commented on a change in pull request #19233: Clarify file naming in release verification doc

2021-10-26 Thread GitBox
dstandish commented on a change in pull request #19233: URL: https://github.com/apache/airflow/pull/19233#discussion_r736939064 ## File path: dev/README_RELEASE_AIRFLOW_UPGRADE_CHECK.md ## @@ -305,7 +305,7 @@ This can be done with the Apache RAT tool. * Download the latest

[GitHub] [airflow] github-actions[bot] commented on pull request #19124: Modify doc contributing

2021-10-26 Thread GitBox
github-actions[bot] commented on pull request #19124: URL: https://github.com/apache/airflow/pull/19124#issuecomment-952324604 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] uranusjr commented on a change in pull request #19124: Modify doc contributing

2021-10-26 Thread GitBox
uranusjr commented on a change in pull request #19124: URL: https://github.com/apache/airflow/pull/19124#discussion_r736919245 ## File path: CONTRIBUTING.rst ## @@ -198,9 +198,7 @@ Step 2: Configure Your Environment -- You can use either a

[GitHub] [airflow] dstandish commented on a change in pull request #19233: Clarify file naming in release verification doc

2021-10-26 Thread GitBox
dstandish commented on a change in pull request #19233: URL: https://github.com/apache/airflow/pull/19233#discussion_r736898370 ## File path: dev/README_RELEASE_AIRFLOW_UPGRADE_CHECK.md ## @@ -305,7 +305,7 @@ This can be done with the Apache RAT tool. * Download the latest

[GitHub] [airflow] uranusjr commented on pull request #19195: SagemakerProcessingOperator ThrottlingException #16763 #19066

2021-10-26 Thread GitBox
uranusjr commented on pull request #19195: URL: https://github.com/apache/airflow/pull/19195#issuecomment-952303369 Need to fix the static checks. ```diff All changes made by hooks: diff --git a/airflow/providers/amazon/aws/operators/sagemaker_processing.py

[GitHub] [airflow] uranusjr commented on a change in pull request #18927: Support query timeout as an argument in CassandraToGCSOperator

2021-10-26 Thread GitBox
uranusjr commented on a change in pull request #18927: URL: https://github.com/apache/airflow/pull/18927#discussion_r736896315 ## File path: tests/providers/google/cloud/transfers/test_cassandra_to_gcs.py ## @@ -48,6 +49,10 @@ def test_execute(self, mock_hook, mock_upload,

[GitHub] [airflow] kaxil commented on a change in pull request #19233: Clarify file naming in release verification doc

2021-10-26 Thread GitBox
kaxil commented on a change in pull request #19233: URL: https://github.com/apache/airflow/pull/19233#discussion_r736894005 ## File path: dev/README_RELEASE_AIRFLOW_UPGRADE_CHECK.md ## @@ -305,7 +305,7 @@ This can be done with the Apache RAT tool. * Download the latest jar

[GitHub] [airflow] kaxil commented on a change in pull request #19233: Clarify file naming in release verification doc

2021-10-26 Thread GitBox
kaxil commented on a change in pull request #19233: URL: https://github.com/apache/airflow/pull/19233#discussion_r736893899 ## File path: dev/README_RELEASE_AIRFLOW.md ## @@ -383,7 +383,7 @@ This can be done with the Apache RAT tool. * Download the latest jar from

[GitHub] [airflow] dstandish commented on a change in pull request #19233: Clarify file naming in release verification doc

2021-10-26 Thread GitBox
dstandish commented on a change in pull request #19233: URL: https://github.com/apache/airflow/pull/19233#discussion_r736891813 ## File path: dev/README_RELEASE_AIRFLOW.md ## @@ -354,9 +354,9 @@ The files should be present in the sub-folder of The following files should be

[airflow] branch main updated: Update dataflow.py (#19231)

2021-10-26 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new eba1b68 Update dataflow.py (#19231) eba1b68 is

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19231: Update dataflow.py

2021-10-26 Thread GitBox
boring-cyborg[bot] commented on pull request #19231: URL: https://github.com/apache/airflow/pull/19231#issuecomment-952294804 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] uranusjr merged pull request #19231: Update dataflow.py

2021-10-26 Thread GitBox
uranusjr merged pull request #19231: URL: https://github.com/apache/airflow/pull/19231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #19231: Update dataflow.py

2021-10-26 Thread GitBox
github-actions[bot] commented on pull request #19231: URL: https://github.com/apache/airflow/pull/19231#issuecomment-952294536 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] rzeydelis-AS commented on pull request #19231: Update dataflow.py

2021-10-26 Thread GitBox
rzeydelis-AS commented on pull request #19231: URL: https://github.com/apache/airflow/pull/19231#issuecomment-952293342 This is my first time doing a PR. Did I do everything correctly? I was just adding a space in an error comment. -- This is an automated message from the Apache Git

[GitHub] [airflow] dstandish commented on a change in pull request #19233: Clarify file naming in release verification doc

2021-10-26 Thread GitBox
dstandish commented on a change in pull request #19233: URL: https://github.com/apache/airflow/pull/19233#discussion_r736886223 ## File path: dev/README_RELEASE_AIRFLOW.md ## @@ -354,9 +354,9 @@ The files should be present in the sub-folder of The following files should be

[GitHub] [airflow] NilsJPWerner opened a new issue #19235: Add task actions to task view

2021-10-26 Thread GitBox
NilsJPWerner opened a new issue #19235: URL: https://github.com/apache/airflow/issues/19235 ### Description A section in the task view that exposes the task actions that are available in the task modal in the dag view. ### Use case/motivation We always check the logs

[GitHub] [airflow] jedcunningham closed pull request #19194: Refactor ti clear next method kwargs tests

2021-10-26 Thread GitBox
jedcunningham closed pull request #19194: URL: https://github.com/apache/airflow/pull/19194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] bbovenzi commented on pull request #18675: New Tree View

2021-10-26 Thread GitBox
bbovenzi commented on pull request #18675: URL: https://github.com/apache/airflow/pull/18675#issuecomment-952258374 Update: I added horizontal scroll and rearranged some labels. ![Oct-26-2021

[GitHub] [airflow] o-nikolas commented on a change in pull request #19195: SagemakerProcessingOperator ThrottlingException #16763 #19066

2021-10-26 Thread GitBox
o-nikolas commented on a change in pull request #19195: URL: https://github.com/apache/airflow/pull/19195#discussion_r736845819 ## File path: airflow/providers/amazon/aws/hooks/sagemaker.py ## @@ -954,3 +954,13 @@ def _list_request( return results

[GitHub] [airflow] MM-Lehmann edited a comment on issue #19205: Grouping of connections

2021-10-26 Thread GitBox
MM-Lehmann edited a comment on issue #19205: URL: https://github.com/apache/airflow/issues/19205#issuecomment-952232885 Well, I thought it was obvious but trying to provide you with a doc link, I must admit it's actually not that well

[GitHub] [airflow] MM-Lehmann edited a comment on issue #19205: Grouping of connections

2021-10-26 Thread GitBox
MM-Lehmann edited a comment on issue #19205: URL: https://github.com/apache/airflow/issues/19205#issuecomment-952232885 Well, I thought it was obvious but trying to provide you with a doc link, I must admit it's actually not that well documented. But there is third-party info on it. Just

[GitHub] [airflow] MM-Lehmann commented on issue #19205: Grouping of connections

2021-10-26 Thread GitBox
MM-Lehmann commented on issue #19205: URL: https://github.com/apache/airflow/issues/19205#issuecomment-952232885 Well, I thought it was obvious but trying to provide you with a doc link, I must admit it's actually not that well documented. But there is third-party info on it. Just like

[airflow] branch main updated: Fix hard-coded /tmp directory in CloudSQL Hook (#19229)

2021-10-26 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 7ecf29f Fix hard-coded /tmp directory in CloudSQL

[GitHub] [airflow] potiuk merged pull request #19229: Fix hard-coded /tmp directory in CloudSQL Hook

2021-10-26 Thread GitBox
potiuk merged pull request #19229: URL: https://github.com/apache/airflow/pull/19229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] edithturn commented on a change in pull request #19124: Modify doc contributing

2021-10-26 Thread GitBox
edithturn commented on a change in pull request #19124: URL: https://github.com/apache/airflow/pull/19124#discussion_r736828298 ## File path: CONTRIBUTING.rst ## @@ -198,50 +198,63 @@ Step 2: Configure Your Environment -- You can use either

[GitHub] [airflow] edithturn commented on a change in pull request #19124: Modify doc contributing

2021-10-26 Thread GitBox
edithturn commented on a change in pull request #19124: URL: https://github.com/apache/airflow/pull/19124#discussion_r736827169 ## File path: CONTRIBUTING.rst ## @@ -198,50 +198,63 @@ Step 2: Configure Your Environment -- You can use either

[airflow] branch main updated (d426b46 -> f83099c)

2021-10-26 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from d426b46 Chart: Add labels to jobs created by cleanup pods (#19225) add f83099c Doc: Improve tutorial

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19186: Improving tutorial documentation and code

2021-10-26 Thread GitBox
boring-cyborg[bot] commented on pull request #19186: URL: https://github.com/apache/airflow/pull/19186#issuecomment-952207170 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] kaxil merged pull request #19186: Improving tutorial documentation and code

2021-10-26 Thread GitBox
kaxil merged pull request #19186: URL: https://github.com/apache/airflow/pull/19186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (77c9268 -> d426b46)

2021-10-26 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 77c9268 Removes hard-coding of /tmp filesystem cache (#19208) add d426b46 Chart: Add labels to jobs created

[GitHub] [airflow] kaxil merged pull request #19225: Add Labels to jobs created by cleanup pods

2021-10-26 Thread GitBox
kaxil merged pull request #19225: URL: https://github.com/apache/airflow/pull/19225 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19225: Add Labels to jobs created by cleanup pods

2021-10-26 Thread GitBox
boring-cyborg[bot] commented on pull request #19225: URL: https://github.com/apache/airflow/pull/19225#issuecomment-952206155 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] kaxil commented on a change in pull request #19233: Clarify file naming in release verification doc

2021-10-26 Thread GitBox
kaxil commented on a change in pull request #19233: URL: https://github.com/apache/airflow/pull/19233#discussion_r736816682 ## File path: dev/README_RELEASE_AIRFLOW.md ## @@ -354,9 +354,9 @@ The files should be present in the sub-folder of The following files should be

[GitHub] [airflow] potiuk commented on a change in pull request #19233: Clarify file naming in release verification doc

2021-10-26 Thread GitBox
potiuk commented on a change in pull request #19233: URL: https://github.com/apache/airflow/pull/19233#discussion_r736807456 ## File path: dev/README_RELEASE_AIRFLOW.md ## @@ -354,9 +354,9 @@ The files should be present in the sub-folder of The following files should be

[GitHub] [airflow] ReadytoRocc opened a new pull request #19234: Added sas_token var to BlobServiceClient return. Updated tests

2021-10-26 Thread GitBox
ReadytoRocc opened a new pull request #19234: URL: https://github.com/apache/airflow/pull/19234 Currently, we are unable to pass the full URI for the `sas_token` argument in an Azure Blob connection. This is because the `extra.get('extra__wasb__sas_token')` was not being passed to the

[GitHub] [airflow] github-actions[bot] commented on pull request #19229: Fix hard-coded /tmp directory in CloudSQL Hook

2021-10-26 Thread GitBox
github-actions[bot] commented on pull request #19229: URL: https://github.com/apache/airflow/pull/19229#issuecomment-952192638 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] potiuk commented on a change in pull request #19233: Clarify file naming in release verification doc

2021-10-26 Thread GitBox
potiuk commented on a change in pull request #19233: URL: https://github.com/apache/airflow/pull/19233#discussion_r736796959 ## File path: dev/README_RELEASE_PROVIDER_PACKAGES.md ## @@ -445,9 +445,9 @@ The files should be present in The following files should be present (9

[GitHub] [airflow] jedcunningham closed pull request #19194: Refactor ti clear next method kwargs tests

2021-10-26 Thread GitBox
jedcunningham closed pull request #19194: URL: https://github.com/apache/airflow/pull/19194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] jedcunningham commented on a change in pull request #19233: Clarify file naming in release verification doc

2021-10-26 Thread GitBox
jedcunningham commented on a change in pull request #19233: URL: https://github.com/apache/airflow/pull/19233#discussion_r736782890 ## File path: dev/README_RELEASE_AIRFLOW.md ## @@ -354,9 +354,9 @@ The files should be present in the sub-folder of The following files should

[GitHub] [airflow] dstandish commented on a change in pull request #19214: Expanding ``.output`` operator property information in TaskFlow tutorial doc

2021-10-26 Thread GitBox
dstandish commented on a change in pull request #19214: URL: https://github.com/apache/airflow/pull/19214#discussion_r736703287 ## File path: docs/apache-airflow/tutorial_taskflow_api.rst ## @@ -224,11 +224,11 @@ is automatically set to true. Note, If you manually set the

[GitHub] [airflow] potiuk commented on pull request #19229: Fix hard-coded /tmp directory in CloudSQL Hook

2021-10-26 Thread GitBox
potiuk commented on pull request #19229: URL: https://github.com/apache/airflow/pull/19229#issuecomment-952167839 > Maybe worth creating another pull request for /tmp usage in

[GitHub] [airflow] aran3 commented on pull request #19229: Fix hard-coded /tmp directory in CloudSQL Hook

2021-10-26 Thread GitBox
aran3 commented on pull request #19229: URL: https://github.com/apache/airflow/pull/19229#issuecomment-952138049 Maybe worth creating another pull request for /tmp usage in

[GitHub] [airflow] xuan616 commented on pull request #18927: Support query timeout as an argument in CassandraToGCSOperator

2021-10-26 Thread GitBox
xuan616 commented on pull request #18927: URL: https://github.com/apache/airflow/pull/18927#issuecomment-952136411 @uranusjr updated. Could you hep take another look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] dstandish opened a new pull request #19233: Clarify file naming in release verification doc

2021-10-26 Thread GitBox
dstandish opened a new pull request #19233: URL: https://github.com/apache/airflow/pull/19233 The file pattern `-bin-` is not actually present in current release process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] potiuk edited a comment on issue #18010: Airflow scheduler with statsd enabled crashes when dag_id contains unexpected characters

2021-10-26 Thread GitBox
potiuk edited a comment on issue #18010: URL: https://github.com/apache/airflow/issues/18010#issuecomment-952120850 Good points @Melodie97 :) I think a) and using python-slugify is the way to go. Anything that we do in `main` is by default now 2.3 (we cut-off the 2.2 branch

[GitHub] [airflow] potiuk commented on issue #18010: Airflow scheduler with statsd enabled crashes when dag_id contains unexpected characters

2021-10-26 Thread GitBox
potiuk commented on issue #18010: URL: https://github.com/apache/airflow/issues/18010#issuecomment-952120850 Good points @Melodie97 :) I think a) and using python-slugify is the way to go. Anything that we do in `main` is by default now 2.3 (we cut-off the 2.2 branch when we

[GitHub] [airflow] Melodie97 commented on issue #18010: Airflow scheduler with statsd enabled crashes when dag_id contains unexpected characters

2021-10-26 Thread GitBox
Melodie97 commented on issue #18010: URL: https://github.com/apache/airflow/issues/18010#issuecomment-952110785 @potiuk, based on the discussions had concerning this issue, should I go ahead to: a) allow to use non-ASCII and fix all the problems related or b) add some non-ASCII

[GitHub] [airflow] dstandish commented on a change in pull request #19214: Expanding ``.output`` operator property information in TaskFlow tutorial doc

2021-10-26 Thread GitBox
dstandish commented on a change in pull request #19214: URL: https://github.com/apache/airflow/pull/19214#discussion_r736703287 ## File path: docs/apache-airflow/tutorial_taskflow_api.rst ## @@ -224,11 +224,11 @@ is automatically set to true. Note, If you manually set the

[GitHub] [airflow] potiuk closed issue #19230: Can't run FFmpeg in python os.system or use ffmpeg-python package

2021-10-26 Thread GitBox
potiuk closed issue #19230: URL: https://github.com/apache/airflow/issues/19230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (726a151 -> 77c9268)

2021-10-26 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 726a151 Fix bug in Dataflow hook when no jobs are returned (#18981) add 77c9268 Removes hard-coding of /tmp

[GitHub] [airflow] potiuk merged pull request #19208: Removes hard-coding of /tmp filesystem cache

2021-10-26 Thread GitBox
potiuk merged pull request #19208: URL: https://github.com/apache/airflow/pull/19208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk closed issue #19206: Webserver uses /tmp and does not respect user-configured tempdir path

2021-10-26 Thread GitBox
potiuk closed issue #19206: URL: https://github.com/apache/airflow/issues/19206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] rzeydelis-AS opened a new pull request #19231: Update dataflow.py

2021-10-26 Thread GitBox
rzeydelis-AS opened a new pull request #19231: URL: https://github.com/apache/airflow/pull/19231 Fixed spelling mistake :) line 902: "the name must consist ofonly the characters" -> "the name must consist of only the characters" --- **^ Add meaningful description

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19231: Update dataflow.py

2021-10-26 Thread GitBox
boring-cyborg[bot] commented on pull request #19231: URL: https://github.com/apache/airflow/pull/19231#issuecomment-952093508 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] potiuk commented on issue #18010: Airflow scheduler with statsd enabled crashes when dag_id contains unexpected characters

2021-10-26 Thread GitBox
potiuk commented on issue #18010: URL: https://github.com/apache/airflow/issues/18010#issuecomment-952093114 Just added it to label the issues related to telemetry :). U think nothing special changed - I think no-one was working on that issue yet. It's free to work on :) -- This is an

[GitHub] [airflow] dstandish commented on a change in pull request #19214: Expanding ``.output`` operator property information in TaskFlow tutorial doc

2021-10-26 Thread GitBox
dstandish commented on a change in pull request #19214: URL: https://github.com/apache/airflow/pull/19214#discussion_r736703287 ## File path: docs/apache-airflow/tutorial_taskflow_api.rst ## @@ -224,11 +224,11 @@ is automatically set to true. Note, If you manually set the

[GitHub] [airflow] Codle opened a new issue #19230: Can't run FFmpeg in python os.system or use ffmpeg-python package

2021-10-26 Thread GitBox
Codle opened a new issue #19230: URL: https://github.com/apache/airflow/issues/19230 ### Apache Airflow version 2.2.0 (latest released) ### Operating System Ubuntu, Debian 9 ### Versions of Apache Airflow Providers _No response_ ### Deployment

[GitHub] [airflow] boring-cyborg[bot] commented on issue #19230: Can't run FFmpeg in python os.system or use ffmpeg-python package

2021-10-26 Thread GitBox
boring-cyborg[bot] commented on issue #19230: URL: https://github.com/apache/airflow/issues/19230#issuecomment-952089980 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] github-actions[bot] commented on pull request #19208: Removes hard-coding of /tmp filesystem cache

2021-10-26 Thread GitBox
github-actions[bot] commented on pull request #19208: URL: https://github.com/apache/airflow/pull/19208#issuecomment-952087255 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] github-actions[bot] commented on pull request #19225: Add Labels to jobs created by cleanup pods

2021-10-26 Thread GitBox
github-actions[bot] commented on pull request #19225: URL: https://github.com/apache/airflow/pull/19225#issuecomment-952086778 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] jedcunningham commented on a change in pull request #19225: Add Labels to jobs created by cleanup pods

2021-10-26 Thread GitBox
jedcunningham commented on a change in pull request #19225: URL: https://github.com/apache/airflow/pull/19225#discussion_r736694572 ## File path: chart/tests/test_cleanup_pods.py ## @@ -158,3 +158,21 @@ def test_command_and_args_overrides_are_templated(self):

[GitHub] [airflow] Melodie97 commented on issue #18010: Airflow scheduler with statsd enabled crashes when dag_id contains unexpected characters

2021-10-26 Thread GitBox
Melodie97 commented on issue #18010: URL: https://github.com/apache/airflow/issues/18010#issuecomment-952079872 Hi @potiuk, what have we resolved to do about this issue, I see you added the telemetry label to it -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] potiuk commented on issue #19205: Grouping of connections

2021-10-26 Thread GitBox
potiuk commented on issue #19205: URL: https://github.com/apache/airflow/issues/19205#issuecomment-952074865 How are you using acess_control roles to achieve that? Could you elaborate a bit? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] potiuk commented on a change in pull request #19227: Fix GCS system tests

2021-10-26 Thread GitBox
potiuk commented on a change in pull request #19227: URL: https://github.com/apache/airflow/pull/19227#discussion_r736675490 ## File path: airflow/providers/google/cloud/example_dags/example_gcs.py ## @@ -50,10 +50,10 @@ BUCKET_2 = os.environ.get("GCP_GCS_BUCKET_2",

[GitHub] [airflow] potiuk commented on a change in pull request #19164: Add support in GCP connection for reading key from Secret Manager

2021-10-26 Thread GitBox
potiuk commented on a change in pull request #19164: URL: https://github.com/apache/airflow/pull/19164#discussion_r736671295 ## File path: airflow/providers/google/cloud/utils/credentials_provider.py ## @@ -283,6 +289,31 @@ def _get_credentials_using_key_path(self):

[airflow] annotated tag 2.2.1rc2 updated (360474f -> f936ddc)

2021-10-26 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to annotated tag 2.2.1rc2 in repository https://gitbox.apache.org/repos/asf/airflow.git. *** WARNING: tag 2.2.1rc2 was modified! *** from 360474f (commit) to f936ddc (tag) tagging

[GitHub] [airflow] MM-Lehmann commented on issue #19205: Grouping of connections

2021-10-26 Thread GitBox
MM-Lehmann commented on issue #19205: URL: https://github.com/apache/airflow/issues/19205#issuecomment-952052234 > I think it makes very little sense to focus on connections, where we even have no "group" access to DAGs. Airflow'w mutli-tenancy features are virtualy non-existing and

[GitHub] [airflow] potiuk commented on issue #19205: Grouping of connections

2021-10-26 Thread GitBox
potiuk commented on issue #19205: URL: https://github.com/apache/airflow/issues/19205#issuecomment-952048924 BTW. I am very likely going to start focusing big part of my time on moving "multi-tenancy" forward in the coming months, and I belive this should be part of the overall AIP. --

svn commit: r50627 - /dev/airflow/2.2.1rc2/

2021-10-26 Thread jedcunningham
Author: jedcunningham Date: Tue Oct 26 15:20:48 2021 New Revision: 50627 Log: Add artifacts for Airflow 2.2.1rc2 Added: dev/airflow/2.2.1rc2/ dev/airflow/2.2.1rc2/apache-airflow-2.2.1-source.tar.gz (with props) dev/airflow/2.2.1rc2/apache-airflow-2.2.1-source.tar.gz.asc

[GitHub] [airflow] potiuk commented on issue #19205: Grouping of connections

2021-10-26 Thread GitBox
potiuk commented on issue #19205: URL: https://github.com/apache/airflow/issues/19205#issuecomment-952047448 I think it makes very little sense to focus on connections, where we even have no "group" access to DAGs. Airflow'w mutli-tenancy features are virtualy non-existing and connection

[airflow] annotated tag constraints-2.2.1rc2 updated (17cff54 -> 85df24e)

2021-10-26 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to annotated tag constraints-2.2.1rc2 in repository https://gitbox.apache.org/repos/asf/airflow.git. *** WARNING: tag constraints-2.2.1rc2 was modified! *** from 17cff54 (commit) to

  1   2   3   >