[GitHub] [airflow] riccardo-salamanna commented on a change in pull request #21401: added envFrom statement to the flower deployment

2022-02-07 Thread GitBox
riccardo-salamanna commented on a change in pull request #21401: URL: https://github.com/apache/airflow/pull/21401#discussion_r801349808 ## File path: chart/templates/flower/flower-deployment.yaml ## @@ -128,6 +128,8 @@ spec: name: {{ template

[GitHub] [airflow] avkirilishin edited a comment on pull request #21214: Removes the next_dagrun_create_after reset

2022-02-07 Thread GitBox
avkirilishin edited a comment on pull request #21214: URL: https://github.com/apache/airflow/pull/21214#issuecomment-1032303165 Can we add `test_runs_are_created_after_max_active_runs_was_reached` to #21413 from this merge request?

[GitHub] [airflow] avkirilishin edited a comment on pull request #21214: Removes the next_dagrun_create_after reset

2022-02-07 Thread GitBox
avkirilishin edited a comment on pull request #21214: URL: https://github.com/apache/airflow/pull/21214#issuecomment-1032303165 Can we add `test_runs_are_created_after_max_active_runs_was_reached` to #21413 from this merge request?

[GitHub] [airflow] avkirilishin commented on pull request #21214: Removes the next_dagrun_create_after reset

2022-02-07 Thread GitBox
avkirilishin commented on pull request #21214: URL: https://github.com/apache/airflow/pull/21214#issuecomment-1032303165 Can we add `test_runs_are_created_after_max_active_runs_was_reached` to #21413 from this merge request? -- This is an automated message from the Apache Git Service.

[GitHub] [airflow] ephraimbuddy commented on pull request #21214: Removes the next_dagrun_create_after reset

2022-02-07 Thread GitBox
ephraimbuddy commented on pull request #21214: URL: https://github.com/apache/airflow/pull/21214#issuecomment-1032286602 I have added the PR: https://github.com/apache/airflow/pull/21413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] ephraimbuddy opened a new pull request #21413: Fix max_active_runs=1 not scheduling runs when min_file_process_interval is high

2022-02-07 Thread GitBox
ephraimbuddy opened a new pull request #21413: URL: https://github.com/apache/airflow/pull/21413 When we make a query to get the total active runs, it returns the dagrun being examined as running. Therefore we subtract the dagrun being examined from active runs. There's a bug

[GitHub] [airflow] Acehaidrey commented on pull request #20733: Add Audit Log View to Dag View

2022-02-07 Thread GitBox
Acehaidrey commented on pull request #20733: URL: https://github.com/apache/airflow/pull/20733#issuecomment-1032262412 I have tried everything I can to get the docker-compose quick start test to complete successfully. I see other PRs also failing similarly. -- This is an automated

[GitHub] [airflow] BenGatewood opened a new issue #21412: v3.5.0 airflow.providers.microsoft.azure.operators.cosmos not running

2022-02-07 Thread GitBox
BenGatewood opened a new issue #21412: URL: https://github.com/apache/airflow/issues/21412 ### Apache Airflow version 2.2.3 (latest released) ### What happened Submitting this on advice from the community Slack: Attempting to use the v3.5.0

[GitHub] [airflow] boring-cyborg[bot] commented on issue #21412: v3.5.0 airflow.providers.microsoft.azure.operators.cosmos not running

2022-02-07 Thread GitBox
boring-cyborg[bot] commented on issue #21412: URL: https://github.com/apache/airflow/issues/21412#issuecomment-1032239971 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] josh-fell opened a new pull request #21411: Update Zendesk example DAG to use TaskFlow API

2022-02-07 Thread GitBox
josh-fell opened a new pull request #21411: URL: https://github.com/apache/airflow/pull/21411 Related: #9415 Staying consistent with previous work that was done to convert example DAGs to the functional style of authoring, this PR updates the example DAG for Zendesk to use the

[airflow] branch main updated (471e368 -> 34d63fa)

2022-02-07 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 471e368 [Oracle] Oracle Hook - automatically set current_schema when defined in Connection (#19084) add

[GitHub] [airflow] mik-laj merged pull request #21293: Fix BigQueryDataTransferServiceHook.get_transfer_run() request parameter

2022-02-07 Thread GitBox
mik-laj merged pull request #21293: URL: https://github.com/apache/airflow/pull/21293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21293: Fix BigQueryDataTransferServiceHook.get_transfer_run() request parameter

2022-02-07 Thread GitBox
boring-cyborg[bot] commented on pull request #21293: URL: https://github.com/apache/airflow/pull/21293#issuecomment-1032194740 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] danmactough commented on issue #13542: Task stuck in "scheduled" or "queued" state, pool has all slots queued, nothing is executing

2022-02-07 Thread GitBox
danmactough commented on issue #13542: URL: https://github.com/apache/airflow/issues/13542#issuecomment-1032153919 > Thre is also 2.2.2 as of recently. Can you please upgrade and check it there @danmactough ? Wow @potiuk I totally missed that update! Huge news! I'll check that out

[GitHub] [airflow] zmac12 opened a new pull request #21408: Remove extra 'of'

2022-02-07 Thread GitBox
zmac12 opened a new pull request #21408: URL: https://github.com/apache/airflow/pull/21408 Just a double 'of', removes the second one. --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21408: Remove extra 'of'

2022-02-07 Thread GitBox
boring-cyborg[bot] commented on pull request #21408: URL: https://github.com/apache/airflow/pull/21408#issuecomment-1032152939 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] pingzh commented on pull request #21296: Fix relationship join bug in FAB/SecurityManager with SQLA 1.4

2022-02-07 Thread GitBox
pingzh commented on pull request #21296: URL: https://github.com/apache/airflow/pull/21296#issuecomment-1032131134 could you please also put more context information about the relationship join bug that this pr tried to fix? -- This is an automated message from the Apache Git Service.

[GitHub] [airflow] pingzh edited a comment on issue #21407: AssertionError: Dependency rule tried to blank-out primary key column 'ab_permission.id' on instance '

2022-02-07 Thread GitBox
pingzh edited a comment on issue #21407: URL: https://github.com/apache/airflow/issues/21407#issuecomment-1032125080 i think it should be related to this PR https://github.com/apache/airflow/pull/21296 after I reseted to a commit before that PR. it worked. How to reproduce:

[GitHub] [airflow] pingzh commented on pull request #21296: Fix relationship join bug in FAB/SecurityManager with SQLA 1.4

2022-02-07 Thread GitBox
pingzh commented on pull request #21296: URL: https://github.com/apache/airflow/pull/21296#issuecomment-1032125611 @ashb , looks like this pr has caused this issue https://github.com/apache/airflow/issues/21407 -- This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] pingzh commented on issue #21407: AssertionError: Dependency rule tried to blank-out primary key column 'ab_permission.id' on instance '

2022-02-07 Thread GitBox
pingzh commented on issue #21407: URL: https://github.com/apache/airflow/issues/21407#issuecomment-1032125080 i think it should be related to this PR https://github.com/apache/airflow/pull/21296 after I reseted to a commit before that PR. it worked. -- This is an automated

[GitHub] [airflow] kbaruri commented on issue #14320: Testing tasks with pytest: sqlalchemy.orm.exc.NoResultFound raised on a task's first .run()

2022-02-07 Thread GitBox
kbaruri commented on issue #14320: URL: https://github.com/apache/airflow/issues/14320#issuecomment-1032123233 +1 encountered this issue while running a similar test using the `python:3.7` docker image. -- This is an automated message from the Apache Git Service. To respond to the

[airflow] branch constraints-2-2 updated: Updating constraints. Build id:1809570159

2022-02-07 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-2-2 in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-2-2 by this push: new 2e47d4d Updating

[GitHub] [airflow] pingzh opened a new issue #21407: AssertionError: Dependency rule tried to blank-out primary key column 'ab_permission.id' on instance '

2022-02-07 Thread GitBox
pingzh opened a new issue #21407: URL: https://github.com/apache/airflow/issues/21407 ### Apache Airflow version main (development) ### What happened airflow webserver cannot start due to error ``` AssertionError: Dependency rule tried to blank-out primary key

[GitHub] [airflow] blag opened a new pull request #21406: Tweak origin parameter

2022-02-07 Thread GitBox
blag opened a new pull request #21406: URL: https://github.com/apache/airflow/pull/21406 This is a simpler alternative to #21310. The `origin` parameter is used to take users back to a previous page they were on. This PR fixes the way this parameter was handled. The

[GitHub] [airflow] dstandish commented on a change in pull request #21398: Add pre-commit check for docstring param types

2022-02-07 Thread GitBox
dstandish commented on a change in pull request #21398: URL: https://github.com/apache/airflow/pull/21398#discussion_r801178851 ## File path: scripts/ci/pre_commit/pre_commit_docstring_param_type.py ## @@ -0,0 +1,58 @@ +#!/usr/bin/env python3 +# Licensed to the Apache Software

[GitHub] [airflow] dstandish commented on a change in pull request #21398: Add pre-commit check for docstring param types

2022-02-07 Thread GitBox
dstandish commented on a change in pull request #21398: URL: https://github.com/apache/airflow/pull/21398#discussion_r801174509 ## File path: scripts/ci/pre_commit/pre_commit_docstring_param_type.py ## @@ -0,0 +1,58 @@ +#!/usr/bin/env python3 +# Licensed to the Apache Software

[airflow] 05/07: Fix docs link for smart sensor deprecation (#21394)

2022-02-07 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch v2-2-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 8971e0ff4283febfdb8a292e978ee1247f583f0d Author: Jed Cunningham

[airflow] 06/07: Avoid deadlock when rescheduling task (#21362)

2022-02-07 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch v2-2-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit e2f3e94f054bc7217378aa743d185e5e508468ea Author: Jarek Potiuk AuthorDate: Mon Feb 7 20:12:05 2022 +0100

[airflow] 07/07: Add possibility to create user in the Remote User mode (#19963)

2022-02-07 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch v2-2-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit b92cf65f0300bbac305f19980384110283eba4d5 Author: Ɓukasz Wyszomirski AuthorDate: Fri Jan 28 06:18:05 2022

[airflow] 03/07: Filter celery stuck task query to exclude completed tasks (#21335)

2022-02-07 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch v2-2-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 317dd298e02f54156f362f8d39307e575106b5b5 Author: Ephraim Anierobi AuthorDate: Mon Feb 7 10:43:51 2022 +0100

[airflow] 04/07: Update example DAGs (#21372)

2022-02-07 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch v2-2-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 99abbfc873d3df070fff5926d69c31bfad462359 Author: Jed Cunningham

[airflow] 02/07: Update error docs to include before_send option (#21275)

2022-02-07 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch v2-2-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit e11b90cd5800f1071bdee311b8f4cbb5e8d4b611 Author: Abhijeet Prasad AuthorDate: Thu Feb 3 18:15:21 2022 -0500

[airflow] 01/07: Fix the incorrect scheduling time for the first run of dag (#21011)

2022-02-07 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch v2-2-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit a04ead208da620040b718151c0800bb2ff59bbc4 Author: wano <55907021+wan...@users.noreply.github.com> AuthorDate:

[airflow] branch v2-2-test updated (d4000e8 -> b92cf65)

2022-02-07 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch v2-2-test in repository https://gitbox.apache.org/repos/asf/airflow.git. from d4000e8 Update stat_name_handler documentation (#21298) new a04ead2 Fix the incorrect scheduling

[GitHub] [airflow] github-actions[bot] closed pull request #14640: Allow ExternalTaskSensor to wait for taskgroup

2022-02-07 Thread GitBox
github-actions[bot] closed pull request #14640: URL: https://github.com/apache/airflow/pull/14640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] aa3pankaj commented on a change in pull request #21342: Add 'Show record' option for variables

2022-02-07 Thread GitBox
aa3pankaj commented on a change in pull request #21342: URL: https://github.com/apache/airflow/pull/21342#discussion_r801157071 ## File path: airflow/www/widgets.py ## @@ -72,3 +72,8 @@ class BS3TextAreaROWidget(BS3TextAreaFieldWidget): def __call__(self, field,

[GitHub] [airflow] kazanzhy edited a comment on issue #21125: apache-airflow-providers-trino issue when I use "run" method, query is not performed

2022-02-07 Thread GitBox
kazanzhy edited a comment on issue #21125: URL: https://github.com/apache/airflow/issues/21125#issuecomment-1032050659 Seems the passing handler is accidentally missed. Talking about `fetchAll()`, did you try the `trino_hook.get_records`? It returns `cursor.fetchall()` -- This is

[GitHub] [airflow] kazanzhy commented on issue #21125: apache-airflow-providers-trino issue when I use "run" method, query is not performed

2022-02-07 Thread GitBox
kazanzhy commented on issue #21125: URL: https://github.com/apache/airflow/issues/21125#issuecomment-1032050659 Seems the passing handler is accidentally missed. Talking about `fetchAll(), did you tried the `trino_hook.get_records`? It returns `cursor.fetchall()` -- This is an

[GitHub] [airflow] pingzh commented on pull request #18675: New Tree View

2022-02-07 Thread GitBox
pingzh commented on pull request #18675: URL: https://github.com/apache/airflow/pull/18675#issuecomment-1032032585 @potiuk yep, adding the upstream/downstream to this new Tree view also works well. I think it is very important for users to easily see upstream/downstream in the Tree view

[GitHub] [airflow] kazanzhy commented on issue #21388: Optionally raise an error if source file does not exist in GCSToGCSOperator

2022-02-07 Thread GitBox
kazanzhy commented on issue #21388: URL: https://github.com/apache/airflow/issues/21388#issuecomment-1032029707 Sounds interesting. It's pretty similar to pandas functions parameter - `errors={'ignore', 'raise', 'coerce'}`. But I see that there are a lot of different operators and sensors

[GitHub] [airflow] pingzh commented on a change in pull request #21332: Add option to compress dag data

2022-02-07 Thread GitBox
pingzh commented on a change in pull request #21332: URL: https://github.com/apache/airflow/pull/21332#discussion_r801092172 ## File path: airflow/models/serialized_dag.py ## @@ -20,11 +20,12 @@ import hashlib import logging +import zlib Review comment: although

[GitHub] [airflow] jedcunningham commented on a change in pull request #21222: Helm: Fix elasticsearch URL in secret when username/password fields are empty,

2022-02-07 Thread GitBox
jedcunningham commented on a change in pull request #21222: URL: https://github.com/apache/airflow/pull/21222#discussion_r801116690 ## File path: chart/tests/test_elasticsearch_secret.py ## @@ -132,3 +132,39 @@ def test_should_generate_secret_with_specified_schemes(self,

[GitHub] [airflow] mik-laj commented on a change in pull request #21398: Add pre-commit check for docstring param types

2022-02-07 Thread GitBox
mik-laj commented on a change in pull request #21398: URL: https://github.com/apache/airflow/pull/21398#discussion_r801110671 ## File path: scripts/ci/pre_commit/pre_commit_docstring_param_type.py ## @@ -0,0 +1,58 @@ +#!/usr/bin/env python3 +# Licensed to the Apache Software

[GitHub] [airflow] subkanthi commented on a change in pull request #21222: Helm: Fix elasticsearch URL in secret when username/password fields are empty,

2022-02-07 Thread GitBox
subkanthi commented on a change in pull request #21222: URL: https://github.com/apache/airflow/pull/21222#discussion_r801109387 ## File path: chart/tests/test_elasticsearch_secret.py ## @@ -132,3 +132,39 @@ def test_should_generate_secret_with_specified_schemes(self, scheme):

[GitHub] [airflow] subkanthi commented on a change in pull request #21222: Helm: Fix elasticsearch URL in secret when username/password fields are empty,

2022-02-07 Thread GitBox
subkanthi commented on a change in pull request #21222: URL: https://github.com/apache/airflow/pull/21222#discussion_r801109387 ## File path: chart/tests/test_elasticsearch_secret.py ## @@ -132,3 +132,39 @@ def test_should_generate_secret_with_specified_schemes(self, scheme):

[GitHub] [airflow] avkirilishin opened a new pull request #21404: EdgeModifier refactoring

2022-02-07 Thread GitBox
avkirilishin opened a new pull request #21404: URL: https://github.com/apache/airflow/pull/21404 closes: #17469 | Dag | Before | After | | - | - | - | | simple_label |

[GitHub] [airflow] potiuk commented on a change in pull request #21403: Update `template_fields_renderers` using new SQL lexers to "sql" renderer

2022-02-07 Thread GitBox
potiuk commented on a change in pull request #21403: URL: https://github.com/apache/airflow/pull/21403#discussion_r801100375 ## File path: airflow/providers/amazon/aws/operators/redshift_sql.py ## @@ -44,7 +44,8 @@ class RedshiftSQLOperator(BaseOperator):

[GitHub] [airflow] potiuk commented on a change in pull request #21403: Update `template_fields_renderers` using new SQL lexers to "sql" renderer

2022-02-07 Thread GitBox
potiuk commented on a change in pull request #21403: URL: https://github.com/apache/airflow/pull/21403#discussion_r801100269 ## File path: airflow/providers/amazon/aws/operators/redshift_sql.py ## @@ -44,7 +44,8 @@ class RedshiftSQLOperator(BaseOperator):

[GitHub] [airflow] josh-fell commented on a change in pull request #21403: Update `template_fields_renderers` using new SQL lexers to "sql" renderer

2022-02-07 Thread GitBox
josh-fell commented on a change in pull request #21403: URL: https://github.com/apache/airflow/pull/21403#discussion_r801100278 ## File path: airflow/providers/amazon/aws/operators/redshift_sql.py ## @@ -44,7 +44,8 @@ class RedshiftSQLOperator(BaseOperator):

[GitHub] [airflow] potiuk commented on a change in pull request #21403: Update `template_fields_renderers` using new SQL lexers to "sql" renderer

2022-02-07 Thread GitBox
potiuk commented on a change in pull request #21403: URL: https://github.com/apache/airflow/pull/21403#discussion_r801098384 ## File path: airflow/providers/amazon/aws/operators/redshift_sql.py ## @@ -44,7 +44,8 @@ class RedshiftSQLOperator(BaseOperator):

[GitHub] [airflow] pingzh commented on a change in pull request #21332: Add option to compress dag data

2022-02-07 Thread GitBox
pingzh commented on a change in pull request #21332: URL: https://github.com/apache/airflow/pull/21332#discussion_r801092172 ## File path: airflow/models/serialized_dag.py ## @@ -20,11 +20,12 @@ import hashlib import logging +import zlib Review comment: although

[GitHub] [airflow] josh-fell commented on pull request #21403: Update `template_fields_renderers` using new SQL lexers to "sql" renderer

2022-02-07 Thread GitBox
josh-fell commented on pull request #21403: URL: https://github.com/apache/airflow/pull/21403#issuecomment-1031968398 CC @potiuk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] josh-fell opened a new pull request #21403: Update `template_fields_renderers` using new SQL lexers to "sql" renderer

2022-02-07 Thread GitBox
josh-fell opened a new pull request #21403: URL: https://github.com/apache/airflow/pull/21403 Related: #21237 #21348 New SQL lexers were added as part of #21237, however, these new lexers won't be available for use as `template_fields_renderers` in operators until Airflow 2.3. This

[GitHub] [airflow] kurtqq edited a comment on issue #21252: Distinguish between marking failure/success by user and by task

2022-02-07 Thread GitBox
kurtqq edited a comment on issue #21252: URL: https://github.com/apache/airflow/issues/21252#issuecomment-1031958805 > There's an enum of task states [here](https://github.com/apache/airflow/blob/1d170f899bcc87110e55192517270ec89d511ca8/airflow/utils/state.py#L26), which we could add to,

[GitHub] [airflow] kurtqq commented on issue #21252: Distinguish between marking failure/success by user and by task

2022-02-07 Thread GitBox
kurtqq commented on issue #21252: URL: https://github.com/apache/airflow/issues/21252#issuecomment-1031958805 > There's an enum of task states [here](https://github.com/apache/airflow/blob/1d170f899bcc87110e55192517270ec89d511ca8/airflow/utils/state.py#L26), which we could add to, but

[airflow] branch constraints-main updated: Updating constraints. Build id:1808732466

2022-02-07 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new e029fd0 Updating

[GitHub] [airflow] jedcunningham commented on a change in pull request #21401: added envFrom statement to the flower deployment

2022-02-07 Thread GitBox
jedcunningham commented on a change in pull request #21401: URL: https://github.com/apache/airflow/pull/21401#discussion_r801061676 ## File path: chart/templates/flower/flower-deployment.yaml ## @@ -128,6 +128,8 @@ spec: name: {{ template "flower_secret" .

[GitHub] [airflow] github-actions[bot] commented on pull request #20733: Add Audit Log View to Dag View

2022-02-07 Thread GitBox
github-actions[bot] commented on pull request #20733: URL: https://github.com/apache/airflow/pull/20733#issuecomment-1031925818 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] raphaelauv commented on a change in pull request #21391: Optionally raise an error if source file does not exist in GCSToGCSOperator

2022-02-07 Thread GitBox
raphaelauv commented on a change in pull request #21391: URL: https://github.com/apache/airflow/pull/21391#discussion_r801042926 ## File path: airflow/providers/google/cloud/transfers/gcs_to_gcs.py ## @@ -313,6 +318,14 @@ def _copy_source_without_wildcard(self, hook, prefix):

[GitHub] [airflow] raphaelauv commented on a change in pull request #21391: Optionally raise an error if source file does not exist in GCSToGCSOperator

2022-02-07 Thread GitBox
raphaelauv commented on a change in pull request #21391: URL: https://github.com/apache/airflow/pull/21391#discussion_r801042926 ## File path: airflow/providers/google/cloud/transfers/gcs_to_gcs.py ## @@ -313,6 +318,14 @@ def _copy_source_without_wildcard(self, hook, prefix):

[GitHub] [airflow] github-actions[bot] commented on pull request #21402: Fix type annotations re task decorator map

2022-02-07 Thread GitBox
github-actions[bot] commented on pull request #21402: URL: https://github.com/apache/airflow/pull/21402#issuecomment-1031898327 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[airflow] branch main updated: [Oracle] Oracle Hook - automatically set current_schema when defined in Connection (#19084)

2022-02-07 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 471e368 [Oracle] Oracle Hook - automatically set

[GitHub] [airflow] ashb commented on a change in pull request #21402: Fix type annotations re task decorator map

2022-02-07 Thread GitBox
ashb commented on a change in pull request #21402: URL: https://github.com/apache/airflow/pull/21402#discussion_r801038280 ## File path: airflow/decorators/__init__.pyi ## @@ -226,4 +226,5 @@ class TaskDecoratorCollection: """ # [END decorator_signature]

[GitHub] [airflow] potiuk merged pull request #19084: [Oracle] Oracle Hook - automatically set current_schema when defined in Connection

2022-02-07 Thread GitBox
potiuk merged pull request #19084: URL: https://github.com/apache/airflow/pull/19084 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19084: [Oracle] Oracle Hook - automatically set current_schema when defined in Connection

2022-02-07 Thread GitBox
boring-cyborg[bot] commented on pull request #19084: URL: https://github.com/apache/airflow/pull/19084#issuecomment-1031897507 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] potiuk closed issue #18664: [Oracle] Oracle Hook - make it possible to define a schema in the connection parameters

2022-02-07 Thread GitBox
potiuk closed issue #18664: URL: https://github.com/apache/airflow/issues/18664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #19084: [Oracle] Oracle Hook - automatically set current_schema when defined in Connection

2022-02-07 Thread GitBox
potiuk commented on pull request #19084: URL: https://github.com/apache/airflow/pull/19084#issuecomment-1031897290 Just a docker-compose failure which we will fix shorlty. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] github-actions[bot] commented on pull request #19084: [Oracle] Oracle Hook - automatically set current_schema when defined in Connection

2022-02-07 Thread GitBox
github-actions[bot] commented on pull request #19084: URL: https://github.com/apache/airflow/pull/19084#issuecomment-1031897211 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] ashb commented on a change in pull request #21342: Add 'Show record' option for variables

2022-02-07 Thread GitBox
ashb commented on a change in pull request #21342: URL: https://github.com/apache/airflow/pull/21342#discussion_r801037088 ## File path: airflow/www/widgets.py ## @@ -72,3 +72,8 @@ class BS3TextAreaROWidget(BS3TextAreaFieldWidget): def __call__(self, field, **kwargs):

[GitHub] [airflow] potiuk commented on issue #21397: Stale DAG Deactivation in DAG Processor is extremely hard on the database in environments with many DAGs

2022-02-07 Thread GitBox
potiuk commented on issue #21397: URL: https://github.com/apache/airflow/issues/21397#issuecomment-1031891355 > Oh thanks Mysql. A lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] github-actions[bot] commented on pull request #21357: Fix incorrect datetime details (DagRun views)

2022-02-07 Thread GitBox
github-actions[bot] commented on pull request #21357: URL: https://github.com/apache/airflow/pull/21357#issuecomment-1031891302 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] riccardo-salamanna opened a new pull request #21401: added envFrom statement to the flower deployment

2022-02-07 Thread GitBox
riccardo-salamanna opened a new pull request #21401: URL: https://github.com/apache/airflow/pull/21401 Added `envFrom` statement to the flower deployement in the helm chart --- The flower deployement is missing the envFrom statement. This causes that if you use the `extraEnvFrom` in

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21401: added envFrom statement to the flower deployment

2022-02-07 Thread GitBox
boring-cyborg[bot] commented on pull request #21401: URL: https://github.com/apache/airflow/pull/21401#issuecomment-1031883639 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] potiuk commented on a change in pull request #20642: Added Hook for Amazon RDS

2022-02-07 Thread GitBox
potiuk commented on a change in pull request #20642: URL: https://github.com/apache/airflow/pull/20642#discussion_r795033020 ## File path: setup.py ## @@ -194,6 +194,7 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version

[GitHub] [airflow] NilsJPWerner commented on issue #21336: Override the dag run_id from within the ui

2022-02-07 Thread GitBox
NilsJPWerner commented on issue #21336: URL: https://github.com/apache/airflow/issues/21336#issuecomment-1031881493 I understand now. I got the indication from @ashb's tag that a PR for this issue would likely be accepted so I will look into what it would take to make the change. --

[GitHub] [airflow] potiuk commented on issue #21336: Override the dag run_id from within the ui

2022-02-07 Thread GitBox
potiuk commented on issue #21336: URL: https://github.com/apache/airflow/issues/21336#issuecomment-1031879570 > In the [CONTRIBUTING.rst](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#submit-feedback) there is a section about creating feature requests, and the issue page

[GitHub] [airflow] NilsJPWerner edited a comment on issue #21336: Override the dag run_id from within the ui

2022-02-07 Thread GitBox
NilsJPWerner edited a comment on issue #21336: URL: https://github.com/apache/airflow/issues/21336#issuecomment-1031876060 > Or pick someone's interest and convince them to implement it. Or mark it as a good first issue and hope someone will pick it as their first issue if this is an easy

[GitHub] [airflow] NilsJPWerner commented on issue #21336: Override the dag run_id from within the ui

2022-02-07 Thread GitBox
NilsJPWerner commented on issue #21336: URL: https://github.com/apache/airflow/issues/21336#issuecomment-1031876060 > Or pick someone's interest and convince them to implement it. Or mark it as a good first issue and hope someone will pick it as their first issue if this is an easy fix.

[GitHub] [airflow] blag commented on pull request #21167: Add a session backend to store session data in the database

2022-02-07 Thread GitBox
blag commented on pull request #21167: URL: https://github.com/apache/airflow/pull/21167#issuecomment-1031870760 @dstandish That's a good call, but it's looking less and less likely that our changes are going to be palatable to the maintainer of Flask-Session. If the changes we need won't

[GitHub] [airflow] kazanzhy opened a new pull request #20642: Added Hook for Amazon RDS

2022-02-07 Thread GitBox
kazanzhy opened a new pull request #20642: URL: https://github.com/apache/airflow/pull/20642 I had two different implementations of `RDSHook`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] potiuk closed pull request #20642: Added Hook for Amazon RDS

2022-02-07 Thread GitBox
potiuk closed pull request #20642: URL: https://github.com/apache/airflow/pull/20642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] pingzh commented on a change in pull request #21332: Add option to compress dag data

2022-02-07 Thread GitBox
pingzh commented on a change in pull request #21332: URL: https://github.com/apache/airflow/pull/21332#discussion_r801008951 ## File path: tests/models/test_serialized_dag.py ## @@ -63,60 +72,68 @@ def _write_example_dags(self): return example_dags def

[GitHub] [airflow] potiuk commented on issue #21400: Docker operator fails

2022-02-07 Thread GitBox
potiuk commented on issue #21400: URL: https://github.com/apache/airflow/issues/21400#issuecomment-1031866151 @ferruzzi @raphaelauv -> would you have time to take a look at that, or should I look first thing tomorrow in the morning :D ? -- This is an automated message from the Apache

[GitHub] [airflow] potiuk opened a new issue #21400: Docker operator fails

2022-02-07 Thread GitBox
potiuk opened a new issue #21400: URL: https://github.com/apache/airflow/issues/21400 ### Apache Airflow version main (development) ### What happened As discussed in #21348 cc: @ferruzzi @raphaelauv Seems that main docker operator is buggy even aftter

[GitHub] [airflow] potiuk commented on pull request #21393: Add how-to guide for WebHDFS operators

2022-02-07 Thread GitBox
potiuk commented on pull request #21393: URL: https://github.com/apache/airflow/pull/21393#issuecomment-1031854918 That's the whole error: it expects that providers.yaml links to the webhdfs.rst and hdfs.rst rather than to index.rst ``` Validate providers.yaml

[GitHub] [airflow] potiuk edited a comment on issue #21392: .airflowignore does not use 'glob' as .gitignore for example

2022-02-07 Thread GitBox
potiuk edited a comment on issue #21392: URL: https://github.com/apache/airflow/issues/21392#issuecomment-1031851652 > Yeah, if we wanted to change the format of this file to more closely match what people expect (which I agree is confusing) -- i.e. `.gitignore` we'd either have to change

[GitHub] [airflow] potiuk edited a comment on issue #21392: .airflowignore does not use 'glob' as .gitignore for example

2022-02-07 Thread GitBox
potiuk edited a comment on issue #21392: URL: https://github.com/apache/airflow/issues/21392#issuecomment-1031851652 > Yeah, if we wanted to change the format of this file to more closely match what people expect (which I agree is confusing) -- i.e. `.gitignore` we'd either have to change

[GitHub] [airflow] potiuk commented on issue #21392: .airflowignore does not use 'glob' as .gitignore for example

2022-02-07 Thread GitBox
potiuk commented on issue #21392: URL: https://github.com/apache/airflow/issues/21392#issuecomment-1031851652 > Yeah, if we wanted to change the format of this file to more closely match what people expect (which I agree is confusing) -- i.e. `.gitignore` we'd either have to change the

[GitHub] [airflow] Melodie97 commented on a change in pull request #21346: Update docs/readme.rst

2022-02-07 Thread GitBox
Melodie97 commented on a change in pull request #21346: URL: https://github.com/apache/airflow/pull/21346#discussion_r801001745 ## File path: docs/README.rst ## @@ -74,7 +74,24 @@ Once you have built the documentation run the following command from the root di

[GitHub] [airflow] Melodie97 commented on pull request #21393: Add how-to guide for WebHDFS operators

2022-02-07 Thread GitBox
Melodie97 commented on pull request #21393: URL: https://github.com/apache/airflow/pull/21393#issuecomment-1031850660 > Some checks failing this is what I'm seeing locally in pre-commit, I don't know what that means

[GitHub] [airflow] bbovenzi commented on a change in pull request #20733: Add Audit Log View to Dag View

2022-02-07 Thread GitBox
bbovenzi commented on a change in pull request #20733: URL: https://github.com/apache/airflow/pull/20733#discussion_r801000678 ## File path: airflow/config_templates/default_airflow.cfg ## @@ -670,6 +670,17 @@ auto_refresh_interval = 3 # Boolean for displaying warning for

[GitHub] [airflow] dstandish commented on a change in pull request #21398: Add pre-commit check for docstring param types

2022-02-07 Thread GitBox
dstandish commented on a change in pull request #21398: URL: https://github.com/apache/airflow/pull/21398#discussion_r800994542 ## File path: scripts/ci/pre_commit/pre_commit_docstring_param_type.py ## @@ -0,0 +1,64 @@ +#!/usr/bin/env python3 +# Licensed to the Apache Software

[GitHub] [airflow] potiuk closed issue #21348: Status of testing Providers that were prepared on February 05, 2022

2022-02-07 Thread GitBox
potiuk closed issue #21348: URL: https://github.com/apache/airflow/issues/21348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] ashb commented on pull request #21342: Add 'Show record' option for variables

2022-02-07 Thread GitBox
ashb commented on pull request #21342: URL: https://github.com/apache/airflow/pull/21342#issuecomment-1031839888 `white-space: pre-wrap;` is the CSS style you are looking for I suspect. Make sure it only gets applied to Variables though, not all Show pages. -- This is an automated

[GitHub] [airflow] potiuk commented on issue #21348: Status of testing Providers that were prepared on February 05, 2022

2022-02-07 Thread GitBox
potiuk commented on issue #21348: URL: https://github.com/apache/airflow/issues/21348#issuecomment-1031840031 As discussed above ^^ I will cancel the whole vote/release and will make an RC2 as soon as we release the conditonally working SQL renderer. Thanks @josh-fell for spotting this

[GitHub] [airflow] potiuk commented on issue #21348: Status of testing Providers that were prepared on February 05, 2022

2022-02-07 Thread GitBox
potiuk commented on issue #21348: URL: https://github.com/apache/airflow/issues/21348#issuecomment-1031838519 Yeah. It's easy enough to fix and I agree it's better. I think - due to the the number of those affected, it makes more sense to cancel the whole release and re-release all

[GitHub] [airflow] ashb commented on issue #21392: .airflowignore does not use 'glob' as .gitignore for example

2022-02-07 Thread GitBox
ashb commented on issue #21392: URL: https://github.com/apache/airflow/issues/21392#issuecomment-1031836603 Yeah, if we wanted to change the format of this file to more closely match what people expect (which I agree is confusing) -- i.e. `.gitignore` we'd either have to change the

[GitHub] [airflow] jedcunningham commented on issue #21348: Status of testing Providers that were prepared on February 05, 2022

2022-02-07 Thread GitBox
jedcunningham commented on issue #21348: URL: https://github.com/apache/airflow/issues/21348#issuecomment-1031835368 I'd rather not include it for 2.2.4 since, as you said, it's a new feature. Doing it conditionally, until the next lower bound bump, I think makes sense. -- This is an

[GitHub] [airflow] potiuk edited a comment on issue #21348: Status of testing Providers that were prepared on February 05, 2022

2022-02-07 Thread GitBox
potiuk edited a comment on issue #21348: URL: https://github.com/apache/airflow/issues/21348#issuecomment-1031832322 The second option is to indeed drop all the "21237" providers an release them in RC2 with some "conditional" code that will check if the lexer is there. After thinking a

[GitHub] [airflow] tlskr commented on issue #21395: Airflow Not Automatically Sending Errors to Sentry

2022-02-07 Thread GitBox
tlskr commented on issue #21395: URL: https://github.com/apache/airflow/issues/21395#issuecomment-1031833167 We're using `sentry-sdk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

  1   2   3   >