[airflow] branch main updated (dffb0d27f2 -> 400f837dfc)

2022-04-11 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from dffb0d27f2 Deprecate `S3PrefixSensor` and `S3KeySizeSensor` in favor of `S3KeySensor` (#22737) add 400f837dfc

[GitHub] [airflow] eladkal merged pull request #22929: Move database config move note to `main` section

2022-04-11 Thread GitBox
eladkal merged PR #22929: URL: https://github.com/apache/airflow/pull/22929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #22929: Move database config move note to `main` section

2022-04-11 Thread GitBox
github-actions[bot] commented on PR #22929: URL: https://github.com/apache/airflow/pull/22929#issuecomment-1096109089 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full

[GitHub] [airflow] github-actions[bot] commented on pull request #22930: Use full version string for deprecated config

2022-04-11 Thread GitBox
github-actions[bot] commented on PR #22930: URL: https://github.com/apache/airflow/pull/22930#issuecomment-1096107359 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the

[airflow] branch main updated: Deprecate `S3PrefixSensor` and `S3KeySizeSensor` in favor of `S3KeySensor` (#22737)

2022-04-11 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new dffb0d27f2 Deprecate `S3PrefixSensor` and

[GitHub] [airflow] eladkal merged pull request #22737: Deprecate `S3PrefixSensor` and `S3KeySizeSensor` in favor of `S3KeySensor`

2022-04-11 Thread GitBox
eladkal merged PR #22737: URL: https://github.com/apache/airflow/pull/22737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #22737: Deprecate `S3PrefixSensor` and `S3KeySizeSensor` in favor of `S3KeySensor`

2022-04-11 Thread GitBox
github-actions[bot] commented on PR #22737: URL: https://github.com/apache/airflow/pull/22737#issuecomment-1096071088 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the

[GitHub] [airflow] eladkal commented on pull request #22832: Deprecate `DummyOperator` in favor of `EmptyOperator`

2022-04-11 Thread GitBox
eladkal commented on PR #22832: URL: https://github.com/apache/airflow/pull/22832#issuecomment-1096065814 hi @ashb @uranusjr WDYT? I'd like to get it in 2.3.0 if possible -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] tirkarthi opened a new pull request, #22934: Use appropriate TaskInstance object related to TaskFail to get execution_date

2022-04-11 Thread GitBox
tirkarthi opened a new pull request, #22934: URL: https://github.com/apache/airflow/pull/22934 `TaskFail` instance has no execution_date attribute. Fetch execution_date from the relevant `TaskInstance` object to form the dictionary key tuple. closes: #22933 related: #22933 --

[GitHub] [airflow] tanelk commented on issue #22779: Paused DAG manual running task has no external_ executor_ id

2022-04-11 Thread GitBox
tanelk commented on issue #22779: URL: https://github.com/apache/airflow/issues/22779#issuecomment-1095987096 Did I understand correctly - in 2.2.t the external_executor_id is filled, but the issue still there? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] github-actions[bot] commented on pull request #22932: Added check before self.clear_xcom_data to ensure XCom is not cleared when resuming from deferral.

2022-04-11 Thread GitBox
github-actions[bot] commented on PR #22932: URL: https://github.com/apache/airflow/pull/22932#issuecomment-1095974045 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the

[GitHub] [airflow] tirkarthi commented on issue #22933: Task duration page crashes when there is a failed task entry

2022-04-11 Thread GitBox
tirkarthi commented on issue #22933: URL: https://github.com/apache/airflow/issues/22933#issuecomment-1095972343 Sample test case, I will submit a PR shortly. ```python def test_task_fail_duration(app, admin_client, dag_maker, session): """Task duration page with a TaskFail

[GitHub] [airflow] tirkarthi opened a new issue, #22933: Task duration page crashes when there is a failed task entry

2022-04-11 Thread GitBox
tirkarthi opened a new issue, #22933: URL: https://github.com/apache/airflow/issues/22933 ### Apache Airflow version 2.2.5 (latest released) ### What happened Task duration page crashes when there is a failed task in the list of task instances. This happens since the

[GitHub] [airflow] nitra-1 commented on issue #21668: Airflow airflow:2.0.2 UI is not getting updated with dag status

2022-04-11 Thread GitBox
nitra-1 commented on issue #21668: URL: https://github.com/apache/airflow/issues/21668#issuecomment-1095949554 Any update on this issue ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] wangzhijunwang commented on issue #22779: Paused DAG manual running task has no external_ executor_ id

2022-04-11 Thread GitBox
wangzhijunwang commented on issue #22779: URL: https://github.com/apache/airflow/issues/22779#issuecomment-1095917067 @tanelk Sorry to bother you again! First, I use the Web UI to operate,And the example of my operation this time comes from

[GitHub] [airflow] pingzh commented on a diff in pull request #22917: remove stale serialized dags

2022-04-11 Thread GitBox
pingzh commented on code in PR #22917: URL: https://github.com/apache/airflow/pull/22917#discussion_r847844780 ## airflow/models/serialized_dag.py: ## @@ -220,6 +220,36 @@ def remove_dag(cls, dag_id: str, session: Session = None): """

[GitHub] [airflow] pingzh commented on a diff in pull request #22917: remove stale serialized dags

2022-04-11 Thread GitBox
pingzh commented on code in PR #22917: URL: https://github.com/apache/airflow/pull/22917#discussion_r847844344 ## airflow/models/serialized_dag.py: ## @@ -220,6 +220,36 @@ def remove_dag(cls, dag_id: str, session: Session = None): """

[GitHub] [airflow] ReadytoRocc opened a new pull request, #22932: Added check before self.clear_xcom_data to ensure XCom is not cleared when resuming from deferral.

2022-04-11 Thread GitBox
ReadytoRocc opened a new pull request, #22932: URL: https://github.com/apache/airflow/pull/22932 closes: #22931 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] ReadytoRocc opened a new issue, #22931: XCom is cleared when a task resumes from deferral.

2022-04-11 Thread GitBox
ReadytoRocc opened a new issue, #22931: URL: https://github.com/apache/airflow/issues/22931 ### Apache Airflow version 2.2.5 (latest released) ### What happened A task's XCom value is cleared when a task is rescheduled after being deferred. ### What you think

[GitHub] [airflow] jedcunningham opened a new pull request, #22930: Use full version string for deprecated config

2022-04-11 Thread GitBox
jedcunningham opened a new pull request, #22930: URL: https://github.com/apache/airflow/pull/22930 Since this is shown to the users in docs, we should use the full version string. Before: ![Screen Shot 2022-04-11 at 5 50 33

[GitHub] [airflow] jedcunningham commented on a diff in pull request #22928: Update ImportError items instead of deleting and recreating them

2022-04-11 Thread GitBox
jedcunningham commented on code in PR #22928: URL: https://github.com/apache/airflow/pull/22928#discussion_r847827828 ## airflow/dag_processing/processor.py: ## @@ -528,23 +529,34 @@ def update_import_errors(session: Session, dagbag: DagBag) -> None: :param session:

[GitHub] [airflow] github-actions[bot] commented on pull request #19949: Only update label when adopting to prevent new pods

2022-04-11 Thread GitBox
github-actions[bot] commented on PR #19949: URL: https://github.com/apache/airflow/pull/19949#issuecomment-1095719461 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

[GitHub] [airflow] github-actions[bot] commented on pull request #21716: Respect user-configured timezone when generating DAG run ID

2022-04-11 Thread GitBox
github-actions[bot] commented on PR #21716: URL: https://github.com/apache/airflow/pull/21716#issuecomment-1095719409 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

[GitHub] [airflow] jedcunningham opened a new pull request, #22929: Move database config move note to `main` section

2022-04-11 Thread GitBox
jedcunningham opened a new pull request, #22929: URL: https://github.com/apache/airflow/pull/22929 This was accidentally added to the `2.2.4` notes instead of `main`. (I also added a missing "the") -- This is an automated message from the Apache Git Service. To respond to the

[airflow] branch main updated: Fix changelog spelling (#22926)

2022-04-11 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new a9e790cf61 Fix changelog spelling (#22926)

[GitHub] [airflow] jedcunningham merged pull request #22926: Fix changelog spelling

2022-04-11 Thread GitBox
jedcunningham merged PR #22926: URL: https://github.com/apache/airflow/pull/22926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] ephraimbuddy opened a new pull request, #22928: Update ImportError items instead of deleting and recreating them

2022-04-11 Thread GitBox
ephraimbuddy opened a new pull request, #22928: URL: https://github.com/apache/airflow/pull/22928 Each time a dag with import error is parsed, the ImportError record is deleted and a new record is created. For example, say I have two dags with import errors, initially, the import

[GitHub] [airflow] github-actions[bot] commented on pull request #22926: Fix changelog spelling

2022-04-11 Thread GitBox
github-actions[bot] commented on PR #22926: URL: https://github.com/apache/airflow/pull/22926#issuecomment-1095682428 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full

[GitHub] [airflow] pierrejeambrun commented on pull request #22927: Add MSSQL link to contributing quick start.

2022-04-11 Thread GitBox
pierrejeambrun commented on PR #22927: URL: https://github.com/apache/airflow/pull/22927#issuecomment-1095671098 @potiuk Now that breeze2 is out, as requested here is the small change in the doc :) Great work btw on breeze, the interface is great :tada: (kind of make me want to work

[GitHub] [airflow] pierrejeambrun opened a new pull request, #22927: Add MSSQL link to contributing quick start.

2022-04-11 Thread GitBox
pierrejeambrun opened a new pull request, #22927: URL: https://github.com/apache/airflow/pull/22927 Small PR to update the `CONTRIBUTING_QUICK_START.rst` doc to include the link to mssql form the host. Also tried to homogenize the doc between `setup and develop` sections for

[airflow] branch constraints-main updated: Updating constraints. Build id:2151407881

2022-04-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 4c56c47089 Updating

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #22925: Update Dockerfile - set proper airflow version

2022-04-11 Thread GitBox
boring-cyborg[bot] commented on PR #22925: URL: https://github.com/apache/airflow/pull/22925#issuecomment-1095644655 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[GitHub] [airflow] piotrekklis opened a new pull request, #22925: Update Dockerfile - set proper airflow version

2022-04-11 Thread GitBox
piotrekklis opened a new pull request, #22925: URL: https://github.com/apache/airflow/pull/22925 Currently set airflow version won't let to build the image --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] uranusjr commented on pull request #22699: add allow_manual DAG argument to prevent scheduled DAGs from being triggered manually

2022-04-11 Thread GitBox
uranusjr commented on PR #22699: URL: https://github.com/apache/airflow/pull/22699#issuecomment-1095613028 You need to find all `create_dagrun` calls that creates manual runs, and decide how this needs to be catched and handled. I believe there are at least two, one in CLI and one in web

[airflow] branch main updated (b8da7a3c8f -> d8889da29c)

2022-04-11 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from b8da7a3c8f Remove installation instructions from Breeze's cheatsheet (#22923) add d8889da29c Move the

[GitHub] [airflow] mik-laj merged pull request #22284: Move the database configuration to a new section

2022-04-11 Thread GitBox
mik-laj merged PR #22284: URL: https://github.com/apache/airflow/pull/22284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #22284: Move the database configuration to a new section

2022-04-11 Thread GitBox
boring-cyborg[bot] commented on PR #22284: URL: https://github.com/apache/airflow/pull/22284#issuecomment-1095612612 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] mik-laj closed issue #15930: Move the database configuration to a new section

2022-04-11 Thread GitBox
mik-laj closed issue #15930: Move the database configuration to a new section URL: https://github.com/apache/airflow/issues/15930 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] uranusjr commented on a diff in pull request #22699: add allow_manual DAG argument to prevent scheduled DAGs from being triggered manually

2022-04-11 Thread GitBox
uranusjr commented on code in PR #22699: URL: https://github.com/apache/airflow/pull/22699#discussion_r847768433 ## airflow/exceptions.py: ## @@ -298,3 +298,7 @@ def __repr__(self) -> str: class TaskDeferralError(AirflowException): """Raised when a task failed during

[airflow] branch main updated: Remove installation instructions from Breeze's cheatsheet (#22923)

2022-04-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new b8da7a3c8f Remove installation instructions from

[GitHub] [airflow] potiuk merged pull request #22923: Remove installation instructions from Breeze's cheatsheet

2022-04-11 Thread GitBox
potiuk merged PR #22923: URL: https://github.com/apache/airflow/pull/22923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (27b3e31178 -> d1a1fe7b47)

2022-04-11 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 27b3e31178 implements #22859 - Add .sql as templatable extension (#22920) add d1a1fe7b47 Fix bug where dynamically

[GitHub] [airflow] ashb merged pull request #22909: Fix bug where dynamically mapped tasks got set to REMOVED

2022-04-11 Thread GitBox
ashb merged PR #22909: URL: https://github.com/apache/airflow/pull/22909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #22483: Priority order tasks even when using pools

2022-04-11 Thread GitBox
github-actions[bot] commented on PR #22483: URL: https://github.com/apache/airflow/pull/22483#issuecomment-1095583680 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the

[GitHub] [airflow] ashb commented on a diff in pull request #22483: Priority order tasks even when using pools

2022-04-11 Thread GitBox
ashb commented on code in PR #22483: URL: https://github.com/apache/airflow/pull/22483#discussion_r847745645 ## airflow/jobs/scheduler_job.py: ## @@ -355,141 +355,120 @@ def _executable_task_instances_to_queued(self, max_tis: int, session: Session = "%s tasks

[GitHub] [airflow] uranusjr commented on a diff in pull request #21077: Kubernetes decorator

2022-04-11 Thread GitBox
uranusjr commented on code in PR #21077: URL: https://github.com/apache/airflow/pull/21077#discussion_r847743501 ## airflow/decorators/__init__.pyi: ## @@ -188,8 +188,7 @@ class TaskDecoratorCollection: Dict will unroll to XCom values with keys as XCom keys.

[GitHub] [airflow] ashb commented on a diff in pull request #22917: remove stale serialized dags

2022-04-11 Thread GitBox
ashb commented on code in PR #22917: URL: https://github.com/apache/airflow/pull/22917#discussion_r847739746 ## airflow/models/serialized_dag.py: ## @@ -220,6 +220,36 @@ def remove_dag(cls, dag_id: str, session: Session = None): """

[GitHub] [airflow] ashb commented on a diff in pull request #22917: remove stale serialized dags

2022-04-11 Thread GitBox
ashb commented on code in PR #22917: URL: https://github.com/apache/airflow/pull/22917#discussion_r847739271 ## airflow/models/serialized_dag.py: ## @@ -220,6 +220,36 @@ def remove_dag(cls, dag_id: str, session: Session = None): """

[GitHub] [airflow] github-actions[bot] commented on pull request #22923: Remove installation instructions from Breeze's cheatsheet

2022-04-11 Thread GitBox
github-actions[bot] commented on PR #22923: URL: https://github.com/apache/airflow/pull/22923#issuecomment-1095567901 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full

[GitHub] [airflow] dstandish commented on pull request #22916: Clarify breeze install message re pipx vs `./breeze`

2022-04-11 Thread GitBox
dstandish commented on PR #22916: URL: https://github.com/apache/airflow/pull/22916#issuecomment-1095567202 haha yeah thought it was bit weird but did not give it much thought -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] edithturn commented on issue #22908: Add nicer error for BREEZE.rst update static check

2022-04-11 Thread GitBox
edithturn commented on issue #22908: URL: https://github.com/apache/airflow/issues/22908#issuecomment-1095556652 @potiuk I reproduced the error. I added breeze installation on static-checks-basic-checks-only, now this step is being skipped, and I don't think it's his purpose to skip it.

[GitHub] [airflow] potiuk commented on pull request #22916: Clarify breeze install message re pipx vs `./breeze`

2022-04-11 Thread GitBox
potiuk commented on PR #22916: URL: https://github.com/apache/airflow/pull/22916#issuecomment-1095556477 Actuallly - this message should not be there at all :). It's chicken-egg. You won't see it until Breeze is installed, but if you have it installed, you don;t need it any more :) #22923

[GitHub] [airflow] josh-fell closed issue #22859: Add .sql template extension rendering for BigQueryInsertJobOperator

2022-04-11 Thread GitBox
josh-fell closed issue #22859: Add .sql template extension rendering for BigQueryInsertJobOperator URL: https://github.com/apache/airflow/issues/22859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] josh-fell commented on issue #22859: Add .sql template extension rendering for BigQueryInsertJobOperator

2022-04-11 Thread GitBox
josh-fell commented on issue #22859: URL: https://github.com/apache/airflow/issues/22859#issuecomment-109636 Closing via #22920. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] potiuk opened a new pull request, #22923: Remove installation instructions from Breeze's cheatsheet

2022-04-11 Thread GitBox
potiuk opened a new pull request, #22923: URL: https://github.com/apache/airflow/pull/22923 The cheatsheet is displayed only after Breeze is installed so it makes no sense to display installation instructions in the cheathsheet. --- **^ Add meaningful description

[GitHub] [airflow] github-actions[bot] commented on pull request #22922: Reuse reflect_tables helper in db.py

2022-04-11 Thread GitBox
github-actions[bot] commented on PR #22922: URL: https://github.com/apache/airflow/pull/22922#issuecomment-1095552825 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the

[airflow] branch main updated (9c9272de3a -> 27b3e31178)

2022-04-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 9c9272de3a typo in BREEZE.rst (#22919) add 27b3e31178 implements #22859 - Add .sql as templatable extension

[GitHub] [airflow] potiuk merged pull request #22920: implements #22859 - Add .sql as templatable extension

2022-04-11 Thread GitBox
potiuk merged PR #22920: URL: https://github.com/apache/airflow/pull/22920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #22920: implements #22859 - Add .sql as templatable extension

2022-04-11 Thread GitBox
boring-cyborg[bot] commented on PR #22920: URL: https://github.com/apache/airflow/pull/22920#issuecomment-1095551963 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] dstandish opened a new pull request, #22922: Reuse reflect_tables helper in db.py

2022-04-11 Thread GitBox
dstandish opened a new pull request, #22922: URL: https://github.com/apache/airflow/pull/22922 Just a small code simplification -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] ashb commented on a diff in pull request #22909: Fix bug where dynamically mapped tasks got set to REMOVED

2022-04-11 Thread GitBox
ashb commented on code in PR #22909: URL: https://github.com/apache/airflow/pull/22909#discussion_r847719456 ## tests/models/test_dagrun.py: ## @@ -1036,14 +1036,17 @@ def test_mapped_mixed__literal_not_expanded_at_create(dag_maker, session): mapped =

[GitHub] [airflow] uranusjr commented on a diff in pull request #22909: Fix bug where dynamically mapped tasks got set to REMOVED

2022-04-11 Thread GitBox
uranusjr commented on code in PR #22909: URL: https://github.com/apache/airflow/pull/22909#discussion_r847717386 ## tests/models/test_dagrun.py: ## @@ -1036,14 +1036,17 @@ def test_mapped_mixed__literal_not_expanded_at_create(dag_maker, session): mapped =

[GitHub] [airflow] ashb commented on a diff in pull request #22909: Fix bug where dynamically mapped tasks got set to REMOVED

2022-04-11 Thread GitBox
ashb commented on code in PR #22909: URL: https://github.com/apache/airflow/pull/22909#discussion_r847715879 ## tests/models/test_dagrun.py: ## @@ -1036,14 +1036,17 @@ def test_mapped_mixed__literal_not_expanded_at_create(dag_maker, session): mapped =

[GitHub] [airflow] uranusjr commented on a diff in pull request #22909: Fix bug where dynamically mapped tasks got set to REMOVED

2022-04-11 Thread GitBox
uranusjr commented on code in PR #22909: URL: https://github.com/apache/airflow/pull/22909#discussion_r847713698 ## tests/models/test_dagrun.py: ## @@ -1036,14 +1036,17 @@ def test_mapped_mixed__literal_not_expanded_at_create(dag_maker, session): mapped =

[GitHub] [airflow] uranusjr commented on issue #22846: UUID encoded in CassandraToGCSOperator but not other operators

2022-04-11 Thread GitBox
uranusjr commented on issue #22846: URL: https://github.com/apache/airflow/issues/22846#issuecomment-1095537819 cc @jgao54 in case you know some more details on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] uranusjr commented on issue #22846: UUID encoded in CassandraToGCSOperator but not other operators

2022-04-11 Thread GitBox
uranusjr commented on issue #22846: URL: https://github.com/apache/airflow/issues/22846#issuecomment-1095537023 You can’t simply revert it since that would introduce a backward incompatibility and break existing usages. Perhaps it’s possible to add a flag on the operator to toggle the

[GitHub] [airflow] github-actions[bot] commented on pull request #22920: implements #22859 - Add .sql as templatable extension

2022-04-11 Thread GitBox
github-actions[bot] commented on PR #22920: URL: https://github.com/apache/airflow/pull/22920#issuecomment-1095535478 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the

[GitHub] [airflow] dstandish commented on pull request #22921: Add revision version map to db.py

2022-04-11 Thread GitBox
dstandish commented on PR #22921: URL: https://github.com/apache/airflow/pull/22921#issuecomment-1095525973 > Do we really need to know it that precisely? Can't we use the `VERSION_REVISION_MAP`and walk the migrations history via alembic api? > > Or could we just "duck-type" the

[GitHub] [airflow] dstandish closed pull request #22921: Add revision version map to db.py

2022-04-11 Thread GitBox
dstandish closed pull request #22921: Add revision version map to db.py URL: https://github.com/apache/airflow/pull/22921 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] ashb commented on a diff in pull request #22909: Fix bug where dynamically mapped tasks got set to REMOVED

2022-04-11 Thread GitBox
ashb commented on code in PR #22909: URL: https://github.com/apache/airflow/pull/22909#discussion_r847700088 ## airflow/models/mappedoperator.py: ## @@ -559,7 +562,12 @@ def _get_map_lengths(self, run_id: str, *, session: Session) -> Dict[str, int]: for task_id,

[GitHub] [airflow] vincbeck commented on pull request #22737: Deprecate S3PrefixSensor

2022-04-11 Thread GitBox
vincbeck commented on PR #22737: URL: https://github.com/apache/airflow/pull/22737#issuecomment-1095518033 I also edited the PR description to add a section to explain the purpose of `default_check_fn` since it might not be very obvious -- This is an automated message from the Apache Git

[GitHub] [airflow] vincbeck commented on pull request #22737: Deprecate S3PrefixSensor

2022-04-11 Thread GitBox
vincbeck commented on PR #22737: URL: https://github.com/apache/airflow/pull/22737#issuecomment-1095517182 I only left tests related to deprecation warnings and default function in `TestS3KeySizeSensor`. I removed the other tests because these use cases are already covered in

[GitHub] [airflow] jedcunningham commented on a diff in pull request #22909: Fix bug where dynamically mapped tasks got set to REMOVED

2022-04-11 Thread GitBox
jedcunningham commented on code in PR #22909: URL: https://github.com/apache/airflow/pull/22909#discussion_r847691219 ## airflow/models/dagrun.py: ## @@ -697,8 +697,9 @@ def _get_ready_tis( old_states[schedulable.key] = old_state continue -

[GitHub] [airflow] uranusjr commented on a diff in pull request #22909: Fix bug where dynamically mapped tasks got set to REMOVED

2022-04-11 Thread GitBox
uranusjr commented on code in PR #22909: URL: https://github.com/apache/airflow/pull/22909#discussion_r847689404 ## airflow/models/mappedoperator.py: ## @@ -559,7 +562,12 @@ def _get_map_lengths(self, run_id: str, *, session: Session) -> Dict[str, int]: for task_id,

[GitHub] [airflow] ashb commented on a diff in pull request #22909: Fix bug where dynamically mapped tasks got set to REMOVED

2022-04-11 Thread GitBox
ashb commented on code in PR #22909: URL: https://github.com/apache/airflow/pull/22909#discussion_r847687365 ## airflow/decorators/base.py: ## @@ -406,6 +406,9 @@ class DecoratedMappedOperator(MappedOperator): # in partial_kwargs, and MappedOperator prevents duplication.

[GitHub] [airflow] dstandish opened a new pull request, #22921: Add revision version map to db.py

2022-04-11 Thread GitBox
dstandish opened a new pull request, #22921: URL: https://github.com/apache/airflow/pull/22921 Sometimes we need to be able to get the airflow version for the current state of the airflow metadata database. In order to do this we need to be able to map alembic revision to airflow version,

[airflow] branch main updated (bc10265077 -> 9c9272de3a)

2022-04-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from bc10265077 Add SmoothOperator (#22813) add 9c9272de3a typo in BREEZE.rst (#22919) No new revisions were added by

[GitHub] [airflow] potiuk merged pull request #22919: typo in BREEZE.rst

2022-04-11 Thread GitBox
potiuk merged PR #22919: URL: https://github.com/apache/airflow/pull/22919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #22920: implements #22859 - Add .sql as templatable extension

2022-04-11 Thread GitBox
boring-cyborg[bot] commented on PR #22920: URL: https://github.com/apache/airflow/pull/22920#issuecomment-1095495729 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[GitHub] [airflow] LennyKLB opened a new pull request, #22920: implements #22859 - Add .sql as templatable extension

2022-04-11 Thread GitBox
LennyKLB opened a new pull request, #22920: URL: https://github.com/apache/airflow/pull/22920 This enables developers to template `.sql` files in Jinja when using `BigQueryInsertJobOperator`. This means that the parameter `configuration.query.query` can now refer to a proper `.sql`

[GitHub] [airflow] github-actions[bot] commented on pull request #22904: Call mapped_dependants only on the original task

2022-04-11 Thread GitBox
github-actions[bot] commented on PR #22904: URL: https://github.com/apache/airflow/pull/22904#issuecomment-1095490525 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the

[GitHub] [airflow] LennyKLB commented on issue #22859: Add .sql template extension rendering for BigQueryInsertJobOperator

2022-04-11 Thread GitBox
LennyKLB commented on issue #22859: URL: https://github.com/apache/airflow/issues/22859#issuecomment-1095481943 The change itself is so small that I refrained from adding/editing tests. I found that the BigQuery-related tests didn't feature any file-based templating. If this is

[GitHub] [airflow] dstandish closed pull request #22916: Clarify breeze install message re pipx vs `./breeze`

2022-04-11 Thread GitBox
dstandish closed pull request #22916: Clarify breeze install message re pipx vs `./breeze` URL: https://github.com/apache/airflow/pull/22916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] dstandish commented on pull request #22916: Clarify breeze install message re pipx vs `./breeze`

2022-04-11 Thread GitBox
dstandish commented on PR #22916: URL: https://github.com/apache/airflow/pull/22916#issuecomment-1095461058 Ok sounds good, was just making assumptions Will close -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] ashb commented on pull request #22904: Call mapped_dependants only on the original task

2022-04-11 Thread GitBox
ashb commented on PR #22904: URL: https://github.com/apache/airflow/pull/22904#issuecomment-1095457156 Oh. https://github.com/apache/airflow/blob/main/scripts/docker/entrypoint_ci.sh#L353-L357 No.  -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] ashb commented on a diff in pull request #22909: Fix bug where dynamically mapped tasks got set to REMOVED

2022-04-11 Thread GitBox
ashb commented on code in PR #22909: URL: https://github.com/apache/airflow/pull/22909#discussion_r847653426 ## airflow/serialization/serialized_objects.py: ## @@ -1081,12 +1081,12 @@ def deserialize_dag(cls, encoded_dag: Dict[str, Any]) -> 'SerializedDAG':

[GitHub] [airflow] uranusjr commented on pull request #22904: Call mapped_dependants only on the original task

2022-04-11 Thread GitBox
uranusjr commented on PR #22904: URL: https://github.com/apache/airflow/pull/22904#issuecomment-1095455487 H… does the CI run long-running tests by default…? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] uranusjr commented on a diff in pull request #22909: Fix bug where dynamically mapped tasks got set to REMOVED

2022-04-11 Thread GitBox
uranusjr commented on code in PR #22909: URL: https://github.com/apache/airflow/pull/22909#discussion_r847650700 ## airflow/serialization/serialized_objects.py: ## @@ -1081,12 +1081,12 @@ def deserialize_dag(cls, encoded_dag: Dict[str, Any]) -> 'SerializedDAG':

[GitHub] [airflow] ashb commented on pull request #22904: Call mapped_dependants only on the original task

2022-04-11 Thread GitBox
ashb commented on PR #22904: URL: https://github.com/apache/airflow/pull/22904#issuecomment-1095450527 ``` FAILED tests/jobs/test_backfill_job.py::TestBackfillJob::test_mapped_dag[test_mapped_classic-DebugExecutor] - RuntimeError: Cannot check for mapped_dependants when not attached to

[GitHub] [airflow] DONDJJ commented on issue #13637: Scheduler takes 100% of CPU without task execution

2022-04-11 Thread GitBox
DONDJJ commented on issue #13637: URL: https://github.com/apache/airflow/issues/13637#issuecomment-1095450372 @[veinkr](https://github.com/veinkr) @[kaxil](https://github.com/kaxil)

[GitHub] [airflow] ashb commented on pull request #22904: Call mapped_dependants only on the original task

2022-04-11 Thread GitBox
ashb commented on PR #22904: URL: https://github.com/apache/airflow/pull/22904#issuecomment-1095449301 Really? Those are failing for me on main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] uranusjr commented on pull request #22904: Call mapped_dependants only on the original task

2022-04-11 Thread GitBox
uranusjr commented on PR #22904: URL: https://github.com/apache/airflow/pull/22904#issuecomment-1095447937 Yeah I just added those two to the test DAG (_without the proposed fix) and CI still passes. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] ashb commented on a diff in pull request #22909: Fix bug where dynamically mapped tasks got set to REMOVED

2022-04-11 Thread GitBox
ashb commented on code in PR #22909: URL: https://github.com/apache/airflow/pull/22909#discussion_r847645333 ## airflow/serialization/serialized_objects.py: ## @@ -1081,12 +1081,12 @@ def deserialize_dag(cls, encoded_dag: Dict[str, Any]) -> 'SerializedDAG':

[GitHub] [airflow] ashb commented on pull request #22909: Fix bug where dynamically mapped tasks got set to REMOVED

2022-04-11 Thread GitBox
ashb commented on PR #22909: URL: https://github.com/apache/airflow/pull/22909#issuecomment-1095440612 This turned out a bit more complex :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] ashb commented on pull request #22909: Fix bug where dynamically mapped tasks got set to REMOVED

2022-04-11 Thread GitBox
ashb commented on PR #22909: URL: https://github.com/apache/airflow/pull/22909#issuecomment-1095441003 And I'm not too happy with how I had to structure the conditionals. Suggestions appreciated. -- This is an automated message from the Apache Git Service. To respond to the message,

[airflow] branch main updated: Add SmoothOperator (#22813)

2022-04-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new bc10265077 Add SmoothOperator (#22813) bc10265077

[GitHub] [airflow] potiuk merged pull request #22813: Add SmoothOperator

2022-04-11 Thread GitBox
potiuk merged PR #22813: URL: https://github.com/apache/airflow/pull/22813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #22813: Add SmoothOperator

2022-04-11 Thread GitBox
potiuk commented on PR #22813: URL: https://github.com/apache/airflow/pull/22813#issuecomment-1095436388 Just in time for 2.3.0. We could not wait for SmoothOperator. It's been highly requested feature by many. -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] potiuk commented on pull request #22813: Add SmoothOperator

2022-04-11 Thread GitBox
potiuk commented on PR #22813: URL: https://github.com/apache/airflow/pull/22813#issuecomment-1095435812 Not SADE any more and just random failure. Merging :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] potiuk commented on pull request #22916: Clarify breeze install message re pipx vs `./breeze`

2022-04-11 Thread GitBox
potiuk commented on PR #22916: URL: https://github.com/apache/airflow/pull/22916#issuecomment-1095431205 I completely missed updatinng those instructions after making this decision :blush: -- This is an automated message from the Apache Git Service. To respond to the message, please log

  1   2   3   >