[GitHub] [airflow] uranusjr commented on a diff in pull request #23160: Always -f when removing container after DockerOperator execution

2022-06-09 Thread GitBox
uranusjr commented on code in PR #23160: URL: https://github.com/apache/airflow/pull/23160#discussion_r894169596 ## airflow/providers/docker/operators/docker.py: ## @@ -189,7 +190,20 @@ def __init__( ) -> None: super().__init__(**kwargs) self.api_version

[GitHub] [airflow] robinsinghstudios commented on issue #24338: TaskFlow AirflowSkipException causes downstream step to fail

2022-06-09 Thread GitBox
robinsinghstudios commented on issue #24338: URL: https://github.com/apache/airflow/issues/24338#issuecomment-1151962041 The same issue has been bothering me for a while now and preventing me from upgrading to the latest airflow version. -- This is an automated message from the Apache

[GitHub] [airflow] github-actions[bot] commented on pull request #24335: `TI.log_url` fix for `map_index`

2022-06-09 Thread GitBox
github-actions[bot] commented on PR #24335: URL: https://github.com/apache/airflow/pull/24335#issuecomment-1151950202 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the

[GitHub] [airflow] heliharry commented on issue #24309: Intermittent failures when deleting pods

2022-06-09 Thread GitBox
heliharry commented on issue #24309: URL: https://github.com/apache/airflow/issues/24309#issuecomment-1151935806 Hit similar issue: [2022-06-10, 04:37:34 UTC] {pod_manager.py:253} WARNING - Pod aaa-xxx-baef53b3f96440a8abfc171d3a683e3d log read interrupted but container base still

[GitHub] [airflow] uranusjr opened a new pull request, #24362: Mask secrets in stdout for CLI command

2022-06-09 Thread GitBox
uranusjr opened a new pull request, #24362: URL: https://github.com/apache/airflow/pull/24362 Same as #21281, but rebased and simplified. Close #21281, fix #17476. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #23905: Added small health check server and endpoint in scheduler and updated…

2022-06-09 Thread GitBox
boring-cyborg[bot] commented on PR #23905: URL: https://github.com/apache/airflow/pull/23905#issuecomment-1151909405 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[airflow] branch main updated: Added small health check server and endpoint in scheduler and updated… (#23905)

2022-06-09 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 6b46240520 Added small health check server

[GitHub] [airflow] mik-laj merged pull request #23905: Added small health check server and endpoint in scheduler and updated…

2022-06-09 Thread GitBox
mik-laj merged PR #23905: URL: https://github.com/apache/airflow/pull/23905 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] mik-laj closed issue #22895: Airflow health API is returning always 200

2022-06-09 Thread GitBox
mik-laj closed issue #22895: Airflow health API is returning always 200 URL: https://github.com/apache/airflow/issues/22895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] Bowrna commented on issue #23538: CI: convert tests to use Breeze tests command

2022-06-09 Thread GitBox
Bowrna commented on issue #23538: URL: https://github.com/apache/airflow/issues/23538#issuecomment-1151881379 I think you have almost captured all the points you suggested to add in this PR [Add CI-friendly progress output for tests](https://github.com/apache/airflow/pull/24236/)

[GitHub] [airflow] Bowrna commented on a diff in pull request #24236: Add CI-friendly progress output for tests

2022-06-09 Thread GitBox
Bowrna commented on code in PR #24236: URL: https://github.com/apache/airflow/pull/24236#discussion_r894117097 ## dev/breeze/src/airflow_breeze/commands/testing_commands.py: ## @@ -112,6 +129,93 @@ def docker_compose_tests( sys.exit(return_code) +class

[GitHub] [airflow] Bowrna commented on a diff in pull request #24236: Add CI-friendly progress output for tests

2022-06-09 Thread GitBox
Bowrna commented on code in PR #24236: URL: https://github.com/apache/airflow/pull/24236#discussion_r894113605 ## dev/breeze/src/airflow_breeze/commands/testing_commands.py: ## @@ -112,6 +129,93 @@ def docker_compose_tests( sys.exit(return_code) +class

[GitHub] [airflow] Bowrna commented on a diff in pull request #24236: Add CI-friendly progress output for tests

2022-06-09 Thread GitBox
Bowrna commented on code in PR #24236: URL: https://github.com/apache/airflow/pull/24236#discussion_r894111895 ## dev/breeze/src/airflow_breeze/commands/testing_commands.py: ## @@ -112,6 +129,93 @@ def docker_compose_tests( sys.exit(return_code) +class

[GitHub] [airflow] zengbotang commented on pull request #23160: Always -f when removing container after DockerOperator execution

2022-06-09 Thread GitBox
zengbotang commented on PR #23160: URL: https://github.com/apache/airflow/pull/23160#issuecomment-1151840363 @potiuk I have update code ,add deprecation warning and fix unit test error , please review. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] zjffdu commented on pull request #21954: Add support for Apache Zeppelin (#21953)

2022-06-09 Thread GitBox
zjffdu commented on PR #21954: URL: https://github.com/apache/airflow/pull/21954#issuecomment-1151749720 @lucianolacurcia Thanks for clarification, how about moving that into another improvement PR? AFAIK, very few zeppelin rest end point are protected by spnego. But you can still submit

[GitHub] [airflow] github-actions[bot] commented on pull request #21281: Mask secrets in stdout for `airflow tasks test ...` CLI command (#17476)

2022-06-09 Thread GitBox
github-actions[bot] commented on PR #21281: URL: https://github.com/apache/airflow/pull/21281#issuecomment-1151736673 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

[GitHub] [airflow] github-actions[bot] commented on pull request #21901: Add `max_active_runs_reached` column to DagModel

2022-06-09 Thread GitBox
github-actions[bot] commented on PR #21901: URL: https://github.com/apache/airflow/pull/21901#issuecomment-1151736646 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

[GitHub] [airflow] github-actions[bot] closed pull request #22391: Update the redshift sql operator to accept multiple sql statements

2022-06-09 Thread GitBox
github-actions[bot] closed pull request #22391: Update the redshift sql operator to accept multiple sql statements URL: https://github.com/apache/airflow/pull/22391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] github-actions[bot] commented on pull request #22315: Airflow file sensor by prefix for azure data lake storage

2022-06-09 Thread GitBox
github-actions[bot] commented on PR #22315: URL: https://github.com/apache/airflow/pull/22315#issuecomment-1151736608 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

[GitHub] [airflow] github-actions[bot] commented on pull request #23188: Rework contract of try_adopt_task_instances method

2022-06-09 Thread GitBox
github-actions[bot] commented on PR #23188: URL: https://github.com/apache/airflow/pull/23188#issuecomment-1151736554 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

[GitHub] [airflow] github-actions[bot] commented on pull request #23184: Track and optionally include row count metadata with GCS upload

2022-06-09 Thread GitBox
github-actions[bot] commented on PR #23184: URL: https://github.com/apache/airflow/pull/23184#issuecomment-1151736579 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

[GitHub] [airflow] argibbs commented on pull request #23647: ExternalTaskSensor respects soft_fail if the external task enters a failed_state

2022-06-09 Thread GitBox
argibbs commented on PR #23647: URL: https://github.com/apache/airflow/pull/23647#issuecomment-1151678564 OK, 4th time's the charm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] grzegorzb1990 opened a new issue, #24360: Pattern parameter in S3ToSnowflakeOperator

2022-06-09 Thread GitBox
grzegorzb1990 opened a new issue, #24360: URL: https://github.com/apache/airflow/issues/24360 ### Description I would like to propose to add a pattern parameter to allow loading only those files that satisfy the given regex pattern. This function is supported on the Snowflake

[GitHub] [airflow] boring-cyborg[bot] commented on issue #24360: Pattern parameter in S3ToSnowflakeOperator

2022-06-09 Thread GitBox
boring-cyborg[bot] commented on issue #24360: URL: https://github.com/apache/airflow/issues/24360#issuecomment-1151672545 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] tronlightracer commented on pull request #23972: Adding connections for sql operator unit tests so they pass

2022-06-09 Thread GitBox
tronlightracer commented on PR #23972: URL: https://github.com/apache/airflow/pull/23972#issuecomment-1151657894 Hey @potiuk I apology for the late reply I've been dealing with some difficult life circumstances. What I was trying to fix with this PR is that for the method

[GitHub] [airflow] boring-cyborg[bot] commented on issue #24359: Timezone changed on server and UI to local/Pacific, but DateTimeSensor still using UTC

2022-06-09 Thread GitBox
boring-cyborg[bot] commented on issue #24359: URL: https://github.com/apache/airflow/issues/24359#issuecomment-1151647426 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] thelastmessiha opened a new issue, #24359: Timezone changed on server and UI to local/Pacific, but DateTimeSensor still using UTC

2022-06-09 Thread GitBox
thelastmessiha opened a new issue, #24359: URL: https://github.com/apache/airflow/issues/24359 ### Apache Airflow version 2.2.5 ### What happened I've set the core default_timezone and default_ui_timezone values to America/Los_Angeles which successfully makes the

[GitHub] [airflow] rmekdma commented on issue #17975: Backfill blocks all tasks from being queued when a single pool is full.

2022-06-09 Thread GitBox
rmekdma commented on issue #17975: URL: https://github.com/apache/airflow/issues/17975#issuecomment-1151640669 This also happened in v2.2.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] dstandish commented on pull request #24356: Serialize pod_override to JSON before pickling executor_config

2022-06-09 Thread GitBox
dstandish commented on PR #24356: URL: https://github.com/apache/airflow/pull/24356#issuecomment-1151632818 Yeah I tried to be mindful of that. I don't just serialize the whole executor config. I only serialize the `pod_override` node if the config is a dict and `pod_override` is a

[GitHub] [airflow] bbovenzi commented on a diff in pull request #24335: `TI.log_url` fix for `map_index`

2022-06-09 Thread GitBox
bbovenzi commented on code in PR #24335: URL: https://github.com/apache/airflow/pull/24335#discussion_r893896740 ## tests/models/test_taskinstance.py: ## @@ -1307,26 +1307,19 @@ def test_get_num_running_task_instances(self, create_task_instance): assert 1 ==

[GitHub] [airflow] bbovenzi commented on a diff in pull request #24335: `TI.log_url` fix for `map_index`

2022-06-09 Thread GitBox
bbovenzi commented on code in PR #24335: URL: https://github.com/apache/airflow/pull/24335#discussion_r893896083 ## tests/models/test_taskinstance.py: ## @@ -1307,26 +1307,15 @@ def test_get_num_running_task_instances(self, create_task_instance): assert 1 ==

[GitHub] [airflow] josh-fell commented on pull request #23647: ExternalTaskSensor respects soft_fail if the external task enters a failed_state

2022-06-09 Thread GitBox
josh-fell commented on PR #23647: URL: https://github.com/apache/airflow/pull/23647#issuecomment-1151553135 > Tests are failing :) Yeah, that's my fault. I provided an incorrect suggestion. @argibbs the state values should be `State.FAILED` and `State.SUCCESS` in your test. --

[GitHub] [airflow] bbovenzi commented on a diff in pull request #24249: Add Task Logs to Grid details panel

2022-06-09 Thread GitBox
bbovenzi commented on code in PR #24249: URL: https://github.com/apache/airflow/pull/24249#discussion_r893893163 ## airflow/www/static/js/grid/details/content/taskInstance/Logs/index.jsx: ## @@ -0,0 +1,191 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [airflow-site] kaxil commented on pull request #611: Fix mistakenly removed links in Providers

2022-06-09 Thread GitBox
kaxil commented on PR #611: URL: https://github.com/apache/airflow-site/pull/611#issuecomment-1151534708 Good eyes @josh-fell ![](https://media.giphy.com/media/aOW8nDmG0aRvNu3nXz/giphy.gif) -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] fritz-astronomer commented on a diff in pull request #24335: `TI.log_url` fix for `map_index`

2022-06-09 Thread GitBox
fritz-astronomer commented on code in PR #24335: URL: https://github.com/apache/airflow/pull/24335#discussion_r893861770 ## airflow/models/taskinstance.py: ## @@ -264,13 +263,13 @@ def clear_task_instances( drs = ( session.query(DagRun) -

[GitHub] [airflow] ashb commented on pull request #24356: Serialize pod_override to JSON before pickling executor_config

2022-06-09 Thread GitBox
ashb commented on PR #24356: URL: https://github.com/apache/airflow/pull/24356#issuecomment-1151487938 Not sure if this impacts things: but executor config can be used for other executors too -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] o-nikolas commented on a diff in pull request #24357: DebugExecutor use ti.run() instead of ti._run_raw_task

2022-06-09 Thread GitBox
o-nikolas commented on code in PR #24357: URL: https://github.com/apache/airflow/pull/24357#discussion_r893856303 ## tests/jobs/test_backfill_job.py: ## @@ -1599,7 +1615,7 @@ def test_mapped_dag(self, dag_id, executor_name, session):

[GitHub] [airflow] o-nikolas opened a new pull request, #24357: DebugExecutor use ti.run() instead of ti._run_raw_task

2022-06-09 Thread GitBox
o-nikolas opened a new pull request, #24357: URL: https://github.com/apache/airflow/pull/24357 The DebugExecutor previously executed tasks by calling the "private" ti._run_raw_task(...) method instead of ti.run(...). But the latter contains the logic to increase task instance try_numbers

[GitHub] [airflow] dstandish opened a new pull request, #24356: Serialize pod_override to JSON before pickling executor_config

2022-06-09 Thread GitBox
dstandish opened a new pull request, #24356: URL: https://github.com/apache/airflow/pull/24356 If we unpickle a k8s object that was pickled under an earlier k8s library version, then the unpickled object may throw an error when to_dict is called. To be more tolerant of version changes we

[GitHub] [airflow] potiuk commented on pull request #23905: Added small health check server and endpoint in scheduler and updated…

2022-06-09 Thread GitBox
potiuk commented on PR #23905: URL: https://github.com/apache/airflow/pull/23905#issuecomment-1151473130 Just re-run failed checks to see if those were accidental -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] michaelmicheal commented on pull request #23905: Added small health check server and endpoint in scheduler and updated…

2022-06-09 Thread GitBox
michaelmicheal commented on PR #23905: URL: https://github.com/apache/airflow/pull/23905#issuecomment-1151471577 @potiuk @mik-laj Anything else I need to do or is it good to merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #24249: Add Task Logs to Grid details panel

2022-06-09 Thread GitBox
pierrejeambrun commented on code in PR #24249: URL: https://github.com/apache/airflow/pull/24249#discussion_r893835007 ## airflow/www/static/js/grid/details/content/taskInstance/Logs/index.jsx: ## @@ -0,0 +1,191 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [airflow] github-actions[bot] commented on pull request #23647: ExternalTaskSensor respects soft_fail if the external task enters a failed_state

2022-06-09 Thread GitBox
github-actions[bot] commented on PR #23647: URL: https://github.com/apache/airflow/pull/23647#issuecomment-1151455738 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the

[GitHub] [airflow] potiuk commented on pull request #23647: ExternalTaskSensor respects soft_fail if the external task enters a failed_state

2022-06-09 Thread GitBox
potiuk commented on PR #23647: URL: https://github.com/apache/airflow/pull/23647#issuecomment-1151454202 Tests are failing :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #24249: Add Task Logs to Grid details panel

2022-06-09 Thread GitBox
pierrejeambrun commented on code in PR #24249: URL: https://github.com/apache/airflow/pull/24249#discussion_r893825573 ## airflow/www/static/js/grid/details/content/taskInstance/Logs/index.jsx: ## @@ -0,0 +1,191 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #24249: Add Task Logs to Grid details panel

2022-06-09 Thread GitBox
pierrejeambrun commented on code in PR #24249: URL: https://github.com/apache/airflow/pull/24249#discussion_r893825573 ## airflow/www/static/js/grid/details/content/taskInstance/Logs/index.jsx: ## @@ -0,0 +1,191 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [airflow] vincbeck opened a new pull request, #24355: Migrate lambda sample dag to system test

2022-06-09 Thread GitBox
vincbeck opened a new pull request, #24355: URL: https://github.com/apache/airflow/pull/24355 Migrate lambda sample dag to system test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] bbovenzi commented on a diff in pull request #24335: `TI.log_url` fix for `map_index`

2022-06-09 Thread GitBox
bbovenzi commented on code in PR #24335: URL: https://github.com/apache/airflow/pull/24335#discussion_r893821855 ## airflow/models/taskinstance.py: ## @@ -264,13 +263,13 @@ def clear_task_instances( drs = ( session.query(DagRun) -.filter( +

[GitHub] [airflow] potiuk commented on pull request #23647: ExternalTaskSensor respects soft_fail if the external task enters a failed_state

2022-06-09 Thread GitBox
potiuk commented on PR #23647: URL: https://github.com/apache/airflow/pull/23647#issuecomment-1151435803 > Yeah, I ran it from the root of the checkout... I dunno what I did wrong. I'm really hoping this is it now though.  Could also be a different black version :). Also I really

[GitHub] [airflow] bbovenzi closed issue #23602: Calendar view is taking too long to load in airflow 2.3.0

2022-06-09 Thread GitBox
bbovenzi closed issue #23602: Calendar view is taking too long to load in airflow 2.3.0 URL: https://github.com/apache/airflow/issues/23602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] bbovenzi commented on issue #23602: Calendar view is taking too long to load in airflow 2.3.0

2022-06-09 Thread GitBox
bbovenzi commented on issue #23602: URL: https://github.com/apache/airflow/issues/23602#issuecomment-1151433386 I think the PR above should be enough to close this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[airflow] branch main updated: Optimize calendar view for cron scheduled DAGs (#24262)

2022-06-09 Thread bbovenzi
This is an automated email from the ASF dual-hosted git repository. bbovenzi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 23fb6635ea Optimize calendar view for cron

[GitHub] [airflow] bbovenzi merged pull request #24262: Optimize calendar view for cron scheduled DAGs

2022-06-09 Thread GitBox
bbovenzi merged PR #24262: URL: https://github.com/apache/airflow/pull/24262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #24262: Optimize calendar view for cron scheduled DAGs

2022-06-09 Thread GitBox
github-actions[bot] commented on PR #24262: URL: https://github.com/apache/airflow/pull/24262#issuecomment-1151430439 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the

[GitHub] [airflow] vincbeck opened a new pull request, #24354: Migrate datasync sample dag to system tests (AIP-47)

2022-06-09 Thread GitBox
vincbeck opened a new pull request, #24354: URL: https://github.com/apache/airflow/pull/24354 Migrate datasync sample dag to system tests (AIP-47) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] argibbs commented on pull request #23647: ExternalTaskSensor respects soft_fail if the external task enters a failed_state

2022-06-09 Thread GitBox
argibbs commented on PR #23647: URL: https://github.com/apache/airflow/pull/23647#issuecomment-1151419396 Yeah, I ran it from the root of the checkout... I dunno what I did wrong. I'm really hoping this is it now though.  It's been a learning curve but I'll hopefully walk into

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #24353: GCSDeleteObjectsOperator empty prefix bug fix

2022-06-09 Thread GitBox
boring-cyborg[bot] commented on PR #24353: URL: https://github.com/apache/airflow/pull/24353#issuecomment-1151413096 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[GitHub] [airflow] Lavedonio opened a new pull request, #24353: GCSDeleteObjectsOperator empty prefix bug fix

2022-06-09 Thread GitBox
Lavedonio opened a new pull request, #24353: URL: https://github.com/apache/airflow/pull/24353 This PR solves the Issue #24352 for a bug found in GCSDeleteObjectsOperator, where an error was thrown if the parameter `prefix` was set to an empty string, which should be a valid input.

[GitHub] [airflow] potiuk commented on pull request #23647: ExternalTaskSensor respects soft_fail if the external task enters a failed_state

2022-06-09 Thread GitBox
potiuk commented on PR #23647: URL: https://github.com/apache/airflow/pull/23647#issuecomment-1151411100 Likely whatever you used to run black does not take pyproject.toml into account: ```[ tool.black] line-length = 110 target-version = ['py37', 'py38', 'py39', 'py310']

[airflow] branch main updated: Add scripts that provide good links to example dags (#24348)

2022-06-09 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 85c247ae10 Add scripts that provide good links to

[GitHub] [airflow] potiuk commented on pull request #24348: Add scripts that provide good links to example dags

2022-06-09 Thread GitBox
potiuk commented on PR #24348: URL: https://github.com/apache/airflow/pull/24348#issuecomment-1151407661 static checks passed . What can go wrong :)? Merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] potiuk merged pull request #24348: Add scripts that provide good links to example dags

2022-06-09 Thread GitBox
potiuk merged PR #24348: URL: https://github.com/apache/airflow/pull/24348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk closed issue #24331: "Example DAGs" link under kubernetes-provider documentation is broken. Getting 404

2022-06-09 Thread GitBox
potiuk closed issue #24331: "Example DAGs" link under kubernetes-provider documentation is broken. Getting 404 URL: https://github.com/apache/airflow/issues/24331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] bbovenzi commented on pull request #23516: clear specific dag run TI

2022-06-09 Thread GitBox
bbovenzi commented on PR #23516: URL: https://github.com/apache/airflow/pull/23516#issuecomment-1151404839 > Then I have to extract only the task_ids( excluding the map_index in tuple) and send that to query and find the upstream or downstream task_ids. Am I right in my understanding?

[GitHub] [airflow] argibbs commented on pull request #23647: ExternalTaskSensor respects soft_fail if the external task enters a failed_state

2022-06-09 Thread GitBox
argibbs commented on PR #23647: URL: https://github.com/apache/airflow/pull/23647#issuecomment-1151403942 Ok, I've run black again, weirdly black via breeze seems to do something different to black run externally 路 . Anyhoo, `breeze static-checks -t black` passes locally for me. --

[GitHub] [airflow] boring-cyborg[bot] commented on issue #24352: GCSDeleteObjectsOperator raises unexpected ValueError for prefix set as empty string

2022-06-09 Thread GitBox
boring-cyborg[bot] commented on issue #24352: URL: https://github.com/apache/airflow/issues/24352#issuecomment-1151399356 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] Lavedonio opened a new issue, #24352: GCSDeleteObjectsOperator raises unexpected ValueError for prefix set as empty string

2022-06-09 Thread GitBox
Lavedonio opened a new issue, #24352: URL: https://github.com/apache/airflow/issues/24352 ### Apache Airflow Provider(s) google ### Versions of Apache Airflow Providers All versions. ``` apache-airflow-providers-google>=1.0.0b1

[GitHub] [airflow] josh-fell commented on a diff in pull request #24347: Add salesforce_default to List Connection

2022-06-09 Thread GitBox
josh-fell commented on code in PR #24347: URL: https://github.com/apache/airflow/pull/24347#discussion_r893773031 ## airflow/utils/db.py: ## @@ -533,6 +533,13 @@ def create_default_connections(session: Session = NEW_SESSION): ), session, ) +

[GitHub] [airflow] github-actions[bot] commented on pull request #24348: Add scripts that provide good links to example dags

2022-06-09 Thread GitBox
github-actions[bot] commented on PR #24348: URL: https://github.com/apache/airflow/pull/24348#issuecomment-1151388508 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full

[airflow-site] branch main updated: Fix mistakenly removed links in Providers (#611)

2022-06-09 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow-site.git The following commit(s) were added to refs/heads/main by this push: new 20252def01 Fix mistakenly removed links in

[GitHub] [airflow-site] potiuk merged pull request #611: Fix mistakenly removed links in Providers

2022-06-09 Thread GitBox
potiuk merged PR #611: URL: https://github.com/apache/airflow-site/pull/611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] chenglongyan opened a new pull request, #24351: Migrate Google sheets example DAG to new design AIP-47

2022-06-09 Thread GitBox
chenglongyan opened a new pull request, #24351: URL: https://github.com/apache/airflow/pull/24351 related: #22430, #22447 --- **^ Add meaningful description above** Read the **[Pull Request

[airflow-site] 01/01: Fix mistakenly removed links in Providers

2022-06-09 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch update-missing-links in repository https://gitbox.apache.org/repos/asf/airflow-site.git commit 861a0e40ba0ce7f4f9fd94fd1cd73292f992af7b Author: Jarek Potiuk AuthorDate: Thu Jun 9 18:56:38 2022

[GitHub] [airflow-site] potiuk opened a new pull request, #611: Fix mistakenly removed links in Providers

2022-06-09 Thread GitBox
potiuk opened a new pull request, #611: URL: https://github.com/apache/airflow-site/pull/611 The #610 removed too many links because GitHub throttled checking if URLS are available. This PR is re-done with better checking for error code. -- This is an automated message from the

[GitHub] [airflow-site] potiuk commented on pull request #611: Fix mistakenly removed links in Providers

2022-06-09 Thread GitBox
potiuk commented on PR #611: URL: https://github.com/apache/airflow-site/pull/611#issuecomment-1151377888 Thanks to @josh-fell for noticing those :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[airflow-site] branch update-missing-links created (now 861a0e40ba)

2022-06-09 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch update-missing-links in repository https://gitbox.apache.org/repos/asf/airflow-site.git at 861a0e40ba Fix mistakenly removed links in Providers This branch includes the following new

[GitHub] [airflow] bbovenzi opened a new issue, #24350: Migrate React js files to typescript

2022-06-09 Thread GitBox
bbovenzi opened a new issue, #24350: URL: https://github.com/apache/airflow/issues/24350 ### Description We added typescript support in #24337. Now, we should work on migrating all the react code over to typescript. We could migrate other js files too, but I think the react

[GitHub] [airflow] chenglongyan closed pull request #24299: Migrate Google search ads system test to new design AIP-47

2022-06-09 Thread GitBox
chenglongyan closed pull request #24299: Migrate Google search ads system test to new design AIP-47 URL: https://github.com/apache/airflow/pull/24299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] chenglongyan opened a new pull request, #24349: Migrate Google example DAG azure_fileshare to new design AIP-47

2022-06-09 Thread GitBox
chenglongyan opened a new pull request, #24349: URL: https://github.com/apache/airflow/pull/24349 related: #22430, #22447 --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] bbovenzi commented on a diff in pull request #24249: Add Task Logs to Grid details panel

2022-06-09 Thread GitBox
bbovenzi commented on code in PR #24249: URL: https://github.com/apache/airflow/pull/24249#discussion_r893723917 ## airflow/www/static/js/grid/details/content/taskInstance/Logs/index.jsx: ## @@ -0,0 +1,191 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [airflow] lucianolacurcia commented on pull request #21954: Add support for Apache Zeppelin (#21953)

2022-06-09 Thread GitBox
lucianolacurcia commented on PR #21954: URL: https://github.com/apache/airflow/pull/21954#issuecomment-1151347835 > I mean enabling kerberized authentication from airflow to zeppelin. For example if I want to run a paragraph of a zeppelin notebook using curl, I have to use

[GitHub] [airflow-site] potiuk commented on a diff in pull request #610: Update links to example dags to point to the right github URL

2022-06-09 Thread GitBox
potiuk commented on code in PR #610: URL: https://github.com/apache/airflow-site/pull/610#discussion_r893721078 ## docs-archive/apache-airflow-providers-airbyte/1.0.0/index.html: ## @@ -331,7 +331,6 @@ Resources

[GitHub] [airflow-site] josh-fell commented on a diff in pull request #610: Update links to example dags to point to the right github URL

2022-06-09 Thread GitBox
josh-fell commented on code in PR #610: URL: https://github.com/apache/airflow-site/pull/610#discussion_r893720464 ## docs-archive/apache-airflow-providers-apache-drill/1.0.0/index.html: ## @@ -330,7 +330,6 @@ Resources

[GitHub] [airflow-site] josh-fell commented on a diff in pull request #610: Update links to example dags to point to the right github URL

2022-06-09 Thread GitBox
josh-fell commented on code in PR #610: URL: https://github.com/apache/airflow-site/pull/610#discussion_r893717748 ## docs-archive/apache-airflow-providers-apache-drill/1.0.0/index.html: ## @@ -330,7 +330,6 @@ Resources

[GitHub] [airflow-site] potiuk commented on a diff in pull request #610: Update links to example dags to point to the right github URL

2022-06-09 Thread GitBox
potiuk commented on code in PR #610: URL: https://github.com/apache/airflow-site/pull/610#discussion_r893714768 ## docs-archive/apache-airflow-providers-apache-drill/1.0.0/index.html: ## @@ -330,7 +330,6 @@ Resources

[GitHub] [airflow-site] josh-fell commented on a diff in pull request #610: Update links to example dags to point to the right github URL

2022-06-09 Thread GitBox
josh-fell commented on code in PR #610: URL: https://github.com/apache/airflow-site/pull/610#discussion_r893706552 ## docs-archive/apache-airflow-providers-apache-drill/1.0.0/index.html: ## @@ -330,7 +330,6 @@ Resources

[GitHub] [airflow] github-actions[bot] commented on pull request #24114: Refactor `DagRun.verify_integrity`

2022-06-09 Thread GitBox
github-actions[bot] commented on PR #24114: URL: https://github.com/apache/airflow/pull/24114#issuecomment-1151330666 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the

[GitHub] [airflow-site] josh-fell commented on a diff in pull request #610: Update links to example dags to point to the right github URL

2022-06-09 Thread GitBox
josh-fell commented on code in PR #610: URL: https://github.com/apache/airflow-site/pull/610#discussion_r893703759 ## docs-archive/apache-airflow-providers-airbyte/1.0.0/index.html: ## @@ -331,7 +331,6 @@ Resources

[GitHub] [airflow] dstandish commented on a diff in pull request #24114: Refactor `DagRun.verify_integrity`

2022-06-09 Thread GitBox
dstandish commented on code in PR #24114: URL: https://github.com/apache/airflow/pull/24114#discussion_r893699388 ## airflow/models/dagrun.py: ## @@ -885,19 +924,21 @@ def verify_integrity(self, session: Session = NEW_SESSION): )

[GitHub] [airflow-site] potiuk merged pull request #610: Update links to example dags to point to the right github URL

2022-06-09 Thread GitBox
potiuk merged PR #610: URL: https://github.com/apache/airflow-site/pull/610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #24348: Add scripts that provide good links to example dags

2022-06-09 Thread GitBox
potiuk commented on PR #24348: URL: https://github.com/apache/airflow/pull/24348#issuecomment-1151324975 cc: @deeptansh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] potiuk opened a new pull request, #24348: Add scripts that provide good links to example dags

2022-06-09 Thread GitBox
potiuk opened a new pull request, #24348: URL: https://github.com/apache/airflow/pull/24348 The documentation generated used "main" in the URL of the example DAGs. The generation of the links have been fixed in the #24307, but this PR adds a tool that has been used to fix

[GitHub] [airflow-site] potiuk commented on pull request #610: Update links to example dags to point to the right github URL

2022-06-09 Thread GitBox
potiuk commented on PR #610: URL: https://github.com/apache/airflow-site/pull/610#issuecomment-1151320722 cc: @deeptansh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow-site] potiuk opened a new pull request, #610: Update links to example dags to point to the right github URL

2022-06-09 Thread GitBox
potiuk opened a new pull request, #610: URL: https://github.com/apache/airflow-site/pull/610 The links to example DAGs from all versions of the providers pointed to "main" version of the example DAGS. This was wrong because it always shown the "latest" version of the examples, and

[airflow-site] branch fix-links-to-example-dags created (now 02cb40aa3a)

2022-06-09 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch fix-links-to-example-dags in repository https://gitbox.apache.org/repos/asf/airflow-site.git at 02cb40aa3a Update links to example dags to point to the right github URL This branch

[GitHub] [airflow] uranusjr commented on pull request #17349: #16037 Templated requirements.txt in Python operators

2022-06-09 Thread GitBox
uranusjr commented on PR #17349: URL: https://github.com/apache/airflow/pull/17349#issuecomment-1151318034 A pull request would be much appreciated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] junaidnasir-ps commented on issue #23588: After upgrade from Airflow 2.2.4, grid disappears for some DAGs

2022-06-09 Thread GitBox
junaidnasir-ps commented on issue #23588: URL: https://github.com/apache/airflow/issues/23588#issuecomment-1151289384 it's also happening for us when the user role is viewer (not logged in). (for admin role it works fine) also using helm and k8 with airflow:2.3.2-debian-11-r2

[GitHub] [airflow] fritz-astronomer commented on a diff in pull request #24335: `TI.log_url` fix for `map_index`

2022-06-09 Thread GitBox
fritz-astronomer commented on code in PR #24335: URL: https://github.com/apache/airflow/pull/24335#discussion_r893660006 ## tests/models/test_taskinstance.py: ## @@ -1307,26 +1307,15 @@ def test_get_num_running_task_instances(self, create_task_instance): assert 1 ==

[GitHub] [airflow] github-actions[bot] commented on pull request #24340: Fix #24339 db clean error - capture warning added rollback

2022-06-09 Thread GitBox
github-actions[bot] commented on PR #24340: URL: https://github.com/apache/airflow/pull/24340#issuecomment-1151258873 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the

[GitHub] [airflow] dstandish commented on issue #24339: airflow db cleanup - psycopg2.errors.InFailedSqlTransaction celery_taskmeta

2022-06-09 Thread GitBox
dstandish commented on issue #24339: URL: https://github.com/apache/airflow/issues/24339#issuecomment-1151256010 This gets improved in https://github.com/apache/airflow/pull/23574

  1   2   >