[GitHub] [airflow] vqcuong closed issue #24693: TrinoHook connecting over https should support CertificateAuthentication from config extras

2022-06-27 Thread GitBox
vqcuong closed issue #24693: TrinoHook connecting over https should support CertificateAuthentication from config extras URL: https://github.com/apache/airflow/issues/24693 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] samhita-alla closed pull request #22646: Add new community provider: Flyte

2022-06-27 Thread GitBox
samhita-alla closed pull request #22646: Add new community provider: Flyte URL: https://github.com/apache/airflow/pull/22646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] samhita-alla commented on pull request #22646: Add new community provider: Flyte

2022-06-27 Thread GitBox
samhita-alla commented on PR #22646: URL: https://github.com/apache/airflow/pull/22646#issuecomment-1168221340 Hi, @potiuk! Thanks for letting me know about the updated process. I have, however, created a [standalone

[GitHub] [airflow] boring-cyborg[bot] commented on issue #24693: TrinoHook connecting over https should support CertificateAuthentication from config extras

2022-06-27 Thread GitBox
boring-cyborg[bot] commented on issue #24693: URL: https://github.com/apache/airflow/issues/24693#issuecomment-1168214785 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] vqcuong opened a new issue, #24693: TrinoHook connecting over https should support CertificateAuthentication from config extras

2022-06-27 Thread GitBox
vqcuong opened a new issue, #24693: URL: https://github.com/apache/airflow/issues/24693 ### Description I have read throught [TrinoHook](https://github.com/apache/airflow/blob/main/airflow/providers/trino/hooks/trino.py#L130) and relize that the method get_conn missed option to

[GitHub] [airflow] github-actions[bot] commented on pull request #24637: Don't render child rows for closed groups

2022-06-27 Thread GitBox
github-actions[bot] commented on PR #24637: URL: https://github.com/apache/airflow/pull/24637#issuecomment-1168201085 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the

[GitHub] [airflow] uranusjr commented on a diff in pull request #24667: Clean up task decorator type hints and docstrings

2022-06-27 Thread GitBox
uranusjr commented on code in PR #24667: URL: https://github.com/apache/airflow/pull/24667#discussion_r908009505 ## airflow/decorators/__init__.pyi: ## @@ -124,20 +124,14 @@ class TaskDecoratorCollection: @overload def virtualenv(self, python_callable: Function) ->

[GitHub] [airflow] jedcunningham commented on a diff in pull request #24688: Use older version of node for pre-commit checks

2022-06-27 Thread GitBox
jedcunningham commented on code in PR #24688: URL: https://github.com/apache/airflow/pull/24688#discussion_r908011658 ## .pre-commit-config.yaml: ## @@ -19,6 +19,7 @@ default_stages: [commit, push] default_language_version: # force all unspecified python hooks to run

[GitHub] [airflow] jedcunningham commented on a diff in pull request #24688: Use older version of node for pre-commit checks

2022-06-27 Thread GitBox
jedcunningham commented on code in PR #24688: URL: https://github.com/apache/airflow/pull/24688#discussion_r908011658 ## .pre-commit-config.yaml: ## @@ -19,6 +19,7 @@ default_stages: [commit, push] default_language_version: # force all unspecified python hooks to run

[GitHub] [airflow] dstandish commented on a diff in pull request #24667: Clean up task decorator type hints and docstrings

2022-06-27 Thread GitBox
dstandish commented on code in PR #24667: URL: https://github.com/apache/airflow/pull/24667#discussion_r908011339 ## airflow/decorators/__init__.pyi: ## @@ -124,20 +124,14 @@ class TaskDecoratorCollection: @overload def virtualenv(self, python_callable: Function) ->

[GitHub] [airflow] uranusjr commented on a diff in pull request #24667: Clean up task decorator type hints and docstrings

2022-06-27 Thread GitBox
uranusjr commented on code in PR #24667: URL: https://github.com/apache/airflow/pull/24667#discussion_r908009505 ## airflow/decorators/__init__.pyi: ## @@ -124,20 +124,14 @@ class TaskDecoratorCollection: @overload def virtualenv(self, python_callable: Function) ->

[airflow] branch main updated: Remove commented out code (#24685)

2022-06-27 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 9e2658ea88 Remove commented out code

[GitHub] [airflow] jedcunningham merged pull request #24685: Remove commented out code

2022-06-27 Thread GitBox
jedcunningham merged PR #24685: URL: https://github.com/apache/airflow/pull/24685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] eladkal commented on a diff in pull request #24673: Rename 'resources' arg in Kub op to k8s_resources

2022-06-27 Thread GitBox
eladkal commented on code in PR #24673: URL: https://github.com/apache/airflow/pull/24673#discussion_r908003508 ## airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py: ## @@ -112,7 +112,7 @@ class KubernetesPodOperator(BaseOperator): :param annotations:

[GitHub] [airflow] github-actions[bot] commented on pull request #24667: Clean up task decorator type hints and docstrings

2022-06-27 Thread GitBox
github-actions[bot] commented on PR #24667: URL: https://github.com/apache/airflow/pull/24667#issuecomment-1168171494 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the

[GitHub] [airflow] dstandish commented on a diff in pull request #24667: Clean up task decorator type hints and docstrings

2022-06-27 Thread GitBox
dstandish commented on code in PR #24667: URL: https://github.com/apache/airflow/pull/24667#discussion_r907990734 ## airflow/decorators/__init__.pyi: ## @@ -124,20 +124,14 @@ class TaskDecoratorCollection: @overload def virtualenv(self, python_callable: Function) ->

[GitHub] [airflow] uranusjr commented on a diff in pull request #24673: Rename 'resources' arg in Kub op to k8s_resources

2022-06-27 Thread GitBox
uranusjr commented on code in PR #24673: URL: https://github.com/apache/airflow/pull/24673#discussion_r907984624 ## airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py: ## @@ -112,7 +112,7 @@ class KubernetesPodOperator(BaseOperator): :param annotations:

[GitHub] [airflow] uranusjr merged pull request #24676: TriggerDagRunOperator.operator_extra_links is attr

2022-06-27 Thread GitBox
uranusjr merged PR #24676: URL: https://github.com/apache/airflow/pull/24676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated: TriggerDagRunOperator.operator_extra_links is attr (#24676)

2022-06-27 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 8dcafdfcdd

[GitHub] [airflow] uranusjr closed issue #24653: Mapped TriggerDagRunOperator causes SerializationError due to operator_extra_links 'property' object is not iterable

2022-06-27 Thread GitBox
uranusjr closed issue #24653: Mapped TriggerDagRunOperator causes SerializationError due to operator_extra_links 'property' object is not iterable URL: https://github.com/apache/airflow/issues/24653 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] cloventt commented on issue #23588: After upgrade from Airflow 2.2.4, grid disappears for some DAGs

2022-06-27 Thread GitBox
cloventt commented on issue #23588: URL: https://github.com/apache/airflow/issues/23588#issuecomment-1168158498 +1, I run Airflow behind an Nginx reverse proxy with `AUTH_ROLE_PUBLIC = 'Admin' ` set in the webserver config. I see 401 Unauthorized errors on the call to

[GitHub] [airflow] potiuk commented on a diff in pull request #24672: Move provider dependencies to inside provider folders

2022-06-27 Thread GitBox
potiuk commented on code in PR #24672: URL: https://github.com/apache/airflow/pull/24672#discussion_r907967053 ## airflow/provider.yaml.schema.json: ## @@ -231,8 +234,26 @@ } }, "additional-extras": { - "type": "object", - "description": "Additional

[GitHub] [airflow] potiuk commented on pull request #24680: Update release process for Providers

2022-06-27 Thread GitBox
potiuk commented on PR #24680: URL: https://github.com/apache/airflow/pull/24680#issuecomment-1168137979 I pushed a fixup with all those comments so far addressed (hopefully) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] potiuk commented on a diff in pull request #24680: Update release process for Providers

2022-06-27 Thread GitBox
potiuk commented on code in PR #24680: URL: https://github.com/apache/airflow/pull/24680#discussion_r907965301 ## README.md: ## @@ -410,6 +410,27 @@ For example this means that by default we upgrade the minimum version of Airflow to 2.3.0 in the first Provider's release after

[GitHub] [airflow] potiuk commented on a diff in pull request #24680: Update release process for Providers

2022-06-27 Thread GitBox
potiuk commented on code in PR #24680: URL: https://github.com/apache/airflow/pull/24680#discussion_r907964660 ## README.md: ## @@ -410,6 +410,27 @@ For example this means that by default we upgrade the minimum version of Airflow to 2.3.0 in the first Provider's release after

[GitHub] [airflow] potiuk commented on a diff in pull request #24680: Update release process for Providers

2022-06-27 Thread GitBox
potiuk commented on code in PR #24680: URL: https://github.com/apache/airflow/pull/24680#discussion_r907954823 ## README.md: ## @@ -410,6 +410,27 @@ For example this means that by default we upgrade the minimum version of Airflow to 2.3.0 in the first Provider's release after

[GitHub] [airflow] potiuk commented on a diff in pull request #24680: Update release process for Providers

2022-06-27 Thread GitBox
potiuk commented on code in PR #24680: URL: https://github.com/apache/airflow/pull/24680#discussion_r907952667 ## README.md: ## @@ -410,6 +410,27 @@ For example this means that by default we upgrade the minimum version of Airflow to 2.3.0 in the first Provider's release after

[GitHub] [airflow] potiuk commented on a diff in pull request #24680: Update release process for Providers

2022-06-27 Thread GitBox
potiuk commented on code in PR #24680: URL: https://github.com/apache/airflow/pull/24680#discussion_r907949281 ## README.md: ## @@ -410,6 +410,27 @@ For example this means that by default we upgrade the minimum version of Airflow to 2.3.0 in the first Provider's release after

[GitHub] [airflow] potiuk commented on a diff in pull request #24680: Update release process for Providers

2022-06-27 Thread GitBox
potiuk commented on code in PR #24680: URL: https://github.com/apache/airflow/pull/24680#discussion_r907947926 ## README.md: ## @@ -410,6 +410,27 @@ For example this means that by default we upgrade the minimum version of Airflow to 2.3.0 in the first Provider's release after

[GitHub] [airflow] potiuk commented on pull request #24680: Update release process for Providers

2022-06-27 Thread GitBox
potiuk commented on PR #24680: URL: https://github.com/apache/airflow/pull/24680#issuecomment-1168112687 > I find it hard to wrap my head around what I'm reading. What is the message you want to convey here? Ok. Cool. I am happy to iterate on it to make it better :). This is

[GitHub] [airflow] tianrobin opened a new issue, #24692: Error for Hive Server2 Connection Document

2022-06-27 Thread GitBox
tianrobin opened a new issue, #24692: URL: https://github.com/apache/airflow/issues/24692 ### What do you see as an issue? In this Document https://airflow.apache.org/docs/apache-airflow-providers-apache-hive/stable/connections/hiveserver2.html Describe , In Extra must use the

[GitHub] [airflow] boring-cyborg[bot] commented on issue #24692: Error for Hive Server2 Connection Document

2022-06-27 Thread GitBox
boring-cyborg[bot] commented on issue #24692: URL: https://github.com/apache/airflow/issues/24692#issuecomment-1168100894 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] potiuk commented on pull request #24664: Add ARM image building for regular PRs

2022-06-27 Thread GitBox
potiuk commented on PR #24664: URL: https://github.com/apache/airflow/pull/24664#issuecomment-1168098448 BTW. @jedcunningham - by writing this answer and looking at the workflows I realized that there is a potential for a small optimization (of cost). I added additional "needs" for the

[airflow] branch add-arm-image-building updated (00d827acbb -> 8731b00958)

2022-06-27 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch add-arm-image-building in repository https://gitbox.apache.org/repos/asf/airflow.git discard 00d827acbb Add ARM image building for regular PRs add c95081406f Turn inability of creating

[GitHub] [airflow] potiuk commented on pull request #24664: Add ARM image building for regular PRs

2022-06-27 Thread GitBox
potiuk commented on PR #24664: URL: https://github.com/apache/airflow/pull/24664#issuecomment-1168093297 > @potiuk, just want to double check there is no security/resource considerations here with us spinning up ARM machines for normal, non-committer PRs, right? Good questions. I

[GitHub] [airflow] dstandish opened a new pull request, #24691: Add DatasetReference model

2022-06-27 Thread GitBox
dstandish opened a new pull request, #24691: URL: https://github.com/apache/airflow/pull/24691 This is an exploratory PR adding model DatasetReference. It represents a slight change to the AIP. Instead of defining upstream datasets at the _DAG_ level through a new scheduling param,

[GitHub] [airflow] github-actions[bot] closed pull request #23558: Add support for webserver.hostAliases to Helm Chart

2022-06-27 Thread GitBox
github-actions[bot] closed pull request #23558: Add support for webserver.hostAliases to Helm Chart URL: https://github.com/apache/airflow/pull/23558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] github-actions[bot] closed pull request #22961: Breeze: Remove duplicate target version for Black

2022-06-27 Thread GitBox
github-actions[bot] closed pull request #22961: Breeze: Remove duplicate target version for Black URL: https://github.com/apache/airflow/pull/22961 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] github-actions[bot] closed pull request #22580: Add variable description

2022-06-27 Thread GitBox
github-actions[bot] closed pull request #22580: Add variable description URL: https://github.com/apache/airflow/pull/22580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] o-nikolas commented on a diff in pull request #24680: Update release process for Providers

2022-06-27 Thread GitBox
o-nikolas commented on code in PR #24680: URL: https://github.com/apache/airflow/pull/24680#discussion_r907899400 ## README.md: ## @@ -410,6 +410,27 @@ For example this means that by default we upgrade the minimum version of Airflow to 2.3.0 in the first Provider's release

[GitHub] [airflow] potiuk commented on issue #24678: Macro prev_execution_date is always empty

2022-06-27 Thread GitBox
potiuk commented on issue #24678: URL: https://github.com/apache/airflow/issues/24678#issuecomment-1168048791 Good idea @uranusjr :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] o-nikolas commented on a diff in pull request #24688: Use older version of node for pre-commit checks

2022-06-27 Thread GitBox
o-nikolas commented on code in PR #24688: URL: https://github.com/apache/airflow/pull/24688#discussion_r90722 ## .pre-commit-config.yaml: ## @@ -19,6 +19,7 @@ default_stages: [commit, push] default_language_version: # force all unspecified python hooks to run python3

[GitHub] [airflow] potiuk commented on pull request #23971: Unify DbApiHook.run() method with the methods which override it

2022-06-27 Thread GitBox
potiuk commented on PR #23971: URL: https://github.com/apache/airflow/pull/23971#issuecomment-1168045347 > @potiuk Unfortunately, this PR took a lot of time and I just want to remind you that it was inspired while I worked on #23767 (#23812, #23815, #23816). > > I see that changes

[GitHub] [airflow] o-nikolas commented on pull request #23402: Introduce sla_miss metric

2022-06-27 Thread GitBox
o-nikolas commented on PR #23402: URL: https://github.com/apache/airflow/pull/23402#issuecomment-1168039931 Just looking through open PRs I've reviewed. Is there any development waiting for this one @Jorricks? Or is it just awaiting a review from a committer? -- This is an automated

[GitHub] [airflow] dstandish commented on a diff in pull request #24673: Rename 'resources' arg in Kub op to k8s_resources

2022-06-27 Thread GitBox
dstandish commented on code in PR #24673: URL: https://github.com/apache/airflow/pull/24673#discussion_r907883591 ## airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py: ## @@ -112,7 +112,7 @@ class KubernetesPodOperator(BaseOperator): :param annotations:

[GitHub] [airflow] zbentzinger commented on issue #24690: sql_alchemy_conn environment variable raises airflow.exceptions.AirflowConfigException

2022-06-27 Thread GitBox
zbentzinger commented on issue #24690: URL: https://github.com/apache/airflow/issues/24690#issuecomment-1168016901 Confirmed, this fixed my issue - thank you! I forgot that on airflow's first run it generates webserver_config.py. Removed that file and it regenerated on next run and issue

[GitHub] [airflow] zbentzinger closed issue #24690: sql_alchemy_conn environment variable raises airflow.exceptions.AirflowConfigException

2022-06-27 Thread GitBox
zbentzinger closed issue #24690: sql_alchemy_conn environment variable raises airflow.exceptions.AirflowConfigException URL: https://github.com/apache/airflow/issues/24690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[airflow] branch main updated: keep Log scrolling only to nearest div (#24689)

2022-06-27 Thread bbovenzi
This is an automated email from the ASF dual-hosted git repository. bbovenzi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 48ceda22bd keep Log scrolling only to nearest

[GitHub] [airflow] bbovenzi merged pull request #24689: Keep grid log scrolling limited to its wrapper div

2022-06-27 Thread GitBox
bbovenzi merged PR #24689: URL: https://github.com/apache/airflow/pull/24689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] Taragolis commented on issue #24690: sql_alchemy_conn environment variable raises airflow.exceptions.AirflowConfigException

2022-06-27 Thread GitBox
Taragolis commented on issue #24690: URL: https://github.com/apache/airflow/issues/24690#issuecomment-1168006653 ``` # Copy over our Airflow DAGs and config COPY --chown=airflow:root ./wait-for-it.sh /usr/local/bin COPY --chown=airflow:root ./airflow /opt/airflow/ ``` ```

[GitHub] [airflow] github-actions[bot] commented on pull request #24689: Keep grid log scrolling limited to its wrapper div

2022-06-27 Thread GitBox
github-actions[bot] commented on PR #24689: URL: https://github.com/apache/airflow/pull/24689#issuecomment-1167988237 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the

[GitHub] [airflow] zbentzinger opened a new issue, #24690: sql_alchemy_conn environment variable raises airflow.exceptions.AirflowConfigException

2022-06-27 Thread GitBox
zbentzinger opened a new issue, #24690: URL: https://github.com/apache/airflow/issues/24690 ### Apache Airflow version 2.3.2 (latest released) ### What happened When configuration of database.sql_alchemy_conn value is set via environment variable

[GitHub] [airflow] boring-cyborg[bot] commented on issue #24690: sql_alchemy_conn environment variable raises airflow.exceptions.AirflowConfigException

2022-06-27 Thread GitBox
boring-cyborg[bot] commented on issue #24690: URL: https://github.com/apache/airflow/issues/24690#issuecomment-1167981064 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] ankurbajaj9 commented on pull request #24550: `WebHDFSHook` Bugfix/optional port

2022-06-27 Thread GitBox
ankurbajaj9 commented on PR #24550: URL: https://github.com/apache/airflow/pull/24550#issuecomment-1167966742 Thanks for the run , I have fixed all the issues that I could find. Please enable the workflows awaiting approval once again to check if everything is working fine -- This is an

[GitHub] [airflow] bbovenzi commented on pull request #24689: Keep grid log scrolling limited to its wrapper div

2022-06-27 Thread GitBox
bbovenzi commented on PR #24689: URL: https://github.com/apache/airflow/pull/24689#issuecomment-1167959753 CC @pierrejeambrun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] bbovenzi opened a new pull request, #24689: Keep grid log scrolling limited to its wrapper div

2022-06-27 Thread GitBox
bbovenzi opened a new pull request, #24689: URL: https://github.com/apache/airflow/pull/24689 When navigating around the grid view logs, the page would jump around when going to a new log that needed to auto-scroll to the bottom. Use `block` and `inline` arguments of

[GitHub] [airflow] argibbs commented on issue #23361: Scheduler crashes with psycopg2.errors.DeadlockDetected exception

2022-06-27 Thread GitBox
argibbs commented on issue #23361: URL: https://github.com/apache/airflow/issues/23361#issuecomment-1167956364 N.B. I've tried shutting down all-but-one schedulers, and that also fixes it. 2 schedulers running: delete fails, as per above. 1 scheduler running, delete works. Is

[airflow] branch main updated (02d8f96bfb -> 2fb93f88b1)

2022-06-27 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 02d8f96bfb Pass worker annotations to generated pod_template_file (#24647) add 2fb93f88b1 Updated

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #24573: Updated Snowflake provider connection documentation

2022-06-27 Thread GitBox
boring-cyborg[bot] commented on PR #24573: URL: https://github.com/apache/airflow/pull/24573#issuecomment-1167954528 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] mik-laj merged pull request #24573: Updated Snowflake provider connection documentation

2022-06-27 Thread GitBox
mik-laj merged PR #24573: URL: https://github.com/apache/airflow/pull/24573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] mik-laj closed issue #24572: Snowflake Provider connection documentation is misleading

2022-06-27 Thread GitBox
mik-laj closed issue #24572: Snowflake Provider connection documentation is misleading URL: https://github.com/apache/airflow/issues/24572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] jedcunningham commented on pull request #24647: Pass worker annotations to generated pod_template_file

2022-06-27 Thread GitBox
jedcunningham commented on PR #24647: URL: https://github.com/apache/airflow/pull/24647#issuecomment-1167954168 Thanks @gmsantos! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[airflow] branch main updated (dee5ba3a51 -> 02d8f96bfb)

2022-06-27 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from dee5ba3a51 Add dataset model (#24613) add 02d8f96bfb Pass worker annotations to generated

[GitHub] [airflow] jedcunningham merged pull request #24647: Pass worker annotations to generated pod_template_file

2022-06-27 Thread GitBox
jedcunningham merged PR #24647: URL: https://github.com/apache/airflow/pull/24647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #24685: Remove commented out code

2022-06-27 Thread GitBox
github-actions[bot] commented on PR #24685: URL: https://github.com/apache/airflow/pull/24685#issuecomment-1167939226 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #24688: Use older version of node for pre-commit checks

2022-06-27 Thread GitBox
boring-cyborg[bot] commented on PR #24688: URL: https://github.com/apache/airflow/pull/24688#issuecomment-1167936550 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[GitHub] [airflow] kevgeo opened a new pull request, #24688: Use older version of node for pre-commit checks

2022-06-27 Thread GitBox
kevgeo opened a new pull request, #24688: URL: https://github.com/apache/airflow/pull/24688 This PR is for airflow to use an older version of node.js when running the pre-commit checks as newer version of node may cause [glibc issues](https://github.com/nodejs/node/issues/42351) on older

[GitHub] [airflow] jedcunningham commented on a diff in pull request #24476: Add Core SQL Provider

2022-06-27 Thread GitBox
jedcunningham commented on code in PR #24476: URL: https://github.com/apache/airflow/pull/24476#discussion_r907820703 ## airflow/providers/core/__init__.py: ## @@ -0,0 +1,16 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: Maybe "common"

[GitHub] [airflow] jedcunningham commented on a diff in pull request #24673: Rename 'resources' arg in Kub op to k8s_resources

2022-06-27 Thread GitBox
jedcunningham commented on code in PR #24673: URL: https://github.com/apache/airflow/pull/24673#discussion_r907810626 ## airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py: ## @@ -112,7 +112,7 @@ class KubernetesPodOperator(BaseOperator): :param annotations:

[GitHub] [airflow] pierrejeambrun commented on pull request #24623: Grid task log, multi select and ts files migration.

2022-06-27 Thread GitBox
pierrejeambrun commented on PR #24623: URL: https://github.com/apache/airflow/pull/24623#issuecomment-1167915648 > https://user-images.githubusercontent.com/4600967/176036792-e39d8bde-b099-4faf-be2d-5fd444ee18af.png;> > > The font colors aren't matching. > > Don't we want the

[GitHub] [airflow] bbovenzi commented on pull request #24623: Grid task log, multi select and ts files migration.

2022-06-27 Thread GitBox
bbovenzi commented on PR #24623: URL: https://github.com/apache/airflow/pull/24623#issuecomment-1167913982 https://user-images.githubusercontent.com/4600967/176036792-e39d8bde-b099-4faf-be2d-5fd444ee18af.png;> The font colors aren't matching. Don't we want the multi-select for

[GitHub] [airflow] rcwoolston opened a new issue, #24687: Scheduler gets permission error when running os.stat on dag file

2022-06-27 Thread GitBox
rcwoolston opened a new issue, #24687: URL: https://github.com/apache/airflow/issues/24687 ### Apache Airflow version 2.3.2 (latest released) ### What happened Scheduler is getting a PermissionError when running the file process error with the following stack trace

[GitHub] [airflow] boring-cyborg[bot] commented on issue #24687: Scheduler gets permission error when running os.stat on dag file

2022-06-27 Thread GitBox
boring-cyborg[bot] commented on issue #24687: URL: https://github.com/apache/airflow/issues/24687#issuecomment-1167901744 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] bbovenzi commented on a diff in pull request #24684: Fix Grid vertical scrolling

2022-06-27 Thread GitBox
bbovenzi commented on code in PR #24684: URL: https://github.com/apache/airflow/pull/24684#discussion_r907798759 ## airflow/www/static/js/grid/dagRuns/index.tsx: ## @@ -54,58 +63,45 @@ const DagRuns = () => { // calculate dag run bar heights relative to max const max =

[GitHub] [airflow] dstandish commented on a diff in pull request #24673: Rename 'resources' arg in Kub op to k8s_resources

2022-06-27 Thread GitBox
dstandish commented on code in PR #24673: URL: https://github.com/apache/airflow/pull/24673#discussion_r907795836 ## airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py: ## @@ -112,7 +112,7 @@ class KubernetesPodOperator(BaseOperator): :param annotations:

[GitHub] [airflow] dstandish commented on a diff in pull request #24673: Rename 'resources' arg in Kub op to k8s_resources

2022-06-27 Thread GitBox
dstandish commented on code in PR #24673: URL: https://github.com/apache/airflow/pull/24673#discussion_r907795836 ## airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py: ## @@ -112,7 +112,7 @@ class KubernetesPodOperator(BaseOperator): :param annotations:

[GitHub] [airflow] dstandish commented on a diff in pull request #24673: Rename 'resources' arg in Kub op to k8s_resources

2022-06-27 Thread GitBox
dstandish commented on code in PR #24673: URL: https://github.com/apache/airflow/pull/24673#discussion_r907794917 ## airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py: ## @@ -112,7 +112,7 @@ class KubernetesPodOperator(BaseOperator): :param annotations:

[GitHub] [airflow] mik-laj commented on a diff in pull request #24672: Move provider dependencies to inside provider folders

2022-06-27 Thread GitBox
mik-laj commented on code in PR #24672: URL: https://github.com/apache/airflow/pull/24672#discussion_r907790016 ## airflow/provider.yaml.schema.json: ## @@ -231,8 +234,26 @@ } }, "additional-extras": { - "type": "object", - "description": "Additional

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #24623: Grid task log, multi select and ts files migration.

2022-06-27 Thread GitBox
pierrejeambrun commented on code in PR #24623: URL: https://github.com/apache/airflow/pull/24623#discussion_r907784898 ## airflow/www/static/js/grid/api/useTaskLog.tsx: ## @@ -17,23 +17,31 @@ * under the License. */ -import axios from 'axios'; +import axios, {

[airflow] branch main updated: Add dataset model (#24613)

2022-06-27 Thread dstandish
This is an automated email from the ASF dual-hosted git repository. dstandish pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new dee5ba3a51 Add dataset model (#24613)

[GitHub] [airflow] dstandish merged pull request #24613: Add dataset model

2022-06-27 Thread GitBox
dstandish merged PR #24613: URL: https://github.com/apache/airflow/pull/24613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] kaxil closed issue #23874: Add Templated SQL Check Operators for Columns and Tables

2022-06-27 Thread GitBox
kaxil closed issue #23874: Add Templated SQL Check Operators for Columns and Tables URL: https://github.com/apache/airflow/issues/23874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] kaxil merged pull request #24476: Add Core SQL Provider

2022-06-27 Thread GitBox
kaxil merged PR #24476: URL: https://github.com/apache/airflow/pull/24476 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] kaxil commented on a diff in pull request #24476: Add Core SQL Provider

2022-06-27 Thread GitBox
kaxil commented on code in PR #24476: URL: https://github.com/apache/airflow/pull/24476#discussion_r907767029 ## airflow/providers/core/__init__.py: ## @@ -0,0 +1,16 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: I am not a fan of

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #24684: Fix Grid vertical scrolling

2022-06-27 Thread GitBox
pierrejeambrun commented on code in PR #24684: URL: https://github.com/apache/airflow/pull/24684#discussion_r907766849 ## airflow/www/static/js/grid/dagRuns/index.tsx: ## @@ -54,58 +63,45 @@ const DagRuns = () => { // calculate dag run bar heights relative to max const

[GitHub] [airflow] dstandish commented on pull request #24613: Add dataset model

2022-06-27 Thread GitBox
dstandish commented on PR #24613: URL: https://github.com/apache/airflow/pull/24613#issuecomment-1167846054 Alright time to put this one out of it's misery -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] Taragolis opened a new pull request, #24685: Remove commented out code

2022-06-27 Thread GitBox
Taragolis opened a new pull request, #24685: URL: https://github.com/apache/airflow/pull/24685 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more

[GitHub] [airflow] savingoyal commented on a diff in pull request #24673: Rename 'resources' arg in Kub op to k8s_resources

2022-06-27 Thread GitBox
savingoyal commented on code in PR #24673: URL: https://github.com/apache/airflow/pull/24673#discussion_r907761806 ## airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py: ## @@ -112,7 +112,7 @@ class KubernetesPodOperator(BaseOperator): :param annotations:

[GitHub] [airflow-site] TohnJhomas opened a new pull request, #618: Publish Airflow Survey 2022 Blog Post

2022-06-27 Thread GitBox
TohnJhomas opened a new pull request, #618: URL: https://github.com/apache/airflow-site/pull/618 This adds the blog post originally drafted and reviewed here: [Google Doc](https://docs.google.com/document/d/18E3gBbrPI6cHAKRkRIPfju9pOk4EJNd2M-1fRJO4glA/edit#heading=h.nl3vp7d4qcal)

[GitHub] [airflow] eladkal commented on a diff in pull request #24673: Rename 'resources' arg in Kub op to k8s_resources

2022-06-27 Thread GitBox
eladkal commented on code in PR #24673: URL: https://github.com/apache/airflow/pull/24673#discussion_r907739432 ## airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py: ## @@ -112,7 +112,7 @@ class KubernetesPodOperator(BaseOperator): :param annotations:

[GitHub] [airflow] dstandish commented on a diff in pull request #24613: Add dataset model

2022-06-27 Thread GitBox
dstandish commented on code in PR #24613: URL: https://github.com/apache/airflow/pull/24613#discussion_r907736797 ## airflow/migrations/versions/0114_2_4_0_add_dataset_model.py: ## @@ -0,0 +1,69 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] dstandish commented on pull request #24673: Rename 'resources' arg in Kub op to k8s_resources

2022-06-27 Thread GitBox
dstandish commented on PR #24673: URL: https://github.com/apache/airflow/pull/24673#issuecomment-1167800469 wow i had no clue we had this thing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] Taragolis commented on a diff in pull request #24670: Update AWS Connection docs and deprecate some extras

2022-06-27 Thread GitBox
Taragolis commented on code in PR #24670: URL: https://github.com/apache/airflow/pull/24670#discussion_r907726445 ## docs/apache-airflow-providers-amazon/connections/aws.rst: ## @@ -51,33 +51,51 @@ Configuring the Connection Login (optional) Specify the AWS access key

[GitHub] [airflow] dstandish commented on a diff in pull request #24613: Add dataset model

2022-06-27 Thread GitBox
dstandish commented on code in PR #24613: URL: https://github.com/apache/airflow/pull/24613#discussion_r907726158 ## airflow/migrations/versions/0114_2_4_0_add_dataset_model.py: ## @@ -0,0 +1,69 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] bbovenzi opened a new pull request, #24684: Fix Grid vertical scrolling

2022-06-27 Thread GitBox
bbovenzi opened a new pull request, #24684: URL: https://github.com/apache/airflow/pull/24684 We had 2 issues with grid scrolling for large DAGs: 1. Grid actions (expand groups, close details panel, auto refresh) would get cut off or overlap with the grid 2. Sticky positioning

[GitHub] [airflow] jedcunningham commented on pull request #24658: Add `airflow_kpo_in_cluster` label to KPO pods

2022-06-27 Thread GitBox
jedcunningham commented on PR #24658: URL: https://github.com/apache/airflow/pull/24658#issuecomment-1167778902 Actually, thinking a little more, it's not terribly hard to get the TI/task from the existing labels on the pod. I wonder if anyone is already doing that now. It could be worth

[GitHub] [airflow] Taragolis commented on a diff in pull request #24670: Update AWS Connection docs and deprecate some extras

2022-06-27 Thread GitBox
Taragolis commented on code in PR #24670: URL: https://github.com/apache/airflow/pull/24670#discussion_r907714338 ## docs/apache-airflow-providers-amazon/connections/aws.rst: ## @@ -51,33 +51,51 @@ Configuring the Connection Login (optional) Specify the AWS access key

[GitHub] [airflow] Taragolis commented on a diff in pull request #24670: Update AWS Connection docs and deprecate some extras

2022-06-27 Thread GitBox
Taragolis commented on code in PR #24670: URL: https://github.com/apache/airflow/pull/24670#discussion_r907708432 ## airflow/providers/amazon/aws/hooks/base_aws.py: ## @@ -83,6 +83,15 @@ def create_session(self) -> boto3.session.Session:

[GitHub] [airflow] jedcunningham commented on pull request #24658: Add `airflow_kpo_in_cluster` label to KPO pods

2022-06-27 Thread GitBox
jedcunningham commented on PR #24658: URL: https://github.com/apache/airflow/pull/24658#issuecomment-1167763772 @ianbuss, I'd be more inclined to also send the task to the `pod_mutation_hook`, and it could be done in a backwards compatible way I believe. That said, I think this

[GitHub] [airflow] tanelk commented on pull request #23929: Clear next method when clearing TIs

2022-06-27 Thread GitBox
tanelk commented on PR #23929: URL: https://github.com/apache/airflow/pull/23929#issuecomment-1167763228 @uranusjr could this approved PR get merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

  1   2   3   >