[GitHub] [airflow] uranusjr commented on pull request #25780: Implement PythonPreexistingVirtualenvOperator

uranusjr commented on PR #25780: URL: https://github.com/apache/airflow/pull/25780#issuecomment-1221461338 The problem with `PythonPreexistingVirtualenvOperator` is it ideologically misleads the user to think it can only reference a virtual environment, while functionally it can work

[GitHub] [airflow] uranusjr commented on a diff in pull request #25845: Update code examples from "classic" operators to taskflow

uranusjr commented on code in PR #25845: URL: https://github.com/apache/airflow/pull/25845#discussion_r950781600 ## docs/apache-airflow/howto/operator/python.rst: ## @@ -22,8 +22,11 @@ PythonOperator == -Use the :class:`~airflow.operators.python.PythonOperator`

[GitHub] [airflow] eladkal commented on pull request #23971: Unify DbApiHook.run() method with the methods which override it

eladkal commented on PR #23971: URL: https://github.com/apache/airflow/pull/23971#issuecomment-1221459638 > Why would we care if it is a select query or PL/SQL? Because PL/SQL has complex multipule statments that can not be splitted. I also think we adressed this already?

[GitHub] [airflow] hewerthomn commented on pull request #23971: Unify DbApiHook.run() method with the methods which override it

hewerthomn commented on PR #23971: URL: https://github.com/apache/airflow/pull/23971#issuecomment-1221442418 I use sql="DECLARE ..." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] github-actions[bot] closed issue #13543: kubernetes refresh config strptime format results in error logs

github-actions[bot] closed issue #13543: kubernetes refresh config strptime format results in error logs URL: https://github.com/apache/airflow/issues/13543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] github-actions[bot] commented on issue #13543: kubernetes refresh config strptime format results in error logs

github-actions[bot] commented on issue #13543: URL: https://github.com/apache/airflow/issues/13543#issuecomment-1221434379 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] github-actions[bot] commented on pull request #23660: Add templates and constructor parameters to list-integrations

github-actions[bot] commented on PR #23660: URL: https://github.com/apache/airflow/pull/23660#issuecomment-1221434347 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

[GitHub] [airflow] github-actions[bot] commented on pull request #23560: Add advanced secrets backend configurations

github-actions[bot] commented on PR #23560: URL: https://github.com/apache/airflow/pull/23560#issuecomment-1221434358 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

[GitHub] [airflow] github-actions[bot] commented on pull request #23628: Fixes SageMaker operator return values

github-actions[bot] commented on PR #23628: URL: https://github.com/apache/airflow/pull/23628#issuecomment-1221434356 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

[GitHub] [airflow] potiuk commented on a diff in pull request #25780: Implement PythonPreexistingVirtualenvOperator

potiuk commented on code in PR #25780: URL: https://github.com/apache/airflow/pull/25780#discussion_r950763784 ## airflow/providers/docker/decorators/docker.py: ## @@ -27,7 +27,8 @@ from airflow.decorators.base import DecoratedOperator, task_decorator_factory from

[GitHub] [airflow] hewerthomn commented on pull request #23971: Unify DbApiHook.run() method with the methods which override it

hewerthomn commented on PR #23971: URL: https://github.com/apache/airflow/pull/23971#issuecomment-1221422681 @kazanzhy yes, I can post the issue. I was using OracleOperator -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] kazanzhy commented on pull request #23971: Unify DbApiHook.run() method with the methods which override it

kazanzhy commented on PR #23971: URL: https://github.com/apache/airflow/pull/23971#issuecomment-1221422349 @hewerthomn can you please create a separate issue and publish the query that worked before? I was sure that it was because of `;`. Also, please describe what operator are you

[GitHub] [airflow] potiuk commented on pull request #23971: Unify DbApiHook.run() method with the methods which override it

potiuk commented on PR #23971: URL: https://github.com/apache/airflow/pull/23971#issuecomment-1221415022 I think this is a bug really @eladkal @kazanzhy - especially if it worked before. I don't think we have any limitation and whether we care if the statement we send is SQL or

[GitHub] [airflow] mik-laj merged pull request #25782: Support project_id argument in BigQueryGetDataOperator

mik-laj merged PR #25782: URL: https://github.com/apache/airflow/pull/25782 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (98a7701942 -> fc6dfa338a)

This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 98a7701942 Workaround setuptools editable packages path issue (#25848) add fc6dfa338a Support project_id

[GitHub] [airflow] mik-laj closed issue #25781: BigQueryGetDataOperator does not support passing project_id

mik-laj closed issue #25781: BigQueryGetDataOperator does not support passing project_id URL: https://github.com/apache/airflow/issues/25781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] hewerthomn commented on pull request #23971: Unify DbApiHook.run() method with the methods which override it

hewerthomn commented on PR #23971: URL: https://github.com/apache/airflow/pull/23971#issuecomment-1221408130 I see... So it will stop working with pl/SQL now? If I need to write procedures for all my operators I will use previous version of package instead for a while

[GitHub] [airflow] DMilmont opened a new pull request, #25850: pretty print KubernetesPodOperator rendered template env_vars

DMilmont opened a new pull request, #25850: URL: https://github.com/apache/airflow/pull/25850 closes: #24197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #25850: pretty print KubernetesPodOperator rendered template env_vars

boring-cyborg[bot] commented on PR #25850: URL: https://github.com/apache/airflow/pull/25850#issuecomment-1221407250 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[GitHub] [airflow] DMilmont commented on issue #24197: KubernetesPodOperator rendered template tab does not pretty print `env_vars`

DMilmont commented on issue #24197: URL: https://github.com/apache/airflow/issues/24197#issuecomment-1221389907 I will make a PR for this! Feel free to assign. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] eladkal commented on pull request #23971: Unify DbApiHook.run() method with the methods which override it

eladkal commented on PR #23971: URL: https://github.com/apache/airflow/pull/23971#issuecomment-1221389283 This looks like a PL/SQL not SQL. I dont think it was ever intended to work with SqlOperator of any kind. When we talked about the unified solution I didnt consider PG/PL SQL (or

[GitHub] [airflow] hewerthomn commented on pull request #23971: Unify DbApiHook.run() method with the methods which override it

hewerthomn commented on PR #23971: URL: https://github.com/apache/airflow/pull/23971#issuecomment-1221387418 Hi @potiuk and @kazanzhy , I added the package apache-airflow-providers-common-sql==1.1.0, but same errors continue,

[GitHub] [airflow] potiuk commented on pull request #25780: Implement PythonPreexistingVirtualenvOperator

potiuk commented on PR #25780: URL: https://github.com/apache/airflow/pull/25780#issuecomment-1221384721 I think this one is ready for review: * tests should be passing now * system Test is working (and uses external venv) * documentation is updated (howtos) * I even added

[GitHub] [airflow] potiuk commented on pull request #23971: Unify DbApiHook.run() method with the methods which override it

potiuk commented on PR #23971: URL: https://github.com/apache/airflow/pull/23971#issuecomment-1221382767 > Hi @hewerthomn. Sorry for the inconvenience. Unfortunately, some bugs were added by this PR. I think in your case it is fixed by #25713 PR @hewerthomn - can you install

[GitHub] [airflow] kazanzhy commented on pull request #23971: Unify DbApiHook.run() method with the methods which override it

kazanzhy commented on PR #23971: URL: https://github.com/apache/airflow/pull/23971#issuecomment-1221380874 @KarthikRajashekaran it's correct. By this PR we added the ability to `split_statements` when you're using the hook. Currently, I'm working on making it possible for the

[GitHub] [airflow] kazanzhy commented on pull request #23971: Unify DbApiHook.run() method with the methods which override it

kazanzhy commented on PR #23971: URL: https://github.com/apache/airflow/pull/23971#issuecomment-1221379735 Hi @hewerthomn. Sorry for the inconvenience. Unfortunately, some bugs were added by this PR. I think in your case it might be fixed by https://github.com/apache/airflow/pull/25713

[GitHub] [airflow] consciencee commented on issue #25846: Status of testing of Apache Airflow 2.3.4rc1

consciencee commented on issue #25846: URL: https://github.com/apache/airflow/issues/25846#issuecomment-1221378631 #24676 working as expected, no any serialization issues anymore -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] rino0601 commented on issue #25846: Status of testing of Apache Airflow 2.3.4rc1

rino0601 commented on issue #25846: URL: https://github.com/apache/airflow/issues/25846#issuecomment-1221354024 #25296 working as expected  2.3.4rc1 able to import Plugins as Python packages #24811 working as expected  2.3.4rc1 use ISO 8601 format in task log -- This is an

[GitHub] [airflow] Jorricks commented on issue #25846: Status of testing of Apache Airflow 2.3.4rc1

Jorricks commented on issue #25846: URL: https://github.com/apache/airflow/issues/25846#issuecomment-1221335907 All good: #25347 - Logging message is no longer excessively present when you remove a task. Op za 20 aug. 2022 om

[GitHub] [airflow] V0lantis commented on a diff in pull request #24999: [FIX] Scheduler crashloopbackoff when using `hostname_callable`

V0lantis commented on code in PR #24999: URL: https://github.com/apache/airflow/pull/24999#discussion_r950707866 ## chart/templates/_helpers.yaml: ## @@ -638,7 +638,7 @@ Create the name of the cleanup service account to use - -c - | CONNECTION_CHECK_MAX_COUNT=0

[GitHub] [airflow] potiuk commented on a diff in pull request #25780: Implement ExternalPythonOperator

potiuk commented on code in PR #25780: URL: https://github.com/apache/airflow/pull/25780#discussion_r950703457 ## airflow/example_dags/example_python_operator.py: ## @@ -93,3 +93,28 @@ def callable_virtualenv(): virtualenv_task = callable_virtualenv() # [END

[GitHub] [airflow] potiuk commented on a diff in pull request #25780: Implement ExternalPythonOperator

potiuk commented on code in PR #25780: URL: https://github.com/apache/airflow/pull/25780#discussion_r950703427 ## airflow/example_dags/example_python_operator.py: ## @@ -93,3 +93,28 @@ def callable_virtualenv(): virtualenv_task = callable_virtualenv() # [END

[GitHub] [airflow] potiuk commented on pull request #25780: Implement ExternalPythonOperator

potiuk commented on PR #25780: URL: https://github.com/apache/airflow/pull/25780#issuecomment-1221325050 I like the `PythonPreexistingVirtualenvOperator` name best -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] potiuk commented on issue #25846: Status of testing of Apache Airflow 2.3.4rc1

potiuk commented on issue #25846: URL: https://github.com/apache/airflow/issues/25846#issuecomment-1221323018 All good: #24982 - correct limits #25169 - assets are properly compiled in the package #25511 - flask correctly limited #25584 - irrelevant -- This is an

[airflow] branch constraints-main updated: Updating constraints. Build id:2894803251

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 22b0cec4af Updating

[GitHub] [airflow] pierrejeambrun commented on issue #25846: Status of testing of Apache Airflow 2.3.4rc1

pierrejeambrun commented on issue #25846: URL: https://github.com/apache/airflow/issues/25846#issuecomment-1221317435 https://github.com/apache/airflow/pull/25554 working as expected :+1: https://github.com/apache/airflow/pull/25097 not much to test on this one. -- This is an

[GitHub] [airflow] tomsej commented on issue #25846: Status of testing of Apache Airflow 2.3.4rc1

tomsej commented on issue #25846: URL: https://github.com/apache/airflow/issues/25846#issuecomment-1221317222 https://github.com/apache/airflow/pull/25689 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] potiuk closed issue #25843: Each scheduler may process same zombie tasks in HA mode

potiuk closed issue #25843: Each scheduler may process same zombie tasks in HA mode URL: https://github.com/apache/airflow/issues/25843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] potiuk commented on issue #25843: Each scheduler may process same zombie tasks in HA mode

potiuk commented on issue #25843: URL: https://github.com/apache/airflow/issues/25843#issuecomment-1221316207 Yep. This is fixed in #24906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] Taragolis commented on issue #25846: Status of testing of Apache Airflow 2.3.4rc1

Taragolis commented on issue #25846: URL: https://github.com/apache/airflow/issues/25846#issuecomment-1221313950 https://github.com/apache/airflow/pull/25764 Check on AWS S3 and AWS Cloudwatch handlers no warnings anymore -- This is an automated message from the Apache Git Service. To

[airflow] branch main updated (cdbad44932 -> 98a7701942)

This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from cdbad44932 Filter out non-editable apache-airflow from constraints. (#25847) add 98a7701942 Workaround

[GitHub] [airflow] potiuk merged pull request #25848: Workaround setuptools editable packages path issue

potiuk merged PR #25848: URL: https://github.com/apache/airflow/pull/25848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk opened a new pull request, #25848: Workaround setuptools editable packages path issue

potiuk opened a new pull request, #25848: URL: https://github.com/apache/airflow/pull/25848 Setuptools 64.0.0 introduced change that broke paths of editable cli packages. This change makes CLIs installed via editable packages to miss paths required to import code from the editable

[airflow] branch v2-3-test updated: Filter out non-editable apache-airflow from constraints. (#25847)

This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v2-3-test in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/v2-3-test by this push: new a927c772a1 Filter out non-editable

[airflow] branch main updated (a5be64ad30 -> cdbad44932)

This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from a5be64ad30 Fix broken link to Trigger Rules (#25840) add cdbad44932 Filter out non-editable apache-airflow from

[GitHub] [airflow] potiuk merged pull request #25847: Filter out non-editable apache-airflow from constraints.

potiuk merged PR #25847: URL: https://github.com/apache/airflow/pull/25847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk opened a new pull request, #25847: Filter out non-editable apache-airflow from constraints.

potiuk opened a new pull request, #25847: URL: https://github.com/apache/airflow/pull/25847 The constraint files should not contain apache-airflow. So far apache-airflow has been automatically filtered out by the fact that it has been an editable installation and we filtered out all

[GitHub] [airflow] Taragolis commented on pull request #25835: Use the extra_args in get_key()

Taragolis commented on PR #25835: URL: https://github.com/apache/airflow/pull/25835#issuecomment-1221299612 BTW, I'm the person who add ExtraArgs to `S3Hook.download_file` method and give to users false hope that it would work  -- This is an automated message from the Apache Git

[GitHub] [airflow] vinitpayal commented on pull request #25622: Google Cloud Tasks Sensor for queue being empty

vinitpayal commented on PR #25622: URL: https://github.com/apache/airflow/pull/25622#issuecomment-1221297600 Thanks @pankajastro, suggestions well noted and applied. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] Taragolis commented on a diff in pull request #25835: Use the extra_args in get_key()

Taragolis commented on code in PR #25835: URL: https://github.com/apache/airflow/pull/25835#discussion_r950684114 ## airflow/providers/amazon/aws/hooks/s3.py: ## @@ -469,7 +469,7 @@ def get_key(self, key: str, bucket_name: Optional[str] = None) -> S3Transfer:

[GitHub] [airflow] Taragolis commented on a diff in pull request #25835: Use the extra_args in get_key()

Taragolis commented on code in PR #25835: URL: https://github.com/apache/airflow/pull/25835#discussion_r950684114 ## airflow/providers/amazon/aws/hooks/s3.py: ## @@ -469,7 +469,7 @@ def get_key(self, key: str, bucket_name: Optional[str] = None) -> S3Transfer:

[GitHub] [airflow] eladkal commented on issue #25843: Each scheduler may process same zombie tasks in HA mode

eladkal commented on issue #25843: URL: https://github.com/apache/airflow/issues/25843#issuecomment-1221296141 Can you try 2.3.4RC1? https://github.com/apache/airflow/pull/24906 probably fixed it? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] Taragolis commented on a diff in pull request #25835: Use the extra_args in get_key()

Taragolis commented on code in PR #25835: URL: https://github.com/apache/airflow/pull/25835#discussion_r950684114 ## airflow/providers/amazon/aws/hooks/s3.py: ## @@ -469,7 +469,7 @@ def get_key(self, key: str, bucket_name: Optional[str] = None) -> S3Transfer:

[airflow-site] branch gh-pages updated: Deploying to gh-pages from @ 9dbd2bde5665892e023265823ba60d30a9cd5041 

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch gh-pages in repository https://gitbox.apache.org/repos/asf/airflow-site.git The following commit(s) were added to refs/heads/gh-pages by this push: new 2fda33bf42 Deploying to gh-pages

[GitHub] [airflow-site] potiuk commented on pull request #649: Add missing comma

potiuk commented on PR #649: URL: https://github.com/apache/airflow-site/pull/649#issuecomment-1221293879 Wow ! :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[airflow-site] branch main updated: Add missing comma (#649)

This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow-site.git The following commit(s) were added to refs/heads/main by this push: new 9dbd2bde56 Add missing comma (#649)

[GitHub] [airflow-site] potiuk merged pull request #649: Add missing comma

potiuk merged PR #649: URL: https://github.com/apache/airflow-site/pull/649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] ephraimbuddy opened a new issue, #25846: Status of testing of Apache Airflow 2.3.4rc1

ephraimbuddy opened a new issue, #25846: URL: https://github.com/apache/airflow/issues/25846 ### Body We have a kind request for all the contributors to the latest [Apache Airflow RC 2.3.4rc1](https://pypi.org/project/apache-airflow/2.3.4rc1/). Could you please help us to test

[GitHub] [airflow] Hasan-J commented on pull request #25251: Make codespace run successfully

Hasan-J commented on PR #25251: URL: https://github.com/apache/airflow/pull/25251#issuecomment-1221292842 ops, I deleted by mistake XD -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] Hasan-J opened a new pull request, #25251: Make codespace run successfully

Hasan-J opened a new pull request, #25251: URL: https://github.com/apache/airflow/pull/25251 Trying to make codespaces work. I faced 2 issues with that, fixed by the first 2 commits respectively. The issue with `local.yml` compose file was that it kept failing the build

[GitHub] [airflow] Hasan-J closed pull request #25251: Make codespace run successfully

Hasan-J closed pull request #25251: Make codespace run successfully URL: https://github.com/apache/airflow/pull/25251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] Taragolis commented on pull request #25835: Use the extra_args in get_key()

Taragolis commented on PR #25835: URL: https://github.com/apache/airflow/pull/25835#issuecomment-1221280477 I thought this issue https://github.com/apache/airflow/issues/25833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[airflow] annotated tag 2.3.4rc1 updated (88b274c95b -> 3a67d58801)

This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to annotated tag 2.3.4rc1 in repository https://gitbox.apache.org/repos/asf/airflow.git *** WARNING: tag 2.3.4rc1 was modified! *** from 88b274c95b (commit) to 3a67d58801 (tag)

[airflow] annotated tag constraints-2.3.4rc1 updated (2edc7d9225 -> 18c024751b)

This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to annotated tag constraints-2.3.4rc1 in repository https://gitbox.apache.org/repos/asf/airflow.git *** WARNING: tag constraints-2.3.4rc1 was modified! *** from 2edc7d9225 (commit) to

[airflow] tag constraints-2.3.4rc1 updated (1b7c58c1c3 -> 2edc7d9225)

This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to tag constraints-2.3.4rc1 in repository https://gitbox.apache.org/repos/asf/airflow.git *** WARNING: tag constraints-2.3.4rc1 was modified! *** from 1b7c58c1c3 (tag) to 2edc7d9225 (commit)

[airflow] branch constraints-2-3 updated: Remove apache-airflow from constraints

This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch constraints-2-3 in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-2-3 by this push: new 2edc7d9225 Remove

[airflow] tag constraints-2-3 created (now f91aa08b98)

This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to tag constraints-2-3 in repository https://gitbox.apache.org/repos/asf/airflow.git at f91aa08b98 (commit) No new revisions were added by this update.

[airflow] annotated tag constraints-2.3.4rc1 updated (c25b126951 -> 1b7c58c1c3)

This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to annotated tag constraints-2.3.4rc1 in repository https://gitbox.apache.org/repos/asf/airflow.git *** WARNING: tag constraints-2.3.4rc1 was modified! *** from c25b126951 (tag) to

[GitHub] [airflow] brki commented on pull request #25710: postgres provider: use non-binary psycopg2

brki commented on PR #25710: URL: https://github.com/apache/airflow/pull/25710#issuecomment-1221268038 OK. Thanks for the explanation! I'll adjust it later. On Sat, 20 Aug 2022, 11:22 Jarek Potiuk ***@***.***> wrote: > ***@***. commented on this pull request. >

[GitHub] [airflow-site] anselboero opened a new pull request, #649: Add missing comma

anselboero opened a new pull request, #649: URL: https://github.com/apache/airflow-site/pull/649 A missing comma didn't allow the Js files to be built. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] potiuk commented on a diff in pull request #25710: postgres provider: use non-binary psycopg2

potiuk commented on code in PR #25710: URL: https://github.com/apache/airflow/pull/25710#discussion_r950673413 ## docs/apache-airflow-providers-postgres/index.rst: ## @@ -65,7 +65,7 @@ Package apache-airflow-providers-postgres `PostgreSQL `__

[GitHub] [airflow] potiuk commented on a diff in pull request #25710: postgres provider: use non-binary psycopg2

potiuk commented on code in PR #25710: URL: https://github.com/apache/airflow/pull/25710#discussion_r950673413 ## docs/apache-airflow-providers-postgres/index.rst: ## @@ -65,7 +65,7 @@ Package apache-airflow-providers-postgres `PostgreSQL `__

[GitHub] [airflow] potiuk commented on pull request #25785: Make GoogleBaseHook credentials functions public

potiuk commented on PR #25785: URL: https://github.com/apache/airflow/pull/25785#issuecomment-1221262681 Btw. I have nothing against moving the method to public. This is even stronger indication 'usr this method as you will', but also 'use it from outside of the class' - this is what the

[airflow] annotated tag constraints-2.3.4rc1 updated (c0889392f2 -> c25b126951)

This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to annotated tag constraints-2.3.4rc1 in repository https://gitbox.apache.org/repos/asf/airflow.git *** WARNING: tag constraints-2.3.4rc1 was modified! *** from c0889392f2 (tag) to

[GitHub] [airflow] brki commented on a diff in pull request #25710: postgres provider: use non-binary psycopg2

brki commented on code in PR #25710: URL: https://github.com/apache/airflow/pull/25710#discussion_r950668374 ## docs/apache-airflow-providers-postgres/index.rst: ## @@ -65,7 +65,7 @@ Package apache-airflow-providers-postgres `PostgreSQL `__

[GitHub] [airflow] brki commented on a diff in pull request #25710: postgres provider: use non-binary psycopg2

brki commented on code in PR #25710: URL: https://github.com/apache/airflow/pull/25710#discussion_r950668374 ## docs/apache-airflow-providers-postgres/index.rst: ## @@ -65,7 +65,7 @@ Package apache-airflow-providers-postgres `PostgreSQL `__

[GitHub] [airflow] brki commented on a diff in pull request #25710: postgres provider: use non-binary psycopg2

brki commented on code in PR #25710: URL: https://github.com/apache/airflow/pull/25710#discussion_r950667836 ## docs/apache-airflow-providers-postgres/index.rst: ## @@ -65,7 +65,7 @@ Package apache-airflow-providers-postgres `PostgreSQL `__

[GitHub] [airflow] feluelle commented on pull request #25785: Make GoogleBaseHook credentials functions public

feluelle commented on PR #25785: URL: https://github.com/apache/airflow/pull/25785#issuecomment-1221256732 I will open a discussion shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

svn commit: r56370 - /dev/airflow/2.3.4rc1/

Author: ephraimanierobi Date: Sat Aug 20 08:14:41 2022 New Revision: 56370 Log: Add artifacts for Airflow 2.3.4rc1 Added: dev/airflow/2.3.4rc1/ dev/airflow/2.3.4rc1/apache-airflow-2.3.4-source.tar.gz (with props) dev/airflow/2.3.4rc1/apache-airflow-2.3.4-source.tar.gz.asc

[airflow] annotated tag constraints-2.3.4rc1 updated (1e47498c0f -> c0889392f2)

This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to annotated tag constraints-2.3.4rc1 in repository https://gitbox.apache.org/repos/asf/airflow.git *** WARNING: tag constraints-2.3.4rc1 was modified! *** from 1e47498c0f (commit) to

[airflow] branch v2-3-stable updated (beaca717c5 -> 88b274c95b)

This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to branch v2-3-stable in repository https://gitbox.apache.org/repos/asf/airflow.git from beaca717c5 Add release notes add 284d25a01e Remove certifi limitations from eager upgrade limits

[GitHub] [airflow] ephraimbuddy merged pull request #25826: Sync v2-3-stable with v2-3-test to release 2.3.4

ephraimbuddy merged PR #25826: URL: https://github.com/apache/airflow/pull/25826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] feluelle commented on pull request #25785: Make GoogleBaseHook credentials functions public

feluelle commented on PR #25785: URL: https://github.com/apache/airflow/pull/25785#issuecomment-1221253655 I totally agree with that breaking changes are not always easy to identify, but in my opinion we are on a much safer side when we define public as being the only user exposed access

[GitHub] [airflow] potiuk commented on pull request #25785: Make GoogleBaseHook credentials functions public

potiuk commented on PR #25785: URL: https://github.com/apache/airflow/pull/25785#issuecomment-1221249711 Wrong image :) but now the right one is there :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] potiuk commented on pull request #25785: Make GoogleBaseHook credentials functions public

potiuk commented on PR #25785: URL: https://github.com/apache/airflow/pull/25785#issuecomment-1221249589 Yeah. i think we should add it. Context matters. A lot. I think we cannot say 'renaming protected class is always breaking' or renaming protected class is always not breaking'.