[airflow] branch main updated (6a1a6f7bef -> a8a67a3f40)

2022-10-25 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 6a1a6f7bef Adds s3_key_prefix to template fields (#27207) add a8a67a3f40 Added environment to templated

[GitHub] [airflow] uranusjr merged pull request #26824: Added environment to templated SSHOperator fields

2022-10-25 Thread GitBox
uranusjr merged PR #26824: URL: https://github.com/apache/airflow/pull/26824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (ced2925fc3 -> 6a1a6f7bef)

2022-10-25 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from ced2925fc3 Add dynamic attr check for ast.unparse method in pre-commit (#27280) add 6a1a6f7bef Adds

[GitHub] [airflow] uranusjr merged pull request #27207: Adds s3_key_prefix to template fields

2022-10-25 Thread GitBox
uranusjr merged PR #27207: URL: https://github.com/apache/airflow/pull/27207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] uranusjr opened a new pull request, #27287: Ignore azure-datalake-store deprecated mod use

2022-10-25 Thread GitBox
uranusjr opened a new pull request, #27287: URL: https://github.com/apache/airflow/pull/27287 This is causing CI failures: https://github.com/apache/airflow/actions/runs/3322283971/jobs/5491167087 Upstream report: https://github.com/Azure/azure-data-lake-store-python/pull/328 --

[GitHub] [airflow] syedahsn opened a new pull request, #27286: System Test for EMR (AIP-47)

2022-10-25 Thread GitBox
syedahsn opened a new pull request, #27286: URL: https://github.com/apache/airflow/pull/27286 System test for EMR, using the template in #24643. `EMRStepSensor` is removed from the system test, and being changed to poke mode only because of hitting throttling limits on the

[airflow] branch main updated (c3940b40f8 -> ced2925fc3)

2022-10-25 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from c3940b40f8 timetable text clarifications (#27283) add ced2925fc3 Add dynamic attr check for ast.unparse method

[GitHub] [airflow] eladkal merged pull request #27280: Add dynamic attr check for ast.unparse method in pre-commit

2022-10-25 Thread GitBox
eladkal merged PR #27280: URL: https://github.com/apache/airflow/pull/27280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (09c045f081 -> c3940b40f8)

2022-10-25 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 09c045f081 Bump Trino version to fix non-working DML queries (#27168) add c3940b40f8 timetable text

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #27283: timetable text clarifications

2022-10-25 Thread GitBox
boring-cyborg[bot] commented on PR #27283: URL: https://github.com/apache/airflow/pull/27283#issuecomment-1291487643 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] uranusjr merged pull request #27283: timetable text clarifications

2022-10-25 Thread GitBox
uranusjr merged PR #27283: URL: https://github.com/apache/airflow/pull/27283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] uranusjr commented on issue #27285: Using .output on non-templated fields

2022-10-25 Thread GitBox
uranusjr commented on issue #27285: URL: https://github.com/apache/airflow/issues/27285#issuecomment-1291486305 I don’t think there’s a strict technical limitation, but a user perception considertation: Not all fields can reference an XComArg (e.g. `outlets` and `executor_config` can’t),

[GitHub] [airflow] o-nikolas commented on a diff in pull request #27134: Add info about JSON Connection format for AWS SSM Parameter Store Secrets Backend

2022-10-25 Thread GitBox
o-nikolas commented on code in PR #27134: URL: https://github.com/apache/airflow/pull/27134#discussion_r1005208001 ## docs/apache-airflow-providers-amazon/secrets-backends/aws-ssm-parameter-store.rst: ## @@ -67,9 +67,10 @@ you would want to store your connection at

[GitHub] [airflow] o-nikolas commented on issue #24730: Google CloudRun job operator

2022-10-25 Thread GitBox
o-nikolas commented on issue #24730: URL: https://github.com/apache/airflow/issues/24730#issuecomment-1291472273 > I think, I also can contribute on this, if required We haven't heard back from Juan, so assigning to @v-hunt, thanks for taking this one! -- This is an automated

[GitHub] [airflow] o-nikolas commented on a diff in pull request #27227: Migration of System Tests: Cloud Composer (AIP-47)

2022-10-25 Thread GitBox
o-nikolas commented on code in PR #27227: URL: https://github.com/apache/airflow/pull/27227#discussion_r1005199854 ## airflow/providers/google/cloud/sensors/cloud_composer.py: ## @@ -0,0 +1,99 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] o-nikolas commented on pull request #27174: BugFix - Druid Airflow Exception to about content

2022-10-25 Thread GitBox
o-nikolas commented on PR #27174: URL: https://github.com/apache/airflow/pull/27174#issuecomment-1291466603 > Thanks Nikolas. I am very busy for this weekend. I will check on Friday. No worries, thanks for sticking with it :) > P.S @o-nikolas Is this problem about character

[GitHub] [airflow] o-nikolas commented on a diff in pull request #27185: Handle AzureBatch task result correctly

2022-10-25 Thread GitBox
o-nikolas commented on code in PR #27185: URL: https://github.com/apache/airflow/pull/27185#discussion_r1005174990 ## airflow/providers/microsoft/azure/operators/batch.py: ## @@ -293,16 +293,17 @@ def execute(self, context: Context) -> None: # Add task to job

[GitHub] [airflow] potiuk commented on a diff in pull request #27191: Make dry_run, verbose, answer breeze flags static

2022-10-25 Thread GitBox
potiuk commented on code in PR #27191: URL: https://github.com/apache/airflow/pull/27191#discussion_r1005174081 ## dev/breeze/src/airflow_breeze/commands/developer_commands.py: ## @@ -546,31 +522,17 @@ def enter_shell(**kwargs) -> RunCommandResult: * executes the command

[GitHub] [airflow] potiuk commented on a diff in pull request #27191: Make dry_run, verbose, answer breeze flags static

2022-10-25 Thread GitBox
potiuk commented on code in PR #27191: URL: https://github.com/apache/airflow/pull/27191#discussion_r1005173583 ## dev/breeze/src/airflow_breeze/utils/shared_options.py: ## @@ -0,0 +1,61 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [airflow] potiuk commented on a diff in pull request #27191: Make dry_run, verbose, answer breeze flags static

2022-10-25 Thread GitBox
potiuk commented on code in PR #27191: URL: https://github.com/apache/airflow/pull/27191#discussion_r1005172389 ## dev/breeze/src/airflow_breeze/commands/testing_commands.py: ## @@ -84,20 +84,18 @@ def testing(): allow_extra_args=True, ), ) -@option_verbose

[GitHub] [airflow] ferruzzi commented on a diff in pull request #27191: Make dry_run, verbose, answer breeze flags static

2022-10-25 Thread GitBox
ferruzzi commented on code in PR #27191: URL: https://github.com/apache/airflow/pull/27191#discussion_r1005158642 ## dev/breeze/src/airflow_breeze/utils/shared_options.py: ## @@ -0,0 +1,61 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[airflow] branch main updated (e361be74cd -> 09c045f081)

2022-10-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from e361be74cd Fix system test for Cloud Build Trigger (#26990) add 09c045f081 Bump Trino version to fix non-working

[GitHub] [airflow] potiuk closed issue #26774: Trino and Presto hooks do not properly execute statements other than SELECT

2022-10-25 Thread GitBox
potiuk closed issue #26774: Trino and Presto hooks do not properly execute statements other than SELECT URL: https://github.com/apache/airflow/issues/26774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] potiuk merged pull request #27168: Bump Trino version to fix non-working DML queries

2022-10-25 Thread GitBox
potiuk merged PR #27168: URL: https://github.com/apache/airflow/pull/27168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (a2dd000bad -> e361be74cd)

2022-10-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from a2dd000bad Add Openverse to INTHEWILD.md (#27101) add e361be74cd Fix system test for Cloud Build Trigger (#26990)

[GitHub] [airflow] potiuk merged pull request #26990: Fix system test for Cloud Build Trigger

2022-10-25 Thread GitBox
potiuk merged PR #26990: URL: https://github.com/apache/airflow/pull/26990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] feluelle commented on pull request #27264: Attempt to add Python 3.11 support

2022-10-25 Thread GitBox
feluelle commented on PR #27264: URL: https://github.com/apache/airflow/pull/27264#issuecomment-1291438548 Related https://github.com/apache/arrow/pull/14499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] potiuk commented on pull request #26982: `KubernetesPodOperator` add `container_resources` as templated field

2022-10-25 Thread GitBox
potiuk commented on PR #26982: URL: https://github.com/apache/airflow/pull/26982#issuecomment-1291438170 conflicts need resolution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] feluelle commented on pull request #27264: Attempt to add Python 3.11 support

2022-10-25 Thread GitBox
feluelle commented on PR #27264: URL: https://github.com/apache/airflow/pull/27264#issuecomment-1291434816 Really cool. Unfortunately pyarrow is currently not compatible with 3.11  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] potiuk closed issue #27025: I used the default docker-compose.yaml to setup CeleryExecutor, but SequentialExecutor is set in airflow.cfg

2022-10-25 Thread GitBox
potiuk closed issue #27025: I used the default docker-compose.yaml to setup CeleryExecutor, but SequentialExecutor is set in airflow.cfg URL: https://github.com/apache/airflow/issues/27025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] potiuk commented on issue #27025: I used the default docker-compose.yaml to setup CeleryExecutor, but SequentialExecutor is set in airflow.cfg

2022-10-25 Thread GitBox
potiuk commented on issue #27025: URL: https://github.com/apache/airflow/issues/27025#issuecomment-1291434015 Precisely. veriables do not change files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] potiuk commented on issue #17373: Allow using default celery commands for custom Celery executors subclassed from existing

2022-10-25 Thread GitBox
potiuk commented on issue #17373: URL: https://github.com/apache/airflow/issues/17373#issuecomment-1291427455 It's pretty uselsss to ask question 'why". By definition it's impossible to answer. Until you provide more details it may or may not be similar or different issue. If you

[GitHub] [airflow] potiuk opened a new issue, #27285: Using .output on non-templated fields

2022-10-25 Thread GitBox
potiuk opened a new issue, #27285: URL: https://github.com/apache/airflow/issues/27285 ### Discussed in https://github.com/apache/airflow/discussions/26938 Originally posted by **stephenonethree** October 7, 2022 I just discovered the `.output` property functionality that

[GitHub] [airflow] ferruzzi commented on pull request #27191: Make dry_run, verbose, answer breeze flags static

2022-10-25 Thread GitBox
ferruzzi commented on PR #27191: URL: https://github.com/apache/airflow/pull/27191#issuecomment-1291418260 For sure. It's a very very nice bit of tech debt cleanup. I'm working through it but may have to call it a night soon and finish tomorrow. -- This is an automated message from

[GitHub] [airflow] potiuk closed issue #27164: The workflow is generated by dragging, rather than writing Python code.

2022-10-25 Thread GitBox
potiuk closed issue #27164: The workflow is generated by dragging, rather than writing Python code. URL: https://github.com/apache/airflow/issues/27164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] potiuk commented on issue #27164: The workflow is generated by dragging, rather than writing Python code.

2022-10-25 Thread GitBox
potiuk commented on issue #27164: URL: https://github.com/apache/airflow/issues/27164#issuecomment-1291407757 yep it's not a feature. it's a dicussion. And huge one. And AIP.. In the meantime feel free to use DagFactory if you wnat to use Yaml. I personally think Drag & Drop is a

[GitHub] [airflow] potiuk commented on pull request #27191: Make dry_run, verbose, answer breeze flags static

2022-10-25 Thread GitBox
potiuk commented on PR #27191: URL: https://github.com/apache/airflow/pull/27191#issuecomment-1291401413 Unfortunately it's next to impossible to split it :(. Once you remove it in one place you must remove it in others. The dry_run/verbose options got flag that make them not produce the

[GitHub] [airflow] potiuk commented on issue #27138: Airflow 2.4.1 ab_permission_view_role database error

2022-10-25 Thread GitBox
potiuk commented on issue #27138: URL: https://github.com/apache/airflow/issues/27138#issuecomment-1291396536 Thanks @tirkarthi. Closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] potiuk closed issue #27138: Airflow 2.4.1 ab_permission_view_role database error

2022-10-25 Thread GitBox
potiuk closed issue #27138: Airflow 2.4.1 ab_permission_view_role database error URL: https://github.com/apache/airflow/issues/27138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] ferruzzi commented on pull request #27191: Make dry_run, verbose, answer breeze flags static

2022-10-25 Thread GitBox
ferruzzi commented on PR #27191: URL: https://github.com/apache/airflow/pull/27191#issuecomment-1291395832 Maybe not a huge change, but seeing 72 modified files is a little daunting. :P -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #27101: Add Openverse to INTHEWILD.md

2022-10-25 Thread GitBox
boring-cyborg[bot] commented on PR #27101: URL: https://github.com/apache/airflow/pull/27101#issuecomment-1291395023 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[airflow] branch main updated (b9c30b2e51 -> a2dd000bad)

2022-10-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from b9c30b2e51 Sorting plugins custom menu links by category before name (#27152) add a2dd000bad Add Openverse to

[GitHub] [airflow] potiuk merged pull request #27101: Add Openverse to INTHEWILD.md

2022-10-25 Thread GitBox
potiuk merged PR #27101: URL: https://github.com/apache/airflow/pull/27101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (d83a1aaa68 -> b9c30b2e51)

2022-10-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from d83a1aaa68 Add Blackify commits to blame ignore file (#27224) add b9c30b2e51 Sorting plugins custom menu links by

[GitHub] [airflow] potiuk merged pull request #27152: Sorting plugins custom menu links by category before name

2022-10-25 Thread GitBox
potiuk merged PR #27152: URL: https://github.com/apache/airflow/pull/27152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (7653c61df8 -> d83a1aaa68)

2022-10-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 7653c61df8 Make GSheetsHook return an empty list when there are no values (#27261) add d83a1aaa68 Add Blackify

[GitHub] [airflow] potiuk merged pull request #27224: Add Blackify commits to blame ignore file

2022-10-25 Thread GitBox
potiuk merged PR #27224: URL: https://github.com/apache/airflow/pull/27224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on issue #27032: Worker sometimes does not reconnect to redis/celery queue after crash

2022-10-25 Thread GitBox
potiuk commented on issue #27032: URL: https://github.com/apache/airflow/issues/27032#issuecomment-1291388879 Maybe just keep it running for a while and let us know if ~ few days of running (depending on previously observed frequency) - if you will not see it after 2x the 'average"

[GitHub] [airflow] potiuk commented on pull request #25094: Initial POC of GRPC Internal API

2022-10-25 Thread GitBox
potiuk commented on PR #25094: URL: https://github.com/apache/airflow/pull/25094#issuecomment-1291365961 Not stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[airflow] branch main updated (c8b2737ab1 -> 7653c61df8)

2022-10-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from c8b2737ab1 Enable string normalization for docs (#27269) add 7653c61df8 Make GSheetsHook return an empty list

[GitHub] [airflow] potiuk merged pull request #27261: Make GSheetsHook return an empty list when there are no values

2022-10-25 Thread GitBox
potiuk merged PR #27261: URL: https://github.com/apache/airflow/pull/27261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (d3691fdb63 -> c8b2737ab1)

2022-10-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from d3691fdb63 Fix emr_eks system test (#27279) add c8b2737ab1 Enable string normalization for docs (#27269) No new

[GitHub] [airflow] potiuk commented on pull request #27269: Enable string normalization for docs

2022-10-25 Thread GitBox
potiuk commented on PR #27269: URL: https://github.com/apache/airflow/pull/27269#issuecomment-1291355774 Known issue. merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] potiuk merged pull request #27269: Enable string normalization for docs

2022-10-25 Thread GitBox
potiuk merged PR #27269: URL: https://github.com/apache/airflow/pull/27269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #27283: timetable text clarifications

2022-10-25 Thread GitBox
boring-cyborg[bot] commented on PR #27283: URL: https://github.com/apache/airflow/pull/27283#issuecomment-1291353743 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[GitHub] [airflow] potiuk commented on pull request #27273: Make grid view widths adjustable

2022-10-25 Thread GitBox
potiuk commented on PR #27273: URL: https://github.com/apache/airflow/pull/27273#issuecomment-1291353652 ❤️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] graben1437 opened a new pull request, #27283: timetable text clarifications

2022-10-25 Thread GitBox
graben1437 opened a new pull request, #27283: URL: https://github.com/apache/airflow/pull/27283 Slight clarification in the wording to make things a little clearer. --- **^ Add meaningful description above** Read the **[Pull Request

[airflow] branch main updated (104cd1ed76 -> d3691fdb63)

2022-10-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 104cd1ed76 Add logging back to Sagemaker system test (#27277) add d3691fdb63 Fix emr_eks system test (#27279) No

[GitHub] [airflow] potiuk merged pull request #27279: Fix emr_eks system test

2022-10-25 Thread GitBox
potiuk merged PR #27279: URL: https://github.com/apache/airflow/pull/27279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #27279: Fix emr_eks system test

2022-10-25 Thread GitBox
potiuk commented on PR #27279: URL: https://github.com/apache/airflow/pull/27279#issuecomment-1291352404 Known issue. merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[airflow] branch main updated (0dd65b9cf6 -> 104cd1ed76)

2022-10-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 0dd65b9cf6 pRint important information outside of the folded output in CI (#27260) add 104cd1ed76 Add logging

[GitHub] [airflow] potiuk merged pull request #27277: Add logging back to Sagemaker system test

2022-10-25 Thread GitBox
potiuk merged PR #27277: URL: https://github.com/apache/airflow/pull/27277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #27277: Add logging back to Sagemaker system test

2022-10-25 Thread GitBox
potiuk commented on PR #27277: URL: https://github.com/apache/airflow/pull/27277#issuecomment-1291351247 Known and fixed issue with warning. Merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] potiuk commented on pull request #27235: Restructure Docs

2022-10-25 Thread GitBox
potiuk commented on PR #27235: URL: https://github.com/apache/airflow/pull/27235#issuecomment-1291348597 Would be great also if you generate the docs `breeze build-docs` and share some screenshots. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] potiuk commented on pull request #27235: Restructure Docs

2022-10-25 Thread GitBox
potiuk commented on PR #27235: URL: https://github.com/apache/airflow/pull/27235#issuecomment-1291348019 Conflicts to resolve I am avraid :( . Emotions are the same :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] punx120 commented on issue #27182: SSHOperator ignores cmd_timeout

2022-10-25 Thread GitBox
punx120 commented on issue #27182: URL: https://github.com/apache/airflow/issues/27182#issuecomment-1291328907 Ok done - I updated the PR and fix/added tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] potiuk closed pull request #27267: Update `actions/checkout` version

2022-10-25 Thread GitBox
potiuk closed pull request #27267: Update `actions/checkout` version URL: https://github.com/apache/airflow/pull/27267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] potiuk commented on pull request #27267: Update `actions/checkout` version

2022-10-25 Thread GitBox
potiuk commented on PR #27267: URL: https://github.com/apache/airflow/pull/27267#issuecomment-1291327206 Already fixed in https://github.com/apache/airflow/pull/27192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] potiuk commented on pull request #27260: Print important information outside of the folded output in CI

2022-10-25 Thread GitBox
potiuk commented on PR #27260: URL: https://github.com/apache/airflow/pull/27260#issuecomment-1291324891 Failure unrelated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[airflow] branch main updated (21cc5316be -> 0dd65b9cf6)

2022-10-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 21cc5316be Update airflow release note to export AIRFLOW_RELEASE_SVN before use (#27253) add 0dd65b9cf6 pRint

[GitHub] [airflow] potiuk merged pull request #27260: Print important information outside of the folded output in CI

2022-10-25 Thread GitBox
potiuk merged PR #27260: URL: https://github.com/apache/airflow/pull/27260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #22562: Adding sensor decorator

2022-10-25 Thread GitBox
potiuk commented on PR #22562: URL: https://github.com/apache/airflow/pull/22562#issuecomment-1291322902 Just one more check @uranusjr @jedcunningham ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] potiuk commented on pull request #26761: Common sql bugfixes and improvements

2022-10-25 Thread GitBox
potiuk commented on PR #26761: URL: https://github.com/apache/airflow/pull/26761#issuecomment-1291320385 Unfortunately string normalization conflicts - pls. rebase and fix em :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] potiuk commented on pull request #27214: Refactor amazon providers tests which use `moto`

2022-10-25 Thread GitBox
potiuk commented on PR #27214: URL: https://github.com/apache/airflow/pull/27214#issuecomment-1291316450 Rebased to account for some main failures. But it's cool -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] potiuk commented on issue #21386: Pod Annotations does not be injected in workers when using KubernetesExecutor

2022-10-25 Thread GitBox
potiuk commented on issue #21386: URL: https://github.com/apache/airflow/issues/21386#issuecomment-1291309867 I have no idea why you are calling me - rather avoid doing it if you have no good reason to believe somene has not been involved. Simply check it. If it is still there is

[airflow] branch main updated (7ad82e3384 -> 21cc5316be)

2022-10-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 7ad82e3384 Chart: Default airflow version to 2.4.2 (#27230) add 21cc5316be Update airflow release note to export

[GitHub] [airflow] potiuk merged pull request #27253: Update airflow release note to export AIRFLOW_RELEASE_SVN before use

2022-10-25 Thread GitBox
potiuk merged PR #27253: URL: https://github.com/apache/airflow/pull/27253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on issue #22438: Migrate Amazon example DAGs to new design

2022-10-25 Thread GitBox
potiuk commented on issue #22438: URL: https://github.com/apache/airflow/issues/22438#issuecomment-1291295503 > Moving the example dags in tests directory will not make the CI run them so we are safe on that side. Though I am wondering if we want to have example dags in this directory.

[GitHub] [airflow] potiuk commented on pull request #27067: Remove deprecated dag_file_processor_timeouts metric

2022-10-25 Thread GitBox
potiuk commented on PR #27067: URL: https://github.com/apache/airflow/pull/27067#issuecomment-1291289263 Let's document it then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] potiuk commented on pull request #27067: Remove deprecated dag_file_processor_timeouts metric

2022-10-25 Thread GitBox
potiuk commented on PR #27067: URL: https://github.com/apache/airflow/pull/27067#issuecomment-1291288588 > So IMHO, we need to make a call whether the goal should be to ultimately remove this code, or decide to keep it long term for backcompat but in that case I'd actually like to see it

[GitHub] [airflow] potiuk commented on pull request #26925: TriggerDagRunOperator porting execution_date to logical_date

2022-10-25 Thread GitBox
potiuk commented on PR #26925: URL: https://github.com/apache/airflow/pull/26925#issuecomment-1291286869 And conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] potiuk commented on pull request #26992: Replace `unittests` in helm chart tests by pure `pytest` [Wave-2]

2022-10-25 Thread GitBox
potiuk commented on PR #26992: URL: https://github.com/apache/airflow/pull/26992#issuecomment-1291286082 ❤️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] github-actions[bot] commented on pull request #25094: Initial POC of GRPC Internal API

2022-10-25 Thread GitBox
github-actions[bot] commented on PR #25094: URL: https://github.com/apache/airflow/pull/25094#issuecomment-1291271874 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

[airflow] branch better-information-in-ci-output updated (3e5b3f1506 -> defadfd11f)

2022-10-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch better-information-in-ci-output in repository https://gitbox.apache.org/repos/asf/airflow.git discard 3e5b3f1506 pRint important information outside of the folded output in CI add

[GitHub] [airflow] potiuk commented on a diff in pull request #27260: Print important information outside of the folded output in CI

2022-10-25 Thread GitBox
potiuk commented on code in PR #27260: URL: https://github.com/apache/airflow/pull/27260#discussion_r1005082524 ## dev/breeze/src/airflow_breeze/utils/parallel.py: ## @@ -352,6 +354,11 @@ def check_async_run_results( :param include_success_outputs: include outputs of

[airflow] branch better-information-in-ci-output updated (8a72a18492 -> 3e5b3f1506)

2022-10-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch better-information-in-ci-output in repository https://gitbox.apache.org/repos/asf/airflow.git discard 8a72a18492 Print important information outside of the folded output in CI omit

[GitHub] [airflow] bbovenzi commented on pull request #27145: Add support for DAG display name different than dag_id

2022-10-25 Thread GitBox
bbovenzi commented on PR #27145: URL: https://github.com/apache/airflow/pull/27145#issuecomment-1291263756 We shouldn't make `display_name` the app since we use `dag_id` absolutely everywhere. But then it only appears in some places, and is that just a shorter description? I wonder what

[GitHub] [airflow] jedcunningham commented on a diff in pull request #27260: Print important information outside of the folded output in CI

2022-10-25 Thread GitBox
jedcunningham commented on code in PR #27260: URL: https://github.com/apache/airflow/pull/27260#discussion_r1005075046 ## dev/breeze/src/airflow_breeze/utils/parallel.py: ## @@ -352,6 +354,11 @@ def check_async_run_results( :param include_success_outputs: include outputs

[GitHub] [airflow] potiuk commented on a diff in pull request #27260: Print important information outside of the folded output in CI

2022-10-25 Thread GitBox
potiuk commented on code in PR #27260: URL: https://github.com/apache/airflow/pull/27260#discussion_r1005071736 ## dev/breeze/src/airflow_breeze/utils/parallel.py: ## @@ -352,6 +354,11 @@ def check_async_run_results( :param include_success_outputs: include outputs of

[GitHub] [airflow] potiuk commented on a diff in pull request #27260: Print important information outside of the folded output in CI

2022-10-25 Thread GitBox
potiuk commented on code in PR #27260: URL: https://github.com/apache/airflow/pull/27260#discussion_r1005071736 ## dev/breeze/src/airflow_breeze/utils/parallel.py: ## @@ -352,6 +354,11 @@ def check_async_run_results( :param include_success_outputs: include outputs of

[GitHub] [airflow] potiuk commented on issue #27147: SparkKubernetesOperator: Dag fails when application_file sent as a ".yaml" file

2022-10-25 Thread GitBox
potiuk commented on issue #27147: URL: https://github.com/apache/airflow/issues/27147#issuecomment-1291256560 Yep. This is as expected. @fzkhouy You should add this: ``` template_searchpath='/opt/airflow/kubernetes/templates/' ``` to your Dag object and use

[GitHub] [airflow] potiuk closed issue #27147: SparkKubernetesOperator: Dag fails when application_file sent as a ".yaml" file

2022-10-25 Thread GitBox
potiuk closed issue #27147: SparkKubernetesOperator: Dag fails when application_file sent as a ".yaml" file URL: https://github.com/apache/airflow/issues/27147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] boring-cyborg[bot] commented on issue #27282: KubernetesPodOperator: Option to show logs from all containers in a pod

2022-10-25 Thread GitBox
boring-cyborg[bot] commented on issue #27282: URL: https://github.com/apache/airflow/issues/27282#issuecomment-1291245880 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] pulquero opened a new issue, #27282: KubernetesPodOperator: Option to show logs from all containers in a pod

2022-10-25 Thread GitBox
pulquero opened a new issue, #27282: URL: https://github.com/apache/airflow/issues/27282 ### Description Currently, KubernetesPodOperator fetches logs using ``` self.pod_manager.fetch_container_logs( pod=self.pod,

[GitHub] [airflow] potiuk commented on pull request #27191: Make dry_run, verbose, answer breeze flags static

2022-10-25 Thread GitBox
potiuk commented on PR #27191: URL: https://github.com/apache/airflow/pull/27191#issuecomment-1291244509 I'd love to get that one merged soon. I have a number of small improvements and extensions to the current CI and this one is rather helpful to merge to make them much faster and

[GitHub] [airflow] potiuk commented on pull request #27145: Add support for DAG display name different than dag_id

2022-10-25 Thread GitBox
potiuk commented on PR #27145: URL: https://github.com/apache/airflow/pull/27145#issuecomment-1291241773 I like how simple it is, though I know different people have different opinion and apparenlty I remember hearing strong voices that we should not add "yet another field for that" and

[GitHub] [airflow] jedcunningham commented on a diff in pull request #27260: Print important information outside of the folded output in CI

2022-10-25 Thread GitBox
jedcunningham commented on code in PR #27260: URL: https://github.com/apache/airflow/pull/27260#discussion_r1005028693 ## dev/breeze/src/airflow_breeze/utils/parallel.py: ## @@ -352,6 +354,11 @@ def check_async_run_results( :param include_success_outputs: include outputs

[GitHub] [airflow] potiuk commented on pull request #26999: Fix log message for kubernetes hooks

2022-10-25 Thread GitBox
potiuk commented on PR #26999: URL: https://github.com/apache/airflow/pull/26999#issuecomment-1291222897 Resolved the "normalization" conflict and re-run it. Let's see. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] potiuk commented on pull request #26680: Pass kwargs from vault hook to hvac client

2022-10-25 Thread GitBox
potiuk commented on PR #26680: URL: https://github.com/apache/airflow/pull/26680#issuecomment-1291221652 Just returned from holidays and re-run it. let's see. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] potiuk commented on issue #27140: Invalid livenessProbe for Standalone DAG Processor

2022-10-25 Thread GitBox
potiuk commented on issue #27140: URL: https://github.com/apache/airflow/issues/27140#issuecomment-1291216927 Assigned it for 1.8.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

  1   2   3   >