Taragolis commented on code in PR #38742:
URL: https://github.com/apache/airflow/pull/38742#discussion_r1551452922
##
dev/breeze/src/airflow_breeze/utils/platforms.py:
##
@@ -16,10 +16,69 @@
# under the License.
from __future__ import annotations
+import platform
+import sys
potiuk commented on code in PR #38742:
URL: https://github.com/apache/airflow/pull/38742#discussion_r1551446250
##
dev/breeze/src/airflow_breeze/utils/platforms.py:
##
@@ -16,10 +16,69 @@
# under the License.
from __future__ import annotations
+import platform
+import sys
+f
potiuk commented on PR #38702:
URL: https://github.com/apache/airflow/pull/38702#issuecomment-2036833005
If you **just** want to get your PR merged faster, then it's a very selfish
reason to tap into time and attention of others when YOU want it and not when
THEY have time for it.
--
Thi
potiuk commented on PR #38702:
URL: https://github.com/apache/airflow/pull/38702#issuecomment-2036830670
> @potiuk Please review this PR.
Why tagging me? @subham611 ? What's the reasoning of doing it ?
I think there are enough reviewers. generally please avoid tagging people
Taragolis commented on code in PR #38742:
URL: https://github.com/apache/airflow/pull/38742#discussion_r1551441913
##
dev/breeze/src/airflow_breeze/utils/platforms.py:
##
@@ -16,10 +16,69 @@
# under the License.
from __future__ import annotations
+import platform
+import sys
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 2b61725f58 feat: Add mobuchowski ad Code Owner for
potiuk merged PR #38738:
URL: https://github.com/apache/airflow/pull/38738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
SubhamSinghal commented on PR #38702:
URL: https://github.com/apache/airflow/pull/38702#issuecomment-2036824428
@potiuk Please review this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
potiuk commented on PR #38740:
URL: https://github.com/apache/airflow/pull/38740#issuecomment-2036817847
First time it failed because the machines were not restarted **yet**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Taragolis commented on PR #38684:
URL: https://github.com/apache/airflow/pull/38684#issuecomment-2036815767
One more rebase before merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
e-galan commented on code in PR #38584:
URL: https://github.com/apache/airflow/pull/38584#discussion_r1551124583
##
airflow/providers/google/cloud/hooks/vertex_ai/custom_job.py:
##
@@ -2178,3 +3300,239 @@ def list_custom_jobs(
metadata=metadata,
)
e-galan commented on code in PR #38584:
URL: https://github.com/apache/airflow/pull/38584#discussion_r1551413438
##
airflow/providers/google/cloud/hooks/vertex_ai/custom_job.py:
##
@@ -1754,79 +1774,1181 @@ def create_custom_training_job(
return model, training_id, cust
potiuk opened a new pull request, #38742:
URL: https://github.com/apache/airflow/pull/38742
When uv docker build is run in WSL2 the default timeout does not cope well
with downloading big packages and times-out with the default UV timeout. This
PR performs detection of whether you are in a
potiuk commented on PR #38742:
URL: https://github.com/apache/airflow/pull/38742#issuecomment-2036792900
cc: @dabla
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
SubhamSinghal commented on PR #38741:
URL: https://github.com/apache/airflow/pull/38741#issuecomment-2036767775
@Lee-W Please review changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
potiuk commented on PR #38739:
URL: https://github.com/apache/airflow/pull/38739#issuecomment-2036744617
Images built. breeze checks passed. Looks good to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from ecd69955f9 fix: Remove redundant operator information from facets
(#38264)
add 329c76d2e3 Rename UV_REQUEST_TIMEO
potiuk merged PR #38739:
URL: https://github.com/apache/airflow/pull/38739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
e-galan commented on code in PR #38584:
URL: https://github.com/apache/airflow/pull/38584#discussion_r1551124583
##
airflow/providers/google/cloud/hooks/vertex_ai/custom_job.py:
##
@@ -2178,3 +3300,239 @@ def list_custom_jobs(
metadata=metadata,
)
e-galan commented on code in PR #38584:
URL: https://github.com/apache/airflow/pull/38584#discussion_r1551347203
##
airflow/providers/google/cloud/hooks/vertex_ai/custom_job.py:
##
@@ -1754,79 +1774,1181 @@ def create_custom_training_job(
return model, training_id, cust
amoghrajesh commented on PR #38651:
URL: https://github.com/apache/airflow/pull/38651#issuecomment-2036692513
@potiuk @eladkal @hussein-awala if all looks good shall we send this one in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
potiuk commented on PR #38720:
URL: https://github.com/apache/airflow/pull/38720#issuecomment-2036686817
But yes - it's a bit misleding and ambiguous, possibly we could improve it
somehow (RC milestone?)
--
This is an automated message from the Apache Git Service.
To respond to the me
potiuk commented on PR #38720:
URL: https://github.com/apache/airflow/pull/38720#issuecomment-2036684606
> Since I am merging this PR now
So far I've been marking those candidates for rc2 as 2.9.0 - then when we
release 2.9.0 finally we will just move those in 2.9.0 which are unmerged
This is an automated email from the ASF dual-hosted git repository.
weilee pushed a change to branch add-weilee-to-committer-list
in repository https://gitbox.apache.org/repos/asf/airflow-site.git
omit 2c9267e99d add Wei Lee to committer list
add 587ae05178 add Wei Lee to committer list
Lee-W opened a new pull request, #996:
URL: https://github.com/apache/airflow-site/pull/996
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
This is an automated email from the ASF dual-hosted git repository.
weilee pushed a change to branch add-weilee-to-committer-list
in repository https://gitbox.apache.org/repos/asf/airflow-site.git
at 2c9267e99d add Wei Lee to committer list
This branch includes the following new commits:
This is an automated email from the ASF dual-hosted git repository.
weilee pushed a commit to branch add-weilee-to-committer-list
in repository https://gitbox.apache.org/repos/asf/airflow-site.git
commit 2c9267e99d13a0bbd343ce74f7b7f696272b2c51
Author: Wei Lee
AuthorDate: Thu Apr 4 17:20:12 2024
Lee-W opened a new pull request, #38740:
URL: https://github.com/apache/airflow/pull/38740
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull
dabla commented on code in PR #38528:
URL: https://github.com/apache/airflow/pull/38528#discussion_r1551300942
##
airflow/providers/common/sql/hooks/sql.py:
##
@@ -173,7 +175,17 @@ def __init__(self, *args, schema: str | None = None,
log_sql: bool = True, **kwa
)
potiuk opened a new pull request, #38739:
URL: https://github.com/apache/airflow/pull/38739
The UV_REQUEST_TIMEOUT was only briefly the correct parameter name, (UV
1.6.0). It is still working as a fallback, but the right parameter name is
UV_HTTP_TIMEOUT. This PR renames the flag and build
e-galan commented on code in PR #38584:
URL: https://github.com/apache/airflow/pull/38584#discussion_r1551136180
##
airflow/providers/google/cloud/hooks/vertex_ai/custom_job.py:
##
@@ -2178,3 +3300,239 @@ def list_custom_jobs(
metadata=metadata,
)
kacpermuda opened a new pull request, #38738:
URL: https://github.com/apache/airflow/pull/38738
Added @mobuchowski as Code Owner for OpenLineage code. Also sorted each
section of the file.
---
**^ Add meaningful description above**
Read the **[Pull Request
G
e-galan commented on code in PR #38584:
URL: https://github.com/apache/airflow/pull/38584#discussion_r1551124583
##
airflow/providers/google/cloud/hooks/vertex_ai/custom_job.py:
##
@@ -2178,3 +3300,239 @@ def list_custom_jobs(
metadata=metadata,
)
e-galan commented on code in PR #38584:
URL: https://github.com/apache/airflow/pull/38584#discussion_r1551279930
##
airflow/providers/google/cloud/operators/vertex_ai/custom_job.py:
##
@@ -539,6 +564,94 @@ def on_kill(self) -> None:
if self.hook:
self.hook.
This is an automated email from the ASF dual-hosted git repository.
mobuchowski pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from 5337066492 Fix grid header rendering (#38720)
add ecd69955f9 fix: Remove redundant operator information from
mobuchowski merged PR #38264:
URL: https://github.com/apache/airflow/pull/38264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airf
Bowrna commented on PR #34457:
URL: https://github.com/apache/airflow/pull/34457#issuecomment-2036583335
All green now :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
HTRafal commented on PR #37936:
URL: https://github.com/apache/airflow/pull/37936#issuecomment-2036568387
So `dag...queued_duration` documented as `Seconds a task
spends in the Queued state, before being Running` is actually a value in
**kiloseconds** :D. You have to multiply it by 1000 to
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from 6c217ae342 bump uv to 0.1.28 (#38690)
add 5337066492 Fix grid header rendering (#38720)
No new revisions were ad
eladkal merged PR #38720:
URL: https://github.com/apache/airflow/pull/38720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.
eladkal commented on PR #38720:
URL: https://github.com/apache/airflow/pull/38720#issuecomment-2036548759
Since I am merging this PR now
I am marking it for 2.9.1 in case we have rc2 for 2.9.0 then release manager
can simply go over the PRs on 2.9.1 and decide what to bring into 2.9.0rc2
eladkal commented on code in PR #38528:
URL: https://github.com/apache/airflow/pull/38528#discussion_r1551212901
##
airflow/providers/common/sql/hooks/sql.py:
##
@@ -50,6 +50,7 @@
from airflow.providers.openlineage.sqlparser import DatabaseInfo
T = TypeVar("T")
+DEFAULT_
dabla commented on code in PR #38715:
URL: https://github.com/apache/airflow/pull/38715#discussion_r1551139206
##
airflow/providers/common/sql/hooks/sql.py:
##
@@ -545,35 +541,19 @@ def insert_rows(
conn.commit()
with closing(conn.cursor()) as cur:
-
dabla commented on PR #38715:
URL: https://github.com/apache/airflow/pull/38715#issuecomment-2036516660
Also deprecated bulk_insert_rows method in Teradata as it does almost the
same as what I did in insert_rows, so for now I log a deprecation warning
message and just delegate the call to t
Lee-W commented on issue #38721:
URL: https://github.com/apache/airflow/issues/38721#issuecomment-2036485673
If you're interested in it, sure 🙂 Let me assign it to you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
dabla commented on code in PR #38715:
URL: https://github.com/apache/airflow/pull/38715#discussion_r1551139206
##
airflow/providers/common/sql/hooks/sql.py:
##
@@ -545,35 +541,19 @@ def insert_rows(
conn.commit()
with closing(conn.cursor()) as cur:
-
SubhamSinghal commented on issue #38721:
URL: https://github.com/apache/airflow/issues/38721#issuecomment-2036477386
@Lee-W Should I pick this up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
e-galan commented on code in PR #38584:
URL: https://github.com/apache/airflow/pull/38584#discussion_r1551136180
##
airflow/providers/google/cloud/hooks/vertex_ai/custom_job.py:
##
@@ -2178,3 +3300,239 @@ def list_custom_jobs(
metadata=metadata,
)
e-galan commented on code in PR #38584:
URL: https://github.com/apache/airflow/pull/38584#discussion_r1551124583
##
airflow/providers/google/cloud/hooks/vertex_ai/custom_job.py:
##
@@ -2178,3 +3300,239 @@ def list_custom_jobs(
metadata=metadata,
)
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch constraints-main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/constraints-main by this push:
new 404b9c3ba8 Updating con
e-galan opened a new pull request, #38737:
URL: https://github.com/apache/airflow/pull/38737
Fixes a conflict in Dataplex system tests that caused them to occasionally
fail, because both tests tried to create and then delete identically-named
resources.
---
*
potiuk commented on PR #38628:
URL: https://github.com/apache/airflow/pull/38628#issuecomment-2036432683
Trigger should (even if it times out) produce a trigger event with batch_id
information in it. So Airflow should not kill trigger, it should timeout itself
before Airflow does it and sig
raphaelauv opened a new issue, #38735:
URL: https://github.com/apache/airflow/issues/38735
### Apache Airflow version
2.8.4
### If "Other Airflow 2 version" selected, which one?
_No response_
### What happened?
if you clear a deferred task , it do not increm
nathadfield opened a new pull request, #38736:
URL: https://github.com/apache/airflow/pull/38736
Adding a set of additional hook functions for the OpenAI provider that deal
with interactions between some of the
[Chat](https://platform.openai.com/docs/api-reference/chat) and
[Assistants](ht
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch constraints-2-9
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/constraints-2-9 by this push:
new 1b9bc71a95 Updating const
potiuk commented on issue #38304:
URL: https://github.com/apache/airflow/issues/38304#issuecomment-2036386909
Assigned you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
github-actions[bot] closed issue #24359: Timezone changed on server and UI to
local/Pacific, but DateTimeSensor still using UTC
URL: https://github.com/apache/airflow/issues/24359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
github-actions[bot] commented on issue #24359:
URL: https://github.com/apache/airflow/issues/24359#issuecomment-2036344466
This issue has been closed because it has not received response from the
issue author.
--
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] commented on issue #24721:
URL: https://github.com/apache/airflow/issues/24721#issuecomment-2036344421
This issue has been automatically marked as stale because it has been open
for 365 days without any activity. There has been several Airflow releases
since last activit
github-actions[bot] commented on issue #24742:
URL: https://github.com/apache/airflow/issues/24742#issuecomment-2036344382
This issue has been automatically marked as stale because it has been open
for 365 days without any activity. There has been several Airflow releases
since last activit
201 - 260 of 260 matches
Mail list logo
