[GitHub] [airflow] Fokko commented on issue #6370: AIRFLOW-5701: Don't clear xcom explicitly before execution

2019-10-29 Thread GitBox
Fokko commented on issue #6370: AIRFLOW-5701: Don't clear xcom explicitly before execution URL: https://github.com/apache/airflow/pull/6370#issuecomment-547280956 > Unless I switch a pickle flag it complains that it is not JSON serializable, the comments in the code indicate pickling is

[GitHub] [airflow] Fokko commented on issue #6370: AIRFLOW-5701: Don't clear xcom explicitly before execution

2019-10-27 Thread GitBox
Fokko commented on issue #6370: AIRFLOW-5701: Don't clear xcom explicitly before execution URL: https://github.com/apache/airflow/pull/6370#issuecomment-546707884 First of all, you should be able to just serialize the execution_date. Instead of converting it to a string, and parse it

[GitHub] [airflow] Fokko commented on issue #6370: AIRFLOW-5701: Don't clear xcom explicitly before execution

2019-10-27 Thread GitBox
Fokko commented on issue #6370: AIRFLOW-5701: Don't clear xcom explicitly before execution URL: https://github.com/apache/airflow/pull/6370#issuecomment-546676541 Just for the record. @bolkedebruin technically you're correct. But I was being pragmatic. We don't use the `id` column, so

[GitHub] [airflow] Fokko commented on issue #6370: AIRFLOW-5701: Don't clear xcom explicitly before execution

2019-10-27 Thread GitBox
Fokko commented on issue #6370: AIRFLOW-5701: Don't clear xcom explicitly before execution URL: https://github.com/apache/airflow/pull/6370#issuecomment-546672430 @notatallshaw I'm pretty sure that this behavior hasn't changed. Before it would be cleared, and then you would insert the

[GitHub] [airflow] Fokko commented on issue #6370: AIRFLOW-5701: Don't clear xcom explicitly before execution

2019-10-26 Thread GitBox
Fokko commented on issue #6370: AIRFLOW-5701: Don't clear xcom explicitly before execution URL: https://github.com/apache/airflow/pull/6370#issuecomment-546640879 > So what happens if the task ran successfully first and then was cleared? Does that clear XCOM. It should IMHO. IMHO

[GitHub] [airflow] Fokko commented on issue #6370: AIRFLOW-5701: Don't clear xcom explicitly before execution

2019-10-26 Thread GitBox
Fokko commented on issue #6370: AIRFLOW-5701: Don't clear xcom explicitly before execution URL: https://github.com/apache/airflow/pull/6370#issuecomment-546582724 The idea started with PR https://github.com/apache/airflow/pull/6210 We needed to store state because we're now having a

[GitHub] [airflow] Fokko commented on issue #6370: AIRFLOW-5701: Don't clear xcom explicitly before execution

2019-10-24 Thread GitBox
Fokko commented on issue #6370: AIRFLOW-5701: Don't clear xcom explicitly before execution URL: https://github.com/apache/airflow/pull/6370#issuecomment-545838956 Thank you @OmerJog This is an automated message from the

[GitHub] [airflow] Fokko commented on issue #6370: AIRFLOW-5701: Don't clear xcom explicitly before execution

2019-10-22 Thread GitBox
Fokko commented on issue #6370: AIRFLOW-5701: Don't clear xcom explicitly before execution URL: https://github.com/apache/airflow/pull/6370#issuecomment-545123697 Actually, the current database layout is backward compatible. We don't use the `id` field, and I don't see too much value in

[GitHub] [airflow] Fokko commented on issue #6370: AIRFLOW-5701: Don't clear xcom explicitly before execution

2019-10-22 Thread GitBox
Fokko commented on issue #6370: AIRFLOW-5701: Don't clear xcom explicitly before execution URL: https://github.com/apache/airflow/pull/6370#issuecomment-545043480 Test failure looks unrelated, pulled in master: ``` Summary of failed tests

[GitHub] [airflow] Fokko commented on issue #6370: AIRFLOW-5701: Don't clear xcom explicitly before execution

2019-10-20 Thread GitBox
Fokko commented on issue #6370: AIRFLOW-5701: Don't clear xcom explicitly before execution URL: https://github.com/apache/airflow/pull/6370#issuecomment-544229682 Yes. I also still have to do the database migrations. The issue here is that for sqlite the migrations are quite limited, and