Taragolis commented on code in PR #29633:
URL: https://github.com/apache/airflow/pull/29633#discussion_r1111744729
##########
airflow/providers/amazon/aws/operators/redshift_data.py:
##########
@@ -73,10 +73,11 @@ def __init__(
secret_arn: str | None = None,
statement_name: str | None = None,
with_event: bool = False,
- await_result: bool = True,
+ await_result: bool | None = None,
poll_interval: int = 10,
aws_conn_id: str = "aws_default",
region: str | None = None,
+ wait_for_completion: bool = True,
Review Comment:
Small nit, could we move in `await_result` in the end of operator arguments?
And in this place we could store `wait_for_completion`
This not affect to users because it is mandatory requirement for all
operators to send arguments as key-value arguments and I think it would be nice
to store all deprecated values in the bottom operator constructor definition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
