Taragolis opened a new pull request, #29075:
URL: https://github.com/apache/airflow/pull/29075

   Unfortunately this test still not stable and first run 🤦‍♂️ 🤦‍♂️ 🤦‍♂️  in 
main failed again.
   
   https://github.com/apache/airflow/actions/runs/3971462849/jobs/6808560333:
   ```console
           finally:
               proc.kill()
       
           assert retry_callback_called.value == 1
           with create_session() as session:
               ti = (
                   session.query(TaskInstance)
                   .filter(
                       TaskInstance.dag_id == dag_id,
                       TaskInstance.task_id == task_id,
                       TaskInstance.run_id == run_id,
                   )
                   .one()
               )
   >       assert ti.state == State.UP_FOR_RETRY
   E       AssertionError: assert 'running' == <TaskInstance...up_for_retry'>
   E         - up_for_retry
   E         + running
   
   tests/jobs/test_local_task_job.py:895: AssertionError
   ```
   
   This error basically mean that we send SIGKILL `proc.kill()` before state 
changed but callback already executed.
   
   Note: We do not check state in the previous version of the test, only 
callback result


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to