[GitHub] [airflow] TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-30 Thread GitBox
TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#issuecomment-536537383 @potiuk I've added message validation. Now when user pass message data as a string which can be base64 decoded, an

[GitHub] [airflow] TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-26 Thread GitBox
TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#issuecomment-535495342 cc @mik-laj @potiuk This is an automated message from

[GitHub] [airflow] TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-23 Thread GitBox
TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#issuecomment-533998153 Updated due to comments, slightly improved test, rebased on last master.

[GitHub] [airflow] TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-20 Thread GitBox
TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#issuecomment-533690184 I've updated `TestPubSubPullSensor` (hook mocking).

[GitHub] [airflow] TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-20 Thread GitBox
TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#issuecomment-533570181 I've rebased but due to fact than previous commits impacted PubSub significantly I had to make some changes (remove

[GitHub] [airflow] TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-19 Thread GitBox
TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#issuecomment-532984150 Rebased on the last `master`. This is an automated

[GitHub] [airflow] TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-17 Thread GitBox
TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#issuecomment-532193257 @mik-laj Yes, hopefully PR is done. I've applied all necessary patches.

[GitHub] [airflow] TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-16 Thread GitBox
TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#issuecomment-531795029 @mik-laj I've applied changes. Please verify is correct.