[GitHub] [airflow] XD-DENG commented on pull request #8685: Fix Spark Conn Add/Edit Pages

2020-05-03 Thread GitBox
XD-DENG commented on pull request #8685: URL: https://github.com/apache/airflow/pull/8685#issuecomment-623144773 Hi @zhongjiajie , I have split the PR into two. The change to order connection types alphabetically is in PR https://github.com/apache/airflow/pull/8692 The PR

[GitHub] [airflow] XD-DENG commented on pull request #8685: Fix Spark Conn Add/Edit Pages + Sort Connection Type Options

2020-05-03 Thread GitBox
XD-DENG commented on pull request #8685: URL: https://github.com/apache/airflow/pull/8685#issuecomment-623142738 > Code looking good, but should we separate PR? Seem sorting and adding miss type unrelated. @zhongjiajie two changes are both small so appended the 2nd change here. But