[GitHub] [airflow] ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-08-01 Thread GitBox
ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309625180 ## File path: airflow/models/baseoperator.py ## @@ -636,51 +636,71 @@ def __setstate__(self, state):

[GitHub] [airflow] ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-08-01 Thread GitBox
ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309626185 ## File path: tests/contrib/operators/test_databricks_operator.py ## @@ -165,7 +165,7 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-08-01 Thread GitBox
ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309625180 ## File path: airflow/models/baseoperator.py ## @@ -636,51 +636,71 @@ def __setstate__(self, state):

[GitHub] [airflow] ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-08-01 Thread GitBox
ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309624049 ## File path: airflow/models/baseoperator.py ## @@ -636,51 +636,71 @@ def __setstate__(self, state):

[GitHub] [airflow] ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-08-01 Thread GitBox
ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309624776 ## File path: airflow/models/baseoperator.py ## @@ -636,51 +636,71 @@ def __setstate__(self, state):

[GitHub] [airflow] ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-08-01 Thread GitBox
ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309626704 ## File path: tests/models/test_dag.py ## @@ -387,243 +392,72 @@ def test_get_num_task_instances(self):

[GitHub] [airflow] ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-08-01 Thread GitBox
ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309625549 ## File path: airflow/models/baseoperator.py ## @@ -636,51 +636,71 @@ def __setstate__(self, state):

[GitHub] [airflow] ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-08-01 Thread GitBox
ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309626828 ## File path: tests/models/test_dag.py ## @@ -387,243 +392,72 @@ def test_get_num_task_instances(self):

[GitHub] [airflow] ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-07-31 Thread GitBox
ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309228963 ## File path: airflow/models/baseoperator.py ## @@ -636,51 +636,50 @@ def __setstate__(self, state):

[GitHub] [airflow] ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-07-31 Thread GitBox
ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309228434 ## File path: tests/models/test_dag.py ## @@ -387,243 +388,93 @@ def test_get_num_task_instances(self):

[GitHub] [airflow] ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-07-31 Thread GitBox
ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309228197 ## File path: tests/models/test_dag.py ## @@ -387,243 +388,93 @@ def test_get_num_task_instances(self):

[GitHub] [airflow] ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-07-31 Thread GitBox
ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309105615 ## File path: tests/models/test_dag.py ## @@ -387,243 +388,93 @@ def test_get_num_task_instances(self):

[GitHub] [airflow] ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-07-31 Thread GitBox
ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309104488 ## File path: airflow/models/taskinstance.py ## @@ -1245,21 +1245,20 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-07-31 Thread GitBox
ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309106148 ## File path: tests/models/test_dag.py ## @@ -387,243 +388,93 @@ def test_get_num_task_instances(self):

[GitHub] [airflow] ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-07-31 Thread GitBox
ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309106230 ## File path: tests/models/test_dag.py ## @@ -387,243 +388,93 @@ def test_get_num_task_instances(self):

[GitHub] [airflow] ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-07-31 Thread GitBox
ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309102556 ## File path: airflow/models/baseoperator.py ## @@ -636,51 +636,50 @@ def __setstate__(self, state):