[GitHub] [airflow] dstandish commented on pull request #6850: [AIRFLOW-6296] add ODBC hook & deprecation warning for pymssql

2021-04-29 Thread GitBox
dstandish commented on pull request #6850: URL: https://github.com/apache/airflow/pull/6850#issuecomment-829582644 OK @eladkal i think in #15594 i have successfully removed the interdependency while maintaining verification of _compatibility_ in the mssql operator test. Please take

[GitHub] [airflow] dstandish commented on pull request #6850: [AIRFLOW-6296] add ODBC hook & deprecation warning for pymssql

2021-04-29 Thread GitBox
dstandish commented on pull request #6850: URL: https://github.com/apache/airflow/pull/6850#issuecomment-829515009 TLDR it seems like we should be able to remove that interdependency by putting this line behind an `if TYPING` guard:

[GitHub] [airflow] dstandish commented on pull request #6850: [AIRFLOW-6296] add ODBC hook & deprecation warning for pymssql

2021-01-27 Thread GitBox
dstandish commented on pull request #6850: URL: https://github.com/apache/airflow/pull/6850#issuecomment-768548513 @ldacey let me add... just going throught the process of getting something merged is meaningful and valuable work in itself and this would probably be a nice

[GitHub] [airflow] dstandish commented on pull request #6850: [AIRFLOW-6296] add ODBC hook & deprecation warning for pymssql

2021-01-27 Thread GitBox
dstandish commented on pull request #6850: URL: https://github.com/apache/airflow/pull/6850#issuecomment-768545232 > I could contribute this but I would feel like a fraud - dstandish provided the function and I just copy and pasted it without making any other changes. @ldacey do

[GitHub] [airflow] dstandish commented on pull request #6850: [AIRFLOW-6296] add ODBC hook & deprecation warning for pymssql

2020-08-20 Thread GitBox
dstandish commented on pull request #6850: URL: https://github.com/apache/airflow/pull/6850#issuecomment-677861161 nice :) glad it worked out for you This is an automated message from the Apache Git Service. To

[GitHub] [airflow] dstandish commented on pull request #6850: [AIRFLOW-6296] add ODBC hook & deprecation warning for pymssql

2020-08-19 Thread GitBox
dstandish commented on pull request #6850: URL: https://github.com/apache/airflow/pull/6850#issuecomment-676500165 > Is it possible to use turbodbc with this as well, or would that have to be a separate custom hook? Support could be added easily because the odbc conn str can be

[GitHub] [airflow] dstandish commented on pull request #6850: [AIRFLOW-6296] add ODBC hook & deprecation warning for pymssql

2020-04-24 Thread GitBox
dstandish commented on pull request #6850: URL: https://github.com/apache/airflow/pull/6850#issuecomment-618900341 ah, the mythical 2.0 ;) This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] dstandish commented on pull request #6850: [AIRFLOW-6296] add ODBC hook & deprecation warning for pymssql

2020-04-24 Thread GitBox
dstandish commented on pull request #6850: URL: https://github.com/apache/airflow/pull/6850#issuecomment-618896713 @potiuk @kaxil another potential reason to cherry pick this one is that it seems pymssql cannot be installed on python 3.8... this PR provides a path to to install airflow