[GitHub] [airflow] eladkal commented on issue #5564: [AIRFLOW-4289] fix spark_binary argument being ignored in SparkSubmit…

2019-09-19 Thread GitBox
eladkal commented on issue #5564: [AIRFLOW-4289] fix spark_binary argument being ignored in SparkSubmit… URL: https://github.com/apache/airflow/pull/5564#issuecomment-533038775 @boiler i see the problem I will PR a fix This i

[GitHub] [airflow] eladkal commented on issue #5564: [AIRFLOW-4289] fix spark_binary argument being ignored in SparkSubmit…

2019-07-30 Thread GitBox
eladkal commented on issue #5564: [AIRFLOW-4289] fix spark_binary argument being ignored in SparkSubmit… URL: https://github.com/apache/airflow/pull/5564#issuecomment-516562245 Hi @ashb added another test and squashed all commits. ---

[GitHub] [airflow] eladkal commented on issue #5564: [AIRFLOW-4289] fix spark_binary argument being ignored in SparkSubmit…

2019-07-30 Thread GitBox
eladkal commented on issue #5564: [AIRFLOW-4289] fix spark_binary argument being ignored in SparkSubmit… URL: https://github.com/apache/airflow/pull/5564#issuecomment-516411245 @ashb Isn't it already covered by `test_resolve_connection_spark_binary_set_connection` it takes `conn_id='spa

[GitHub] [airflow] eladkal commented on issue #5564: [AIRFLOW-4289] fix spark_binary argument being ignored in SparkSubmit…

2019-07-29 Thread GitBox
eladkal commented on issue #5564: [AIRFLOW-4289] fix spark_binary argument being ignored in SparkSubmit… URL: https://github.com/apache/airflow/pull/5564#issuecomment-516230270 @ashb CI is green. Can you review? This is an au

[GitHub] [airflow] eladkal commented on issue #5564: [AIRFLOW-4289] fix spark_binary argument being ignored in SparkSubmit…

2019-07-29 Thread GitBox
eladkal commented on issue #5564: [AIRFLOW-4289] fix spark_binary argument being ignored in SparkSubmit… URL: https://github.com/apache/airflow/pull/5564#issuecomment-516081700 @ashb I need some help in resolving the failed test: ``` test_resolve_connection_yarn_default (tests.contri