[GitHub] [airflow] feluelle commented on issue #6352: [WIP][AIRFLOW-5683] Add SubDagOperator that propagates skipped state

2019-10-26 Thread GitBox
feluelle commented on issue #6352: [WIP][AIRFLOW-5683] Add SubDagOperator that propagates skipped state URL: https://github.com/apache/airflow/pull/6352#issuecomment-546601759 I think my special cases should be solvable via sth. like the `ExternalTaskSensor`.

[GitHub] [airflow] feluelle commented on issue #6352: [WIP][AIRFLOW-5683] Add SubDagOperator that propagates skipped state

2019-10-26 Thread GitBox
feluelle commented on issue #6352: [WIP][AIRFLOW-5683] Add SubDagOperator that propagates skipped state URL: https://github.com/apache/airflow/pull/6352#issuecomment-546601273 Thanks @kaxil and @milton0825 for you opinions. So then I will add sth like a `propagate_skipped_state`

[GitHub] [airflow] feluelle commented on issue #6352: [WIP][AIRFLOW-5683] Add SubDagOperator that propagates skipped state

2019-10-16 Thread GitBox
feluelle commented on issue #6352: [WIP][AIRFLOW-5683] Add SubDagOperator that propagates skipped state URL: https://github.com/apache/airflow/pull/6352#issuecomment-542878228 > How about we check whether any of the leaf nodes in the subdag is `skipped` and propagate that to parent DAG so

[GitHub] [airflow] feluelle commented on issue #6352: [WIP][AIRFLOW-5683] Add SubDagOperator that propagates skipped state

2019-10-16 Thread GitBox
feluelle commented on issue #6352: [WIP][AIRFLOW-5683] Add SubDagOperator that propagates skipped state URL: https://github.com/apache/airflow/pull/6352#issuecomment-542874196 Yes, (we only need to do it for the `skipped` state, because other states like success or failed propagate

[GitHub] [airflow] feluelle commented on issue #6352: [WIP][AIRFLOW-5683] Add SubDagOperator that propagates skipped state

2019-10-16 Thread GitBox
feluelle commented on issue #6352: [WIP][AIRFLOW-5683] Add SubDagOperator that propagates skipped state URL: https://github.com/apache/airflow/pull/6352#issuecomment-542871719 > > > > Currently there is no way of telling the parent dag of a sub dag that an essential task has been

[GitHub] [airflow] feluelle commented on issue #6352: [WIP][AIRFLOW-5683] Add SubDagOperator that propagates skipped state

2019-10-16 Thread GitBox
feluelle commented on issue #6352: [WIP][AIRFLOW-5683] Add SubDagOperator that propagates skipped state URL: https://github.com/apache/airflow/pull/6352#issuecomment-542848213 @milton0825 I requested you to review because I think you know the most about subdags :)