[GitHub] [airflow] jaketf commented on issue #6210: [AIRFLOW-5567] [Do not Merge] prototype BaseAsyncOperator

2019-10-02 Thread GitBox
jaketf commented on issue #6210: [AIRFLOW-5567] [Do not Merge] prototype BaseAsyncOperator URL: https://github.com/apache/airflow/pull/6210#issuecomment-537766761 I have noticed in looking at existing dataflow and dataproc hooks many hooks conflate job submission and `wait_for_done`

[GitHub] [airflow] jaketf commented on issue #6210: [AIRFLOW-5567] [Do not Merge] prototype BaseAsyncOperator

2019-10-02 Thread GitBox
jaketf commented on issue #6210: [AIRFLOW-5567] [Do not Merge] prototype BaseAsyncOperator URL: https://github.com/apache/airflow/pull/6210#issuecomment-537765917 @mik-laj Is there any operator you can think of that might be a better example to refactor as an async operator that might not

[GitHub] [airflow] jaketf commented on issue #6210: [AIRFLOW-5567] [Do not Merge] prototype BaseAsyncOperator

2019-10-02 Thread GitBox
jaketf commented on issue #6210: [AIRFLOW-5567] [Do not Merge] prototype BaseAsyncOperator URL: https://github.com/apache/airflow/pull/6210#issuecomment-537697927 Digging deeper on `DataflowJavaOperator` as an example. This is a poor choice because it requires running a java process on

[GitHub] [airflow] jaketf commented on issue #6210: [AIRFLOW-5567] [Do not Merge] prototype BaseAsyncOperator

2019-10-01 Thread GitBox
jaketf commented on issue #6210: [AIRFLOW-5567] [Do not Merge] prototype BaseAsyncOperator URL: https://github.com/apache/airflow/pull/6210#issuecomment-537199801 I can refactor the `DataflowJavaOperator` as part of this PR as an opinionated illustration of how others might use

[GitHub] [airflow] jaketf commented on issue #6210: [AIRFLOW-5567] [Do not Merge] prototype BaseAsyncOperator

2019-10-01 Thread GitBox
jaketf commented on issue #6210: [AIRFLOW-5567] [Do not Merge] prototype BaseAsyncOperator URL: https://github.com/apache/airflow/pull/6210#issuecomment-537192679 @nuclearpinguin I think those concerns are quite valid. > How should I decide whether I should create an async operator