[GitHub] [airflow] jaketf commented on pull request #7197: [AIRFLOW-6586] Improvements to gcs sensor

2020-05-15 Thread GitBox
jaketf commented on pull request #7197: URL: https://github.com/apache/airflow/pull/7197#issuecomment-629421104 @turbaszek seems like only quarantined test failing. Any blocker to merge? This is an automated message from the

[GitHub] [airflow] jaketf commented on pull request #7197: [AIRFLOW-6586] Improvements to gcs sensor

2020-05-06 Thread GitBox
jaketf commented on pull request #7197: URL: https://github.com/apache/airflow/pull/7197#issuecomment-624922589 Please re-run travis. It appears the failure is unrelated in TestKubernetesExecutor https://travis-ci.org/github/apache/airflow/jobs/683599411#L2002

[GitHub] [airflow] jaketf commented on pull request #7197: [AIRFLOW-6586] Improvements to gcs sensor

2020-05-05 Thread GitBox
jaketf commented on pull request #7197: URL: https://github.com/apache/airflow/pull/7197#issuecomment-624183460 Build docs is sad, but I do not understand the error message. Is there a way I can catch things like this sooner than CI checks? my pre-commit was clean. ```

[GitHub] [airflow] jaketf commented on pull request #7197: [AIRFLOW-6586] Improvements to gcs sensor

2020-05-04 Thread GitBox
jaketf commented on pull request #7197: URL: https://github.com/apache/airflow/pull/7197#issuecomment-623613676 @mik-laj thanks it does make more sense in that module. looks like those docs don't really touch on sensors so `poke_mode_only` docs there would've seem out of place.

[GitHub] [airflow] jaketf commented on pull request #7197: [AIRFLOW-6586] Improvements to gcs sensor

2020-05-03 Thread GitBox
jaketf commented on pull request #7197: URL: https://github.com/apache/airflow/pull/7197#issuecomment-623235491 @turbaszek this is the first decorator in this dir. How do you think we should document this? In the same place the docs ci check is complaining about ?