[GitHub] [airflow] jmcarp commented on issue #5030: [AIRFLOW-4227] Use python3-style type annotations.

2019-06-02 Thread GitBox
jmcarp commented on issue #5030: [AIRFLOW-4227] Use python3-style type annotations. URL: https://github.com/apache/airflow/pull/5030#issuecomment-498105763 Looks like this was reimplemented in #5327. Thanks @BasPH. This is

[GitHub] [airflow] jmcarp commented on issue #5030: [AIRFLOW-4227] Use python3-style type annotations.

2019-05-07 Thread GitBox
jmcarp commented on issue #5030: [AIRFLOW-4227] Use python3-style type annotations. URL: https://github.com/apache/airflow/pull/5030#issuecomment-490177519 @mik-laj: I hadn't changed all the named tuples in tests, but now I've gone through and dropped all uses of `collections.namedtuple`.

[GitHub] [airflow] jmcarp commented on issue #5030: [AIRFLOW-4227] Use python3-style type annotations.

2019-04-23 Thread GitBox
jmcarp commented on issue #5030: [AIRFLOW-4227] Use python3-style type annotations. URL: https://github.com/apache/airflow/pull/5030#issuecomment-486064887 This should be ready to go now that #5090 is finished. cc @Fokko @kaxil

[GitHub] [airflow] jmcarp commented on issue #5030: [AIRFLOW-4227] Use python3-style type annotations.

2019-04-12 Thread GitBox
jmcarp commented on issue #5030: [AIRFLOW-4227] Use python3-style type annotations. URL: https://github.com/apache/airflow/pull/5030#issuecomment-482631271 Looks like #5090 will fix the kubernetes tests here. This is an

[GitHub] [airflow] jmcarp commented on issue #5030: [AIRFLOW-4227] Use python3-style type annotations.

2019-04-10 Thread GitBox
jmcarp commented on issue #5030: [AIRFLOW-4227] Use python3-style type annotations. URL: https://github.com/apache/airflow/pull/5030#issuecomment-48189 Added some typed namedtuples. Since we're supporting python3.5, we can't use variable annotations, so I used the backwards-compatible

[GitHub] [airflow] jmcarp commented on issue #5030: [AIRFLOW-4227] Use python3-style type annotations.

2019-04-03 Thread GitBox
jmcarp commented on issue #5030: [AIRFLOW-4227] Use python3-style type annotations. URL: https://github.com/apache/airflow/pull/5030#issuecomment-479606123 Thanks @ashb, I backed out variable annotations, and tests are passing on 3.5.x.

[GitHub] [airflow] jmcarp commented on issue #5030: [AIRFLOW-4227] Use python3-style type annotations.

2019-04-02 Thread GitBox
jmcarp commented on issue #5030: [AIRFLOW-4227] Use python3-style type annotations. URL: https://github.com/apache/airflow/pull/5030#issuecomment-479310246 Thanks @BasPH. Also, will we support python3.5 in the future? If so, we can use function annotations but not variable annotations.