malthe commented on pull request #15589:
URL: https://github.com/apache/airflow/pull/15589#issuecomment-835768889
@potiuk fixed whitespace – using `black` locally helps :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
malthe commented on pull request #15589:
URL: https://github.com/apache/airflow/pull/15589#issuecomment-835740658
@potiuk fixed – thanks for the patience!
(I had a missing newline in the rst markup.)
--
This is an automated message from the Apache Git Service.
To respond to the
malthe commented on pull request #15589:
URL: https://github.com/apache/airflow/pull/15589#issuecomment-835729258
@potiuk done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
malthe commented on pull request #15589:
URL: https://github.com/apache/airflow/pull/15589#issuecomment-835186869
These test failures seem unrelated to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
malthe commented on pull request #15589:
URL: https://github.com/apache/airflow/pull/15589#issuecomment-833818061
@potiuk I think the test failure is unrelated. I noticed this in the test
log:
```
Yarn requires Node.js 4.0 or higher to be installed.
```
--
This is an automated
malthe commented on pull request #15589:
URL: https://github.com/apache/airflow/pull/15589#issuecomment-832818739
@potiuk so this still needs two additional reviews is that how the process
works?
--
This is an automated message from the Apache Git Service.
To respond to the message,
malthe commented on pull request #15589:
URL: https://github.com/apache/airflow/pull/15589#issuecomment-829608618
@potiuk I have cleaned up the docs and code to emphasize that _Host_ and
_Schema_ (and the rest of the standard fields) are perfectly good for most
users.
If a user has
malthe commented on pull request #15589:
URL: https://github.com/apache/airflow/pull/15589#issuecomment-829590431
@potiuk just a quick question – the Oracle-specific fields in the connection
documentation (e.g. "Sid" and "Service_name"), those don't make sense to me at
all looking at:
malthe commented on pull request #15589:
URL: https://github.com/apache/airflow/pull/15589#issuecomment-829388253
@potiuk yes, but when you're just providing a connection string,
`service_name` is not what gets populated, `conn.schema` is.
So if we want `host:port/` to be translated
malthe commented on pull request #15589:
URL: https://github.com/apache/airflow/pull/15589#issuecomment-829167561
@uranusjr it seems to me that `conn.schema` should be added there as well:
```python
if conn.schema is not None:
dsn += "/" + conn.schema
```
E.g.
malthe commented on pull request #15589:
URL: https://github.com/apache/airflow/pull/15589#issuecomment-829075499
@potiuk done – and I have fixed a minor bug (it shouldn't add the port
suffix if it's the default port).
--
This is an automated message from the Apache Git Service.
To
11 matches
Mail list logo
