[GitHub] [airflow] mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-17 Thread GitBox
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#discussion_r325137820 ## File path: airflow/gcp/operators/pubsub.py ## @@ -403,29 +617,43 @@ class

[GitHub] [airflow] mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-17 Thread GitBox
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#discussion_r325137231 ## File path: airflow/gcp/operators/pubsub.py ## @@ -326,34 +505,68 @@ class

[GitHub] [airflow] mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-14 Thread GitBox
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#discussion_r324422335 ## File path: airflow/gcp/hooks/pubsub.py ## @@ -292,14 +504,38 @@ def

[GitHub] [airflow] mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-14 Thread GitBox
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#discussion_r324422317 ## File path: airflow/gcp/hooks/pubsub.py ## @@ -259,29 +443,57 @@ def pull(

[GitHub] [airflow] mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-14 Thread GitBox
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#discussion_r324422308 ## File path: airflow/gcp/hooks/pubsub.py ## @@ -177,40 +293,88 @@ def

[GitHub] [airflow] mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-14 Thread GitBox
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#discussion_r324422309 ## File path: airflow/gcp/hooks/pubsub.py ## @@ -219,30 +383,50 @@ def

[GitHub] [airflow] mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-14 Thread GitBox
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#discussion_r324422287 ## File path: airflow/gcp/hooks/pubsub.py ## @@ -154,6 +262,14 @@ def

[GitHub] [airflow] mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-14 Thread GitBox
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#discussion_r324422256 ## File path: airflow/gcp/hooks/pubsub.py ## @@ -77,47 +106,110 @@ def

[GitHub] [airflow] mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-14 Thread GitBox
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#discussion_r324422266 ## File path: airflow/gcp/hooks/pubsub.py ## @@ -129,23 +221,39 @@ def

[GitHub] [airflow] mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-14 Thread GitBox
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#discussion_r324422248 ## File path: airflow/gcp/hooks/pubsub.py ## @@ -77,47 +106,110 @@ def

[GitHub] [airflow] mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-14 Thread GitBox
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#discussion_r324422208 ## File path: airflow/gcp/hooks/pubsub.py ## @@ -19,12 +19,18 @@ """ This module

[GitHub] [airflow] mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-14 Thread GitBox
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#discussion_r324422074 ## File path: airflow/gcp/hooks/pubsub.py ## @@ -77,47 +106,110 @@ def

[GitHub] [airflow] mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-14 Thread GitBox
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#discussion_r324422078 ## File path: airflow/gcp/hooks/pubsub.py ## @@ -129,23 +221,39 @@ def

[GitHub] [airflow] mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-14 Thread GitBox
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#discussion_r324422081 ## File path: airflow/gcp/hooks/pubsub.py ## @@ -177,40 +293,88 @@ def

[GitHub] [airflow] mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-14 Thread GitBox
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#discussion_r324422078 ## File path: airflow/gcp/hooks/pubsub.py ## @@ -129,23 +221,39 @@ def

[GitHub] [airflow] mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-14 Thread GitBox
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#discussion_r324422074 ## File path: airflow/gcp/hooks/pubsub.py ## @@ -77,47 +106,110 @@ def

[GitHub] [airflow] mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-14 Thread GitBox
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#discussion_r324422081 ## File path: airflow/gcp/hooks/pubsub.py ## @@ -177,40 +293,88 @@ def