mik-laj commented on issue #3656: [AIRFLOW-2803] Fix all ESLint issues
URL: https://github.com/apache/airflow/pull/3656#issuecomment-469663477
 
 
   Hi.
   I created a related PR: 
   https://github.com/apache/airflow/pull/4787
   This also fixes linting of the javascript that is in the HTML code.
   
   I also worked on fixing these linter errors. I have not found your PR before.
   https://github.com/PolideaInternal/airflow/pull/75
   Firstly, I wanted to introduce linting with a list of exclusions. In the 
next PRs I would gradually fix the code.  I was afraid that changes in the JS 
code are difficult to test. Therefore, they should be carefully reviewed. It is 
difficult to review all changes if they affect each line.
   
   The next step would be to extract Javascript code completely into separate 
files and introduce tests for them. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to