[GitHub] [airflow] pankajastro commented on a diff in pull request #29835: Provider Google Cloud - Add bigquery bi engine reservation operators

2023-03-07 Thread via GitHub
pankajastro commented on code in PR #29835: URL: https://github.com/apache/airflow/pull/29835#discussion_r1127687575 ## airflow/providers/google/cloud/hooks/bigquery_reservation.py: ## @@ -0,0 +1,123 @@ +# Review Comment: +1 for `hooks/bigquery_biengine.py` -- This is

[GitHub] [airflow] pankajastro commented on a diff in pull request #29835: Provider Google Cloud - Add bigquery bi engine reservation operators

2023-03-06 Thread via GitHub
pankajastro commented on code in PR #29835: URL: https://github.com/apache/airflow/pull/29835#discussion_r112636 ## airflow/providers/google/cloud/hooks/bigquery_reservation.py: ## @@ -0,0 +1,125 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] pankajastro commented on a diff in pull request #29835: Provider Google Cloud - Add bigquery bi engine reservation operators

2023-03-06 Thread via GitHub
pankajastro commented on code in PR #29835: URL: https://github.com/apache/airflow/pull/29835#discussion_r1126307197 ## airflow/providers/google/cloud/hooks/bigquery_reservation.py: ## @@ -0,0 +1,125 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] pankajastro commented on a diff in pull request #29835: Provider Google Cloud - Add bigquery bi engine reservation operators

2023-03-02 Thread via GitHub
pankajastro commented on code in PR #29835: URL: https://github.com/apache/airflow/pull/29835#discussion_r1123551136 ## airflow/providers/google/cloud/hooks/bigquery_reservation.py: ## @@ -0,0 +1,125 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] pankajastro commented on a diff in pull request #29835: Provider Google Cloud - Add bigquery bi engine reservation operators

2023-03-02 Thread via GitHub
pankajastro commented on code in PR #29835: URL: https://github.com/apache/airflow/pull/29835#discussion_r1123530878 ## airflow/providers/google/cloud/hooks/bigquery_reservation.py: ## @@ -0,0 +1,125 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] pankajastro commented on a diff in pull request #29835: Provider Google Cloud - Add bigquery bi engine reservation operators

2023-03-02 Thread via GitHub
pankajastro commented on code in PR #29835: URL: https://github.com/apache/airflow/pull/29835#discussion_r1122802132 ## airflow/providers/google/cloud/hooks/bigquery_reservation.py: ## @@ -0,0 +1,129 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more