[GitHub] [airflow] potiuk commented on pull request #14521: Add Asana Provider

2021-05-17 Thread GitBox
potiuk commented on pull request #14521: URL: https://github.com/apache/airflow/pull/14521#issuecomment-842537262 :tada: :tada: :tada: :tada: :tada: :tada: :tada: :tada: :tada: :tada: :tada: :tada: :tada: :tada: :tada: :tada: -- This is an automated message from the Apache Git Service.

[GitHub] [airflow] potiuk commented on pull request #14521: Add Asana Provider

2021-05-17 Thread GitBox
potiuk commented on pull request #14521: URL: https://github.com/apache/airflow/pull/14521#issuecomment-841807035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [airflow] potiuk commented on pull request #14521: Add Asana Provider

2021-05-17 Thread GitBox
potiuk commented on pull request #14521: URL: https://github.com/apache/airflow/pull/14521#issuecomment-842429286 Hey @eladkal - are you OK With the change ? It looks GREAT to me finally (just one random flaky test failed). -- This is an automated message from the Apache Git Service.

[GitHub] [airflow] potiuk commented on pull request #14521: Add Asana Provider

2021-05-17 Thread GitBox
potiuk commented on pull request #14521: URL: https://github.com/apache/airflow/pull/14521#issuecomment-842210690 Hey @jmelot - can you please rebase (I hope one last time !) -> there are some conflicts around INSTALL/CONTRIBUTING. -- This is an automated message from the Apache Git

[GitHub] [airflow] potiuk commented on pull request #14521: Add Asana Provider

2021-05-17 Thread GitBox
potiuk commented on pull request #14521: URL: https://github.com/apache/airflow/pull/14521#issuecomment-842156111 Seems the CI is much more stable today. Closing/reopening to trigger the build. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] potiuk commented on pull request #14521: Add Asana Provider

2021-05-16 Thread GitBox
potiuk commented on pull request #14521: URL: https://github.com/apache/airflow/pull/14521#issuecomment-841807035 I am looking into fixing thed CI problems (some infra problems we have) later right after major outage of GitHub is solved :(

[GitHub] [airflow] potiuk commented on pull request #14521: Add Asana Provider

2021-05-14 Thread GitBox
potiuk commented on pull request #14521: URL: https://github.com/apache/airflow/pull/14521#issuecomment-841089222 Looks much better ! I think the only real problem is docs building - there is apparently a problem with builing the docuementaiton, If you can try it locally with breeze

[GitHub] [airflow] potiuk commented on pull request #14521: Add Asana Provider

2021-05-13 Thread GitBox
potiuk commented on pull request #14521: URL: https://github.com/apache/airflow/pull/14521#issuecomment-841021619 I pushed a fixup. @jmelot -> please pull my fixup (:crossed_fingers: that it succeds). -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] potiuk commented on pull request #14521: Add Asana Provider

2021-05-13 Thread GitBox
potiuk commented on pull request #14521: URL: https://github.com/apache/airflow/pull/14521#issuecomment-841020004 I think we are very close :) I see this failure. Asana package has not been released yet and apparently there is a bug in preparing the package. I will provide a fixup

[GitHub] [airflow] potiuk commented on pull request #14521: Add Asana Provider

2021-05-10 Thread GitBox
potiuk commented on pull request #14521: URL: https://github.com/apache/airflow/pull/14521#issuecomment-836668381 No problem, rebases are tricky :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] potiuk commented on pull request #14521: Add Asana Provider

2021-05-10 Thread GitBox
potiuk commented on pull request #14521: URL: https://github.com/apache/airflow/pull/14521#issuecomment-836472630 Let me just close/reopen to trigger the build :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] potiuk commented on pull request #14521: Add Asana Provider

2021-05-09 Thread GitBox
potiuk commented on pull request #14521: URL: https://github.com/apache/airflow/pull/14521#issuecomment-835892096 One more request :(. We had some problems still. Can you please rebase again. Happy to pay closer look and make sure we get that one to completiion! -- This is an automated

[GitHub] [airflow] potiuk commented on pull request #14521: Add Asana Provider

2021-05-07 Thread GitBox
potiuk commented on pull request #14521: URL: https://github.com/apache/airflow/pull/14521#issuecomment-834200418 Hey @jmelot - really sorry (and sorry it takes THAT long) Could you please rebase it one more time ? I would really love to get Asana Provider in and happy to accelerate it.

[GitHub] [airflow] potiuk commented on pull request #14521: Add Asana Provider

2021-05-01 Thread GitBox
potiuk commented on pull request #14521: URL: https://github.com/apache/airflow/pull/14521#issuecomment-830627265 Hey @jmelot -> I think you will have to rebase to latest master in order to make this work. We'v migrated to PIP 21 and now the images won't build until you rebase : `This