[GitHub] [airflow] potiuk commented on pull request #15589: [Oracle] Add port to DSN

2021-05-09 Thread GitBox
potiuk commented on pull request #15589: URL: https://github.com/apache/airflow/pull/15589#issuecomment-835811739 Actually having `pre-commit` installed locally helps even more :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] potiuk commented on pull request #15589: [Oracle] Add port to DSN

2021-05-08 Thread GitBox
potiuk commented on pull request #15589: URL: https://github.com/apache/airflow/pull/15589#issuecomment-835188482 Yeah. Can you please rebae on top of the latest master? There were a couple of problems in master that have been just fixed. -- This is an automated message from the Apache

[GitHub] [airflow] potiuk commented on pull request #15589: [Oracle] Add port to DSN

2021-05-05 Thread GitBox
potiuk commented on pull request #15589: URL: https://github.com/apache/airflow/pull/15589#issuecomment-832820049 No. I t just needs fixes of the failing tests (just make sure to rebase it to latest master and make sure all the checks are green) -- This is an automated message from the

[GitHub] [airflow] potiuk commented on pull request #15589: [Oracle] Add port to DSN

2021-04-29 Thread GitBox
potiuk commented on pull request #15589: URL: https://github.com/apache/airflow/pull/15589#issuecomment-829428066 > So if we want host:port/ to be translated back to host:port/, then it seems conn.schema is the way to go. Hmm. I think this is not how (at least originally) the oracle

[GitHub] [airflow] potiuk commented on pull request #15589: [Oracle] Add port to DSN

2021-04-29 Thread GitBox
potiuk commented on pull request #15589: URL: https://github.com/apache/airflow/pull/15589#issuecomment-829049303 Could you please add a unit test for that ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL