[GitHub] [airflow] potiuk commented on pull request #20847: Added other Opentelemery Instrumentations

2022-01-26 Thread GitBox
potiuk commented on pull request #20847: URL: https://github.com/apache/airflow/pull/20847#issuecomment-1022347709 Hey @Melodie97 . I just pushed some fixes. I also rebased your changes to latest `main` so you will have to do: `git fetch && git reset --hard origin/main` In

[GitHub] [airflow] potiuk commented on pull request #20847: Added other Opentelemery Instrumentations

2022-01-13 Thread GitBox
potiuk commented on pull request #20847: URL: https://github.com/apache/airflow/pull/20847#issuecomment-1011925528 > I will make some comments in your PR and give you some guidelines for that :) OK. I think all comments added for that one. -- This is an automated message

[GitHub] [airflow] potiuk commented on pull request #20847: Added other Opentelemery Instrumentations

2022-01-12 Thread GitBox
potiuk commented on pull request #20847: URL: https://github.com/apache/airflow/pull/20847#issuecomment-1011887017 Nice. @Melodie97 - while you are at it - maybe - while preparing to the demo next week you could also take a look at the beginning of this: