[GitHub] [airflow] uranusjr commented on a diff in pull request #33864: Replace single quotes by double quotes in tests

2023-08-31 Thread via GitHub
uranusjr commented on code in PR #33864: URL: https://github.com/apache/airflow/pull/33864#discussion_r1311304685 ## tests/dags/test_imports.py: ## Review Comment: There is already this comment

[GitHub] [airflow] uranusjr commented on a diff in pull request #33864: Replace single quotes by double quotes in tests

2023-08-30 Thread via GitHub
uranusjr commented on code in PR #33864: URL: https://github.com/apache/airflow/pull/33864#discussion_r138765 ## tests/dags/test_imports.py: ## Review Comment: I think `fmt: off` in this file is so we can test our lexer can correctly parse exotically formatted code.

[GitHub] [airflow] uranusjr commented on a diff in pull request #33864: Replace single quotes by double quotes in tests

2023-08-30 Thread via GitHub
uranusjr commented on code in PR #33864: URL: https://github.com/apache/airflow/pull/33864#discussion_r1309970337 ## tests/providers/google/cloud/hooks/test_mlengine.py: ## @@ -1009,11 +1009,11 @@ def test_delete_version(self, mock_get_conn, mock_project_id):

[GitHub] [airflow] uranusjr commented on a diff in pull request #33864: Replace single quotes by double quotes in tests

2023-08-28 Thread via GitHub
uranusjr commented on code in PR #33864: URL: https://github.com/apache/airflow/pull/33864#discussion_r1308183098 ## tests/providers/google/cloud/hooks/test_mlengine.py: ## @@ -1009,11 +1009,11 @@ def test_delete_version(self, mock_get_conn, mock_project_id):